• last updated 19 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Fixed unreviewed commit, which might lead to hard-to-spot errors

The last change assumed that "nls_language" can be hard-wired to

contain most 5 characters. While this not backed by the OpenACS data

model, the standard (RFC 5646) explicitly states that there is no

upper limit on the size of language tags. The tree letter language

codes have been standard since 2001 (RFC 4646).

The change accepts now all defined locales. When the specified locale

is not enabled, it provides a log notice, when the locale is not

defined at all, it provides a warning and falls back to "en_US".

  1. … 3 more files in changeset.
Validate as a token also the default coming from _nls_language, ensure the resulting language key is at most 5 chars long (many thanks to Markus Moser for this)

fix typo

Cleanup commented code

fix typo

improved parameter checking

  1. … 3 more files in changeset.
Use signed value for form_parameter "__object_name"

Bumped version number to 5.10.1d40

  1. … 3 more files in changeset.
disallow names, which look like a language prefix followed by an empty name

Empty names are not allowed.

The error message is just always the same for wiki pages, so

this is not perfect.

improved checking of parameter values, which might be influenced via query parameters

  1. … 6 more files in changeset.
Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 6 more files in changeset.
Fall back to en_US also when a value for nls_language is there, but empty

for orthogonaly, remove "-html" flag from dom parse to avoid a potential top-level <html> element

  1. … 4 more files in changeset.
fix typo

We differentiate now between the classical name validation error and

the name-too-long error. Message keys had to be extended.

Version number bumped to 5.10.1d27

  1. … 7 more files in changeset.
handle cases in name-validation/normalization, where the language comes from _nls_language rather than nls_language

Many thanks to Markus Moser for analyzing and identifying the problem.

fix default value for nls_language

support renaming of autonamed entries

previously, it was not possible to rename autonamed entries via edit form.

now this is allowed, and item name validation is more robust, support

functions return meaningful error in unexpected situations.

  1. … 1 more file in changeset.
fix creating/editing of xowiki::Forms

This change essentially reverts the change of July 2, which broke

the feature to specify "editor=none". This is important for the

"form" form-field entry, which requires a FORM tag, that is

usually removed by actual version of the ckeditor.

  1. … 1 more file in changeset.
In order to make the "editor=" formfield spec option have any effect, one should catch the value from the spec early, before the formfield is reclassed and initialized

This also exposes that the editor=none value is not valid (detected by xowiki and xowf automated tests). For this to be valid one should define it as a richtext subclass.

  1. … 1 more file in changeset.
use ad_proc -private

make end of resub options explicit

  1. … 12 more files in changeset.
improve spelling

  1. … 4 more files in changeset.
fix propagation of validate results in old-style (ad_form-based) forms. One should really switch to FormPages soon.

  1. … 1 more file in changeset.
Make ::xowiki::Package default_locale react to changes in the connection locale by caching only when the parameter use_connection_locale is not set, use ::xowiki::Package default_locale result instead of always the connection locale to determine nls_language for new Pages and FormPages, so that default language for a particular xowiki instance is decided by use_connection_locale parameter

  1. … 2 more files in changeset.
introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 50 more files in changeset.
improve spelling

  1. … 19 more files in changeset.
fix bug: never update references in the search renderer

before, it was possible that the search renderer added some

unsresolved references, although these were already fixed.

This was caused by the asynchrnous search queue, which

might have inserted such values.

The interface of Page.render was extended to be able to

specify, that the references should be always updated in the DB,

or just when unresolved references are encountered, or


  1. … 3 more files in changeset.
  1. … 4 more files in changeset.
improve input validaton on query variables

  1. … 7 more files in changeset.
improving comments, variable names, and indentation

  1. … 2 more files in changeset.