• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve comments

Improve fix: do not even fetch the context_id for revisions, so we do not touch it when saving

Make sure that the context_id of a CRItem is always fetched from that of the item, rather than the revision, otherwise we could break object_id = context_id constraint on saving

CrClass->instance_select_query: return context_id of cr_item unless it is explicitly asked differently.

Before, calls like get_folder_children returned items having the context_id of the revision.

Since this attribute is ignored by most applications, it did not harm. However, a recent

bugfix for honoring different context_ids caused troubles. In the worst case, one can

end up with items having its own item_id as context id, which in turn causes

permission queries to loop.

provide default value for storage_type for in-memory created items

perform conditional updates of context_id, fetch now storage_type as well to streamline code in the future

reduce verbosity

  1. … 1 more file in changeset.
remove unneeded method

improve consistency of interface: use instance variable when no folder_id is provided

whitespace changes

avoid array notation for per_thread caches to ease flushing

  1. … 5 more files in changeset.
follow naming convention as used in other places as well

start key with the package name, use array notation

  1. … 1 more file in changeset.
cache failed name lookups in a per-request cache (flushing maybe overly conservative)

  1. … 3 more files in changeset.
Added support for row-level lock modes of PostgreSQL; used in "save" method of cr-items

This change is necesary to avoid potential dead-locks in concurrent "save" operations

  1. … 1 more file in changeset.
whitespace changes

improve comment

prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 18 more files in changeset.
use "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 8 more files in changeset.
- fix remove_non_persistent_vars (ignored specified pattern)

- update_attribute_from_slot: make sure the instance variable is also updated

address issue #3423: Move is_package_root_folder up in class hierarchy to CrItem

follow user wish

  1. … 3 more files in changeset.
whitespace changes

  1. … 1 more file in changeset.
re-enable source_dependent operation (not clear, why this was commented out)

Address suggestion from issue #3420

prefer all caps spelling for SQL

  1. … 2 more files in changeset.
improve comment

Fix call to get_context in functions used in third party applications (see #3424)

added suggestion #3424

added suggestion #3425

improve spelling

  1. … 15 more files in changeset.
prefer "nsf::is object" over ":isobject" or "info commands", since it is faster, more generic and can be used in all contexts

  1. … 10 more files in changeset.