OpenACS / openacs-4 / packages / xotcl-core / tcl

06-package-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 22 Jun 18
Commits this week: 0
Total Lines of Code (LoC): 461
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 Mar
10:48 am

gustafn

Factor out Package->process_init_parameter into package-custom-procs

This change makes it easier to provide instance specific customization.

In general, these package-custom-procs could also be kept in other

packages.

Options
    • -9
    • +18
    ./06-package-procs.tcl
  2. … 4 more files in changeset.
Sunday 27 Nov 2022
6:28 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./06-package-procs.tcl
  2. … 8 more files in changeset.
Tuesday 08 Nov 2022
7:04 pm

gustafn

Deescalation: the usage of the pairs in export_vars is not so dangerous as it looked at first sight.

The problem case was originating from the call

lappend __vars [lindex $_var 0] [uplevel subst [lindex $_var 1]]

which calls Tcl's "uplevel" with two arguments. In this case, the arguments

are concatenated and the evaluated in the caller's frame. There is a substitution

before the evaluation. When just one argument is passed in, this problem there

is only one evaluation:

lappend __vars [lindex $_var 0] [uplevel [list subst [lindex $_var 1]]]

Options
    • -6
    • +8
    ./06-package-procs.tcl
  2. … 1 more file in changeset.
2:24 pm

gustafn

Added support for passing parameter_name:value_constraint to xowiki::Package->get_parameter

- The get_parameter method can get values from query-parameters, therefore

we have to validate these.

- Use the new feature at several places (especially for boolean values)

- Still, more places should be checked

- bumped xowiki to 5.10.1d37

- bumped xotcl-core to 5.10.1d14

Options
    • -26
    • +4
    ./06-package-procs.tcl
  2. … 10 more files in changeset.
1:47 pm

trenner

add missing brackets

Options
    • -2
    • +2
    ./06-package-procs.tcl
Monday 07 Nov 2022
2:34 pm

gustafn

new API call util::potentially_unsafe_eval_p

Check content of the string to identify potentially unsafe content

in the provided string. The content is unsafe, when it contains

externally provided content, which might be provided e.g. via

query variables, or via user values stored in the database. When

such content contains square braces, a "subst" command on

theses can evaluate arbitrary commands, which is dangerous.

The new API call is used in "::xo::Package->return_page", where the

"subst" command stripped from its command substitution capabilities.

In case, command subsitution is needed, perform this prior this call.

bumped acs-tcl to 5.10.1d23

bumped xotcl-core to 5.10.1d13

Options
    • -2
    • +5
    ./06-package-procs.tcl
  2. … 3 more files in changeset.
Monday 22 Aug 2022
7:06 pm

gustafn

new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

Options
    • -3
    • +3
    ./06-package-procs.tcl
  2. … 11 more files in changeset.
Tuesday 15 Mar 2022
1:01 pm

gustafn

prefer global variable over proc

Options
    • -2
    • +2
    ./06-package-procs.tcl
  2. … 6 more files in changeset.
Wednesday 23 Feb 2022
7:40 pm

gustafn

Prefer "::acs::dc call ..." over "::xo::db::sql::..."

Use the common new acs interface rather than the xotcl-core variant.

Goal should be on the medium time range to replace all of the

"::xo::db::sql::*" interface.

Options
    • -2
    • +2
    ./06-package-procs.tcl
  2. … 2 more files in changeset.
Sunday 20 Feb 2022
6:24 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling, *lobs

- fix boolean permission query

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- revived blob and clob handling in "xo::dc dml" since this is needed

for updating

- modernize Oracle offset/limit handling

- added missing "-dbn" attributes for Oracle xo::dc calls

Options
    • -2
    • +2
    ./06-package-procs.tcl
  2. … 2 more files in changeset.
Friday 28 Jan 2022
11:46 pm

gustafn

improve wording in comments

Options
    • -6
    • +6
    ./06-package-procs.tcl
Sunday 09 Jan 2022
6:51 pm

gustafn

make use of "from_cache_indicator" for the per_request_cache in instantiate_forms

Options
    • -5
    • +15
    ./06-package-procs.tcl
  2. … 1 more file in changeset.
Friday 07 Jan 2022
2:59 pm

antoniop

Add the root folder id to the cache key so that when one does not specify any parent_id, the method still reacts to a package being uninstantiated or the root folder messed around with

Fixes xowiki automated tests when run all together in the same request

Options
    • -2
    • +2
    ./06-package-procs.tcl
Tuesday 04 Jan 2022
9:22 pm

gustafn

use per-request cache for relatively expensive operation, which is called potentially often per request

We might consider in the future a longer lasting cache for "global" form pages.

Options
    • -22
    • +32
    ./06-package-procs.tcl
Monday 27 Dec 2021
5:20 pm

gustafn

improve comment

Options
    • -2
    • +2
    ./06-package-procs.tcl
Sunday 26 Dec 2021
3:54 pm

gustafn

base refetch on "publish_date" rather than on "last_modified" of a CR item object

Interestingly, the last_modified field of an item is not updated, when an revision is added,

but the publish_date is

on CVS: ----------------------------------------------------------------------

Options
    • -9
    • +19
    ./06-package-procs.tcl
Friday 19 Nov 2021
8:30 pm

gustafn

part 2 of parameter reform

unify xo::parameter handling with classical parameter handling (parameter::get).

This change implements calls for "::xo::parameter get" by parameter::get

and outputs deprecated log entries. In addition, the initialization

of all parameters is deactivated, such that startup time is slightly faster.

so far, the full code is kept but deactivated to allow to change

quickly back, in case early adaptors run into troubles.

At least in cases, where new naviserver versions are used, the implementaton

of parameter::get became sufficiently fast to beat the xo::parameter

implementation, which was at time of its introduction ~30x faster.

Options
    • -25
    • +32
    ./06-package-procs.tcl
  2. … 1 more file in changeset.
Tuesday 17 Aug 2021
4:38 pm

antoniop

For Postgres, take advantage of exclusive database api to check for permissions more efficiently, improve doc

Options
    • -13
    • +41
    ./06-package-procs.tcl
Thursday 29 Jul 2021
2:33 pm

gustafn

tighten checking on input parameters

Options
    • -2
    • +3
    ./06-package-procs.tcl
  2. … 1 more file in changeset.
Tuesday 23 Mar 2021
3:46 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./06-package-procs.tcl
  2. … 1 more file in changeset.
Monday 01 Mar 2021
10:27 am

gustafn

reduce verbosity

Options
    • -2
    • +4
    ./06-package-procs.tcl
Sunday 14 Feb 2021
10:13 pm

gustafn

provide warning about deprecated location

Options
    • -65
    • +75
    ./06-package-procs.tcl
  2. … 1 more file in changeset.
Wednesday 16 Dec 2020
6:03 pm

antoniop

Add missing parameter in doc

Options
    • -4
    • +4
    ./06-package-procs.tcl
  2. … 1 more file in changeset.
Tuesday 08 Dec 2020
4:50 pm

gustafn

improve comments and rise warning, when best-effort url is generated

Options
    • -8
    • +34
    ./06-package-procs.tcl
Sunday 06 Dec 2020
12:41 pm

gustafn

refactor code and use caching to reduce (maybe overly cautious) flushes on site_nodes_id_cache-*

Options
    • -24
    • +32
    ./06-package-procs.tcl
Saturday 26 Sep 2020
11:00 pm

gustafn

support folder instances as prototype pages

Options
    • -3
    • +16
    ./06-package-procs.tcl
Wednesday 26 Aug 2020
8:34 pm

gustafn

make "instantiate_forms" a method of packages

this reads better than the previous variant based on the Weblog class.

Options
    • -1
    • +29
    ./06-package-procs.tcl
  2. … 14 more files in changeset.
Thursday 13 Aug 2020
8:16 pm

gustafn

form_usages: add revisions and full path to output

Options
    • -7
    • +16
    ./06-package-procs.tcl
7:05 pm

gustafn

form_unify: use switch instead of boolean flag; iterate over single forms

Options
    • -61
    • +63
    ./06-package-procs.tcl
Wednesday 12 Aug 2020
9:20 pm

gustafn

use the same defaults for the "-forms" switch in form_usages and form_unify

Options
    • -6
    • +10
    ./06-package-procs.tcl