OpenACS / openacs-4 / packages / xotcl-core / tcl

05-db-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 31 Jan 19
Commits this week: 0
Total Lines of Code (LoC): 2,826
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Apr
7:19 pm

gustafn

Undo part of the recent cache-deactivation for attribute definitions

When all calls for "db_attribute_defined" are performed without

caching, this results in a huge amount of additional SQL queries,

since these tests are performed during blueprint definition as well

during every blueprint reload of every db attribute. On a small site

with just 6 connection threads (2 monitor, 2 default, 2 slow), this

results during startup with 969 additional SQL queries, a reload of

xowiki causes an additional 1063 of such queries. When a site defines

much more connection threads ((the LEARN site has e.g. 85 connection

threads defined), these DB attribute testing operations will result in

10K+ of mostly useless SQL queries. As a consequence of this, the

startup of the server will become slower, reloads will become slower

etc., which is bad especially for large sites.

The new implementation seems to fix the original problem case (running

xotcl_core_tutorial_4 multiple times). If there is still a problem

with installing xolp [2] this problem should be analyzed and fixed

probably there. If necessary, a proper bug report would be appreciated

to reduce guessing work.

[1] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230310183055

[2] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230317160241

Options
    • -10
    • +29
    ./05-db-procs.tcl
Friday 17 Mar
5:02 pm

antoniop

As it turns out, even caching only by request has consequences e.g. when one installs xolp from scratch

Disabl caching and prepare the statement instead

Options
    • -4
    • +10
    ./05-db-procs.tcl
Friday 10 Mar
7:30 pm

antoniop

Improve robustness when a class is created/deleted multiple times (e.g. by repeating xotcl-core.xotcl_core_tutorial_4 automated test)

Options
    • -35
    • +8
    ./05-db-procs.tcl
Wednesday 08 Feb
8:04 pm

gustafn

imporved log message

Options
    • -2
    • +2
    ./05-db-procs.tcl
Wednesday 01 Feb
2:40 pm

antoniop

Use an idiom without expr to fill up the multirow after the body execution

Options
    • -2
    • +4
    ./05-db-procs.tcl
Thursday 26 Jan
3:25 pm

antoniop

Performance improvements:

- add with_headers flag to ::xo::dc list_of_lists behaving like the db_list_of_lists counterpart

- use ::xo::dc list_of_lists as internal for ::xo::dc foreach and ::xo::dc multirow to reduce the need for ns_sets

Options
    • -78
    • +77
    ./05-db-procs.tcl
1:31 pm

antoniop

Collect all query results before executing the code to avoid the out-of-pools bug

Options
    • -1
    • +6
    ./05-db-procs.tcl
11:53 am

antoniop

-prepare flag must not be supplied when not available

Options
    • -3
    • +4
    ./05-db-procs.tcl
11:47 am

antoniop

Fix regression: the reimplementation of ::xo::dc foreach reintroduced the old "out of pools bug"

The fix makes again use of the ns_set api to free the handle before the code is executed

Options
    • -25
    • +17
    ./05-db-procs.tcl
Monday 23 Jan
10:23 am

antoniop

Remove hack and prefer to document limitation in the automated test

Options
    • -17
    • +1
    ./05-db-procs.tcl
  2. … 1 more file in changeset.
Friday 20 Jan
1:15 pm

antoniop

Fix typo and include again the hack for strings with colon char in the fallback implementation of ns_pg_prepare

Fixes xotcl-core.test_prepared_statements automated test

Options
    • -3
    • +21
    ./05-db-procs.tcl
Thursday 19 Jan
7:10 pm

gustafn

improved spelling

Options
    • -3
    • +3
    ./05-db-procs.tcl
6:53 pm

gustafn

use the built-in bindvars parser (when available) for prepared statements

Options
    • -30
    • +34
    ./05-db-procs.tcl
Tuesday 17 Jan
10:54 am

antoniop

Do not extend the existing multirow, we only enforce that this call will have the same columns

Options
    • -8
    • +2
    ./05-db-procs.tcl
Monday 16 Jan
5:23 pm

antoniop

Do not enforce that body is a list

Options
    • -2
    • +2
    ./05-db-procs.tcl
3:42 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./05-db-procs.tcl
3:40 pm

antoniop

Performance improvements:

- set variables from the ns_set and extended variables separately

- collect the values and append to the multirow in one sweep

- when no code body is there, just bulk append the values

This appears to be ~5% faster than db_multirow when both are invoked with a code body and ~30% faster when invoked without (with no prepared statements)

Options
    • -20
    • +36
    ./05-db-procs.tcl
12:30 pm

antoniop

Simplify idiom

Options
    • -2
    • +2
    ./05-db-procs.tcl
11:52 am

antoniop

Fix behavior of continue in the multirow code block, make the generic fallback behave the same as the postgres version with respect to appending

Options
    • -3
    • +3
    ./05-db-procs.tcl
Friday 13 Jan
6:21 pm

antoniop

Cleanup leftover line

Options
    • -2
    • +1
    ./05-db-procs.tcl
6:16 pm

antoniop

Provide an ::xo::dc api to generate multirows

Notable differences with the classical db_multirow:

- a multirow will always be appended when it already exists. The constraint that the two multirows must have the same columns remains.

- no "if_no_rows_code_block"

- no unclobber

- no subst, do it yourself :-)

- no cache stuff

- support for prepared statements

The remaining behavior has been kept the same, e.g. variables will always be reset to empty string, even if they existed outside of the code block. Compatibility has been checked with knowns idiosyncrasies.

Options
    • -1
    • +116
    ./05-db-procs.tcl
Monday 09 Jan
6:11 pm

antoniop

Provide, as for other interfaces, a Postgres implementation of database foreach that will support prepared statements won't just wrap the db_* api

Options
    • -0
    • +39
    ./05-db-procs.tcl
5:51 pm

antoniop

Make sure the original SQL stays unchanged, as it is used e.g. in the nsv storing the statement and in log messages

Options
    • -6
    • +6
    ./05-db-procs.tcl
11:53 am

antoniop

Improve the approach with strings containing colons in prepared SQL statements:

we first normalize all strings with a safe placeholder, substitute the variables, then put the strings back in place.

Options
    • -2
    • +19
    ./05-db-procs.tcl
Thursday 05 Jan
5:50 pm

antoniop

Improve the regexp detecting variables in a prepared statement, so that a prepared variable must not be preceded by a semicolon (as before), but also by any character allowed for a variable name

Options
    • -2
    • +2
    ./05-db-procs.tcl
Wednesday 04 Jan
12:34 pm

antoniop

Allow to prepare a statement with no parameters (See https://www.postgresql.org/docs/11/sql-prepare.html)

Options
    • -3
    • +11
    ./05-db-procs.tcl
Monday 12 Sep 2022
3:09 pm

antoniop

Add doc to public api

Options
    • -2
    • +11
    ./05-db-procs.tcl
  2. … 1 more file in changeset.
Monday 22 Aug 2022
7:06 pm

gustafn

new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

Options
    • -3
    • +3
    ./05-db-procs.tcl
  2. … 11 more files in changeset.
Wednesday 30 Mar 2022
3:45 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./05-db-procs.tcl
Tuesday 29 Mar 2022
6:12 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./05-db-procs.tcl