• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve robustness when called without connection

avoid subst in export_vars by using xo::update_query

improve comments

Improve fix: do not even fetch the context_id for revisions, so we do not touch it when saving

Make sure that the context_id of a CRItem is always fetched from that of the item, rather than the revision, otherwise we could break object_id = context_id constraint on saving

Fix typo

improve spelling

CrClass->instance_select_query: return context_id of cr_item unless it is explicitly asked differently.

Before, calls like get_folder_children returned items having the context_id of the revision.

Since this attribute is ignored by most applications, it did not harm. However, a recent

bugfix for honoring different context_ids caused troubles. In the worst case, one can

end up with items having its own item_id as context id, which in turn causes

permission queries to loop.

provide default value for storage_type for in-memory created items

Use built-in "ns_parsequery" instead of manual parsing of query parameters

  1. … 1 more file in changeset.
Use built-in "ns_parsequery" instead of manual parsing of query parameters.

Note, that this change might alter query processing, since previously

query parameter without explicit values were treated as boolean values

(like in HTML), now these are treated like "x=" before. The new version is

about 10x faster.

Furthermore, new tests of the regression tests were added for query parameter

processing.

file api-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/api-test-procs.tcl
fixed description of test file

    • -3
    • +2
    ./test/xotcl-core-db-tutorial-procs.tcl
perform conditional updates of context_id, fetch now storage_type as well to streamline code in the future

support messages with multiple arguments

reduce verbosity

  1. … 1 more file in changeset.
fix entry in listing of covered procs

    • -1
    • +1
    ./test/xotcl-core-db-tutorial-procs.tcl
reduce verbosity

adjust to api-browser changes for trailing non-positional arguments

  1. … 1 more file in changeset.
remove unneeded method

whitespace changes

improve test coverage

    • -0
    • +27
    ./test/xotcl-core-db-tutorial-procs.tcl
improve consistency of interface: use instance variable when no folder_id is provided

improve test coverage

    • -3
    • +60
    ./test/xotcl-core-db-tutorial-procs.tcl
small performance improvement

replace call to deprecated function

remove protection "private", since function has to be called from other packages

  1. … 6 more files in changeset.
improve listing of test coverage

    • -12
    • +17
    ./test/xotcl-core-db-tutorial-procs.tcl
  1. … 5 more files in changeset.
improve listing of test coverage

    • -0
    • +56
    ./test/xotcl-core-db-tutorial-procs.tcl
  1. … 7 more files in changeset.
provide warning about deprecated location