• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix typo

Do not require uuid package anymore

Use ns_uuid Naviserver command instead of uuid::uuid generate from tcllib: apparently, this can interact badly with clock localized formatting, leading to the "GREGORIAN_CHANGE_DATE" issue

Do not depend on dt_systime

Apparently, this makes xolp tests more robust with respect to issue discussed in https://stackoverflow.com/questions/49031790/how-can-i-debug-a-tcl-8-6-error-in-clock-tcl#49033144

Fix 3 inconsistent log messages in the test

Prefer portable current_timestamp idiom to NOW()

Exploit existing acs::test::user::create api

Normalize indentation, add editor hints

    • -859
    • +866
    ./test/xolp-test-procs.tcl
Modernize XoTcl idioms

Use xotcl-core indentation convention

Whitespace cleanup, normalize indentation, add editor hints

Use xotcl db idioms

Rollback tests or they will interfere with the others

Reimplement query to obtain user competencies to fix xolp.user_get_competencies automated test

Personal perplexities:

- why do we specify the competency_set_id on the indicator facts? If one fact can be e.g. an exam, this might be related with multiple competency sets

- should we take into account also the validity of an activity?

Port downstream commit cab327aeda04f1f1f6b8f2310ddc88c7c081a84f from Günter Ernst:

Minor adjustments to ensure install- and uninstallability

Port of downstream commit 9cbc3f04aad075e902e64d0c67d53158160a933c from Felix Möedritscher:

feature / issue #10359: added message keys, extended the xolp API - get_competencies, get_activities_of_package, update_title

  1. … 3 more files in changeset.
Insert missing performance indicators for the user

Fix typo

As xolp_indicator_facts_check1 wants end_timestamp <= storage_timestamp, force end_timestamp some time in the past (api won't allow to specify storage_timestamp)

As the original test expects it, make sure begin timestamp and end timestamp are the same

Fix indicator_create test case:

- handle timezone correctly

- don't rely on database language

Add documentation or make procs private to please documentation__check_proc_doc test

Init the right table

Whitespace changes

  1. … 6 more files in changeset.
Fix typos

  1. … 8 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 357 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
remove useless "expr" calls

fix typos