• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
feed_parser::test::parse_feed is also used by the news-aggregator package, make it public again, document this and claim its coverage

  1. … 1 more file in changeset.
Document public api

Make 'source_feeds_ok' test case 'production_safe'

Bring portable SQL inline, prefer portable SQL idioms

Use portable SQL idioms

Cleanup unreferenced SQL, moved to other places a long time ago

    • -85
    • +0
    ./news-aggregator-procs-postgresql.xql
Improve sql portability, reduce number of statements

Replace deprecated idioms

improve .adp quoting, fix spelling, whitespace changes

  1. … 5 more files in changeset.
Fix upgrade timing

  1. … 1 more file in changeset.
Make guid,source_id unique for na_items

  1. … 2 more files in changeset.
Whitespace changes + Editor hints

Rework news source update to simplify the logics and handle updating of existing news items (passes tests)

Move normalization of the pub date closer to its source

New test checking behavior of the news aggregator

This currently fails for what concerns updating an existing news item

    • -0
    • +90
    ./test/news-aggregator-test-procs.tcl
Add test for the news aggregator and feed-parser

news-aggregator will reuse basic test from the feed parser

    • -0
    • +46
    ./test/news-aggregator-test-procs.tcl
  1. … 1 more file in changeset.
New test to check whether configured news feeds look ok

Trim whitespace

Repair broken opml export, exploit new api to streamline query, fix typo

Return 0 also when a default is there but is the empty string

Bring other sql inline, simplify idioms

Bring sql for this proc inline, remove unused statements

Document public procs (fixes automated tests), rework code, remove leftover statements

Trim whitespace

Remove obsolete xql files

    • -34
    • +0
    ./subscription-procs-postgresql.xql
Make all sql portable and bring it in line, remove code duplication

Use db_0or1row flag to return an array natively, repair news_aggregator::aggregator::as_xml as for some reason creating the xml processing instruction via tDOM is broken on tDOM 0.8.3

Whitespace cleanup

Package rework and maintenance

- deprecate undocumented news_aggregator::source::get_identifier as no mention was found in upstream code (fixes automated tests)

- put all portable sql inline

- rework all sql idioms that could be made portable

- remove leftover sql statements

- simplify idioms

Rework of news_aggregator::source::update

- replace deprecated calls

- replace array idioms with dict idioms

- bring portable sql inline

This was tested against RSS feeds used downstream on a vanilla instance