• last updated 12 hours ago
Constraints: committers
Constraints: files
Constraints: dates
re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>


: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Harden page and include contracts using new acs-tcl feature

  1. … 35 more files in changeset.
improve spelling

  1. … 4 more files in changeset.
show notification controls only, when the request is not from a bot

  1. … 4 more files in changeset.
Implement a new type of "Moderator" notification type for forums

This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message.

  1. … 7 more files in changeset.
remove print.css and include its content in forums.css

  1. … 3 more files in changeset.
Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set

  1. … 3 more files in changeset.
make boolean test strict

  1. … 2 more files in changeset.
Hot fix for latest changes concerning reading info

  1. … 2 more files in changeset.
Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

  1. … 21 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- move validation of message_id into a validation block

- prefer doc(title) over page_title

  1. … 1 more file in changeset.
- use notification-widget for message notification as well

  1. … 1 more file in changeset.
- add editor hints to keep spaces/tabs in the future more consistent

  1. … 350 more files in changeset.
- do localization in script since apparently the arrays for the embedded variables (%forum.name%, %message.subject%) are not passed to the environment where the master is evaluated

- strengthen page contracts

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- remove unneeded braces

- use consistently "naturalnum" instead of "integer" when accepting just positive values

  1. … 125 more files in changeset.
- use numeric comparison for truth value comparison

  1. … 2 more files in changeset.
More fixes for bug 3153 to consider the "anonymous" user case

  1. … 2 more files in changeset.
Fix for bug 3153

  1. … 4 more files in changeset.
1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

  1. … 379 more files in changeset.
- normalize string expressions

  1. … 23 more files in changeset.
- present reply/post button only, when permissions allow it

- present email-message button only, if user is logged in

- present mark_all_read button only, if user is logged in

- add parameter "-user_id" to forums:permissions for orthogonality with the rest of the API

  1. … 4 more files in changeset.
Set meaningful alt text for the expand/collapse image of a message. Added title attribute to the link. Made both accurate with the status of the message.

  1. … 5 more files in changeset.
The print.css link shouldn't be "alternative" but just plain style, since

it's enabled only for the "print" media type and we don't want theme zen's

or any other js to accidently select it ...

Cleaned up forums.js. As discussed in e-mail, changed generic function names

such as "toggle()" to "forums_toggle()" to reduce the odds of future name

clashes causing as much confusion and embarrassment as the recent ones in zen

and forums did. Made formatting consistent. Got rid of template::head calls

to load unused javascript which just made the code more confusing.

Behavior matches .LRN 2.2 behavior, the arrow on a message collapses or

expands that message only, not its subtree. Subtree would probably be better

(and I swear it did, once upon a time) but that will have to wait for the

future if people want it.

  1. … 3 more files in changeset.
I think I removed a bit too much, such as stuff related to optional ajax

usage or something like that, so I put it back.