• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Trim whitespaces

    • -129
    • +129
    ./test/tclwebtest-procs.tcl
- new API function: forum::delete (can't believe, this was missing)

- rework regression test

* make API calls explicit

* ported one test case from (broken) twt to aa_http

- bump version number to 1.3.1d6

    • -0
    • +11
    ./forums-procs-oracle.xql
    • -0
    • +11
    ./forums-procs-postgresql.xql
  1. … 1 more file in changeset.
make tested API calls explicit

improve spelling

  1. … 11 more files in changeset.
Add documentation for public procs (fixes automated tests), replace faq with forum

Add documentation for public proc (fixes automated tests), feed user_id from arguments to permission api, explicitly default to current user (as called procs would do anyway)

Uniform documentation style, add documentation for public proc (fixes automated tests)

Deprecate (former) service contract implementations

Their body was always empty according to the cvs history and there is no mention of them in the code.

Their counterpart in the forum::notification namespace takes care of both forums and messages, therefore supersedes them.

Clearly separate callback hooks from callback implementations, uniform documentation style, remove duplicated callback implementation definitions, uniform indentation, add documentation to public procs (fixes automated tests)

    • -155
    • +111
    ./forums-callback-procs.tcl
Add documentation to public procs (fixes automated tests)

Uniform documentation style

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized for tests when a system was freshly restarted

Put cache flushing logics into procs and use them when forum info needs to be updated (fixes automated tests)

Add documentation and a fallback body for this deprecated proc

Provide a minimal documentation to public procs

Remove hotfix and exploit new api, that won't fail on the guest user

Fix regression when checking if user can anonimously post

Fix regressions in forums when user is not logged in

  1. … 5 more files in changeset.
Disambiguate table reference in subquery

Use more api to streamline queries and reduce divergency between oracle and postgres codebase

move template cacheing function "cache" into template namespace (resulting in template::cache)

  1. … 2 more files in changeset.
Centralize templating cache "black magic"

Use the new proc into forum api

  1. … 1 more file in changeset.
Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

  1. … 2 more files in changeset.
Replace deprecated 'can_read_forum_p' by 'permission::permission_p'

Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

  1. … 4 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
unify spelling of URL

  1. … 1 more file in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
fix typo

  1. … 1 more file in changeset.