• last updated 11 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Handle correctly the indexing of moderated messages in fulltext search:

so far the fulltext search would also include unapproved messages and threads. With this reform we address this by:

- making sure unapproved threads are deleted from the index

- making sure new threads are added to the index only when the are approved

- making sure we unindex or reindex a thread whenever the approval state changes

- not fetching unapproved messages in the datasource callback, hence excluding them from the index

Note that Oracle has not been targeted by the reform. However, the situation improves for Oracle as well, because we won't render unmoderated messages in the datasource callback anymore.

  1. … 3 more files in changeset.
file upgrade-1.4.0d3-1.4.0d4.sql was initially added on branch oacs-5-10.

    • -0
    • +0
New index on the forums_reading_info table

  1. … 2 more files in changeset.
file upgrade-1.4d2-1.4d3.sql was initially added on branch oacs-5-10.

    • -0
    • +0
file upgrade-1.3.1d16-1.3.1d17.sql was initially added on branch oacs-5-10.

    • -0
    • +0
Redefine forum charter as text, therefore without length limit

  1. … 2 more files in changeset.
Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

  1. … 4 more files in changeset.
file upgrade-1.3.1d12-1.3.1d13.sql was initially added on branch oacs-5-10.

    • -0
    • +0
  1. … 1 more file in changeset.
Removed obsolete @arch-tag

  1. … 26 more files in changeset.
improve spelliing

  1. … 3 more files in changeset.
Fix typos

  1. … 61 more files in changeset.
- fix inconsistency between updated versions and new intallations: check always the message format

- add text/markdown to accepted formats

    • -0
    • +11
  1. … 2 more files in changeset.
Port downstream only usage of reading info api

Also fix such api so that root message is retrieved for every given source message

    • -0
    • +34
  1. … 7 more files in changeset.
Fix sql update to populate new forum_id column in existing data

  1. … 1 more file in changeset.
Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in


TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

    • -0
    • +173
  1. … 8 more files in changeset.
Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.


- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

    • -0
    • +13
  1. … 10 more files in changeset.
Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

    • -0
    • +13
  1. … 21 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- make update script more robust

Alter caveman style booleans (type character(1)) to real SQL boolean types.

  1. … 4 more files in changeset.
file upgrade-1.3d12-1.3d13.sql was initially added on branch oacs-5-9.

    • -0
    • +0
- add function args missed by earlier upgrades

- bump version numbers

    • -0
    • +21
  1. … 9 more files in changeset.
- fix half-baken dollar quoting

  1. … 1 more file in changeset.
- fix half-baken dollar quoting

  1. … 1 more file in changeset.
- update postgres function to modern style plpgsql definitions, avoid backslash escaping

- add missing function_args

  1. … 15 more files in changeset.
1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

  1. … 379 more files in changeset.
Fix path of the upgrade script to source

store and display reading info

    • -0
    • +1
  1. … 19 more files in changeset.
Merged changes to HEAD ...

  1. … 1556 more files in changeset.
Forgot the function that needed upgrades as well. Good to have sites that acutally upgraded from 4.6 around :-). ORACLE: NOT TESTED. NOT SURE IF IT IS THE PROPER THING. PLEASE TEST.

  1. … 1 more file in changeset.