• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Forum attachments reform.

- Add new style of attachments to the forums, allowing multiple attachments to a single message directly from the message post page, using the multiple file input widget.

- Retain compatibility with old style attachments, using the new 'AttachmentStyle' package instance parameter. Currently, this supports two values: 'simple' (new behavior) and 'complex' previous behavior.

- Both attachment styles can coexist, and attachments added by any of such methods will be shown.

- Improve the contract on 'forums/lib/message/post.tcl'.

- Show attachments on message preview.

- Bump version number.

  1. … 4 more files in changeset.
Use the attachment icon, available since 10+ years, for forums attachments.

  1. … 2 more files in changeset.
Secure forums delete button by protecting the message_id with a timed signature

  1. … 5 more files in changeset.
Fix regressions in forums when user is not logged in

  1. … 5 more files in changeset.
Pass user_name through the message array, as message-view expects it there

  1. … 1 more file in changeset.
Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

  1. … 4 more files in changeset.
normalize boolean expressions in .adp files

  1. … 1 more file in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- make boolean tests more uniform

  1. … 3 more files in changeset.
- use "true" instead of 0/1 comparison for boolean values in .adp file

- turn javascript: url into an event listener

  1. … 1 more file in changeset.
- fix typo

- allow users to write stuff that looks like a message key in a forums subject or body

- handle post_p like moderate_p

  1. … 4 more files in changeset.
- turn forums/lib/message/row into an include with a include_contract to document expected arguments and defaults

- optimize adp, since this can be called quite frequently in a forums thread

  1. … 1 more file in changeset.
- fix validity of HTML

  1. … 1 more file in changeset.
i18n

  1. … 2 more files in changeset.
Resolve conflicts merging from oacs-5-4

  1. … 1 more file in changeset.
Don't output the UL if the actions list is empty (not valid HTML)

  1. … 1 more file in changeset.
- present reply/post button only, when permissions allow it

- present email-message button only, if user is logged in

- present mark_all_read button only, if user is logged in

- add parameter "-user_id" to forums:permissions for orthogonality with the rest of the API

  1. … 4 more files in changeset.
Moved the reply, forward, etc. buttons after the content (in the read order) but keep it displayed at the same place (CSS magic!).

  1. … 1 more file in changeset.
Set meaningful alt text for the expand/collapse image of a message. Added title attribute to the link. Made both accurate with the status of the message.

  1. … 5 more files in changeset.
Moved css and js and a couple of templates over from 5.4, getting rid of

the notoriously broken expand/collapse thread buttons. This commit is a work

in progress, need to test and perhaps fix ...

  1. … 1 more file in changeset.
Cleaned up forums.js. As discussed in e-mail, changed generic function names

such as "toggle()" to "forums_toggle()" to reduce the odds of future name

clashes causing as much confusion and embarrassment as the recent ones in zen

and forums did. Made formatting consistent. Got rid of template::head calls

to load unused javascript which just made the code more confusing.

Behavior matches .LRN 2.2 behavior, the arrow on a message collapses or

expands that message only, not its subtree. Subtree would probably be better

(and I swear it did, once upon a time) but that will have to wait for the

future if people want it.

  1. … 3 more files in changeset.
HTML Strict cleanup. Refactor to use listtemplate. Added a lib for search box

  1. … 19 more files in changeset.
HTML Strict cleanup

  1. … 4 more files in changeset.
Fixing the display of messages for forums in flat mode:

1. Removing buttons "expand", "collapse" ( flat mode and threaded mode ).

2. Showing messages ordered by input.

3. Showing messages in "flat" mode.

4. Removing "Replay" button.

  1. … 3 more files in changeset.
Merged changes to HEAD ...

  1. … 1556 more files in changeset.
Added Mannheim's changes which includes allowing of screen name rather than

real name (privacy, parameterized), changes some hard-wired english to message

resource keys, etc.

  1. … 27 more files in changeset.
Merging dotlrn-all and dotlrn-extras from oacs-5-2

  1. … 882 more files in changeset.