• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix folder creation in 'folder-zip-add'

Whitespace changes

Fix erroneus file description in page contract

Whitespace changes

rely on ad_urlencode_folder_path working with empty path

check for empty folder_path

encode folder_path

fix overquoting in notification-widget

  1. … 6 more files in changeset.
Localize file-size limits in the UI

Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

Prettify code

Remove obsolete xql files

Bugfixes et al:

- don't throw a server error if one clicks submit on the empty form without specifying a file

- allow to upload the same zipfile multiple times without throwing an error

- streamline idioms

File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

  1. … 4 more files in changeset.
Whitespace changes

  1. … 2 more files in changeset.
Fix typos and wording.

  1. … 1 more file in changeset.
create folder only if it not already exists

Remove commented leftover debugging statement, add comment about why we need to name the list by folder_id

Put template::list name back as parametric, because this code might be included multiple times

Redefine this page as ad_include_contract, therefore removing all hardcoded variable checks and exploit builtin checks, remove duplicated definitions and queries, streamline template::list definitions in a way its is readable and simpler to maintain

Pass also orderby to the includelet

Trim whitespaces

Remove unnecessary parentheses and idioms, state query variables explicitly

don't pass deprecated argumentent "-user_id" to fs::get_folder_contents_count

  1. … 1 more file in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 1 more file in changeset.
Exploit api instead of using local sql

Localize possible I18n message in folder name

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

  1. … 3 more files in changeset.
Reduce divergency between oracle and postgres codebase and remove redundant statements

Dont even offer to delete the root folder as this is prevented anyway