• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- add nonces to script tags

- add body handlers

  1. … 7 more files in changeset.
- replace onChange handlers in forms of evaluation package by event listeners

- modernize HTML (prefer "semantic" attributes)

- quote HTML attributes

    • -25
    • +25
    ./admin/evaluations/student-list.adp
  1. … 9 more files in changeset.
- updated version numbers, regenerated documentation

  1. … 298 more files in changeset.
- add editor hints to .vuh files

  1. … 29 more files in changeset.
- bump version number to 2.9.1d2

- improve security of page_contracts

    • -2
    • +2
    ./admin/tasks/task-add-to-communities.tcl
  1. … 4 more files in changeset.
- add editor hints to keep spaces/tabs in the future more consistent

    • -1
    • +7
    ./admin/evaluations/evaluate-students.tcl
    • -1
    • +7
    ./admin/evaluations/evaluation-delete.tcl
    • -1
    • +7
    ./admin/evaluations/evaluations-edit.tcl
  1. … 336 more files in changeset.
- fix syntax and indentation

    • -8
    • +13
    ./admin/evaluations/student-list.tcl
  1. … 1 more file in changeset.
- standardize argument passing to adp-includes, don't perform double i18n and double quoting

    • -1
    • +1
    ./admin/evaluations/evaluation-delete.adp
    • -1
    • +1
    ./admin/grades/student-grades-report.adp
  1. … 111 more files in changeset.
- fix and standardize quoting in template properties

    • -2
    • +2
    ./admin/evaluations/evaluate-students.adp
    • -2
    • +2
    ./admin/evaluations/evaluation-delete.adp
    • -2
    • +2
    ./admin/evaluations/evaluations-edit.adp
    • -2
    • +2
    ./admin/evaluations/grades-sheet-parse.adp
  1. … 331 more files in changeset.
- standardize url construction to protect against injection attacks

    • -2
    • +2
    ./admin/evaluations/evaluations-edit.tcl
    • -19
    • +28
    ./admin/evaluations/student-list.tcl
    • -2
    • +2
    ./admin/grades/grades-type-reports.tcl
    • -2
    • +2
    ./admin/grades/student-grades-report.tcl
  1. … 10 more files in changeset.
- quote HTML attribute values

- use & in hrefs

    • -13
    • +13
    ./admin/evaluations/evaluate-students.adp
    • -5
    • +5
    ./admin/evaluations/evaluations-edit.adp
    • -1
    • +1
    ./admin/evaluations/grades-sheet-parse.adp
    • -29
    • +29
    ./admin/evaluations/student-list.adp
  1. … 1 more file in changeset.
- use type checking for boolean parameters in page_contracts to improve security

    • -2
    • +2
    ./admin/grades/distribution-edit-2.tcl
    • -2
    • +2
    ./admin/tasks/task-add-to-communities.tcl
  1. … 9 more files in changeset.
Merging back to HEAD all changes that happened in branch oacs-5-8 between tags: vg-merge-oacs-5-8-from-20141027 and vg-merge-oacs-5-8-from-20150427

  1. … 520 more files in changeset.
- replace deprecated ad_require_permission by permission::require_permission in index.vuh files

- replace deprecated ns_tmpnam by ad_tmpname in index.vuh files

  1. … 3 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

    • -15
    • +15
    ./admin/evaluations/evaluate-students.tcl
    • -3
    • +3
    ./admin/evaluations/evaluation-delete.tcl
    • -10
    • +10
    ./admin/evaluations/evaluations-edit.tcl
    • -15
    • +15
    ./admin/evaluations/grades-sheet-parse.tcl
    • -27
    • +27
    ./admin/evaluations/student-list.tcl
    • -5
    • +5
    ./admin/grades/distribution-edit-2.tcl
  1. … 2533 more files in changeset.
- fix ambiguous markup in adp pages due to missing quoting

  1. … 2 more files in changeset.
- improve page contracts (use right type for IDs)

    • -2
    • +2
    ./admin/evaluations/evaluate-students.tcl
    • -3
    • +3
    ./admin/evaluations/evaluation-delete.tcl
    • -3
    • +3
    ./admin/evaluations/evaluations-edit.tcl
    • -3
    • +3
    ./admin/evaluations/grades-sheet-parse.tcl
    • -1
    • +1
    ./admin/grades/distribution-edit-2.tcl
  1. … 29 more files in changeset.
- modernize Tcl (use byte-compiled comparisons, don't use numeric comparisons for string expressions, brace expressions)

    • -14
    • +14
    ./admin/evaluations/evaluate-students.tcl
    • -8
    • +8
    ./admin/evaluations/evaluations-edit.tcl
    • -13
    • +13
    ./admin/evaluations/grades-sheet-parse.tcl
    • -24
    • +24
    ./admin/evaluations/student-list.tcl
    • -4
    • +4
    ./admin/grades/distribution-edit-2.tcl
    • -4
    • +4
    ./admin/grades/distribution-edit-3.tcl
  1. … 20 more files in changeset.
HTML cleanup

  1. … 3 more files in changeset.
Indentation

It's easier to use lang::util::localize instead of lang::message::lookup to render the messages in the tcl

  1. … 1 more file in changeset.
Do the uppercase in the tcl to avoid wrong messages when the grade_plural_name is stored as a message-key

  1. … 1 more file in changeset.
Render the grade_plural_name in the tcl when is stored as a message-key to display it properly

  1. … 1 more file in changeset.
Close unbalanced html tags

Render the message-keys in the tcl to show them in the options of a select in the form

1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

    • -6
    • +14
    ./admin/evaluations/evaluate-students.adp
    • -9
    • +11
    ./admin/evaluations/evaluations-edit.adp
    • -2
    • +3
    ./admin/evaluations/grades-sheet-parse.adp
    • -16
    • +18
    ./admin/evaluations/student-list.adp
    • -4
    • +1
    ./admin/grades/grades-type-reports.adp
    • -2
    • +3
    ./admin/tasks/task-add-to-communities.adp
  1. … 366 more files in changeset.
Checkpoint 3.7 (level AA): Mark up quotations. Do not use quotation markup for formatting effects such as indentation.

    • -6
    • +14
    ./admin/evaluations/evaluate-students.adp
    • -5
    • +7
    ./admin/evaluations/evaluations-edit.adp
    • -2
    • +3
    ./admin/evaluations/grades-sheet-parse.adp
    • -16
    • +18
    ./admin/evaluations/student-list.adp
    • -4
    • +1
    ./admin/grades/grades-type-reports.adp
    • -2
    • +3
    ./admin/tasks/task-add-to-communities.adp
  1. … 2 more files in changeset.
HTML Strict cleanup: removed trailing slash of input, img, link and meta tags

    • -5
    • +5
    ./admin/evaluations/evaluations-edit.adp
  1. … 36 more files in changeset.
HTML Strict cleanup

    • -29
    • +26
    ./admin/evaluations/student-list.adp
  1. … 2 more files in changeset.