• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use 'portal::exists_p' instead of custom idioms

  1. … 7 more files in changeset.
Reinstate get_portal_id_not_cached as private, flush the cache before calling public api instead

  1. … 3 more files in changeset.
Fix api:

upstream dotlrn mounts dotlrn-forums at /dotlrn/forums/, but testcase dotlrn_forums__applet_portlet (dotlrn-forums) deletes such node and replaces it with a new one at /dotlrn/applets/forums/. As site_node::get_package_url does not get flushed, the api will expect to find the mounted instance at the old URL, which now resolves to the parent dotlrn instead! Fix this by not relying on the cache to retrieve the applet node id.

Delete site_node after unmount in 'dotlrn_forums::remove_applet'

Unmount applet on removal

Add 'dotlrn_forums__applet_portlet' test case, covering 'dotlrn_forums::add_applet', 'dotlrn_forums::add_portlet', 'dotlrn_forums::add_portlet_helper', 'dotlrn_forums::remove_portlet' and 'dotlrn_forums::remove_applet'

    • -0
    • +90
    ./test/dotlrn-forums-test-procs.tcl
Implement 'dotlrn_forums::remove_applet'

Set 'dotlrn-forums' procs without current implementation to private

Whitespace changes

  1. … 5 more files in changeset.
Add 'dotlrn_forums::get_pretty_name' and 'dotlrn_forums_admin_portlet::get_pretty_name' to the 'dotlrn_forums_portlet_links_names' test

Add simple test for 'dotlrn_forums_admin_portlet::link'

    • -0
    • +11
    ./test/dotlrn-forums-test-procs.tcl
Add new simple tests for dotlrn-* packages

    • -0
    • +33
    ./test/dotlrn-forums-test-procs.tcl
  1. … 10 more files in changeset.
file dotlrn-forums-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/dotlrn-forums-test-procs.tcl
Add documentation to public procs (fixes automated tests), uniform doc sytle

    • -3
    • +9
    ./dotlrn-forums-admin-portlet-procs.tcl
  1. … 2 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

    • -1
    • +7
    ./dotlrn-forums-admin-portlet-procs.tcl
  1. … 7833 more files in changeset.
- add editor hints to keep spaces/tabs in the future more consistent

    • -1
    • +7
    ./dotlrn-forums-admin-portlet-procs.tcl
  1. … 216 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

    • -1
    • +1
    ./dotlrn-forums-admin-portlet-procs.tcl
  1. … 2546 more files in changeset.
- fix invalid pi-doc variable @version and @cvs_id

    • -1
    • +1
    ./dotlrn-forums-admin-portlet-procs.tcl
  1. … 20 more files in changeset.
- modernize Tcl (use byte-compiled comparisons, don't use numeric comparisons for string expressions)

  1. … 1 more file in changeset.
i18n of admin portlet title

    • -2
    • +2
    ./dotlrn-forums-admin-portlet-procs.tcl
tabs 2 spaces, before making a change about dotlrn admin portlet title

    • -7
    • +7
    ./dotlrn-forums-admin-portlet-procs.tcl
Merged changes to HEAD ...

  1. … 1556 more files in changeset.
Added Mannheim's changes which includes allowing of screen name rather than

real name (privacy, parameterized), changes some hard-wired english to message

resource keys, etc.

  1. … 27 more files in changeset.
Reverted all changes from Mannheim

  1. … 222 more files in changeset.
Mannheim update, fix and merge bugbash

  1. … 197 more files in changeset.
First shot at merging oacs-5-2 apps used in .LRN to HEAD.

  1. … 2478 more files in changeset.
commit to OACS-5-2 merge of changes on OACS-5-1

(using tag vg-merge-dotlrn-2-1-20050922) for packages under dotlrn-all

  1. … 16 more files in changeset.
Resolving outstanding permissions bugs in forums. Please let me know if you have any trouble with it.

  1. … 8 more files in changeset.
merging dotlrn-1-0-1 tag down onto head. Thanks to Jarkko Laine and Mohan Pakkurti for all the help. See comments at http://openacs.org/storage/download/index?version_id=104101

  1. … 121 more files in changeset.
Fixed bug #213: adding user hangs when there's autosubscribe.