• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Clear out old java codebase and update the docs referring to the previous java implementation

  1. … 15 more files in changeset.
Move the main chat rendering in an include to allow reuse in other contexts

  1. … 2 more files in changeset.
skip "-url" in "export_vars -url" since it is the default

  1. … 11 more files in changeset.
Make sure only one tuple per room is returned

room_id is required

Improved SQL query significantly by using "acs_permission.permission_p_recursive_array"

Before, a sample query used 300K buffers, now it is down to 2.6 buffers.

Under bad conditions, the old query used 2s or more.

Fixed broken oracle.xql file (broken since 5 years)

Cleanup the vestigial moderated_p flag

  1. … 7 more files in changeset.
Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

  1. … 3 more files in changeset.
Use better message key

Don't hardcode login requirement (to be continued)

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

  1. … 5 more files in changeset.
Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

  1. … 11 more files in changeset.
Deprecate util_commify_number, replace occurrences and translate automated tests

  1. … 9 more files in changeset.
Harden page contracts using new features in acs-tcl

  1. … 8 more files in changeset.
passing properties consistently with @....;literal@

  1. … 11 more files in changeset.
get rid of legacy message key "menu-Clipboard-Copy"; "menu-Clipboard-Use-Copy" is used since several years instead

  1. … 6 more files in changeset.
When deleting, make sure supplied id is actually a room id

Cleanup unreferenced SQL

Refactor display and edit modes to be based on ad_form. Many thanks to Monika Andergassen and Günter Ernst

  1. … 3 more files in changeset.
Replace handcrafted form with 'ad_form'. Many thanks to Monika Andergassen.

file transcript-new.adp was initially added on branch oacs-5-10.

Replace deprecated API. Fixes 'callgraph__bad_page_calls' test case

Remove 'moderator-grant' and 'moderator-revoke' pages, linked nowhere and using obsolete API

Remove 'chat-room-grant.tcl' page, linked nowhere and using obsolete API

Change input widget to 'number' and use a maximum value for 'messages_time_window' that can be validated in the browser. Bump version number, and add dependency to the 'acs-templating' version providing with the new 'number' widget

  1. … 1 more file in changeset.
improve spelling: move closer to the linux documentation recommendations

  1. … 7 more files in changeset.
Show the "Enable notifications" button in the chat only if the user has not accepted, or explicitly denied, notifications yet

  1. … 1 more file in changeset.
Add "Web notifications" for new messages in the chat. See: https://www.w3.org/TR/notifications/

"You should only request consent to display notifications in response to a user gesture

(e.g. clicking a button). This is not only best practice — you should not be spamming

users with notifications they didn't agree to — but going forward browsers will explicitly

disallow notification permission requests not triggered in response to a user gesture.

Firefox is already doing this from version 72, for example, and Safari has done it for some time."

https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API/Using_the_Notifications_API

  1. … 4 more files in changeset.
Show number of active users in chat. Many thanks to Monika Andergassen

  1. … 3 more files in changeset.