• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace permission::require_write_permission with permission::require_permission across the calendar package

Rationale: permission::require_write_permission assumes the object creator to have write permission on the object. Instead, we should rely on permissions to be set correctly on the calendar. permission::require_write_permission also performs an additional query to retrieve the object creator.

It is unclear whether permission::require_write_permission makes sense at all as an api, but we leave this to a future post-release reform.

  1. … 1 more file in changeset.
strengthen boolean parameters in page contracts

  1. … 26 more files in changeset.
regenerated documentation

  1. … 295 more files in changeset.
Name the form in a way that it will be de-facto unique on the page and multiple instances of the same portlet can be rendered together

Modernize idiom

Use new feature for dt_get_info to retrieve variables in a way that we know what is there and what not

Keep populating the event duration radio button according to the time settings

Provide package_id to the api explicitly

Cleanup unused variables

Cleanup reference to non-existent parameter

Deprecate calendar::assign_permissions, trivial wrapper to the permission api

  1. … 2 more files in changeset.
Deprecate calendar::adjust_date, implementing a trivial default logic

  1. … 1 more file in changeset.
Fix typo

calendar_ids_list won't be passed in the right format to be validated in the page contract, in exchange, quote it properly in the database

Use standard %H:%M notation to pass the event time to calendar creation

Clarify idiom, improve markup

Harden page contract, use modern date widget to avoid custom date parsing

    • -31
    • +11
    ./cal-item-create-recurrence.tcl
Fix spec syntax

Cleanup variables never used and form never rendered

Harden and modernize page contract, remove reference to non-existing database columns from ancient downstream installations

Reinstate lost comment

Use modern date and time form input types so that the time values validated by the contract are the same used by the UI and no different values can be supplied to the form via the pseudo-fields for e.g. year, day and so on...

Shorten idiom

Modernize and tighten page contract

Validate start_date the same way as date

register javascript click event for adding a calender entry only once for each day

before javascript event was registered multiple times: for each day and for each calender event

javascript click event for adding a calender entry was also fired when a calender event was viewed

use adp:icon and fix broken layout

- prefer adp:icon over old-style .gif images

- fix line-breaks in table headers of week-calender, which causes

diffent heights of some of the table headers (1 line vs. 2lines)

This was a problem at least with bootstrap5

  1. … 2 more files in changeset.
prefer adp:icon over old-style .gif images

  1. … 1 more file in changeset.
Allow only one format for the 'date' query parameter, bringing the page contract in line with the "Go to date"-form on this page from which this value is supplied.

Add include contract, bring export page parameter in the page contract, fix javascript handlers