• last updated 3 hours ago
Constraints: committers
Constraints: files
Constraints: dates
minor changes: fixed typo, ease debugging, ...

  1. … 3 more files in changeset.
improve spelling

  1. … 4 more files in changeset.
added warnings/errors in case outdated code is encountered

reduce verbosity

Fix typo

template::element validation reform: do not run custom user-defined validation on fields that are not formally correct

Rationale: user-defined validation often assumes some basic consistency of the submitted value. When this is not formally correct, users might have to reimplement the whole formal validation in their custom fields in order to prevent exceptions. By preventing their custom blocks from being executed, users can rely on their custom fields to be run only against sane values.

Restore formatting in procs doc

Normalize indentation according to editor hints

Go back supporting arbitrary options, potentially from custom user-defined widgets: these will be assumed to be expressed as name-value pairs and we will keep notifying such cases in the logfile

Keep supporting also the htmlarea_p option

Fix doc

Keep handling also the section option

Keep recognizing "format" template::element property, which was never documented

Improve doc

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

  1. … 1 more file in changeset.
Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 58 more files in changeset.
Avoid sending potentially unquoted text via hidden form field

  1. … 1 more file in changeset.
address issue #3433: add option "noquote" for the "inform" widget type

The flag is currently ignored for all other widget types

  1. … 2 more files in changeset.
Deprecate 'element' proc, defined without a namespace

improve documentation

  1. … 1 more file in changeset.
Whitespace changes

  1. … 1 more file in changeset.
ad_form: allow multiple files in 'template::widget::file' by using the 'multiple' attribute of the input tag, new on HTML5.

- Pass the 'multiple' flag to 'template::element::create', so it can be used by widgets to modify their behavior.

- Update 'template::element::create' doc.

- This opens the door to reducing the number of widgets by combining single and multivalued ones into one (for instance, 'multiselect' and 'select' widgets), in the same way the 'file' widget does now.

  1. … 2 more files in changeset.
Quote form field values in validation error messages to prevent XSS attacks

  1. … 4 more files in changeset.
white space changes

improve spelling

  1. … 7 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Fix spelling errors

  1. … 44 more files in changeset.
- fix test for strange validation error

- use ad_log instead of ns_log for warning in such cases