• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
In acs-tcl.documentation__check_proc_doc automated test, if the test fails on procs that belong to namespaces outside the OpenACS codebase, just issue a warning rather than failing

reduce verbosity

Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

  1. … 7 more files in changeset.
make listing of tested procs more complete

  1. … 18 more files in changeset.
make code slightly more regular

  1. … 1 more file in changeset.
make end of options explicit

  1. … 42 more files in changeset.
Exclude deprecated procs from the test

Add an exception for the 'berkdb' command, defined in the global namespace by the Berkeley DB Tcl extension, to the 'naming__proc_naming testcase'

Add exceptions for some commands defined in the global namespace by the 'Trf' Tcl extension to the 'naming__proc_naming testcase'

Add xml-rpc system.* methods as exceptions in the naming__proc_naming test.

The xml-rpc package defines procs of the form system.*, that not only pollute the root namespace, but also contain the '.' character, which is not allowed by OpenACS naming standards.

The package is designed in a way that XML-RPC methods are implemented as 'ad_procs' of the same name (see package doc), and the system.* methods are standard XML-RPC methods (see XML-RPC spec). One could also expect current users of the package to have their own local 'whatever.verb' methods/ad_procs in the root namespace as well. Until future refactoring of the package to decouple XML-RPC method and proc names is done, this exception is added.

Add an exception for the operators implemented as procs in the context of the functional programming logic, on 'acs-tcl/tcl/ad-functional-procs.tcl', to the 'naming__proc_naming' test case. While some of them have names that are not compliant with OpenACS naming conventions, like '-' or '/', replacing them with other symbols is non-trivial and could make things more confusing

Add an exception for the 'dom' proc, defined in tDom, to the 'naming__proc_naming' test case

Add an exception for procs defined inside ns/aolserver modules, such as h264*, on the 'naming__proc_naming' test case

Check the namespace as well in the 'naming__proc_naming' testcase

added test to check, if names of Tcl procsfollow the naming guidelines of OpenACS

Remove the acs-tcl testcase 'documentation__check_proc_testcase', as it provides information already covered by the new 'acs-automated-testing/www/admin/proc-coverage' page and the '::aa::coverage::*' procs

Move xowiki tests in the xowiki package

  1. … 1 more file in changeset.
extend regression test to cover webcallable funcitons

set error-level to warning for documentation__check_proc_testcase (similar to datamodel__named_constraints)

Add 'documentation__check_proc_testcase' test, for checking public procs without test cases. Many thanks to Monika Andergassen.

Allow square brackets in proc doc. In particular, this fixed a false positive with [doc_string] in 'ad_proc'

Improve 'args' check in 'documentation__check_parameters' test case by using the built-in 'varargs_p' variable.

Add 'args' parameter to the real parameter list of the 'documentation__check_parameters', as it is not included into 'switches' or 'positionals'.

Take care of '_p' boolean parameters when checking for discrepancies between real and documented proc parameters.

Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

  1. … 18 more files in changeset.
Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.

Remove apparent leftover + trailing whitespace

rework test case documentation__check_typos

- make test case more robust (don't abort tests when there is a proc_doc without a "main" section

- improve performance and sanity:

* move invariantes out of the loop

* use built-in hashes

* don't check the same term multiple times

... times went from >15 sec to <1sec

Add new test case 'files__trailing_whitespace', which looks for trailing whitespace (spaces or tabs at the end of lines).

Currently, only .tcl files are checked.

  1. … 1 more file in changeset.
Add more information about typos loaded and checks passed