• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured to omit loading of long deprecated code

(WithDeprecatedCode set to 0) files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have

one release time to fix calls to deprecated code. This is especially

important for public procs.

  1. … 1 more file in changeset.
improve spelling

  1. … 6 more files in changeset.
Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured with loading of deprecated procs

deactivated, files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have one

release time to fix calls to deprecated code.

This change reverts in part Antonio's commit from 26 Aug 2022 which

causes errors like the following on openacs.org:

Error in include template "/var/www/openacs.org/packages/news/lib/news":

invalid command name "ad_parameter_all_values_as_list"

  1. … 1 more file in changeset.
Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

  1. … 4 more files in changeset.
Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

  1. … 13 more files in changeset.
Add @see to deprecated procs

  1. … 2 more files in changeset.
Add @see to deprecated procs

  1. … 1 more file in changeset.
Add @see to deprecated procs

Add @see to deprecated procs

Reform of site-nodes-procs

- made XOTcl2 based implementation of site-nodes usable during

initial bootstrap

- made new site-node cache implementation working for Oracle

- now, the same code works during bootstrap, for PostgreSQL and Oracle

and independent of xotcl-core being installed or not.

- removed old and broken nsv-based site-node cache

- reduced need of .xql files (removed query for delete.delete_site_node)

- moved deprecated calls to deprecated-procs.tcl

This change make the code much clearer and eases maintenance and debugging.

  1. … 3 more files in changeset.
move broken procs based on undefined function to decprecated procs and comment it out

  1. … 2 more files in changeset.
Move deprecated api out of the way

  1. … 1 more file in changeset.
Deprecate oacs_util::vars_to_ns_set: modern ns_set idioms make this proc obsolete

  1. … 7 more files in changeset.
Deprecate ad_tcl_vars_list_to_ns_set: modern ns_set idioms make this proc obsolete

  1. … 1 more file in changeset.
Deprecate ad_tcl_vars_to_ns_set: modern ns_set idioms make it obsolete

  1. … 1 more file in changeset.
Deprecate util_ns_set_to_list: ns_set array is an equivalent oneliner

  1. … 5 more files in changeset.
Deprecate util_list_to_ns_set: it can be replaced with a more efficient oneliner

  1. … 2 more files in changeset.
improved spelling

  1. … 5 more files in changeset.
make end of options explicit

  1. … 42 more files in changeset.
Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 58 more files in changeset.
improve spelling

  1. … 6 more files in changeset.
fix loading and Don't move non-deprectated proc to deprecated-procs

  1. … 1 more file in changeset.
Move deprecated stuff in util-procs to deprecated-procs

This has the advantage that their loading can be disabled in the settings

  1. … 1 more file in changeset.
Reduce acs-tcl.documentation__check_deprecated_see test warnings

  1. … 2 more files in changeset.
introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 50 more files in changeset.
Deprecate ad_quotehtml. use ns_quotehtml instead.

  1. … 11 more files in changeset.
improve spelling

  1. … 15 more files in changeset.
improve spelling and deactivate changes that were probably needed only for Firefox 2

  1. … 9 more files in changeset.
improve spelling

  1. … 14 more files in changeset.
Add some @see in deprecated procs