OpenACS / openacs-4 / packages / acs-tcl / tcl

01-database-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 17 Jul 19
Commits this week: 0
Total Lines of Code (LoC): 0
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Sep
2:34 pm

gustafn

Change caching of driver keys

There seems to be a bug in "db_driverkey", when OpenACS connects to

multiple databases [1]. The situation with "db_driverkey" is

complicated by the fact that this function is sometimes called with a

database name in its argument "dbn", and sometimes with a database

handle. This is something to look at in the future.

The new version removes the per-thread caching, which was introduced

to reduce the high number of mutex locks caused in busy machines. The

new version is better by a factor of 2 than older versions, but relies

on NaviServer.

[1] https://openacs.org/forums/message-view?message_id=5537865

Options
    • -33
    • +42
    ./01-database-procs.tcl
Monday 02 Aug
11:26 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

Options
    • -6
    • +3
    ./01-database-procs.tcl
  2. … 7 more files in changeset.
Wednesday 03 Mar
11:32 am

gustafn

whitespace changes: break overlong lines

Options
    • -21
    • +36
    ./01-database-procs.tcl
Monday 01 Mar
10:26 am

gustafn

move function db_current_rdbms to acs-bootstrap installer to improve code locality

Options
    • -6
    • +1
    ./01-database-procs.tcl
  2. … 1 more file in changeset.
10:19 am

gustafn

Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

Options
    • -2
    • +2
    ./01-database-procs.tcl
  2. … 3 more files in changeset.
Sunday 28 Feb
10:56 pm

gustafn

reduce usage of ad_arg_parser by using c-level implementation; fixes as well broken cases of bind-var handling

Options
    • -46
    • +23
    ./01-database-procs.tcl
Saturday 27 Feb
11:25 pm

gustafn

Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

Options
    • -6
    • +5
    ./01-database-procs.tcl
  2. … 7 more files in changeset.
6:48 pm

gustafn

Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

Options
    • -55
    • +65
    ./01-database-procs.tcl
  2. … 3 more files in changeset.
Monday 22 Feb
4:51 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -2
    • +2
    ./01-database-procs.tcl
  2. … 4 more files in changeset.
Wednesday 17 Feb
9:20 am

gustafn

prefer ns_dbquotevalue over db_quote, mark latter as deprecated

Options
    • -3
    • +8
    ./01-database-procs.tcl
  2. … 3 more files in changeset.
Monday 01 Feb
11:47 am

gustafn

make end of options explicit

Options
    • -2
    • +2
    ./01-database-procs.tcl
  2. … 42 more files in changeset.
Tuesday 08 Dec 2020
3:33 pm

gustafn

whitespace changes: break overlong lines

Options
    • -4
    • +11
    ./01-database-procs.tcl
3:31 pm

gustafn

don't throw error message on transaction rollbacks (these are no errors, but use the same exception handling)

Options
    • -3
    • +9
    ./01-database-procs.tcl
Wednesday 28 Oct 2020
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -2
    • +2
    ./01-database-procs.tcl
  2. … 58 more files in changeset.
Tuesday 22 Sep 2020
10:44 am

gustafn

fix broken support for explicit bindvars to db_foreach

Options
    • -2
    • +3
    ./01-database-procs.tcl
Tuesday 25 Aug 2020
1:50 am

gustafn

improve comments

Options
    • -7
    • +1
    ./01-database-procs.tcl
  2. … 4 more files in changeset.
Monday 13 Jul 2020
2:02 pm

gustafn

introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

Options
    • -16
    • +16
    ./01-database-procs.tcl
  2. … 50 more files in changeset.
Friday 03 Jul 2020
9:27 am

gustafn

improve spelling: move closer to the linux documentation recommendations

Options
    • -12
    • +12
    ./01-database-procs.tcl
  2. … 34 more files in changeset.
Monday 25 May 2020
12:21 pm

gustafn

more more fix for issue #3441

As Keith reported, there is was one more issue concerning missing column_names and empty query results. This is now as well fixed in oacs-5-10. Also, the regression test was extended to handle these cases as well.

Options
    • -20
    • +31
    ./01-database-procs.tcl
  2. … 2 more files in changeset.
Friday 22 May 2020
12:45 pm

gustafn

fix for issue #3441

Options
    • -1
    • +2
    ./01-database-procs.tcl
  2. … 1 more file in changeset.
Monday 18 May 2020
11:20 pm

gustafn

use dot instead of colon as separator between package name and cache key to ease readability

Options
    • -2
    • +2
    ./01-database-procs.tcl
  2. … 10 more files in changeset.
11:13 pm

gustafn

acs::per_thread_cache: standardize per-thread caching

- added per-thread cache based on namespaced Tcl variables.

- use per-thread-cache on several occasions

- bump version number of acs-tcl to 5.10.0d34

Options
    • -67
    • +36
    ./01-database-procs.tcl
  2. … 14 more files in changeset.
Wednesday 13 May 2020
10:07 am

gustafn

move code pieces around to centralize concerns

Options
    • -19
    • +2
    ./01-database-procs.tcl
  2. … 2 more files in changeset.
Friday 08 May 2020
3:12 pm

gustafn

fix for issue #3440: problem with SQL queries in db_transactions after some db_multirows

the was a problem with with db_handle management in complex setups,

where a db_multirow iterating over more than one tuple causes

some other queries in the transaction to fail. See as well

the new test case added to the regression test.

Many thanks to Keith Paskett for reporting and the good test case!

https://openacs.org/bugtracker/openacs/bug?format=table&bug_number=3440

Options
    • -131
    • +152
    ./01-database-procs.tcl
  2. … 2 more files in changeset.
Sunday 03 May 2020
6:32 pm

gustafn

provide compatibility function ns_dbquotelist, which is available in newer versions of NaviServer

Options
    • -1
    • +22
    ./01-database-procs.tcl
  2. … 1 more file in changeset.
Friday 22 Nov 2019
5:21 pm

gustafn

prefer all caps spelling for SQL

Options
    • -3
    • +3
    ./01-database-procs.tcl
  2. … 10 more files in changeset.
Friday 01 Nov 2019
2:16 pm

gustafn

Deprecate ad_quotehtml. use ns_quotehtml instead.

Options
    • -2
    • +2
    ./01-database-procs.tcl
  2. … 11 more files in changeset.
Tuesday 08 Oct 2019
6:30 pm

gustafn

Make comma setting more consistent

see: https://onlinewritingtraining.com.au/however-therefore-furthermore/

Options
    • -2
    • +2
    ./01-database-procs.tcl
  2. … 6 more files in changeset.
Sunday 29 Sep 2019
4:55 pm

gustafn

prefer curly braces for list of options

Options
    • -2
    • +2
    ./01-database-procs.tcl
Saturday 10 Aug 2019
4:33 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./01-database-procs.tcl
  2. … 15 more files in changeset.