• last updated 6 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Expose a bug in the message key registration:

when a message key is soft-deleted and the server is restarted, upon re-registration the nsv that signals its presence won't be found and an insertion will be attempted. However, as the db entry is there, a primary key constraint will be triggered.

Stick to packages that are enabled

  1. … 1 more file in changeset.
Use the intended table to get packages that are known to the system

  1. … 1 more file in changeset.
Add comment

Make api to retrieve the dependencies of a package public, as we use it in a test in another package, swith to the api that will retrieve the cached value instead of re-computing the result

  1. … 1 more file in changeset.
New test to check that message keys are used consistently with package dependencies

this can only be enforced as a warning because it is possible to have constructs such as "if installed, then use message key" that would be tricky to detect

list called api procs

complete listing of covered procs in test cases

  1. … 14 more files in changeset.
bring test coverage to >50% by adding test cases and marking only locally called functions as private

  1. … 2 more files in changeset.
improve listing of test coverage

  1. … 17 more files in changeset.
make listing of tested procs more complete

  1. … 5 more files in changeset.
make comment more precise

New test to enforce that catalog files are valid XML

Improve sql portability

    • -22
    • +22
  1. … 6 more files in changeset.
Improve test

New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc

improve spelling

  1. … 4 more files in changeset.
Refactor 'locale_language_fallback' testcase, using 'aa_run_with_teardown' and preventing errors when the 'en_GB' locale is not enabled

mprove spelling: move closer to the linux documentation recommendations

  1. … 21 more files in changeset.
Keep supporting previously undocumented use cases for lc_time_fmt:

- database timestamps e.g. "2019-12-16 12:58:10.370124+01"

- short timestamps without seconds e.g. "2019-12-16 12:58"

Improved documentation and extended test cases

  1. … 1 more file in changeset.
Rename 'random', 'randomInit' and 'randomRange' procs to something compliant to OpenACS naming convention, replace occurrences, create deprecated wrapper

  1. … 7 more files in changeset.
improve handling of invalid (hacked) ad_locale cookies.

Previously, invalid ad_locale cookies lead to an error, which in turn

prevented all communication with OpenACS. So, a user had to delete the

cookie manually. Now, we just produce a warning, ignore and delete such

broken cookies.

  1. … 1 more file in changeset.
Fix typo

Do not rely on error trapping for file retrieval, introduce a test for this proc

  1. … 1 more file in changeset.
lc_content_size_pretty: go the extra mile and return a localized 'byte' when the result is just 1 byte. Bump acs-lang version to reload message keys.

  1. … 34 more files in changeset.
Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

  1. … 41 more files in changeset.
improve spelling

Add 'message-undelete' page to make use of the new '::message::undelete' proc for undeleting messages, a couple of icons, the undelete option in 'message-list' and the undelete action in automated tests

  1. … 6 more files in changeset.
Exclude locales that are not enabled from test

Do not test deleted keys