• last updated 29 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make sure test email is fine even when usernames are emails

Use lowercase letter to append to the fake username, so that if it should be an email, it will still be valid

Complete coverage of ACS Service Contract 'auth_sync_retrieve' implementations

Test IMS_Enterprise_v_1p1 implementation of the auth_sync_process Service Contract

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
Add auth::sync::job::get_authority_id to an existing test

improve listing of test coverage

  1. … 17 more files in changeset.
make listing of tested procs more complete

  1. … 18 more files in changeset.
mprove spelling: move closer to the linux documentation recommendations

  1. … 21 more files in changeset.
Fallback to + #

Whitespace changes

Fix uncomplete test description and simplify single -procs line.

Remove ns_parseurl from list of tested procs, as not being a openacs proc will trigger an error at load time

improve testcases by removing useless expr commands

  1. … 17 more files in changeset.
make tested procs explicit

  1. … 2 more files in changeset.
Fix test on system having 0.0.0.0 as IPv4 address in the config file

Rework of this tests

- use dict idioms instead of array, so we don't have to unset all the time

- use new user api when appropriate

- fix test when we try to reuse the username of somebody who was previously banned.

This is no longer possible and is now reflected in the test

merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.

ad_proc reform:

- use nsf::proc for defining ad_procs, when nsf::proc is available

- nsf::proc is part of the environment of XOTcl2 and provides

an efficient, C-implemented argument parser that can replace

the scripted *__arg_parser of OpenACS.

- The benefits are performance and reduced memory consumption.

* Simple functions (where the calling overhead was a large

part of the execution times can become several times faster

(e.g. db_name is 3x faster, cookie handling is 2x faster),

for functions with much db-activities the percentage will

be less.

* The memory consumption (RSS) of a site like OpenACS.org

is reduced by about 15%.

NEW (with nsf::proc)

::ad_get_cookie x: 10.93 microseconds per iteration

::ad_get_cookie ad_session_id: 21.95 microseconds per iteration

::dt_systime: 24.89 microseconds per iteration

::db_name: 8.70 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 316.66 microseconds per iteration

::ad_convert_to_html "hello world": 102.29 microseconds per iteration

OLD (without nsf::proc)

::ad_get_cookie x: 19.42 microseconds per iteration

::ad_get_cookie ad_session_id: 30.10 microseconds per iteration

::dt_systime: 27.55 microseconds per iteration

::db_name: 32.28 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 366.69 microseconds per iteration

::ad_convert_to_html "hello world": 160.51 microseconds per iteration

======================================================================

proc mtime cmd {set c 5000

set t [time [list time $cmd $c]];

regexp {^(-?[0-9]+) +} $t _ mS1;

set ms [expr {$mS1*1.0/$c}];

return "[format %6.2f $ms] microseconds per iteration"

}

set tests {

{::ad_get_cookie x} {::ad_get_cookie ad_session_id} {::dt_systime}

{::db_name} {::db_string dbqd.null.g "select version() from dual"}

{::ad_convert_to_html "hello world"}

}

foreach t $tests {append ::_ $t ": " [mtime $t] \n}

set ::_

======================================================================

  1. … 9 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

  1. … 13 more files in changeset.
- make exists_and_not_null explicit

  1. … 6 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
Should've been more thorough. Turns out every single test case was registered with backslash-space on the first line, causing an error

Fixed broken case: space after backslash

Added categories to the automated test(s).

  1. … 3 more files in changeset.
Added local file system auth_retrieve_doc driver

  1. … 2 more files in changeset.
Fixed batch sync test cases

  1. … 1 more file in changeset.
Fixed broken test cases

  1. … 2 more files in changeset.