OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 28 Nov
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 17 Jun 2018
9:30 pm

hectorr

Whitespace changes

Options
    • -13
    • +13
    /openacs-4/packages/acs-automated-testing/tcl/tclwebtest-procs.tcl
9:27 pm

hectorr

Fix wrong bracket

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/tclwebtest-procs.tcl
9:20 pm

hectorr

Avoid unnecesary existence checks

Options
    • -3
    • +3
    /openacs-4/packages/acs-service-contract/tcl/contract-procs.tcl
Saturday 16 Jun 2018
2:01 am

gustafn

align comment to implementation; be more explicit on optional/default values

Options
    • -7
    • +13
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
1:55 am

hectorr

Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

Options
    • -4
    • +4
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
1:11 am

hectorr

Whitespace changes

Options
    • -196
    • +195
    /openacs-4/packages/assessment/tcl/as-assessment-procs.tcl
    • -60
    • +61
    /openacs-4/packages/assessment/tcl/as-item-display-tb-procs.tcl
    • -92
    • +92
    /openacs-4/packages/assessment/tcl/as-item-procs.tcl
    • -51
    • +51
    /openacs-4/packages/assessment/tcl/as-item-type-sa-procs.tcl
    • -70
    • +70
    /openacs-4/packages/bug-tracker/tcl/bug-procs.tcl
    • -5
    • +5
    /openacs-4/packages/chat/www/search-2.tcl
12:47 am

hectorr

Avoid unnecesary existence checks.

Options
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/as-assessment-procs.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/as-item-display-tb-procs.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/tcl/as-item-procs.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/as-item-type-sa-procs.tcl
    • -3
    • +3
    /openacs-4/packages/bug-tracker/tcl/bug-procs.tcl
    • -4
    • +2
    /openacs-4/packages/chat/www/search-2.tcl
12:17 am

antoniop

Remove duplication and use more api

This code could not work on oracle... not sure if this was considered, or people just assumed fts was a Postgres-only thing

Options
    • -36
    • +14
    /openacs-4/packages/acs-content-repository/tcl/search-procs.tcl
12:12 am

hectorr

Whitespace cleanup

Options
    • -71
    • +71
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
12:10 am

hectorr

Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/users/complex-search.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
Friday 15 Jun 2018
11:49 pm

antoniop

Use api to remove difference between oracle and postgres code and replace array with dict idioms

Options
    • -20
    • +0
    /openacs-4/packages/acs-admin/www/subsites-oracle.xql
    • -20
    • +0
    /openacs-4/packages/acs-admin/www/subsites-postgresql.xql
    • -10
    • +22
    /openacs-4/packages/acs-admin/www/subsites.tcl
11:33 pm

antoniop

Remove leftover xql files

Options
    • -19
    • +0
    /openacs-4/packages/acs-admin/www/index-oracle.xql
    • -19
    • +0
    /openacs-4/packages/acs-admin/www/index-postgresql.xql
11:25 pm

antoniop

Use api to remove difference between oracle and postgres codebase

Options
    • -24
    • +0
    /openacs-4/packages/acs-subsite/www/admin/host-node-map/index-oracle.xql
    • -25
    • +0
    /openacs-4/packages/acs-subsite/www/admin/host-node-map/index-postgresql.xql
    • -5
    • +14
    /openacs-4/packages/acs-subsite/www/admin/host-node-map/index.tcl
11:04 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -22
    • +0
    /openacs-4/packages/rss-support/www/subscrs-include-oracle.xql
    • -22
    • +0
    /openacs-4/packages/rss-support/www/subscrs-include-postgresql.xql
    • -1
    • +14
    /openacs-4/packages/rss-support/www/subscrs-include.tcl
10:55 pm

antoniop

Avoid two times the same query just because we might filter by forum

Options
    • -20
    • +2
    /openacs-4/packages/forums/lib/search/search-chunk-oracle.xql
    • -20
    • +2
    /openacs-4/packages/forums/lib/search/search-chunk-postgresql.xql
    • -12
    • +10
    /openacs-4/packages/forums/lib/search/search-chunk.tcl
10:50 pm

antoniop

Pass user_name through the message array, as message-view expects it there

Options
    • -2
    • +2
    /openacs-4/packages/forums/lib/message/row.adp
    • -4
    • +4
    /openacs-4/packages/forums/lib/message/row.tcl
10:26 pm

antoniop

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

Options
    • -46
    • +0
    /openacs-4/packages/forums/lib/message/content-updater-oracle.xql
    • -51
    • +0
    /openacs-4/packages/forums/lib/message/content-updater-postgresql.xql
    • -8
    • +0
    /openacs-4/packages/forums/lib/message/content-updater.adp
    • -45
    • +0
    /openacs-4/packages/forums/lib/message/content-updater.tcl
    • -4
    • +1
    /openacs-4/packages/forums/www/load-message-content.adp
    • -3
    • +9
    /openacs-4/packages/forums/www/load-message-content.tcl
9:59 pm

antoniop

Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

Options
    • -3
    • +8
    /openacs-4/packages/forums/lib/message/row.adp
    • -16
    • +5
    /openacs-4/packages/forums/lib/message/row.tcl
    • -2
    • +0
    /openacs-4/packages/forums/lib/message/thread-chunk-oracle.xql
    • -10
    • +4
    /openacs-4/packages/forums/lib/message/thread-chunk-postgresql.xql
    • -19
    • +15
    /openacs-4/packages/forums/lib/message/thread-chunk.tcl
6:46 pm

antoniop

Use more api to streamline queries and reduce divergency between oracle and postgres codebase

Options
    • -22
    • +4
    /openacs-4/packages/forums/tcl/messages-procs-oracle.xql
    • -28
    • +6
    /openacs-4/packages/forums/tcl/messages-procs-postgresql.xql
    • -7
    • +22
    /openacs-4/packages/forums/tcl/messages-procs.tcl
5:11 pm

antoniop

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

Options
    • -25
    • +0
    /openacs-4/packages/file-storage/tcl/file-storage-procs-oracle.xql
    • -43
    • +0
    /openacs-4/packages/file-storage/tcl/file-storage-procs-postgresql.xql
    • -61
    • +78
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -39
    • +13
    /openacs-4/packages/file-storage/www/folder-delete.tcl
    • -26
    • +17
    /openacs-4/packages/file-storage/www/version-delete.tcl
2:31 pm

antoniop

Remove leftover sql and unused variables

Options
    • -45
    • +0
    /openacs-4/packages/calendar-portlet/www/calendar-portlet-oracle.xql
    • -45
    • +0
    /openacs-4/packages/calendar-portlet/www/calendar-portlet-postgresql.xql
    • -13
    • +5
    /openacs-4/packages/calendar-portlet/www/calendar-portlet.tcl
2:28 pm

hectorr

Whitespace changes

Options
    • -3
    • +3
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
12:04 pm

gustafn

new feature: offer swa the ability to view compiled template

Options
    • -7
    • +9
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +3
    /openacs-4/packages/acs-api-browser/www/content-page-view.adp
    • -6
    • +28
    /openacs-4/packages/acs-api-browser/www/content-page-view.tcl
11:27 am

antoniop

Reduce divergency between oracle and postgres codebase and remove redundant statements

Options
    • -17
    • +0
    /openacs-4/packages/file-storage/www/file-oracle.xql
    • -43
    • +0
    /openacs-4/packages/file-storage/www/file-postgresql.xql
    • -8
    • +22
    /openacs-4/packages/file-storage/www/file.tcl
11:14 am

antoniop

Remove leftover statement

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/filter-procs.tcl
10:43 am

gustafn

remove empty, unused, privated function acs_reference_get_db_structure

Options
    • -21
    • +0
    /openacs-4/packages/acs-reference/tcl/acs-reference-procs.tcl
10:39 am

gustafn

whitespace changes

Options
    • -13
    • +13
    /openacs-4/packages/acs-tcl/tcl/object-type-procs.tcl
10:35 am

gustafn

remove unused private function acs_object_type::acs_object_instance_of

Options
    • -17
    • +1
    /openacs-4/packages/acs-tcl/tcl/object-type-procs.tcl
10:30 am

gustafn

fix broken API function acs_object_type::get_table_name (broken since 13 years) and use API instead of direct SQL queries

Options
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -11
    • +4
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
    • -5
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-content-repository/tcl/filter-procs.tcl
    • -9
    • +0
    /openacs-4/packages/acs-content-repository/tcl/filter-procs.xql
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -5
    • +10
    /openacs-4/packages/acs-tcl/tcl/object-type-procs.tcl
    • -19
    • +0
    /openacs-4/packages/acs-tcl/tcl/object-type-procs.xql
9:57 am

gustafn

remove outdated file, maintained version of the code is in the function apm_build_repository

Options
    • -313
    • +0
    /openacs-4/packages/acs-admin/www/apm/build-repository.tcl