2021-09-07 gustafn * packages/acs-core-docs/www/aolserver.html: * packages/acs-core-docs/www/aolserver4.html: * packages/acs-core-docs/www/automated-testing-best-practices.html: * packages/acs-core-docs/www/backup-recovery.adp: * packages/acs-core-docs/www/backup-recovery.html: * packages/acs-core-docs/www/bootstrap-acs.html: * packages/acs-core-docs/www/configuring-configuring-packages.adp: * packages/acs-core-docs/www/configuring-configuring-packages.html: * packages/acs-core-docs/www/configuring-configuring-permissions.adp: * packages/acs-core-docs/www/configuring-configuring-permissions.html: * packages/acs-core-docs/www/configuring-install-packages.adp: * packages/acs-core-docs/www/configuring-install-packages.html: * packages/acs-core-docs/www/configuring-mounting-packages.adp: * packages/acs-core-docs/www/configuring-mounting-packages.html: * packages/acs-core-docs/www/credits.html: * packages/acs-core-docs/www/cvs-guidelines.adp: * packages/acs-core-docs/www/cvs-guidelines.html: * packages/acs-core-docs/www/cvs-tips.adp: * packages/acs-core-docs/www/cvs-tips.html: * packages/acs-core-docs/www/db-api-detailed.html: * packages/acs-core-docs/www/db-api.html: * packages/acs-core-docs/www/docbook-primer.adp: * packages/acs-core-docs/www/docbook-primer.html: * packages/acs-core-docs/www/eng-standards-constraint-naming.html: * packages/acs-core-docs/www/eng-standards-filenaming.html: * packages/acs-core-docs/www/eng-standards-plsql.html: * packages/acs-core-docs/www/eng-standards-versioning.html: * packages/acs-core-docs/www/ext-auth-requirements.adp: * packages/acs-core-docs/www/ext-auth-requirements.html: * packages/acs-core-docs/www/filename.html: * packages/acs-core-docs/www/form-builder.adp: * packages/acs-core-docs/www/form-builder.html: * packages/acs-core-docs/www/high-avail.adp: * packages/acs-core-docs/www/high-avail.html: * packages/acs-core-docs/www/how-do-I.adp: * packages/acs-core-docs/www/how-do-I.html: * packages/acs-core-docs/www/i18n-convert.adp: * packages/acs-core-docs/www/i18n-convert.html: * packages/acs-core-docs/www/index.adp: * packages/acs-core-docs/www/index.html: * packages/acs-core-docs/www/individual-programs.html: * packages/acs-core-docs/www/install-cvs.adp: * packages/acs-core-docs/www/install-cvs.html: * packages/acs-core-docs/www/install-daemontools.adp: * packages/acs-core-docs/www/install-daemontools.html: * packages/acs-core-docs/www/install-full-text-search-tsearch2.adp: * packages/acs-core-docs/www/install-full-text-search-tsearch2.html: * packages/acs-core-docs/www/install-next-nightly-vacuum.html: * packages/acs-core-docs/www/install-openacs-keepalive.adp: * packages/acs-core-docs/www/install-openacs-keepalive.html: * packages/acs-core-docs/www/install-qmail.adp: * packages/acs-core-docs/www/install-qmail.html: * packages/acs-core-docs/www/install-redhat.adp: * packages/acs-core-docs/www/install-redhat.html: * packages/acs-core-docs/www/install-steps.adp: * packages/acs-core-docs/www/install-steps.html: * packages/acs-core-docs/www/ix01.adp: * packages/acs-core-docs/www/ix01.html: * packages/acs-core-docs/www/mac-installation.html: * packages/acs-core-docs/www/maint-performance.adp: * packages/acs-core-docs/www/maint-performance.html: * packages/acs-core-docs/www/maintenance-deploy.adp: * packages/acs-core-docs/www/maintenance-deploy.html: * packages/acs-core-docs/www/object-identity.html: * packages/acs-core-docs/www/objects.adp: * packages/acs-core-docs/www/objects.html: * packages/acs-core-docs/www/openacs.adp: * packages/acs-core-docs/www/openacs.html: * packages/acs-core-docs/www/oracle.html: * packages/acs-core-docs/www/packages.adp: * packages/acs-core-docs/www/packages.html: * packages/acs-core-docs/www/parties.html: * packages/acs-core-docs/www/permissions-tediously-explained.adp: * packages/acs-core-docs/www/permissions-tediously-explained.html: * packages/acs-core-docs/www/permissions.html: * packages/acs-core-docs/www/programming-with-aolserver.html: * packages/acs-core-docs/www/psgml-for-emacs.adp: * packages/acs-core-docs/www/psgml-for-emacs.html: * packages/acs-core-docs/www/psgml-mode.html: * packages/acs-core-docs/www/release-notes.adp: * packages/acs-core-docs/www/release-notes.html: * packages/acs-core-docs/www/releasing-openacs-core.html: * packages/acs-core-docs/www/request-processor.html: * packages/acs-core-docs/www/requirements-template.html: * packages/acs-core-docs/www/security-notes.html: * packages/acs-core-docs/www/style-guide.html: * packages/acs-core-docs/www/subsites.html: * packages/acs-core-docs/www/tcl-doc.html: * packages/acs-core-docs/www/templates.html: * packages/acs-core-docs/www/tutorial-css-layout.adp: * packages/acs-core-docs/www/tutorial-css-layout.html: * packages/acs-core-docs/www/tutorial-cvs.adp: * packages/acs-core-docs/www/tutorial-cvs.html: * packages/acs-core-docs/www/tutorial-database.adp: * packages/acs-core-docs/www/tutorial-database.html: * packages/acs-core-docs/www/tutorial-debug.adp: * packages/acs-core-docs/www/tutorial-debug.html: * packages/acs-core-docs/www/tutorial-distribute.adp: * packages/acs-core-docs/www/tutorial-distribute.html: * packages/acs-core-docs/www/tutorial-etp-templates.adp: * packages/acs-core-docs/www/tutorial-etp-templates.html: * packages/acs-core-docs/www/tutorial-newpackage.adp: * packages/acs-core-docs/www/tutorial-newpackage.html: * packages/acs-core-docs/www/tutorial-pages.adp: * packages/acs-core-docs/www/tutorial-pages.html: * packages/acs-core-docs/www/unix-installation.html: * packages/acs-core-docs/www/upgrade-4.5-to-4.6.adp: * packages/acs-core-docs/www/upgrade-4.5-to-4.6.html: * packages/acs-core-docs/www/upgrade-openacs-files.adp: * packages/acs-core-docs/www/upgrade-openacs-files.html: * packages/acs-core-docs/www/upgrade-overview.adp: * packages/acs-core-docs/www/upgrade-overview.html: * packages/acs-core-docs/www/variables.adp: * packages/acs-core-docs/www/variables.html: * packages/acs-core-docs/www/xml/for-everyone/release-notes-5-10.xml: * packages/acs-core-docs/www/xml/for-everyone/release-notes.xml: * packages/acs-events/www/doc/requirements.adp: * packages/acs-lang/www/doc/i18n-requirements.adp: regenerated documentation, including change log 2021-09-06 gustafn * packages/acs-tcl/tcl/text-html-procs.tcl: make ad_dom_sanitize_html more robust against invalid input * packages/acs-tcl/tcl/request-processor-procs.tcl: prettify error message * packages/acs-core-docs/www/xml/for-everyone/release-notes-5-10.xml: * packages/acs-core-docs/www/xml/for-everyone/release-notes.xml: wrestled DocBook down to accept Changes listing 2021-09-06 antoniop * packages/acs-tcl/tcl/text-html-procs.tcl: Fix typo * packages/xowiki/tcl/form-field-procs.tcl: State dependecny from package-procs, or ::xowiki::CSS class won't be available to this library at boot * packages/acs-tcl/tcl/text-html-procs.tcl: Unwrap fake one-liners * packages/xowiki/tcl/package-procs.tcl: Whitespace cleanup 2021-09-03 gustafn * packages/acs-authentication/www/doc/configure-batch-sync.adp: * packages/acs-authentication/www/doc/ext-auth-pam-install.adp: * packages/acs-automated-testing/www/doc/index.adp: * packages/acs-automated-testing/www/doc/install.adp: * packages/acs-automated-testing/www/doc/requirements.adp: * packages/acs-automated-testing/www/doc/usage.adp: * packages/acs-content-repository/www/doc/api/content.adp: * packages/acs-content-repository/www/doc/api/extlink.adp: * packages/acs-content-repository/www/doc/api/folder.adp: * packages/acs-content-repository/www/doc/api/item.adp: * packages/acs-content-repository/www/doc/api/keyword.adp: * packages/acs-content-repository/www/doc/api/permission.adp: * packages/acs-content-repository/www/doc/api/revision.adp: * packages/acs-content-repository/www/doc/api/symlink.adp: * packages/acs-content-repository/www/doc/api/template.adp: * packages/acs-content-repository/www/doc/api/type.adp: * packages/acs-content-repository/www/doc/design.adp: * packages/acs-content-repository/www/doc/guide/access-control.adp: * packages/acs-content-repository/www/doc/guide/convert.adp: * packages/acs-content-repository/www/doc/guide/file-system.adp: * packages/acs-content-repository/www/doc/guide/items.adp: * packages/acs-content-repository/www/doc/guide/keywords.adp: * packages/acs-content-repository/www/doc/guide/object-relationships.adp: * packages/acs-content-repository/www/doc/guide/publish.adp: * packages/acs-content-repository/www/doc/guide/revisions.adp: * packages/acs-content-repository/www/doc/guide/search.adp: * packages/acs-content-repository/www/doc/guide/storage.adp: * packages/acs-content-repository/www/doc/guide/template.adp: * packages/acs-content-repository/www/doc/guide/types.adp: * packages/acs-content-repository/www/doc/guide/workflow.adp: * packages/acs-content-repository/www/doc/index.adp: * packages/acs-content-repository/www/doc/install.adp: * packages/acs-content-repository/www/doc/intermedia.adp: * packages/acs-content-repository/www/doc/object-model.adp: * packages/acs-content-repository/www/doc/requirements.adp: * packages/acs-content-repository/www/doc/todo.adp: * packages/acs-content-repository/www/doc/tutorial.adp: * packages/acs-content-repository/www/doc/uninstall.adp: * packages/acs-core-docs/www/acs-admin.adp: * packages/acs-core-docs/www/acs-package-dev.adp: * packages/acs-core-docs/www/acs-plat-dev.adp: * packages/acs-core-docs/www/analog-install.adp: * packages/acs-core-docs/www/analog-setup.adp: * packages/acs-core-docs/www/aolserver.adp: * packages/acs-core-docs/www/aolserver.html: * packages/acs-core-docs/www/aolserver4.adp: * packages/acs-core-docs/www/aolserver4.html: * packages/acs-core-docs/www/apm-design.adp: * packages/acs-core-docs/www/apm-design.html: * packages/acs-core-docs/www/apm-requirements.adp: * packages/acs-core-docs/www/apm-requirements.html: * packages/acs-core-docs/www/automated-backup.adp: * packages/acs-core-docs/www/automated-testing-best-practices.adp: * packages/acs-core-docs/www/automated-testing-best-practices.html: * packages/acs-core-docs/www/backup-recovery.adp: * packages/acs-core-docs/www/backup-recovery.html: * packages/acs-core-docs/www/backups-with-cvs.adp: * packages/acs-core-docs/www/bootstrap-acs.adp: * packages/acs-core-docs/www/bootstrap-acs.html: * packages/acs-core-docs/www/complete-install.adp: * packages/acs-core-docs/www/configuring-configuring-packages.adp: * packages/acs-core-docs/www/configuring-configuring-packages.html: * packages/acs-core-docs/www/configuring-configuring-permissions.adp: * packages/acs-core-docs/www/configuring-configuring-permissions.html: * packages/acs-core-docs/www/configuring-install-packages.adp: * packages/acs-core-docs/www/configuring-install-packages.html: * packages/acs-core-docs/www/configuring-mounting-packages.adp: * packages/acs-core-docs/www/configuring-mounting-packages.html: * packages/acs-core-docs/www/configuring-new-site.adp: * packages/acs-core-docs/www/configuring-new-site.html: * packages/acs-core-docs/www/credits.adp: * packages/acs-core-docs/www/credits.html: * packages/acs-core-docs/www/cvs-guidelines.adp: * packages/acs-core-docs/www/cvs-guidelines.html: * packages/acs-core-docs/www/cvs-tips.adp: * packages/acs-core-docs/www/cvs-tips.html: * packages/acs-core-docs/www/database-management.adp: * packages/acs-core-docs/www/db-api-detailed.adp: * packages/acs-core-docs/www/db-api-detailed.html: * packages/acs-core-docs/www/db-api.adp: * packages/acs-core-docs/www/db-api.html: * packages/acs-core-docs/www/dev-guide.adp: * packages/acs-core-docs/www/doc-standards.adp: * packages/acs-core-docs/www/docbook-primer.adp: * packages/acs-core-docs/www/docbook-primer.html: * packages/acs-core-docs/www/eng-standards-constraint-naming.adp: * packages/acs-core-docs/www/eng-standards-constraint-naming.html: * packages/acs-core-docs/www/eng-standards-filenaming.adp: * packages/acs-core-docs/www/eng-standards-filenaming.html: * packages/acs-core-docs/www/eng-standards-plsql.adp: * packages/acs-core-docs/www/eng-standards-plsql.html: * packages/acs-core-docs/www/eng-standards-versioning.adp: * packages/acs-core-docs/www/eng-standards-versioning.html: * packages/acs-core-docs/www/eng-standards.adp: * packages/acs-core-docs/www/ext-auth-requirements.adp: * packages/acs-core-docs/www/ext-auth-requirements.html: * packages/acs-core-docs/www/filename.adp: * packages/acs-core-docs/www/filename.html: * packages/acs-core-docs/www/files/acs-start.adp: * packages/acs-core-docs/www/files/dotlrn-style-2.adp: * packages/acs-core-docs/www/files/openacs-start.adp: * packages/acs-core-docs/www/for-everyone.adp: * packages/acs-core-docs/www/form-builder.adp: * packages/acs-core-docs/www/form-builder.html: * packages/acs-core-docs/www/general-documents.adp: * packages/acs-core-docs/www/groups-design.adp: * packages/acs-core-docs/www/groups-requirements.adp: * packages/acs-core-docs/www/groups-requirements.html: * packages/acs-core-docs/www/high-avail.adp: * packages/acs-core-docs/www/high-avail.html: * packages/acs-core-docs/www/how-do-I.adp: * packages/acs-core-docs/www/how-do-I.html: * packages/acs-core-docs/www/i18n-convert.adp: * packages/acs-core-docs/www/i18n-convert.html: * packages/acs-core-docs/www/i18n-design.adp: * packages/acs-core-docs/www/i18n-introduction.adp: * packages/acs-core-docs/www/i18n-introduction.html: * packages/acs-core-docs/www/i18n-overview.adp: * packages/acs-core-docs/www/i18n-requirements.adp: * packages/acs-core-docs/www/i18n-requirements.html: * packages/acs-core-docs/www/i18n-translators.adp: * packages/acs-core-docs/www/i18n.adp: * packages/acs-core-docs/www/index.adp: * packages/acs-core-docs/www/index.html: * packages/acs-core-docs/www/individual-programs.adp: * packages/acs-core-docs/www/individual-programs.html: * packages/acs-core-docs/www/install-cvs.adp: * packages/acs-core-docs/www/install-cvs.html: * packages/acs-core-docs/www/install-daemontools.adp: * packages/acs-core-docs/www/install-daemontools.html: * packages/acs-core-docs/www/install-full-text-search-tsearch2.adp: * packages/acs-core-docs/www/install-full-text-search-tsearch2.html: * packages/acs-core-docs/www/install-ldap-radius.adp: * packages/acs-core-docs/www/install-ldap-radius.html: * packages/acs-core-docs/www/install-more-software.adp: * packages/acs-core-docs/www/install-next-add-server.adp: * packages/acs-core-docs/www/install-next-add-server.html: * packages/acs-core-docs/www/install-next-backups.adp: * packages/acs-core-docs/www/install-next-nightly-vacuum.adp: * packages/acs-core-docs/www/install-next-nightly-vacuum.html: * packages/acs-core-docs/www/install-nsopenssl.adp: * packages/acs-core-docs/www/install-nspam.adp: * packages/acs-core-docs/www/install-openacs-delete-tablespace.adp: * packages/acs-core-docs/www/install-openacs-inittab.adp: * packages/acs-core-docs/www/install-openacs-inittab.html: * packages/acs-core-docs/www/install-openacs-keepalive.adp: * packages/acs-core-docs/www/install-openacs-keepalive.html: * packages/acs-core-docs/www/install-origins.adp: * packages/acs-core-docs/www/install-overview.adp: * packages/acs-core-docs/www/install-pam-radius.adp: * packages/acs-core-docs/www/install-php.adp: * packages/acs-core-docs/www/install-php.html: * packages/acs-core-docs/www/install-qmail.adp: * packages/acs-core-docs/www/install-qmail.html: * packages/acs-core-docs/www/install-redhat.adp: * packages/acs-core-docs/www/install-redhat.html: * packages/acs-core-docs/www/install-resources.adp: * packages/acs-core-docs/www/install-squirrelmail.adp: * packages/acs-core-docs/www/install-ssl.adp: * packages/acs-core-docs/www/install-steps.adp: * packages/acs-core-docs/www/install-steps.html: * packages/acs-core-docs/www/install-tclwebtest.adp: * packages/acs-core-docs/www/ix01.adp: * packages/acs-core-docs/www/ix01.html: * packages/acs-core-docs/www/kernel-doc.adp: * packages/acs-core-docs/www/kernel-overview.adp: * packages/acs-core-docs/www/mac-installation.adp: * packages/acs-core-docs/www/mac-installation.html: * packages/acs-core-docs/www/maint-performance.adp: * packages/acs-core-docs/www/maint-performance.html: * packages/acs-core-docs/www/maintenance-deploy.adp: * packages/acs-core-docs/www/maintenance-deploy.html: * packages/acs-core-docs/www/maintenance-web.adp: * packages/acs-core-docs/www/nxml-mode.adp: * packages/acs-core-docs/www/object-identity.adp: * packages/acs-core-docs/www/object-identity.html: * packages/acs-core-docs/www/object-system-design.adp: * packages/acs-core-docs/www/object-system-design.html: * packages/acs-core-docs/www/object-system-requirements.adp: * packages/acs-core-docs/www/object-system-requirements.html: * packages/acs-core-docs/www/objects.adp: * packages/acs-core-docs/www/objects.html: * packages/acs-core-docs/www/openacs-overview.adp: * packages/acs-core-docs/www/openacs-unpack.adp: * packages/acs-core-docs/www/openacs.adp: * packages/acs-core-docs/www/openacs.html: * packages/acs-core-docs/www/oracle.adp: * packages/acs-core-docs/www/oracle.html: * packages/acs-core-docs/www/os-install.adp: * packages/acs-core-docs/www/os-security.adp: * packages/acs-core-docs/www/packages.adp: * packages/acs-core-docs/www/packages.html: * packages/acs-core-docs/www/parties.adp: * packages/acs-core-docs/www/parties.html: * packages/acs-core-docs/www/permissions-design.adp: * packages/acs-core-docs/www/permissions-design.html: * packages/acs-core-docs/www/permissions-requirements.adp: * packages/acs-core-docs/www/permissions-tediously-explained.adp: * packages/acs-core-docs/www/permissions-tediously-explained.html: * packages/acs-core-docs/www/permissions.adp: * packages/acs-core-docs/www/permissions.html: * packages/acs-core-docs/www/postgres.adp: * packages/acs-core-docs/www/profile-code.adp: * packages/acs-core-docs/www/programming-with-aolserver.adp: * packages/acs-core-docs/www/programming-with-aolserver.html: * packages/acs-core-docs/www/psgml-for-emacs.adp: * packages/acs-core-docs/www/psgml-for-emacs.html: * packages/acs-core-docs/www/psgml-mode.adp: * packages/acs-core-docs/www/psgml-mode.html: * packages/acs-core-docs/www/release-notes.adp: * packages/acs-core-docs/www/release-notes.html: * packages/acs-core-docs/www/releasing-openacs-core.adp: * packages/acs-core-docs/www/releasing-openacs-core.html: * packages/acs-core-docs/www/releasing-openacs.adp: * packages/acs-core-docs/www/releasing-package.adp: * packages/acs-core-docs/www/remote-postgres.adp: * packages/acs-core-docs/www/request-processor.adp: * packages/acs-core-docs/www/request-processor.html: * packages/acs-core-docs/www/requirements-template.adp: * packages/acs-core-docs/www/requirements-template.html: * packages/acs-core-docs/www/rp-design.adp: * packages/acs-core-docs/www/rp-design.html: * packages/acs-core-docs/www/rp-requirements.adp: * packages/acs-core-docs/www/security-design.adp: * packages/acs-core-docs/www/security-design.html: * packages/acs-core-docs/www/security-notes.adp: * packages/acs-core-docs/www/security-notes.html: * packages/acs-core-docs/www/security-requirements.adp: * packages/acs-core-docs/www/snapshot-backup.adp: * packages/acs-core-docs/www/snapshot-backup.html: * packages/acs-core-docs/www/style-guide.adp: * packages/acs-core-docs/www/style-guide.html: * packages/acs-core-docs/www/subsites-design.adp: * packages/acs-core-docs/www/subsites-requirements.adp: * packages/acs-core-docs/www/subsites.adp: * packages/acs-core-docs/www/subsites.html: * packages/acs-core-docs/www/tcl-doc.adp: * packages/acs-core-docs/www/tcl-doc.html: * packages/acs-core-docs/www/templates.adp: * packages/acs-core-docs/www/templates.html: * packages/acs-core-docs/www/tutorial-admin-pages.adp: * packages/acs-core-docs/www/tutorial-admin-pages.html: * packages/acs-core-docs/www/tutorial-advanced.adp: * packages/acs-core-docs/www/tutorial-caching.adp: * packages/acs-core-docs/www/tutorial-categories.adp: * packages/acs-core-docs/www/tutorial-categories.html: * packages/acs-core-docs/www/tutorial-comments.adp: * packages/acs-core-docs/www/tutorial-css-layout.adp: * packages/acs-core-docs/www/tutorial-css-layout.html: * packages/acs-core-docs/www/tutorial-cvs.adp: * packages/acs-core-docs/www/tutorial-cvs.html: * packages/acs-core-docs/www/tutorial-database.adp: * packages/acs-core-docs/www/tutorial-database.html: * packages/acs-core-docs/www/tutorial-debug.adp: * packages/acs-core-docs/www/tutorial-debug.html: * packages/acs-core-docs/www/tutorial-distribute.adp: * packages/acs-core-docs/www/tutorial-distribute.html: * packages/acs-core-docs/www/tutorial-etp-templates.adp: * packages/acs-core-docs/www/tutorial-etp-templates.html: * packages/acs-core-docs/www/tutorial-future-topics.adp: * packages/acs-core-docs/www/tutorial-hierarchical.adp: * packages/acs-core-docs/www/tutorial-html-email.adp: * packages/acs-core-docs/www/tutorial-newpackage.adp: * packages/acs-core-docs/www/tutorial-newpackage.html: * packages/acs-core-docs/www/tutorial-notifications.adp: * packages/acs-core-docs/www/tutorial-notifications.html: * packages/acs-core-docs/www/tutorial-pages.adp: * packages/acs-core-docs/www/tutorial-pages.html: * packages/acs-core-docs/www/tutorial-parameters.adp: * packages/acs-core-docs/www/tutorial-schedule-procs.adp: * packages/acs-core-docs/www/tutorial-second-database.adp: * packages/acs-core-docs/www/tutorial-specs.adp: * packages/acs-core-docs/www/tutorial-upgrade-scripts.adp: * packages/acs-core-docs/www/tutorial-upgrade-scripts.html: * packages/acs-core-docs/www/tutorial-upgrades.adp: * packages/acs-core-docs/www/tutorial-vuh.adp: * packages/acs-core-docs/www/tutorial-wysiwyg-editor.adp: * packages/acs-core-docs/www/tutorial.adp: * packages/acs-core-docs/www/unit-testing-guide/index.adp: * packages/acs-core-docs/www/unix-installation.adp: * packages/acs-core-docs/www/unix-installation.html: * packages/acs-core-docs/www/update-repository.adp: * packages/acs-core-docs/www/update-translations.adp: * packages/acs-core-docs/www/update-translations.html: * packages/acs-core-docs/www/upgrade-4.5-to-4.6.adp: * packages/acs-core-docs/www/upgrade-4.5-to-4.6.html: * packages/acs-core-docs/www/upgrade-4.6.3-to-5.adp: * packages/acs-core-docs/www/upgrade-4.6.3-to-5.html: * packages/acs-core-docs/www/upgrade-5-0-dot.adp: * packages/acs-core-docs/www/upgrade-5-0-dot.html: * packages/acs-core-docs/www/upgrade-openacs-files.adp: * packages/acs-core-docs/www/upgrade-openacs-files.html: * packages/acs-core-docs/www/upgrade-overview.adp: * packages/acs-core-docs/www/upgrade-overview.html: * packages/acs-core-docs/www/upgrade-supporting.adp: * packages/acs-core-docs/www/upgrade.adp: * packages/acs-core-docs/www/uptime.adp: * packages/acs-core-docs/www/variables.adp: * packages/acs-core-docs/www/variables.html: * packages/acs-core-docs/www/win2k-installation.adp: * packages/acs-datetime/www/doc/coversheet.adp: * packages/acs-datetime/www/doc/design.adp: * packages/acs-datetime/www/doc/index.adp: * packages/acs-datetime/www/doc/requirements.adp: * packages/acs-developer-support/www/doc/developer-support-example.adp: * packages/acs-developer-support/www/doc/index.adp: * packages/acs-events/www/doc/design.adp: * packages/acs-events/www/doc/index.adp: * packages/acs-events/www/doc/requirements.adp: * packages/acs-lang/www/doc/i18n-design.adp: * packages/acs-lang/www/doc/i18n-requirements.adp: * packages/acs-lang/www/doc/index.adp: * packages/acs-messaging/www/doc/design.adp: * packages/acs-messaging/www/doc/index.adp: * packages/acs-messaging/www/doc/requirements.adp: * packages/acs-reference/www/doc/design.adp: * packages/acs-reference/www/doc/index.adp: * packages/acs-reference/www/doc/requirements.adp: * packages/acs-service-contract/www/doc/index.adp: * packages/acs-service-contract/www/doc/notes.adp: * packages/acs-subsite/www/doc/group-admin-pages-acceptance-test.adp: * packages/acs-subsite/www/doc/group-admin-pages-design.adp: * packages/acs-subsite/www/doc/group-admin-pages-requirements.adp: * packages/acs-subsite/www/doc/images.adp: * packages/acs-subsite/www/doc/index.adp: * packages/acs-templating/www/doc/TclDocs/cm_widget.adp: * packages/acs-templating/www/doc/TclDocs/cms_rel.adp: * packages/acs-templating/www/doc/TclDocs/content.adp: * packages/acs-templating/www/doc/TclDocs/content_add.adp: * packages/acs-templating/www/doc/TclDocs/content_method.adp: * packages/acs-templating/www/doc/TclDocs/doc.adp: * packages/acs-templating/www/doc/TclDocs/doc__util.adp: * packages/acs-templating/www/doc/TclDocs/form.adp: * packages/acs-templating/www/doc/TclDocs/item.adp: * packages/acs-templating/www/doc/TclDocs/namespace-list.adp: * packages/acs-templating/www/doc/TclDocs/namespaces.adp: * packages/acs-templating/www/doc/TclDocs/pagination.adp: * packages/acs-templating/www/doc/TclDocs/publish.adp: * packages/acs-templating/www/doc/TclDocs/request.adp: * packages/acs-templating/www/doc/TclDocs/tcl-procs.adp: * packages/acs-templating/www/doc/TclDocs/util.adp: * packages/acs-templating/www/doc/TclDocs/widget.adp: * packages/acs-templating/www/doc/api/database.adp: * packages/acs-templating/www/doc/api/element.adp: * packages/acs-templating/www/doc/api/form.adp: * packages/acs-templating/www/doc/api/index.adp: * packages/acs-templating/www/doc/api/multirow.adp: * packages/acs-templating/www/doc/api/request.adp: * packages/acs-templating/www/doc/appendices/memory.adp: * packages/acs-templating/www/doc/demo/index.adp: * packages/acs-templating/www/doc/design.adp: * packages/acs-templating/www/doc/designer-guide.adp: * packages/acs-templating/www/doc/developer-guide.adp: * packages/acs-templating/www/doc/exercise/ats-for-designers.adp: * packages/acs-templating/www/doc/gen/proc-doc.adp: * packages/acs-templating/www/doc/guide/components.adp: * packages/acs-templating/www/doc/guide/composite.adp: * packages/acs-templating/www/doc/guide/data.adp: * packages/acs-templating/www/doc/guide/document.adp: * packages/acs-templating/www/doc/guide/form-datatypes.adp: * packages/acs-templating/www/doc/guide/form-process.adp: * packages/acs-templating/www/doc/guide/form-templates.adp: * packages/acs-templating/www/doc/guide/form-widgets.adp: * packages/acs-templating/www/doc/guide/forms.adp: * packages/acs-templating/www/doc/guide/index.adp: * packages/acs-templating/www/doc/guide/master.adp: * packages/acs-templating/www/doc/guide/search.adp: * packages/acs-templating/www/doc/guide/skins.adp: * packages/acs-templating/www/doc/guide/tcl.adp: * packages/acs-templating/www/doc/guide/templates.adp: * packages/acs-templating/www/doc/guide/wizard-procs-doc.adp: * packages/acs-templating/www/doc/guide/wizards.adp: * packages/acs-templating/www/doc/index.adp: * packages/acs-templating/www/doc/install.adp: * packages/acs-templating/www/doc/introduction.adp: * packages/acs-templating/www/doc/migration.adp: * packages/acs-templating/www/doc/no-quote-upgrade.adp: * packages/acs-templating/www/doc/noquote.adp: * packages/acs-templating/www/doc/requirements.adp: * packages/acs-templating/www/doc/tagref/formerror.adp: * packages/acs-templating/www/doc/tagref/formgroup.adp: * packages/acs-templating/www/doc/tagref/formtemplate.adp: * packages/acs-templating/www/doc/tagref/formwidget.adp: * packages/acs-templating/www/doc/tagref/grid.adp: * packages/acs-templating/www/doc/tagref/group.adp: * packages/acs-templating/www/doc/tagref/if.adp: * packages/acs-templating/www/doc/tagref/include-optional.adp: * packages/acs-templating/www/doc/tagref/include.adp: * packages/acs-templating/www/doc/tagref/index.adp: * packages/acs-templating/www/doc/tagref/list.adp: * packages/acs-templating/www/doc/tagref/listtemplate.adp: * packages/acs-templating/www/doc/tagref/master.adp: * packages/acs-templating/www/doc/tagref/multiple.adp: * packages/acs-templating/www/doc/tagref/noparse.adp: * packages/acs-templating/www/doc/tagref/property.adp: * packages/acs-templating/www/doc/tagref/slave.adp: * packages/acs-templating/www/doc/tagref/switch.adp: * packages/acs-templating/www/doc/tagref/variable.adp: * packages/acs-templating/www/doc/timing-1.adp: * packages/acs-templating/www/doc/timing-2.adp: * packages/acs-templating/www/doc/timing-3.adp: * packages/acs-templating/www/doc/timing.adp: * packages/acs-templating/www/doc/todo.adp: * packages/acs-templating/www/doc/widgets/date.adp: * packages/acs-templating/www/doc/widgets/index.adp: * packages/acs-templating/www/doc/widgets/input.adp: * packages/acs-templating/www/doc/widgets/select.adp: * packages/acs-templating/www/doc/widgets/table.adp: * packages/ajaxhelper/www/doc/index.adp: * packages/assessment/www/doc/as_items.adp: * packages/assessment/www/doc/as_types.adp: * packages/assessment/www/doc/asm_trigger_doc/bi01.adp: * packages/assessment/www/doc/asm_trigger_doc/bi02.adp: * packages/assessment/www/doc/asm_trigger_doc/ch01.adp: * packages/assessment/www/doc/asm_trigger_doc/ch01s01.adp: * packages/assessment/www/doc/asm_trigger_doc/ch02.adp: * packages/assessment/www/doc/asm_trigger_doc/ch02s01.adp: * packages/assessment/www/doc/asm_trigger_doc/ch02s02.adp: * packages/assessment/www/doc/asm_trigger_doc/ch02s03.adp: * packages/assessment/www/doc/asm_trigger_doc/ch02s04.adp: * packages/assessment/www/doc/asm_trigger_doc/ch02s05.adp: * packages/assessment/www/doc/asm_trigger_doc/ch02s06.adp: * packages/assessment/www/doc/asm_trigger_doc/ch02s07.adp: * packages/assessment/www/doc/asm_trigger_doc/ch03.adp: * packages/assessment/www/doc/asm_trigger_doc/ch04.adp: * packages/assessment/www/doc/asm_trigger_doc/index.adp: * packages/assessment/www/doc/data-model.adp: * packages/assessment/www/doc/data_collection.adp: * packages/assessment/www/doc/display_types.adp: * packages/assessment/www/doc/grouping.adp: * packages/assessment/www/doc/index.adp: * packages/assessment/www/doc/item_types.adp: * packages/assessment/www/doc/page_flow.adp: * packages/assessment/www/doc/policies.adp: * packages/assessment/www/doc/requirements.adp: * packages/assessment/www/doc/sequencing.adp: * packages/assessment/www/doc/user_interface/assessment_creation.adp: * packages/assessment/www/doc/user_interface/index.adp: * packages/assessment/www/doc/user_interface/item_creation.adp: * packages/assessment/www/doc/user_interface/section_creation.adp: * packages/assessment/www/doc/user_interface/tests.adp: * packages/assessment/www/doc/user_interface/user_experience.adp: * packages/assessment/www/doc/versioning.adp: * packages/attachments/www/doc/index.adp: * packages/calendar/www/doc/index.adp: * packages/calendar/www/doc/requirements.adp: * packages/calendar/www/doc/test-cases.adp: * packages/categories/www/doc/design.adp: * packages/categories/www/doc/index.adp: * packages/categories/www/doc/install.adp: * packages/categories/www/doc/o.adp: * packages/categories/www/doc/requirements.adp: * packages/dotlrn-homework/www/doc/design.adp: * packages/file-storage/www/doc/design.adp: * packages/file-storage/www/doc/index.adp: * packages/file-storage/www/doc/requirements.adp: * packages/general-comments/www/doc/design.adp: * packages/general-comments/www/doc/dev-guide.adp: * packages/general-comments/www/doc/index.adp: * packages/general-comments/www/doc/users-guide.adp: * packages/news/www/doc/requirements.adp: * packages/oacs-dav/www/doc/index.adp: * packages/ref-countries/www/doc/index.adp: * packages/rss-support/www/doc/bboard.adp: * packages/rss-support/www/doc/design.adp: * packages/rss-support/www/doc/index.adp: * packages/search/www/doc/guidelines.adp: * packages/search/www/doc/index.adp: * packages/tsearch2-driver/www/doc/index.adp: regenerated documentation 2021-09-02 gustafn * packages/xowiki/lib/view.tcl: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/link-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/personal-notification-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/xowiki.info: New CSS abstraction: xowiki::CSS Before this change, the application developer was responsible to initialize the CSS-speficic settings (such as setting default values for parameter classes). The new object xowiki::CSS is initialized automatically, when an xowiki class (or one of its subclasses) is initialized. Furthermore, it provides a per-thread caching to reduce double work. Furthermore, the xowiki::CSS provides a mapping between abstract and concrete CSS class names, such that switching between different CSS toolkits becomes easier (e.g. upgrade from bootstrap 3 to newer versions). xowiki::CSS initialize ;# make sure, everything is in line with PreferredCSSToolkit xowiki::CSS clear ;# reset the mapping xowiki::CSS toolkit ;# return the toolkit name xowiki::CSS class /classname/ ;# perform CSS class name mapping The methods "setCSSDefaults" and "preferredCSSToolkit" as deprecated. The version number was bumped to 5.10.0d81 * packages/acs-admin/acs-admin.info: * packages/acs-api-browser/acs-api-browser.info: * packages/acs-authentication/acs-authentication.info: * packages/acs-automated-testing/acs-automated-testing.info: * packages/acs-bootstrap-installer/acs-bootstrap-installer.info: * packages/acs-content-repository/acs-content-repository.info: * packages/acs-core-docs/acs-core-docs.info: * packages/acs-datetime/acs-datetime.info: * packages/acs-developer-support/acs-developer-support.info: * packages/acs-events/acs-events.info: * packages/acs-kernel/acs-kernel.info: * packages/acs-lang/acs-lang.info: * packages/acs-mail-lite/acs-mail-lite.info: * packages/acs-messaging/acs-messaging.info: * packages/acs-reference/acs-reference.info: * packages/acs-service-contract/acs-service-contract.info: * packages/acs-subsite/acs-subsite.info: * packages/acs-tcl/acs-tcl.info: * packages/acs-templating/acs-templating.info: * packages/acs-translations/acs-translations.info: * packages/ajaxhelper/ajaxhelper.info: * packages/assessment-portlet/assessment-portlet.info: * packages/assessment/assessment.info: * packages/attachments/attachments.info: * packages/bm-portlet/bm-portlet.info: * packages/boomerang/boomerang.info: * packages/bulk-mail/bulk-mail.info: * packages/calendar-portlet/calendar-portlet.info: * packages/calendar/calendar.info: * packages/categories/categories.info: * packages/chat-portlet/chat-portlet.info: * packages/chat/chat.info: * packages/cookie-consent/cookie-consent.info: * packages/dotlrn-assessment/dotlrn-assessment.info: * packages/dotlrn-bm/dotlrn-bm.info: * packages/dotlrn-bootstrap3-theme/dotlrn-bootstrap3-theme.info: * packages/dotlrn-calendar/dotlrn-calendar.info: * packages/dotlrn-chat/dotlrn-chat.info: * packages/dotlrn-dotlrn/dotlrn-dotlrn.info: * packages/dotlrn-evaluation/dotlrn-evaluation.info: * packages/dotlrn-faq/dotlrn-faq.info: * packages/dotlrn-forums/dotlrn-forums.info: * packages/dotlrn-fs/dotlrn-fs.info: * packages/dotlrn-homework/dotlrn-homework.info: * packages/dotlrn-news/dotlrn-news.info: * packages/dotlrn-portlet/dotlrn-portlet.info: * packages/dotlrn-static/dotlrn-static.info: * packages/dotlrn-xowiki/dotlrn-xowiki.info: * packages/dotlrn/dotlrn.info: * packages/evaluation-portlet/evaluation-portlet.info: * packages/evaluation/evaluation.info: * packages/faq-portlet/faq-portlet.info: * packages/faq/faq.info: * packages/file-storage/file-storage.info: * packages/forums-portlet/forums-portlet.info: * packages/forums/forums.info: * packages/fs-portlet/fs-portlet.info: * packages/general-comments/general-comments.info: * packages/intermedia-driver/intermedia-driver.info: * packages/new-portal/new-portal.info: * packages/news-portlet/news-portlet.info: * packages/news/news.info: * packages/notifications/notifications.info: * packages/oacs-dav/oacs-dav.info: * packages/openacs-bootstrap3-theme/openacs-bootstrap3-theme.info: * packages/openacs-default-theme/openacs-default-theme.info: * packages/proctoring-support/proctoring-support.info: * packages/profile-provider/profile-provider.info: * packages/ref-countries/ref-countries.info: * packages/ref-language/ref-language.info: * packages/ref-timezones/ref-timezones.info: * packages/richtext-ckeditor4/richtext-ckeditor4.info: * packages/richtext-tinymce/richtext-tinymce.info: * packages/richtext-xinha/richtext-xinha.info: * packages/rss-support/rss-support.info: * packages/search/search.info: * packages/static-portlet/static-portlet.info: * packages/survey/survey.info: * packages/theme-zen/theme-zen.info: * packages/tsearch2-driver/tsearch2-driver.info: * packages/user-profile/user-profile.info: * packages/views/views.info: * packages/xooauth/xooauth.info: * packages/xotcl-core/xotcl-core.info: * packages/xotcl-request-monitor/xotcl-request-monitor.info: * packages/xowf/xowf.info: * packages/xowiki-portlet/xowiki-portlet.info: * packages/xowiki/xowiki.info: bump version numbers of 5.9|5.10 packages to 5.10.0b1 adjust dependencies * packages/forums/tcl/messages-procs.tcl: fix recent editing bug * packages/openacs-bootstrap3-theme/resources/templates/packages/acs-subsite/lib/login.tcl: fix typo and modernize code * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: * packages/acs-authentication/tcl/authentication-procs-naviserver.tcl: * packages/acs-automated-testing/tcl/tclwebtest-procs.tcl: * packages/acs-content-repository/tcl/content-revision-procs.tcl: * packages/acs-core-docs/tcl/acs-core-docs-procs.tcl: * packages/acs-core-docs/www/sql/display-sql.tcl: * packages/acs-core-docs/www/xml/developers-guide/packages.xml: * packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml: * packages/acs-core-docs/www/xml/engineering-standards/filenaming.xml: * packages/acs-core-docs/www/xml/engineering-standards/psgml-mode.xml: * packages/acs-core-docs/www/xml/install-guide/openacs.xml: * packages/acs-core-docs/www/xml/kernel/apm-design.xml: * packages/acs-core-docs/www/xml/kernel/apm-requirements.xml: * packages/acs-core-docs/www/xml/kernel/object-system-design.xml: * packages/acs-core-docs/www/xml/kernel/security-design.xml: * packages/acs-core-docs/www/xml/kernel/security-notes.xml: * packages/acs-mail-lite/tcl/email-inbound-procs.tcl: * packages/acs-outdated/tcl/acs-tcl-admin-procs.tcl: * packages/acs-templating/tcl/head-procs.tcl: * packages/acs-templating/tcl/test/data-procs.tcl: * packages/acs-templating/tcl/widget-procs.tcl: * packages/ajaxhelper/lib/ajaxhelper-template.tcl: * packages/ajaxhelper/tcl/ajax-dojo-procs.tcl: * packages/ajaxhelper/tcl/ajax-procs.tcl: * packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl: * packages/ajaxhelper/www/doc/acs-integration-procs.tcl: * packages/assessment-portlet/tcl/assessment-portlet-procs.tcl: * packages/boomerang/tcl/boomerang-init.tcl: * packages/calendar-portlet/tcl/calendar-admin-portlet-procs.tcl: * packages/calendar-portlet/tcl/calendar-portlet-procs.tcl: * packages/calendar-portlet/www/calendar-full-portlet.tcl: * packages/categories/www/cadmin/tree-order-update.tcl: * packages/chat/tcl/xotcl-chat-procs.tcl: * packages/dotlrn-dotlrn/tcl/dotlrn-members-procs.tcl: * packages/dotlrn-homework/tcl/dotlrn-homework-procs.tcl: * packages/dotlrn-portlet/tcl/dotlrn-members-staff-portlet-procs.tcl: * packages/evaluation-portlet/tcl/test/tclwebtest-procs.tcl: * packages/evaluation/tcl/evaluation-procs.tcl: * packages/evaluation/www/admin/evaluations/grades-sheet-parse.tcl: * packages/forums/tcl/messages-procs.tcl: * packages/fs-portlet/tcl/fs-contents-portlet-procs.tcl: * packages/oacs-dav/tcl/oacs-dav-procs.tcl: * packages/proctoring-support/tcl/safe-exam-browser-procs.tcl: * packages/ref-timezones/tcl/apm-callback-procs.tcl: * packages/survey/www/admin/process-response.tcl: * packages/survey/www/admin/question-add-2.tcl: * packages/survey/www/process-response.tcl: * packages/theme-zen/tcl/navigation-procs.tcl: * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl: * packages/xooauth/tcl/lti-procs.tcl: * packages/xotcl-core/tcl/05-db-procs.tcl: improve spelling * packages/acs-core-docs/www/xml/for-everyone/release-notes.xml: provide skeleton for next release entry * packages/acs-tcl/tcl/apm-init.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: use per-thread caching infrastructure instead of reinventing 2021-09-02 antoniop * packages/acs-tcl/tcl/apm-init.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/parameter-procs.tcl: Cache the information about a package being a singleton and expose into a private api, use the API in parameter::get_from_package_key, called quite often in our downstream pages * packages/acs-templating/tcl/head-procs.tcl: Enable to attach handlers by CSS selector also for template::add_confirm_handler * packages/evaluation/catalog/evaluation.en_US.ISO-8859-1.xml: * packages/evaluation/evaluation.info: Fix typos in message keys * packages/evaluation-portlet/catalog/evaluation-portlet.it_IT.ISO-8859-1.xml: * packages/evaluation-portlet/evaluation-portlet.info: * packages/evaluation/catalog/evaluation.it_IT.ISO-8859-1.xml: * packages/evaluation/evaluation.info: * packages/theme-zen/catalog/theme-zen.it_IT.ISO-8859-1.xml: * packages/theme-zen/theme-zen.info: * packages/views/catalog/views.it_IT.ISO-8859-1.xml: * packages/views/views.info: Italian localization for the package 2021-09-01 gustafn * packages/acs-admin/www/send-email.tcl: fix cut&paste error * packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl: improve robustness of deep_copy method since so far, we do not require that an empty ordered composite has always the children variable set (but maybe we should), don't assume it is always there * packages/acs-admin/www/send-email.tcl: * packages/acs-subsite/www/shared/send-email.tcl: improve validation of email address and user-id used as source for email address 2021-08-31 hectorr * packages/proctoring-support/catalog/proctoring-support.es_ES.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Ad es_ES translation to the proctoring-support package 2021-08-31 antoniop * packages/dotlrn-evaluation/catalog/dotlrn-evaluation.it_IT.ISO-8859-1.xml: * packages/dotlrn-evaluation/dotlrn-evaluation.info: (Trivial) Italian localization for the package * packages/acs-lang/www/admin/batch-editor.tcl: Fix overquoting resulting in batch message key editor This was caused by the now stricter quoting applied to ad_form, which is used under the hood to produce this UI * packages/assessment-portlet/assessment-portlet.info: * packages/assessment-portlet/catalog/assessment-portlet.it_IT.ISO-8859-1.xml: * packages/assessment/assessment.info: * packages/assessment/catalog/assessment.it_IT.ISO-8859-1.xml: Italian localization for the package * packages/dotlrn-calendar/catalog/dotlrn-calendar.it_IT.ISO-8859-1.xml: * packages/dotlrn-calendar/dotlrn-calendar.info: Provide better translation 2021-08-30 hectorr * packages/acs-templating/acs-templating.info: * packages/acs-templating/catalog/acs-templating.es_ES.ISO-8859-1.xml: Update es_ES translation 2021-08-30 antoniop * packages/chat-portlet/catalog/chat-portlet.it_IT.ISO-8859-1.xml: * packages/chat-portlet/chat-portlet.info: * packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: * packages/xowiki-portlet/catalog/xowiki-portlet.it_IT.ISO-8859-1.xml: * packages/xowiki-portlet/xowiki-portlet.info: Italian localization for the package * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Remove reference to WU in upstream message keys * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/catalog/acs-tcl.it_IT.ISO-8859-1.xml: * packages/acs-templating/acs-templating.info: * packages/acs-templating/catalog/acs-templating.it_IT.ISO-8859-1.xml: * packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml: * packages/xowf/xowf.info: Update italian localization 2021-08-29 gustafn * packages/forums/tcl/test/forums-procs.tcl: fixed categorization of test case * packages/xowiki/tcl/xowiki-procs.tcl: improved code comments 2021-08-27 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: added message key for sub-question, fixed cut&paste error. * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: fix for issue #3463 Many thanks to Tony Kirkham for the fix! * packages/acs-tcl/tcl/request-processor-procs.tcl: fixed bug in redirects and disabled acs-testing package, changed node info from array to dict * packages/xowf/lib/inclass-exam.wf: * packages/xowf/www/resources/test-item.css: minor styling improvements 2021-08-26 gustafn * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: - fix collateral damage from earlier submissions download change (error: can't read "__form_fields") - improve styling (many thanks to Monika Andergassen and Stephan Adelsberger) for composite questions in 2-col layout 2021-08-24 hectorr * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/catalog/acs-tcl.es_ES.ISO-8859-1.xml: * packages/acs-templating/acs-templating.info: * packages/acs-templating/catalog/acs-templating.es_ES.ISO-8859-1.xml: * packages/file-storage/catalog/file-storage.es_ES.ISO-8859-1.xml: * packages/file-storage/file-storage.info: * packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml: * packages/xowf/xowf.info: Update es_ES translation 2021-08-20 gustafn * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: add log warnings when include-contract is violated, since (in most cases) the passed values should be pre-checked * packages/acs-tcl/tcl/site-nodes-procs.tcl: fix case where the manual slash-parsing in the sitenode code is confused with percent-substitutions This is just a "quick fix", since the Proper solution in more complex: # A URL path /%2f/ is syntactically permissible, # but this is not supported in the current site-nodes code. It # would be correct, to avoid the parsing of the slashes here and # to process instead the result of [ns_conn urlv], which is # already parsed (before the percent substitutions). This would # probably require the request processor to perform some mangling # of urlv in vhost cases to set a a proper [ad_conn urlv] ... and # of course to pass the "urlv" instead of the "url" to the # slash-parsing functions. * packages/acs-tcl/catalog/acs-tcl.de_DE.ISO-8859-1.xml: improve German message catalog * packages/acs-tcl/tcl/utilities-procs.tcl: improve documentation 2021-08-19 antoniop * packages/news/lib/news.tcl: Change value-checker form "html" to "allhtml", otherwise already saved news articles containing data urls can't be viewed Port of downstream hotfix from Gustaf Neumann * packages/acs-templating/tcl/date-procs.tcl: Port of downstream modification: apply trimming of zeros to all fields in advance This allows one to treat fields as real numbers without the need to trim case by case. One can also reduce dependency to api and just use plain tcl expressions to evaluate conditions 2021-08-18 antoniop * packages/acs-templating/tcl/date-procs.tcl: Arrays might or not have been a better choice for the date object, however, such decision happened very long ago and it has worked good enough... cleanup concerning remarks * packages/acs-templating/tcl/date-procs.tcl: Comment noop result of a 18 years old typo, add remarks * packages/proctoring-support/lib/proctoring-configure.tcl: Improve doc, remove needless properties * packages/acs-templating/acs-templating.info: * packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml: * packages/acs-templating/tcl/date-procs.tcl: Port of downstream HTML5 date and time form widgets by Günter Ernst These widgets provide a better and more consistent user experience and client-side validation across multiple platforms. They should in time become the preferred alternative for dates and time for template forms. * packages/acs-templating/tcl/date-procs.tcl: Replace deprecated idiom * packages/acs-templating/tcl/date-procs.tcl: Review concerning remark: the algorithm is indeed correct, assuming the year is expressed in the Gregorian calendar * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/lib/proctoring-configure.adp: * packages/proctoring-support/lib/proctoring-configure.tcl: * packages/proctoring-support/proctoring-support.info: UI include to configure proctoring on an arbitrary ACS object, meant to be integrated downstream into custom UIs * packages/acs-templating/tcl/date-procs.tcl: Uniform documentation formatting and indentation, add missing documentation * packages/acs-templating/tcl/date-procs.tcl: Whitespace change 2021-08-17 gustafn * packages/notifications/tcl/sweep-procs.tcl: Notification request cleanup refactoring One of the most expensive operations in large site is the cleanup for notification_requests in situations, where the user has lost permissions on an object, on which the user wanted to receive notifications. This check was performed previously in notification::sweep::cleanup_notifications via a permission check over all notification requests, which can be very costly on large sites. This change moves this cleanup into the actual notification sending, where the permissions have to be sent anyhow. 2021-08-17 antoniop * packages/xotcl-core/tcl/06-package-procs.tcl: For Postgres, take advantage of exclusive database api to check for permissions more efficiently, improve doc 2021-08-10 hectorr * packages/acs-templating/www/doc/no-quote-upgrade.adp: * packages/acs-templating/www/doc/no-quote-upgrade.html: Fix typo 2021-08-10 antoniop * packages/acs-tcl/tcl/request-processor-procs.tcl: Fix expression to the original intention: check if ns_conn url ends by ad_conn extra_url 2021-08-09 gustafn * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/menu-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: more cleanup for setting of potentially unencoded return_url 2021-08-07 gustafn * packages/xooauth/tcl/lti-procs.tcl: don't hard-code "Learner" as role * packages/xotcl-request-monitor/www/flush-url-statistics.tcl: * packages/xowf/tcl/xowf-procs.tcl: minor cleanup for returnurls * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: streamline returnredirect commands make sure, the provided URL is always properly encoded 2021-08-06 gustafn * packages/acs-tcl/tcl/defs-procs.tcl: ad_return_url: experimental change to produce per default a proper encoded result Background: before this change, ad_return_url encoded always the query variables but not the URL path. This mixed result is complex to handle to achieve ex-post a proper encoding. The function has a flag "-urlencode", which is nowhere used in OpenACS. Other functions like e.g. export_vars, or pretty_link return per default as well the encoded URL. "ad_return_url" has a new flag "-path_encode=false" to obtain the previous behavior (similar to the other mentioned functions). 2021-08-06 antoniop * packages/proctoring-support/sql/postgresql/proctoring-support-create.sql: Fix typo in datamodel creation, make it atomic 2021-08-05 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: break overlong lines and improve comments * packages/xowf/tcl/test-item-procs.tcl: bugfix: don't call get_non_empty_file_formfields in render_answers when in export mode 2021-08-03 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/xowf.info: added composite question per default to the "New" pull-down menu, added message keys for German * packages/acs-tcl/tcl/utilities-procs.tcl: improve spelling * packages/acs-automated-testing/tcl/aa-test-procs.tcl: make spelling more consistent * packages/acs-lang/www/admin/edit-localized-message.tcl: make sure that the query variable "show" is only passed nonempty, otherwise the page-contract of admin/message-list.tcl will fail * packages/xowiki/tcl/form-field-procs.tcl: minor refactoring to correct old-style widgetSpecs; prefer variable resolver over method calls for unset * packages/xowiki/tcl/xowiki-procs.tcl: prefer variable resolver over method calls for unset * packages/acs-tcl/tcl/00-icanuse-procs.tcl: provide a compatibility function for ns_parsehostport for earlier versions of NaviServer * packages/xowiki/tcl/form-field-procs.tcl: support editor=none in arbitrary form-field specs 2021-08-02 gustafn * packages/acs-admin/tcl/test/acs-admin-procs.tcl: * packages/acs-subsite/www/shared/1pixel.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/pdf-procs.tcl: * packages/acs-tcl/tcl/utilities-procs-aolserver.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/acs-templating/tcl/spellcheck-procs.tcl: * packages/xotcl-core/tcl/bgdelivery-procs.tcl: * packages/xotcl-core/www/show-class-graph.tcl: * packages/xotcl-core/www/show-object.tcl: Reduce usage of ns_mktemp in OpenACS ns_mktemp uses the deprecated old POSIX call mktemp(), which should not be used anymore for security reasons (race between the name creation and opening the file). This change removes several usages of "ns_mktemp" from OpenACS and replaces it with calls to the safe Tcl call "file tempfile ..." (introduced by Tcl 8.6). * packages/xotcl-core/tcl/utilities-procs.tcl: * packages/xotcl-core/xotcl-core.info: added function xo::write_tmp_file The new function uses an atomic call to create a temporary file and is therefore lass prone to attacks. bumped version number to 5.10.0d41 * packages/acs-tcl/tcl/test/http-client-procs.tcl: fix header generation since the headers are set in a loop, "ns_set put" is incorrect since it is additive. "ns_set update" is correct. * packages/acs-admin/tcl/apm-admin-procs.tcl: improve log message * packages/acs-tcl/tcl/test/security-procs.tcl: improve spelling * packages/acs-admin/www/apm/version-reload.tcl: * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: make using page-filter "object_id" backwards compatible by allowing it to be used also during update scripts * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/test/test-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: * packages/xowiki/xowiki.info: prefer usage of "xo::write_tmp_file" over "xo::write_file" for writing temporary files * packages/xowf/tcl/test-item-procs.tcl: reinstantiate accidentally deleted code 2021-08-02 antoniop * packages/xowiki/tcl/xowiki-www-procs.tcl: Do not urlencode the return URL in every case, but only when this falls back to the current URL from the connection context, normally coming from "ns_conn url" which will return it "raw", as in not encoded for any purpose 2021-08-01 gustafn * packages/xowf/tcl/test-item-procs.tcl: add comments with class names to ease navigation in the source file 2021-07-30 antoniop * packages/xowiki/tcl/xowiki-www-procs.tcl: URLencode the return URL, or the server might complain for invalid characters (e.g. unencoded umlaut characters) 2021-07-29 hectorr * packages/acs-tcl/tcl/utilities-procs.tcl: Adapt 'ad_urlencode_url' to the new 'ns_parseurl' stricter behavior 2021-07-29 gustafn * packages/xowf/resources/prototypes/TestItemComposite.form.page: * packages/xowf/tcl/test-item-procs.tcl: Initial support for composite questions A composite question is a test-item containing other regular test items. This makes it possible to define a larger test item case for which arbitrary other questions can be associated (e.g. short text question plus an MC and ordering question etc.). The randomization features (shuffling, x out of N, etc.) of the included test-items are preserved such that it is possible to present the student e.g. a sub question where only 2 out of 5 possible alternatives are displayed. The provided implementation builds for a composite question consisting of a constant exam intro text and the selected sub items including points, minutes etc. The points and minutes of the composite question are computed as the sum of the points and minutes of the sub-items. The actual sub-items are constructed at runtime such that per-user randomization can be applied. Current shortcoming: question with percent-substitutions are not supported (since the exam intro text is placed at composite form creation time already into the form, therefore, it is the same for all students). Furthermore, the substitution semantics are not clear concerning the included content. * packages/xowiki/tcl/bootstrap-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/table-widget-procs.tcl: * packages/xowiki/tcl/yui-procs.tcl: * packages/xowiki/www/admin/list.tcl: * packages/xowiki/www/resources/xowiki-yui-specific.css: Remove hard-coded styling with the "style" element to get a more consistent appearance (many thanks to Monika Andergassen for looking into this). * packages/xotcl-core/tcl/01-debug-procs.tcl: add checker for object_ids. In order to use this, a recent version of nsf is required, no accepting abbreviations for all types * packages/xowf/www/resources/test-item.css: added CSS properties for adding scrollbars to overly large exam texts. Not sure, these are always wanted. * packages/xowiki/tcl/folder-procs.tcl: improve query variable checking * packages/xowf/www/index.vuh: include form-vars in log messages for workflows since this eases debugging * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/06-package-procs.tcl: tighten checking on input parameters * packages/xotcl-core/tcl/30-widget-procs.tcl: whitespace change 2021-07-29 antoniop * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: Document behavior * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: Whitespace cleanup 2021-07-27 hectorr * packages/faq/www/admin/one-faq.adp: * packages/faq/www/admin/one-question.tcl: * packages/faq/www/admin/q-and-a-delete-oracle.xql: * packages/faq/www/admin/q-and-a-delete-postgresql.xql: * packages/faq/www/admin/q-and-a-delete.tcl: * packages/faq/www/admin/q-and-a-edit-2.tcl: * packages/faq/www/admin/q-and-a-edit.adp: * packages/faq/www/admin/q-and-a-edit.tcl: * packages/faq/www/admin/q-and-a-new-2-postgresql.xql: * packages/faq/www/admin/q-and-a-new-2.tcl: * packages/faq/www/admin/q-and-a-new.adp: * packages/faq/www/admin/q-and-a-new.tcl: * packages/faq/www/admin/q_and_a-delete-oracle.xql: * packages/faq/www/admin/q_and_a-delete-postgresql.xql: * packages/faq/www/admin/q_and_a-delete.tcl: * packages/faq/www/admin/q_and_a-edit-2.tcl: * packages/faq/www/admin/q_and_a-edit.adp: * packages/faq/www/admin/q_and_a-edit.tcl: * packages/faq/www/admin/q_and_a-new-2-postgresql.xql: * packages/faq/www/admin/q_and_a-new-2.tcl: * packages/faq/www/admin/q_and_a-new.adp: * packages/faq/www/admin/q_and_a-new.tcl: Adapt filenames to OpenACS naming conventions 2021-07-27 gustafn * packages/xowiki/tcl/xowiki-www-procs.tcl: added value checker, improved comments and logging statements * packages/xowf/lib/inclass-exam-answer.wf: allow user to open exam answering in multiple tabs in try-out mode * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/xowiki-form-procs.tcl: fix creating/editing of xowiki::Forms This change essentially reverts the change of July 2, which broke the feature to specify "editor=none". This is important for the "form" form-field entry, which requires a FORM tag, that is usually removed by actual version of the ckeditor. 2021-07-22 gustafn * packages/openacs-bootstrap3-theme/tcl/resource-init.tcl: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.5.1.js: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.5.1.min.js: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.6.0.js: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.6.0.min.js: * packages/xowiki/tcl/resource-init.tcl: * packages/xowiki/www/resources/jquery/jquery-3.5.1.js: * packages/xowiki/www/resources/jquery/jquery-3.5.1.min.js: * packages/xowiki/www/resources/jquery/jquery-3.6.0.js: * packages/xowiki/www/resources/jquery/jquery-3.6.0.min.js: Upgrade to jQuery 3.6.0 (released March 2021) * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: * packages/richtext-ckeditor4/www/sitewide-admin/download.tcl: * packages/xowiki/tcl/form-field-procs.tcl: upgrade default ckeditor from 4.15.1 to 4.16.1 (released in May 2021) 2021-07-20 gustafn * packages/acs-admin/tcl/acs-admin-procs.tcl: check_expired_certificates: automated certificate nenewal for letsencrypt This change reduce maintenance effort by automating certificate renewal. When the NaviServer letsencrypt module is installed and configured, the background operation check_expired_certificates will automatically update the certificates when these expire soon (as defined by the "ExpireCertificateWarningPeriod" parameter of acs-admin). When a recent version of NaviServer is used that supports certificate refetch on SIGHUP, the new certificates are automatically updated without a server restart. Prerequisites: - Recent version of letsencrypt NaviServer module installed (0.6) and configured - Recent version of NaviServer (currently Bitbucket tip) for automated certificate reloading When the recent letsencrypt module is not installed, check_expired_certificates sends expiration warnings as usual. Therefore, it is also useful for sites using certificates from different sources. This new functionality was used for latest certificate renewal on openacs.org. 2021-07-15 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: Added optional layout for question types, where question text and answer interactions are displayed in two columns The implementation supports responsive design and switches for small width display again to single column display. Supported question types: - Text Interaction - ShortText Interaction - MC Interaction - SC Interaction - Reorder Interaction - Upload Interaction 2021-07-14 gustafn * packages/xowf/tcl/test/test-item-procs.tcl: * packages/xowf/xowf.info: Extended regression test for test item procs - compose exam by three exericises instead of one - added test for short-text exercise with a file submission - exam contain now a text exercise, a short-text exercise with a file submission, and a MC question - test case fills out first two questions in the test case - bumped version number due to dependency on xowiki (option "-next_page_must_contain" for "xowiki::test::edit_form_page") * packages/xowf/lib/inclass-exam-answer.wf: improve comment * packages/xowiki/tcl/test/test-procs.tcl: * packages/xowiki/xowiki.info: parameterize xowiki::test::edit_form_page with -next_page_must_contain This changes supports more flexible checking of expected content on page after editing. Default is backwards compatible * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: xowf.info catalog/xowf.en_US.ISO-8859-1.xml tcl/test-item-procs.tcl www/resources/test-item.css 2021-07-08 gustafn * packages/acs-tcl/tcl/00-icanuse-procs.tcl: added "ns_parseurl -strict" to icanuse definitions * packages/xowf/resources/prototypes/ExamFolder.page: * packages/xowf/resources/prototypes/TestItemComposite.form.page: * packages/xowf/resources/prototypes/TestItemMC.form.page: * packages/xowf/resources/prototypes/TestItemReorder.form.page: * packages/xowf/resources/prototypes/TestItemSC.form.page: * packages/xowf/resources/prototypes/TestItemShortText.form.page: * packages/xowf/resources/prototypes/TestItemText.form.page: * packages/xowf/resources/prototypes/TestItemUpload.form.page: * packages/xowf/resources/prototypes/Workflow.form.page: * packages/xowf/resources/prototypes/answer-single-question.wf.page: * packages/xowf/resources/prototypes/atjob-form.page: * packages/xowf/resources/prototypes/edit-interaction.wf.page: * packages/xowf/resources/prototypes/inclass-exam.wf.page: * packages/xowf/resources/prototypes/inclass-quiz.wf.page: * packages/xowf/resources/prototypes/online-exam.wf.page: * packages/xowf/resources/prototypes/quiz-select_question.form.page: * packages/xowf/resources/prototypes/select_question.form.page: * packages/xowf/www/prototypes/TestItemMC.form.page: * packages/xowf/www/prototypes/TestItemReorder.form.page: * packages/xowf/www/prototypes/TestItemSC.form.page: * packages/xowf/www/prototypes/TestItemShortText.form.page: * packages/xowf/www/prototypes/TestItemText.form.page: * packages/xowf/www/prototypes/TestItemUpload.form.page: * packages/xowf/www/prototypes/Workflow.form.page: * packages/xowf/www/prototypes/answer-single-question.wf.page: * packages/xowf/www/prototypes/atjob-form.page: * packages/xowf/www/prototypes/edit-interaction.wf.page: * packages/xowf/www/prototypes/inclass-exam.wf.page: * packages/xowf/www/prototypes/inclass-quiz.wf.page: * packages/xowf/www/prototypes/online-exam.wf.page: * packages/xowf/www/prototypes/quiz-select_question.form.page: * packages/xowf/www/prototypes/select_question.form.page: * packages/xowiki/resources/prototypes/folder.form.page: * packages/xowiki/resources/prototypes/form.form.page: * packages/xowiki/resources/prototypes/import-archive.form.page: * packages/xowiki/resources/prototypes/link.form.page: * packages/xowiki/resources/prototypes/page.form.page: * packages/xowiki/resources/prototypes/photo.form.page: * packages/xowiki/www/prototypes/folder.form.page: * packages/xowiki/www/prototypes/form.form.page: * packages/xowiki/www/prototypes/import-archive.form.page: * packages/xowiki/www/prototypes/link.form.page: * packages/xowiki/www/prototypes/page.form.page: * packages/xowiki/www/prototypes/photo.form.page: reduce warnings on loading: Move resources to non-deprecated location 2021-07-06 trenner * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: allow sorting of submissions via query parameter 2021-07-05 antoniop * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d32-5.10.0d33.sql: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d32-5.10.0d33.sql: As we now enforce emails to be lowercase, also sanitize existing data 2021-07-02 hectorr * packages/acs-templating/tcl/test/data-procs.tcl: Extend 'validate_url' test case * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Refine regex and extend tests 2021-07-02 antoniop * packages/xotcl-core/tcl/06-param-procs.tcl: Cloase bracket * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/xowiki-form-procs.tcl: In order to make the "editor=" formfield spec option have any effect, one should catch the value from the spec early, before the formfield is reclassed and initialized This also exposes that the editor=none value is not valid (detected by xowiki and xowf automated tests). For this to be valid one should define it as a richtext subclass. * packages/acs-tcl/tcl/community-core-procs.tcl: * packages/acs-tcl/tcl/test/community-core-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Make so that also party::update enforces emails to be lowercase, add/extend automated tests to make sure emails are lowercase everywhere 2021-07-01 hectorr * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Add the 'relative' flag to 'util_url_valid_p', to check also relative URLs. Extend 'acs_tcl__util_url_valid_p' test case and bump package version. * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: Extend 'acs_tcl__util_url_valid_p' test case * packages/xowf/tcl/test-item-procs.tcl: Fix typo. Fixes 'files__tcl_file_common_errors' test case * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Make the check for relative URLs less strict to cover some valid cases (see RFC 1808) and extend test cases. * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Refine URL validation regexp and extend 'acs_tcl__util_url_valid_p' test case. * packages/acs-templating/acs-templating.info: * packages/acs-templating/tcl/data-procs.tcl: * packages/acs-templating/tcl/test/data-procs.tcl: Unify URL checking, now that 'util_url_valid_p' accepts relative URLs. Extend 'validate_url' test case and bump package version for dependencies. 2021-07-01 gustafn * packages/xowiki/tcl/form-field-procs.tcl: Added new method "child_components": Return for a list of form-field objs all child components * packages/xowiki/tcl/form-field-procs.tcl: make child_components a proc (::xowiki::formfield::child_components) and add filter expression 2021-06-30 hectorr * packages/acs-templating/tcl/test/util-procs.tcl: Add 'get_url_directory' test case, covering 'template::util::get_url_directory' * packages/acs-templating/tcl/test/util-procs.tcl: Add 'number_list' test case, covering 'template::util::number_list' * packages/acs-templating/tcl/test/util-procs.tcl: Add 'nvl' test case, covering 'template::util::nvl' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_checkbox_text' test case, covering 'template::data::validate' and 'template::data::validate::checkbox_text' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_currency' test case, covering 'template::data::validate' and 'template::data::validate::currency' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_enumeration' test case, covering 'template::data::validate' and 'template::data::validate::checkbox_enumeration' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_file' test case, covering 'template::data::validate' and 'template::data::validate::file' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_oneof' test case, covering 'template::data::validate' and 'template::data::validate::oneof' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_search' test case, covering 'template::data::validate' and 'template::data::validate::search' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_textdate' test case, covering 'template::data::validate' and 'template::data::validate::textdate' * packages/acs-templating/tcl/test/data-procs.tcl: Break overlong lines * packages/acs-templating/tcl/test/data-procs.tcl: Extend 'validate_search' test case with 'template::data::validate::party_search' * packages/acs-templating/tcl/test/data-procs.tcl: Extend 'validate_text' test case and reduce code duplication * packages/acs-templating/tcl/data-procs.tcl: Fix clock check. The clock command will not fail on incorrect dates (e.g. 2021-13-00) unless the format is specified. * packages/acs-templating/tcl/data-procs.tcl: Whitespace changes 2021-06-30 gustafn * packages/xowf/tcl/test-item-procs.tcl: factor out render_full_submission_form 2021-06-28 hectorr * packages/acs-templating/tcl/test/date-procs.tcl: Add 'util_negative' test case, covering 'template::util::negative' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_date' test case, covering 'template::data::validate', 'template::data::validate::date' and 'template::data::validate::timestamp' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_filename' test case, covering 'template::data::validate' and 'template::data::validate::filename' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_float' test case, covering 'template::data::validate' and 'template::data::validate::float' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_integer' test case, covering 'template::data::validate' and 'template::data::validate::integer' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_keyword' test case, covering 'template::data::validate' and 'template::data::validate::keyword' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_naturalnum' test case, covering 'template::data::validate' and 'template::data::validate::naturalnum' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_number' test case, covering 'template::data::validate' and 'template::data::validate::number' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_string' test case, covering 'template::data::validate' and 'template::data::validate::string' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_text' test case, covering 'template::data::validate' and 'template::data::validate::text' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_url' test case, covering 'template::data::validate' and 'template::data::validate::url' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_url_element' test case, covering 'template::data::validate' and 'template::data::validate::url_element' * packages/acs-templating/tcl/test/data-procs.tcl: Extend 'validate_date' with 'template::data::validate::time_of_day' * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Make package_id explicit 2021-06-28 gustafn * packages/xowiki/tcl/test/test-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: added test case for form field validation * packages/xowiki/tcl/menu-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: improve spelling * packages/xowiki/tcl/includelet-procs.tcl: make comments more uniform * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: provide a less confusing name for new methodm improve comments 2021-06-28 antoniop * packages/xowiki/tcl/form-field-procs.tcl: Fix typo in comment * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: Implement reset_to_default method to reset formfields in case of validation error the current behavior of this method is currently a no-op for every formfield, except files, where we want to make sure the value has been reset. We also handle the case now of compound fields, as they might be compounds of file formfields 2021-06-25 hectorr * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Add 'acs_subsite_application_group_new' test case, covering 'application_group::new' and 'application_group::delete' * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Add 'acs_subsite_rel_segment_new' test case, covering 'rel_segment::new', 'rel_segment::delete' and 'group::get_rel_segment' * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Add 'acs_subsite_rel_type_roles' test case, covering 'rel_types::create_role' and 'rel_types::create_role' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_boolean' test case, covering 'template::data::validate' and 'template::data::validate::boolean' * packages/acs-templating/tcl/test/data-procs.tcl: Add 'validate_email' test case, covering 'template::data::validate' and 'template::data::validate::email' * packages/acs-templating/tcl/test/date-procs.tcl: * packages/acs-templating/tcl/test/parse-test-procs.tcl: Make some tests production_safe 2021-06-24 hectorr * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Add 'acs_subsite_relation_procs' test case, covering 'relation_add', 'relation_remove', 'relation::get_object_one', 'relation::get_object_two', 'relation::get_objects' and 'relation::get_id' * packages/acs-mail-lite/tcl/utils-procs.tcl: Deprecate 'acs_mail_lite::utils::valid_email_p', as it is duplicated by 'util_email_valid_p'. It was not deleted because it was a public proc recently turned to private. * packages/categories/tcl/test/categories-procs.tcl: Extend 'category_tree_procs' test case with 'category::change_parent' * packages/categories/tcl/test/categories-procs.tcl: Extend 'category_tree_procs' test case with 'category::count_children' * packages/categories/tcl/test/categories-procs.tcl: Extend 'category_tree_procs' test case with 'category::relation::add_meta_category' and 'category::relation::get_meta_categories' * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: Fix ancient typo * packages/acs-mail-lite/tcl/email-inbound-procs.tcl: Replace deprecated 'acs_mail_lite::utils::valid_email_p' with 'util_email_valid_p' * packages/acs-tcl/tcl/test/utilities-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Replace regexp for mail validation by the version proposed by mozilla for the email input type validation, and increment the test cases for valid/invalid emails. Thanks to Günter Ernst for the pointers. * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: Reuse email validation logic 2021-06-24 gustafn * packages/acs-automated-testing/tcl/aa-test-procs.tcl: - support var args for "aa_log_result" like for "ns_log" and "ad_log" - make form parsing via xpath more robust (don't assume, every INPUT has a name, although it should) * packages/xowf/tcl/test/test-item-procs.tcl: extend regression test by including participants page during and after exam * packages/xowf/tcl/test-item-procs.tcl: fixed undefined parent_obj for strongly synchronous exams * packages/xowf/tcl/test-item-procs.tcl: set default grading scheme to "wi1p" instead of "wi1" * packages/xowf/tcl/test/test-item-procs.tcl: update covered procs in test case 2021-06-23 hectorr * packages/acs-tcl/tcl/test/widget-test-procs.tcl: Add 'ad_future_years_list' test case, covering 'ad_future_years_list' * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: Add 'db_boolean' test case, covering 'db_boolean' * packages/forums/tcl/test/forums-procs.tcl: Add 'forum_enable_disable' test case, covering 'forum::enable' and 'forum::disable' * packages/acs-tcl/tcl/test/utilities-procs.tcl: Add 'host_admin_and_outgoing_sender' test case, covering 'ad_outgoing_sender' and 'ad_host_administrator' * packages/acs-tcl/tcl/test/utilities-procs.tcl: Add 'name_to_path' test case, covering 'util::name_to_path' * packages/acs-tcl/tcl/test/object-test-case-procs.tcl: Add 'object_p' test case, covering 'acs_object::object_p' * packages/acs-tcl/tcl/test/utilities-procs.tcl: Add 'string_length_compare' test case, covering 'util::string_length_compare' * packages/acs-tcl/tcl/test/utilities-procs.tcl: Add 'util_email_valid_p' test case, covering 'util_email_valid_p' * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: Increase verbosity 2021-06-23 gustafn * packages/xowf/lib/inclass-exam-answer.wf: add a 10sec grace period to allow typing until the last seconds (but not longer) 2021-06-22 hectorr * packages/acs-datetime/tcl/test/acs-datetime-procs.tcl: Add minimal test case for 'dt_midnight_p' 2021-06-22 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml: * packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: - fixed display of total points in exam protocol: base calculations on total points rather than the points achievable based on progress - fixed typo in message key * packages/xowiki/tcl/test/api-test-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: Add all whitespace characters between double quotes when converting a dict to hstore Many thanks to Guenter Ernst for the analysis. Extended regression test * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: Improved handling of autosaved revisions - reject autosave attempts when time for a student is up (works for synchronized and non-synchronized exams) - include submissions with autosaved content in exam protocol (even when state is "initial") 2021-06-21 trenner * packages/xowf/tcl/test-item-procs.tcl: show personal bulk-notification link only if at least one user can receive the notification 2021-06-21 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/xowf.info: avoid potential loss of submission data on "publish" operations 2021-06-21 gernst * packages/xowiki/tcl/test/api-test-procs.tcl: Fix typo 2021-06-21 antoniop * packages/file-storage/catalog/file-storage.de_DE.ISO-8859-1.xml: * packages/file-storage/catalog/file-storage.en_US.ISO-8859-1.xml: * packages/file-storage/catalog/file-storage.it_IT.ISO-8859-1.xml: * packages/file-storage/file-storage.info: * packages/file-storage/www/download-zip.tcl: Improve zip file download solution: instead of a link to be clicked, stay closer to previous implementation and trigger the download automatically by including an invisible iframe pointing to the file in the user message 2021-06-19 gustafn * packages/xowiki/www/resources/autosave-text.js: support multiple autosave fields on a single page 2021-06-18 hectorr * packages/acs-content-repository/acs-content-repository.info: * packages/acs-content-repository/sql/postgresql/content-revision.sql: * packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d14-5.10.0d15.sql: Use 'revision_id' as a tiebreaker in case creation_date is the same, which can happen if different revisions were created inside a single transaction. 2021-06-18 antoniop * packages/file-storage/www/download-zip.tcl: Break overlong line * packages/file-storage/www/download-zip.tcl: Check objects ids all in one query, before any further action is taken * packages/file-storage/www/download-zip.tcl: Fix english of query name * packages/file-storage/catalog/file-storage.de_DE.ISO-8859-1.xml: * packages/file-storage/catalog/file-storage.en_US.ISO-8859-1.xml: * packages/file-storage/catalog/file-storage.it_IT.ISO-8859-1.xml: * packages/file-storage/file-storage.info: * packages/file-storage/www/download-zip-2.tcl: * packages/file-storage/www/download-zip.tcl: Implement a simple "progress-bar" interaction when one downloads a zip file: file is generated while the progress bar is running and the download link is generated and served to the user as part of a util_user_message * packages/file-storage/www/download-zip.tcl: Move operations so that they are closer to their computation's actual usage * packages/file-storage/www/download-zip.tcl: Simplify determining outfile destination * packages/file-storage/www/download-zip.tcl: Take more advantage of exception handling * packages/file-storage/www/download-zip.tcl: We are only interested in the side effects of this computation 2021-06-17 antoniop * packages/proctoring-support/tcl/safe-exam-browser-procs.tcl: Prefer returning forbidden, unauthorized actually asks for authentication * packages/proctoring-support/tcl/safe-exam-browser-procs.tcl: Update doc 2021-06-16 antoniop * packages/proctoring-support/tcl/safe-exam-browser-procs.tcl: Fix typo * packages/proctoring-support/proctoring-support.info: * packages/proctoring-support/sql/postgresql/proctoring-support-create.sql: * packages/proctoring-support/sql/postgresql/upgrade/upgrade-1.5.1-2.0.0.sql: * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/tcl/safe-exam-browser-procs.tcl: * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Safe Exam Browser support reform: - capture both RequestHash and ConfigKeyHash from the request headers and use both to validate the request. This enables to choose to just enforce the plain conf, instead of the whole conf+binaries combination, which is platform-specific - support storing multiple keys, required e.g. to support multiple platform-specific keys - make suppling of the config file optional - extend automated tests to cover new features - clanup redundant index - return config file using its stored filename 2021-06-14 antoniop * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/proctoring-support.info: * packages/proctoring-support/tcl/safe-exam-browser-procs.tcl: Correct hash challenging: actually, the hash sent by the browser changes based on the requested URL, so it does not make sense to set it directly. 2021-06-12 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/xowf.info: Maintain revision date for "update_attribute_from_slot" This is not a full-featured version, since it does not update the modifying user and the modifying IP (since this data is not always available). But this version is at least good enough for experimenting and checking for unwanted side-effects. xotcl-core: upadated version number to 5.10.0d40 xowf: upadated version number to 5.10.0d39 * packages/acs-tcl/tcl/request-processor-procs.tcl: fix once more handling of internal redirects in error cases many thanks to thomas renner! * packages/xowiki/www/index.vuh: improve comments, make logging output more regular 2021-06-11 antoniop * packages/proctoring-support/lib/proctoring-display.tcl: Avoid double encoding of base URL * packages/proctoring-support/tcl/safe-exam-browser-procs.tcl: Make sure the file is downloaded with a .seb extension 2021-06-09 gustafn * packages/xowf/tcl/test-item-procs.tcl: fix editing bug * packages/xowf/www/index.vuh: improve comments and reguarity of log messages * packages/xowf/lib/inclass-exam.wf: no need to ask answer_manager for package_id 2021-06-09 antoniop * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/proctoring-support.info: * packages/proctoring-support/sql/postgresql/proctoring-support-create.sql: * packages/proctoring-support/sql/postgresql/proctoring-support-drop.sql: * packages/proctoring-support/sql/postgresql/upgrade/upgrade-1.4.2-1.5.0.sql: * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/tcl/safe-exam-browser-procs.tcl: Basic backend support for Safe Exam Browser (https://safeexambrowser.org/): via the API is possible to associate a Safe Exam Browser configuration and its validation key to the proctored object. The proctored page will then take care of enforcing that, if the safe exam browser is in use, the supplied request header matches with the configuration and the URL. When such match fails, we now return the configuration file to the browser, so that users can open it and restart their session properly configured. 2021-06-08 trenner * packages/xowf/lib/inclass-exam.wf: add missing variable which was deleted during the refactoring of the exam protocol 2021-06-07 trenner * packages/xowiki/tcl/personal-notification-procs.tcl: adapt personal-notification interface to support bulk messaging * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: add bulk-notification functionality to participants_table 2021-06-07 antoniop * packages/file-storage/www/folder-chunk.tcl: Do not localize the filename: it is not expected that message keys are expanded here as we do for the file title * packages/file-storage/www/file-add.tcl: Port sanitizing of upload filename from downstream * packages/acs-tcl/tcl/utilities-procs.tcl: Remove message keys sanitizing, which does not belong here 2021-06-04 antoniop * packages/proctoring-support/lib/proctoring-enforce.tcl: Formatting change * packages/proctoring-support/sql/postgresql/upgrade-1.2.3-1.3.1.sql: * packages/proctoring-support/sql/postgresql/upgrade-1.3.1-1.4.1.sql: * packages/proctoring-support/sql/postgresql/upgrade/upgrade-1.2.3-1.3.1.sql: * packages/proctoring-support/sql/postgresql/upgrade/upgrade-1.3.1-1.4.1.sql: Reconcile unusual folder structure 2021-06-02 hectorr * packages/chat/lib/transcript-view.adp: * packages/chat/lib/transcript-view.tcl: * packages/chat/lib/transcripts.tcl: * packages/chat/www/chat-transcript.adp: * packages/chat/www/transcript-edit-2.tcl: * packages/chat/www/transcript-edit.adp: * packages/chat/www/transcript-edit.tcl: Refactor display and edit modes to be based on ad_form. Many thanks to Monika Andergassen and Günter Ernst 2021-06-01 gernst * packages/xooauth/tcl/lti-procs.tcl: Zoom LTI Interface: do not unset "lis_person_sourcedid" and "lis_person_contact_email_primary". The latter is not needed if a user should be logged in as "Student", but is required if the user should be logged in as "Instructor". "Instructor" in the Zoom context means, giving this person the permission to create/manage meetings in the context of the launch. Which roles are considered by Zoom as being an "Instructor" have to be specified in the settings of Zoom's "LTI Pro" application. 2021-05-31 hectorr * packages/attachments/attachments.info: Increment version number due to past catalog changes 2021-05-31 antoniop * packages/acs-developer-support/tcl/acs-developer-support-procs.tcl: Cleanup typo in doc * packages/acs-templating/tcl/list-procs.tcl: Make api public, as this might be called in adp files from other packages * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Make test more robust when re-running * packages/acs-developer-support/tcl/acs-developer-support-procs.tcl: Whitespace changes 2021-05-30 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: reduce verbosity * packages/xowf/lib/answer-single-question.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: strengthen parameter checking 2021-05-27 gustafn * packages/acs-tcl/tcl/request-processor-procs.tcl: Fixed a bug in the request processor, when URL is /%3F The problem was that /%3F corresponds to a URL which is literally '/?' (question mark is not the separator for query variables). In this case a "string match" operation to determine the suffix based on this string will lead to unexpected characters since '?' is a match character. This lead in turn to a problem with redirects to the internally redirect of custom error pages. So, in this case (and probably others) the custom error page was not displayed. * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: use the right message key 2021-05-25 gustafn * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/xowiki.info: - Added new method extra_html_fields to provide an easy means to add extra HTML fields to the form autogenerated for form pages - bump version number to 5.10.0d79 * packages/xowf/tcl/test-item-procs.tcl: Added warning, when (not all) requested forms could not be loaded. Reduced verbosity. * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: Handling of mutual overwrites in answer workflows Mutual overwrites occur in answer workflows when a user manages to open multiple browser instances/or tabs on the same exam. In case there was an mutual overwrite, the position as provided by the instance attributes might deviate from the position, based on which the actual form data was generated. So, for validating and updating one has to change the position to the one from the form data (when this differs). Note that the randomizer depends on property "position" as well. The new version avoids that the user might accidentally overwrite his data and closes on mutual overwrite automatically the older instance window. Bumped version number to 5.10.0d38 * packages/xowiki/tcl/package-procs.tcl: More restricted checking for object_ids This avoids SQL errors in cases, where values are passed in via query variables which are valid integers but out of range for SQL integer, which are 32-bit integers. The better solution would even be to define an NSF argument type "object_id", but unfortunately, this requires a newer version of NSF than we target for the release. * packages/xowf/www/index.vuh: add more more option for quick debugging passed in form data * packages/xowiki/tcl/xowiki-procs.tcl: add warning to log file, when an HTML form-data is passed in for which we have no form-fields defined 2021-05-25 gernst * packages/xooauth/tcl/lti-procs.tcl: Added feature to auto lauch LTI login forms upon page loading. This is especially useful when embedding LTI content using an iframe. 2021-05-23 gustafn * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/catalog/acs-tcl.de_DE.ISO-8859-1.xml: * packages/acs-tcl/catalog/acs-tcl.en_US.ISO-8859-1.xml: * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: Added page_contract filter "object_id" This change adds the page_contract filter "object_id", which validates values whether these are syntactically acceptable as object_ids in PostgreSQL and Oracle. Note that before one is able to use the filter, the server has to be restarted. Otherwise, when e.g. "apm/version_reload.tcl" would be executed with the new filter, it would fail. So, one has to be careful on update scripts, when people upgrade from old version not to create a blocking mutual blocking condition. * packages/acs-tcl/tcl/request-processor-procs.tcl: improve comments * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/deprecated-procs.tcl: * packages/acs-tcl/tcl/form-processing-procs.tcl: * packages/acs-tcl/tcl/navigation-procs.tcl: * packages/acs-tcl/tcl/test/proxy-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: improved spelling 2021-05-21 gustafn * packages/assessment/tcl/as-qti-procs.tcl: * packages/assessment/www/asm-admin/unzip-file.tcl: * packages/file-storage/www/folder-zip-add.tcl: * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: use util::unzip instead of plain "exec unzip" commands 2021-05-20 trenner * packages/xowf/tcl/test-item-procs.tcl: add question_info_block to documentation block 2021-05-20 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: new variant of zip_file_contains_valid_filenames independent of "unuip -l" unfortunately the behavior of "unzip -l" differs not only between macOS and Linux, but even between different linux families, although showing the same version. 2021-05-19 trenner * packages/xowf/tcl/test-item-procs.tcl: add explicit return to be more human readable * packages/acs-tcl/tcl/utilities-procs.tcl: fix typo * packages/xowf/tcl/test-item-procs.tcl: split out question_info_block 2021-05-19 gernst * packages/xowiki/tcl/xowiki-procs.tcl: Refine regular expression used for the detection of Includelets 2021-05-18 gustafn * packages/xowf/tcl/test-item-procs.tcl: bugfix: pass "-revisions" to "render_proctor_images" since it is needed there * packages/xowiki/tcl/form-field-procs.tcl: fix braces for return_url * packages/acs-tcl/tcl/utilities-procs.tcl: improve handling of zip files that contain filenames, which are not valid UTF-8 2021-05-12 hectorr * packages/chat/www/transcript-entry.adp: * packages/chat/www/transcript-new-2.tcl: * packages/chat/www/transcript-new.adp: * packages/chat/www/transcript-new.tcl: Replace handcrafted form with 'ad_form'. Many thanks to Monika Andergassen. 2021-05-10 hectorr * release-steps.txt: Remove obsolete file that was re-added to the oacs-5-10 branch. 2021-05-10 antoniop * packages/acs-admin/www/apm/version-view-postgresql.xql: Prefer portable limit idiom, streamline query, "bad postgres" does not need this... 2021-05-07 trenner * packages/xowf/tcl/test-item-procs.tcl: added attachments for text_interaction * packages/xowf/tcl/test/test-item-procs.tcl: force en_US locale 2021-05-07 gustafn * packages/xowf/www/resources/test-item.css: preserve colors for printing "match-contains" and "match-contains-not" Background: bootstrap.css removes all backgrounds per default. * packages/xowf/tcl/test-item-procs.tcl: whitespace changes 2021-05-06 trenner * packages/xowf/tcl/test/test-item-procs.tcl: use language prefix from system locale 2021-05-05 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: Refactored exam protocol renderers The new code reduces the sinze of inclass-exam.wf significantly by moving the exam protocol into test-item-procs.tcl. In the same step, the largish function was split up, the rendering functions of submissions are now named consistently, and there are now different functions for rendering single items vs. many items, making the single-item rendering reusable. Additionally, the answer manager is documented in a more eye-friendly and modular way. * packages/xowf/tcl/xowf-procs.tcl: prefer var over proc 2021-05-05 antoniop * packages/acs-templating/tcl/head-procs.tcl: Allow to specify javascrit event handlers at the tcl level using CSS query selectors * packages/acs-tcl/tcl/test/doc-check-procs.tcl: In acs-tcl.documentation__check_proc_doc automated test, if the test fails on procs that belong to namespaces outside the OpenACS codebase, just issue a warning rather than failing * packages/acs-templating/tcl/head-procs.tcl: Modernize javascript idiom 2021-05-03 hectorr * packages/file-storage/file-storage.info: Add explicit version dependency on 'acs-lang' 2021-05-03 gustafn * packages/acs-automated-testing/tcl/aa-test-procs.tcl: * packages/acs-automated-testing/tcl/aa-test-procs.xql: Reduced number of "global" statements (which are often not used and probably leftovers from ancient times) * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: added minor debugging aids, make disk-cache more similar to ns_cache * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: improved listing of covered procs * packages/acs-automated-testing/tcl/aa-test-procs.tcl: removed further "global" statements 2021-05-03 antoniop * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Comment command that won't be defined in upstream codebase 2021-05-02 gustafn * packages/acs-automated-testing/tcl/aa-test-procs.tcl: * packages/acs-automated-testing/www/admin/index.tcl: fix broken test category handling previously, the exclusion categories were provided as categories, but the "real" categories could not be selected. An in case they were selected via query-parameter, filtering was broken. * packages/xowf/lib/inclass-exam.wf: improve comments * packages/acs-core-docs/www/db-api-detailed.adp: * packages/acs-core-docs/www/db-api-detailed.html: * packages/acs-core-docs/www/xml/kernel/db-api.xml: improve type setting For whatever reason, spaces are missing in the final .adp files * packages/acs-templating/www/doc/api/multirow.adp: * packages/acs-templating/www/doc/api/multirow.html: improve typesetting * packages/acs-automated-testing/www/admin/index.adp: * packages/acs-automated-testing/www/admin/index.tcl: pass selected categories from top-level overview to per-package tests * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: provide an analysis method for cleared input (callable for swas via method blank-inputs) * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: provide means to show submissions of students per test item * packages/acs-automated-testing/www/admin/index.adp: * packages/acs-automated-testing/www/admin/index.tcl: reduce redundancy in adp file 2021-05-01 gustafn * packages/file-storage/tcl/file-storage-procs.tcl: allow one to specify max upload size in configuration file in KB or MB 2021-04-30 gernst * packages/acs-authentication/tcl/local-procs.tcl: Bring the implementation of the "Search" operation of the "auth_search" service contract in line with the operation's definition by correcting the returned value ("username" instead of "user_id") and restricting the search to the local authority. 2021-04-30 antoniop * packages/forums/tcl/forums-callback-procs.tcl: Fix typo * packages/tsearch2-driver/sql/postgresql/upgrade/upgrade-5.10.0d5-5.10.0d6.sql: * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-install-procs.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-procs-postgresql.xql: * packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl: * packages/tsearch2-driver/tsearch2-driver.info: Reduce duplication: index and update_index were in fact implementing a upsert logic. Modern sql allows one to write this in a single query and merge the two apis into one. Replace reference in the service contracts as well. 2021-04-29 gustafn * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/www/resources/proctoring.js: improve spelling 2021-04-29 antoniop * packages/forums/forums.info: * packages/forums/sql/postgresql/forums-sc-create.sql: * packages/forums/sql/postgresql/upgrade/upgrade-1.4.0d3-1.4.0d4.sql: * packages/forums/tcl/forums-callback-procs.tcl: Handle correctly the indexing of moderated messages in fulltext search: so far the fulltext search would also include unapproved messages and threads. With this reform we address this by: - making sure unapproved threads are deleted from the index - making sure new threads are added to the index only when the are approved - making sure we unindex or reindex a thread whenever the approval state changes - not fetching unapproved messages in the datasource callback, hence excluding them from the index Note that Oracle has not been targeted by the reform. However, the situation improves for Oracle as well, because we won't render unmoderated messages in the datasource callback anymore. * packages/acs-authentication/tcl/local-procs.tcl: * packages/acs-authentication/tcl/local-procs.xql: Streamline idiom: we are only interested in the user ids 2021-04-28 antoniop * packages/news/lib/item-oracle.xql: * packages/news/lib/item.tcl: Address long standing todo: view news_items_live_or_submitted is defined for oracle exactly as the "workaround query" was doing, that is, from cr_revisions.content column * packages/news/lib/item.adp: Don't display an empty list element when comment_url is empty * packages/notifications/tcl/notification-email-procs.tcl: Fix typo in comment * packages/news/lib/item.tcl: Prefer api to hardcoded urls * packages/notifications/tcl/notification-email-procs.tcl: When sending a notification on behalf of a person, if the system is not configured to process replies to notification, do not set the reply-to address to anything different than the sender * packages/news/lib/item.tcl: Whitespace changes * packages/news/lib/item.tcl: Whitespace cleanup 2021-04-27 antoniop * packages/proctoring-support/www/resources/proctored-page.js: Do not handle 400 responses in any special way: cases found in practice were always the result of a client-side timeout * packages/proctoring-support/lib/proctoring-upload.tcl: * packages/proctoring-support/www/upload.adp: * packages/proctoring-support/www/upload.tcl: Now that the proctoring display UI has been ported, notify by default new proctoring events via websockets 2021-04-26 gustafn * packages/xowiki/tcl/xowiki-www-procs.tcl: improve error messages for autosave-handler 2021-04-26 antoniop * packages/proctoring-support/www/resources/proctored-page.js: Hide timing information from the user * packages/proctoring-support/www/resources/proctored-page.js: Streamline proctoring upload: - do not hardcode a timeout, requests will either complete or eventually fail - use a single event handler at the end of the request to decide if and how to reschedule the upload. This prevents the possibility that the same error event triggers multiple uploads via different handlers - improve documentation 2021-04-25 gustafn * packages/xowiki/tcl/includelet-procs.tcl: Added support for "-orderby" to includeletes "toc" and "book" Previously, these includelets could be only used when a page_order was given. In some cases, the base functionality came in handy for other cases, such as e.g. a glossary. * packages/xowf/tcl/test-item-procs.tcl: added type per question to exam overview * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: improve message keys * packages/xowiki/lib/view.tcl: * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/www/index.vuh: intensify argument checking * packages/xowiki/tcl/includelet-procs.tcl: make function "get_current_folder" more robust in case invalid data is fed in * packages/xowiki/tcl/package-procs.tcl: new web-callback method "www-update-references" This method can be called on the package-level to referesh all page references (from wiki-links) for an instance. * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: provide a nicer exam-overview * packages/xowf/tcl/test-item-procs.tcl: provide more detailed test-item descriptions for exam/question overviews * packages/xowiki/tcl/table-widget-procs.tcl: * packages/xowiki/www/resources/xowiki-bootstrap3-specific.css: * packages/xowiki/www/resources/xowiki-yui-specific.css: provide nicer icon for revisions button 2021-04-24 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/answer-single-question.wf: * packages/xowf/lib/edit-interaction.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/index.vuh: added exam-overview 2021-04-23 gustafn * packages/xowiki/tcl/table-widget-procs.tcl: added button for form-usages for displaying revisions * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/edit-interaction.wf: * packages/xowf/tcl/test-item-procs.tcl: added policy for supporting view of revisions, used more detailed message key values for supporting rounding by points or revisions * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: make grading checke configurable via URL, make calculations more robust 2021-04-23 gernst * packages/acs-tcl/tcl/form-processing-procs.tcl: * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: Remove non-functional "double click protection" in order to remove a potential attack vector 2021-04-23 antoniop * packages/xowf/tcl/xowf-procs.tcl: Improve fix: in FormPage www-edit, just after the save_data operation we render the FormPage to refresh the references. We should flush the form object cache here, as otherwise any formfield spec will come from the form in the previous state * packages/xowf/tcl/xowf-procs.tcl: Improve further: flush the object only when the state changes * packages/file-storage/file-storage.info: Reinstate oacs-dav as a dependency... there is api usage that is not so easy to replace at the moment 2021-04-22 gustafn * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: added page contract filter "printable" to avoid passing of binary values to certain pages * packages/search/search.info: * packages/search/www/search.tcl: added page contract filter "printable" to avoid potential DB errors on certain binary values * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: avoid site-map lookups from the DB when the connections is already closed. This avoids hard DB-errors when the URL contains invalid characters * packages/acs-api-browser/www/index.tcl: fixed bug introduced 8 months ago 2021-04-21 gustafn * packages/xotcl-core/tcl/30-widget-procs.tcl: improve robustness when called without connection 2021-04-21 antoniop * packages/file-storage/tcl/test/file-storage-procs.tcl: Fix test category, add tested api * packages/xowf/tcl/xowf-procs.tcl: Make sure that the form object is flushed whenever state might have changed If code executed after the state change accesses the form object again, this could be that from a previous state and e.g. hold the wrong form definition. This happens in practice downstream, where the submitting of activities also involves accessing the form definition to e.g. compute the grade based on the questions. Downstream we also cache the formfield specs, so if a spec is dependent on the state, might be wrong in also for future requests. 2021-04-20 gustafn * packages/xowiki/tcl/package-procs.tcl: allow at most 50K days, otherwise Tcl time scanner bails out * packages/xotcl-core/tcl/30-widget-procs.tcl: * packages/xotcl-core/tcl/context-procs.tcl: avoid subst in export_vars by using xo::update_query * packages/xowiki/tcl/package-procs.tcl: provide a friendly error message * packages/xowiki/tcl/package-procs.tcl: provide page-contract error instead of backtrace * packages/xowiki/tcl/package-procs.tcl: revert incompatible change * packages/xowiki/tcl/package-procs.tcl: strengthen regular expression for "days"; valid arguments are e.g. "20d" or "14days" 2021-04-20 antoniop * packages/xowiki/tcl/package-procs.tcl: Accept only integers as value for the rss query parameter * packages/file-storage/tcl/file-storage-procs.tcl: Fix typo * packages/acs-content-repository/tcl/content-revision-procs.tcl: * packages/file-storage/tcl/test/file-storage-procs.tcl: Fix typo, write a basic test for the involved api * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: Sanitize bogus URLs such as "//" or e.g. dotlrn URL lookup would fail Not clear if this should happen already at the ns_conn level or somewhere in the site_node api 2021-04-19 gustafn * packages/xooauth/tcl/lti-procs.tcl: added KTI 1.1 properties * packages/xooauth/xooauth.info: removed automounting * packages/xooauth/www/index.vuh: removed obsolete index.vuh file 2021-04-19 antoniop * packages/notifications/www/unsubscribe.tcl: Check permissions when one accesses the script and also when one performs the actual unsubscribing operation * packages/notifications/www/unsubscribe.xql: Cleanup leftover file * packages/xooauth/www/index.vuh: Disable vuh, add remarks * packages/acs-service-contract/tcl/contract-procs.tcl: Fix typo * packages/notifications/www/request-change-frequency.tcl: Harden safety: require login, do not let people outside the requester fiddle with the frequency * packages/file-storage/file-storage.info: * packages/file-storage/tcl/file-storage-procs.tcl: * packages/file-storage/www/index.tcl: Make oacs-dav only a weak dependency for file-storage, if the package is not there, just treat it as if the parameter was disabled * packages/notifications/www/test-cleanup.tcl: * packages/notifications/www/test.adp: * packages/notifications/www/test.tcl: Remove attack surface 2021-04-18 gustafn * packages/xooauth/tcl/lti-includelet-procs.tcl: * packages/xooauth/tcl/lti-procs.tcl: * packages/xooauth/tcl/oauth-procs.tcl: * packages/xooauth/xooauth.info: added OAuth based LTI integration and launch buttons For details, see https://openacs.org/xowiki/accessing-lti-services 2021-04-17 gustafn * packages/xowiki/tcl/includelet-procs.tcl: use colon prefix for cmd names, simplify logic slightly 2021-04-16 antoniop * packages/xowiki/tcl/includelet-procs.tcl: Make sure package_id is set (many thanks to Günter Ernst) 2021-04-13 trenner * packages/xowf/lib/inclass-exam-answer.wf: fix typo 2021-04-13 hectorr * packages/file-storage/tcl/test/file-storage-procs.tcl: Avoid rollback in 'fs_add_file_to_folder' test in particular * packages/file-storage/tcl/test/file-storage-procs.tcl: Avoid rollback in web tests * packages/acs-tcl/tcl/test/proxy-test-procs.tcl: Relax error level * packages/file-storage/tcl/test/file-storage-procs.tcl: Rollback after tests * packages/acs-tcl/tcl/test/proxy-test-procs.tcl: Whitespace changes + Editor hints 2021-04-13 gustafn * packages/acs-automated-testing/tcl/aa-test-procs.tcl: delete modifying user info in acs_objects such that test user can be deleted as well * packages/file-storage/tcl/test/webtest-procs.tcl: fix error message * packages/file-storage/tcl/test/file-storage-procs.tcl: perform proper cleanup after the test * packages/acs-tcl/tcl/test/proxy-test-procs.tcl: removed unclear test 2021-04-12 gustafn * packages/xowf/lib/inclass-exam-answer.wf: decativate prevention of multiple tabs for exam protocol (and maybe other listings) 2021-04-12 antoniop * packages/news/www/item-create-3.tcl: Do not abort the script until we are done with e.g. notifications and such * packages/news/www/item-create-3.tcl: Fix blind spot when setting the return_url * packages/acs-templating/tcl/list-procs.tcl: Fix long standing regression After https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A2 0080908165252, in template::list::write_csv we started looping through the list "elements", rather than the "display_elements". This prevents specifying different sets of columns to be returned depending on the "-formats" and "-selected_format" options in template::list::create. Many thanks to Oasi Software that customized this proc a long time ago, so that I could realize where the problem was. * packages/news/tcl/news-procs.tcl: Fix typo * packages/file-storage/tcl/file-storage-procs.tcl: Refactor query to go over the fs hierarchy, rather than the permission one, add remarks * packages/news/www/item-create.tcl: * packages/news/www/preview.tcl: Whitespace cleanup 2021-04-09 gustafn * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: passing "-debug" flag explicitly to nsf::proc * packages/acs-content-repository/tcl/content-item-procs.tcl: * packages/acs-content-repository/tcl/content-revision-procs.tcl: * packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl: whitespace changes 2021-04-09 antoniop * packages/acs-authentication/tcl/authentication-procs.tcl: Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc * packages/acs-authentication/tcl/authentication-procs.tcl: Make proc public, as was intended * packages/file-storage/tcl/file-storage-procs.tcl: Recover logic went missing after refactoring (with some remarks) 2021-04-08 hectorr * packages/acs-automated-testing/www/admin/index.adp: Remove leftover 2021-04-08 gustafn * packages/xowf/lib/inclass-exam-answer.wf: fix last commit (many thanks to Thomas Renner) * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: made includelet "categories" folder aware (on can pass "parent" in form of a page-ref to the includelet) refactored some of the code to increase reusability * packages/xowiki/tcl/tree-procs.tcl: * packages/xowiki/www/resources/xowiki-bootstrap3-specific.css: make treeview more compact 2021-04-08 antoniop * packages/acs-authentication/tcl/authentication-procs.tcl: * packages/acs-authentication/tcl/password-procs.tcl: Deprecated trivial private ad_user_login wrapper, which is already a public api * packages/acs-authentication/tcl/authentication-procs.tcl: * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: * packages/acs-core-docs/www/xml/kernel/ext-auth-design.xml: Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias Rationale: - the proc provides some value to the user by choosing the right contract implementation depending on the authority - we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO - the proc was already tested and documented * packages/proctoring-support/lib/proctoring-upload.tcl: * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Refactoring, as proctoring files are not only pictures, make api public, write automated test * packages/acs-core-docs/www/tutorial-categories.adp: * packages/acs-core-docs/www/tutorial-categories.html: * packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml: Update doc following the acs_named_objects phasing out, this escaped the commit back in the days 2021-04-07 hectorr * packages/acs-content-repository/tcl/content-revision-procs.tcl: Fixed var name and add warning for 'cr_file_name' being empty (the latter ported from downstream, originally made by Günter Ernst) 2021-04-07 gustafn * packages/file-storage/tcl/file-storage-procs.tcl: break overlong lines * packages/file-storage/tcl/file-storage-procs-oracle.xql: * packages/file-storage/tcl/file-storage-procs-postgresql.xql: * packages/file-storage/tcl/file-storage-procs.tcl: * packages/file-storage/tcl/file-storage-procs.xql: stick to content-repository API instead of duplicating code here. 2021-04-07 antoniop * packages/proctoring-support/tcl/proctoring-support-init.tcl: Use better timing idiom 2021-04-06 hectorr * packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml: * packages/xowf/xowf.info: Update spanish message keys 2021-04-06 gustafn * packages/file-storage/tcl/file-storage-procs.tcl: break overlong lines * packages/xotcl-core/tcl/cr-procs.tcl: improve comments * packages/xowf/lib/inclass-exam.wf: make actions changed from the background state-safe * packages/acs-content-repository/acs-content-repository.info: * packages/acs-content-repository/tcl/content-revision-procs-oracle.xql: * packages/acs-content-repository/tcl/content-revision-procs-postgresql.xql: * packages/acs-content-repository/tcl/content-revision-procs.tcl: * packages/file-storage/file-storage.info: * packages/file-storage/tcl/file-storage-procs-oracle.xql: * packages/file-storage/tcl/file-storage-procs-postgresql.xql: * packages/file-storage/tcl/file-storage-procs.tcl: new function: ::content::revision::export_to_filesystem This change moves functionality from file-storage to acs-content-repository. all application packages should be free of internals, such as the storage type. Storage_type should be handled in the content-repository package. We are not yet done, there is still more to do in this respect in the file-storage package. 2021-04-06 antoniop * packages/proctoring-support/lib/proctoring-upload.tcl: * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/tcl/proctoring-support-init.tcl: Implement a checksum + cache mechanism to check whether user is sending the same file multiple times: this is needed to address the problem of timeouts, where the server might process a request even when the client has given up and rescheduled the upload. We now store the latest checksum that has been received and compare it with the new picture. * packages/xotcl-core/tcl/cr-procs.tcl: Improve fix: do not even fetch the context_id for revisions, so we do not touch it when saving * packages/xotcl-core/tcl/cr-procs.tcl: Make sure that the context_id of a CRItem is always fetched from that of the item, rather than the revision, otherwise we could break object_id = context_id constraint on saving 2021-04-05 gustafn * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: added support for avoiding quoting of labels (e.g. in buttons) * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: added support for pagination buttons, visited buttons and flagged buttons * packages/xowf/tcl/test/test-item-procs.tcl: improve listing of covered methods * packages/acs-content-repository/www/doc/api/extlink.adp: * packages/acs-content-repository/www/doc/api/extlink.html: * packages/acs-content-repository/www/doc/guide/file-system.adp: * packages/acs-content-repository/www/doc/guide/file-system.html: * packages/acs-content-repository/www/doc/guide/keywords.adp: * packages/acs-content-repository/www/doc/guide/keywords.html: * packages/acs-content-repository/www/doc/guide/publish.adp: * packages/acs-content-repository/www/doc/guide/publish.html: * packages/acs-content-repository/www/doc/guide/storage.adp: * packages/acs-content-repository/www/doc/guide/storage.html: * packages/acs-content-repository/www/doc/guide/template.adp: * packages/acs-content-repository/www/doc/guide/template.html: * packages/acs-content-repository/www/doc/intermedia.adp: * packages/acs-content-repository/www/doc/intermedia.html: * packages/acs-content-repository/www/doc/requirements.adp: * packages/acs-content-repository/www/doc/requirements.html: * packages/acs-content-repository/www/doc/tutorial.adp: * packages/acs-content-repository/www/doc/tutorial.html: improve spelling * packages/xowiki/tcl/xowiki-www-procs.tcl: write mutual overwrites to the system log 2021-04-03 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test/test-item-procs.tcl: fix regression test which was broken due to last change (move of links to answer panel) * packages/xowf/lib/inclass-exam-answer.wf: make question manager configurable * packages/acs-admin/www/apm/bulk-install.xql: * packages/acs-admin/www/apm/index-oracle.xql: * packages/acs-admin/www/apm/index-postgresql.xql: * packages/acs-admin/www/apm/package-add-2.xql: * packages/acs-admin/www/apm/packages-install-3-oracle.xql: * packages/acs-admin/www/apm/packages-install-3-postgresql.xql: * packages/acs-admin/www/apm/packages/index-oracle.xql: * packages/acs-admin/www/apm/packages/index-postgresql.xql: * packages/acs-admin/www/apm/parameter-add-2.xql: * packages/acs-admin/www/apm/parameter-add.xql: * packages/acs-admin/www/apm/version-dependencies-oracle.xql: * packages/acs-admin/www/apm/version-dependencies-postgresql.xql: * packages/acs-admin/www/apm/version-dependencies.xql: * packages/acs-admin/www/apm/version-dependency-add-2.xql: * packages/acs-admin/www/apm/version-edit-2.xql: * packages/acs-admin/www/auth/batch-job.xql: * packages/acs-admin/www/users/bouncing-users.xql: * packages/acs-admin/www/users/merge.xql: whitespace changes (remove tabs) 2021-04-01 gustafn * packages/acs-templating/tcl/parse-procs.tcl: * packages/calendar/tcl/calendar-procs.tcl: * packages/calendar/www/cal-item-view.adp: * packages/calendar/www/cal-item-view.tcl: make template::adp_puts private again. removed some of the weirdness in calendar attachments * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: moved answer status into answer_panel (similar to downstream), made sensitivity of inspect links automatically updating (like downstream) made templating easier and refactored code 2021-03-31 trenner * packages/xowf/tcl/test-item-procs.tcl: call 'next' to ensure file attachments are stored in the database and content repository * packages/xowf/tcl/test-item-procs.tcl: fix attachments for short_text_interaction 2021-03-31 hectorr * packages/file-storage/tcl/file-storage-procs.tcl: Mark 'fs::max_upload_size' as public, as it is used in 'attachments' * packages/acs-templating/tcl/parse-procs.tcl: Mark 'template::adp_puts' as public, as it is used in 'calendar' * packages/file-storage/tcl/test/file-storage-procs.tcl: Remove bogus proc name. Fixes 'naming__proc_naming' test case * packages/acs-admin/www/apm/package-scan.tcl: Remove obsolete file, initially deleted in oacs-5-8 branch, 8 years ago, which somehow managed to survive * packages/acs-api-browser/www/type-view.tcl: Remove obsolete file. Fixes 'callgraph__bad_page_calls' test case * packages/acs-admin/www/apm/version-generate-diffs.tcl: * packages/acs-admin/www/apm/version-generate-diffs.xql: Remove obsolete files, initially deleted in oacs-5-8 branch, 8 years ago, which somehow managed to survive * packages/chat/www/search-3.tcl: * packages/chat/www/user-ban-2.tcl: * packages/chat/www/user-unban-2.tcl: Replace deprecated API. Fixes 'callgraph__bad_page_calls' test case 2021-03-31 gustafn * packages/file-storage/tcl/test/file-storage-procs.tcl: * packages/file-storage/tcl/test/webtest-procs.tcl: * packages/file-storage/www/delete.tcl: extend regression test, add covered procs to webtest * packages/acs-automated-testing/www/admin/index.adp: fix output in summary line * packages/forums/tcl/test/forums-procs.tcl: * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: improve listing of procs covered by regression test * packages/file-storage/tcl/file-storage-callback-procs.tcl: * packages/file-storage/tcl/file-storage-procs.tcl: * packages/file-storage/tcl/test/tclwebtest-procs.tcl: * packages/file-storage/www/download-zip.tcl: * packages/file-storage/www/file-add.tcl: * packages/file-storage/www/folder-zip-add.tcl: improve spelling * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: list called api procs * packages/xowiki/tcl/test/xowiki-test-procs.tcl: whitespace change * packages/acs-automated-testing/www/admin/index.tcl: * packages/file-storage/tcl/file-storage-procs.tcl: * packages/file-storage/tcl/test/file-storage-procs.tcl: * packages/file-storage/www/delete.tcl: whitespace changes 2021-03-31 antoniop * packages/proctoring-support/lib/proctoring-display.tcl: Improve doc, bring param in the contract * packages/proctoring-support/lib/proctoring-display.adp: * packages/proctoring-support/lib/proctoring-display.tcl: Make proctoring-display provide a master, according to a parameter * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: Plug the proctoring-display include to the inclass-exam via a web-callable method * packages/proctoring-support/lib/proctoring-display.adp: * packages/proctoring-support/lib/proctoring-display.tcl: Port of the downstream proctoring-display user interface, minus the WU-specific stuff, that we will maintain locally * packages/proctoring-support/lib/proctoring-display.adp: * packages/proctoring-support/lib/proctoring-display.tcl: Some changes to allow including the UI in pages that need query parameters (e.g. the 'm' method) 2021-03-30 hectorr * packages/acs-tcl/tcl/test/test-set-cookie-procs.tcl: Check also token value in nsv in 'secret_tokens_get' test case * packages/acs-tcl/tcl/admin-procs.tcl: * packages/acs-tcl/tcl/apm-file-procs.tcl: * packages/acs-tcl/tcl/apm-install-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/apm-xml-procs.tcl: Make a bunch of apm procs public, as they are used in 'acs-admin'. Could be worth considering moving the ones used only in 'acs-admin' to that package, and making them private again, leaving public only those who may be useful to other packages/applications (i.e. CI/CD logic). * packages/acs-tcl/tcl/apm-procs.tcl: Mark 'apm_application_new_checkbox' as public, as it is used in the site-map * packages/acs-tcl/tcl/apm-procs.tcl: Mark 'apm_mark_version_for_reload' as public, as it is used in 'acs-automated-testing' * packages/acs-authentication/tcl/authority-procs.tcl: Mark 'auth::authority::get_sc_impl_columns' as public, as it is used in 'acs-admin' * packages/acs-authentication/tcl/authentication-procs.tcl: Mark 'auth::can_admin_system_without_authority_p' as public, as it is used in 'acs-admin' * packages/acs-lang/tcl/lang-catalog-procs.tcl: Mark 'lang::catalog::package_catalog_dir' as public, as it is used in 'acs-admin' * packages/acs-lang/tcl/lang-message-procs.tcl: Mark 'lang::message::cache' as public, as it is used in 'acs-admin' * packages/acs-lang/tcl/lang-util-procs.tcl: Mark 'lang::util::get_hash_indices' as public, as it is used in 'acs-admin' * packages/acs-tcl/tcl/security-procs.tcl: Mark 'sec_get_random_cached_token_id' as public, as it is used in 'acs-subsite' * packages/acs-tcl/tcl/whos-online-procs.tcl: Mark 'whos_online::interval' as public, as it is used in 'acs-subsite' 2021-03-30 gustafn * packages/acs-automated-testing/acs-automated-testing.info: * packages/acs-automated-testing/sql/oracle/acs-automated-testing-create.sql: * packages/acs-automated-testing/sql/oracle/upgrade/upgrade-5.10.0d14-5.10.0d15.sql: * packages/acs-automated-testing/sql/postgresql/acs-automated-testing-create.sql: * packages/acs-automated-testing/sql/postgresql/upgrade/upgrade-5.10.0d14-5.10.0d15.sql: added index to speed up test cleanup The number of entries on also small sites is getting large, which is a good thing (i have > 30k on a pure OpenACS + xo* site) * packages/xowiki/tcl/test/api-test-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: extend regression test * packages/file-storage/tcl/test/file-storage-procs.tcl: * packages/file-storage/tcl/test/tclwebtest-procs.tcl: * packages/file-storage/tcl/test/webtest-procs.tcl: extend tests by porting obsolete test fs_add_file_to_folder to new web testing framework * packages/acs-automated-testing/tcl/aa-test-procs.tcl: extend web testing by adding a call to fined a link via link label previously, we just could follow a link based on a link label * packages/acs-tcl/tcl/test/navigation-procs.tcl: fix and extend regression test, when bread-crumb label needs quoting * packages/xowiki/tcl/xowiki-procs.tcl: improve comments * packages/xowiki/tcl/link-procs.tcl: mark deprecated procs as private 2021-03-29 hectorr * packages/acs-tcl/tcl/test/test-set-cookie-procs.tcl: Add new 'secret_tokens_get' and refactor 'test_set_cookie_procs' to include cases handled by the deleted ancient tests in 'acs-admin/www/test/signed-cookies-test' * packages/acs-tcl/tcl/test/test-set-cookie-procs.tcl: Change test category and rollback after execution * packages/acs-tcl/tcl/test/test-set-cookie-procs.tcl: Whitespace changes 2021-03-29 gustafn * packages/xowf/resources/prototypes/select-group-members.form.page: * packages/xowf/resources/prototypes/select-group-students.form.page: * packages/xowf/resources/prototypes/select-topics.form.page: * packages/xowf/resources/prototypes/topic-assignment.wf.page: add prototype pages * packages/xowf/tcl/test-item-procs.tcl: added support to "Answer_manager.get_answers" to return also non-exercise specific attributes * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: * packages/xowiki/www/prototypes/form.form.page: * packages/xowiki/xowiki.info: added utility function xowiki::filter_option_list to select a subset from an option list added form.form to ease creation of forms as form pages (important for using forms from global instance as form pages in workflows) * packages/xowiki/tcl/test/api-test-procs.tcl: extend regression test * packages/xowf/tcl/xowf-form-field-procs.tcl: * packages/xowf/xowf.info: extend role manager to include rel_type based roles (especially useful for DotLRN) * packages/xowiki/tcl/form-field-procs.tcl: improve robustness * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: improve spelling and whitespace changes * packages/xowf/tcl/xowf-procs.tcl: include recent site-wide pages, modernize code 2021-03-26 hectorr * packages/acs-authentication/tcl/authentication-procs.tcl: Make 'auth::get_register_authority' public, as it is used by acs-subsite * packages/chat/www/chat-room-grant.tcl: Remove 'chat-room-grant.tcl' page, linked nowhere and using obsolete API * packages/chat/www/moderator-grant-2.tcl: * packages/chat/www/moderator-grant.tcl: * packages/chat/www/moderator-revoke-2.tcl: * packages/chat/www/moderator-revoke.adp: * packages/chat/www/moderator-revoke.tcl: Remove 'moderator-grant' and 'moderator-revoke' pages, linked nowhere and using obsolete API 2021-03-26 gustafn * packages/xowiki/tcl/form-field-procs.tcl: order entries delivered by form-field "form_page" by title, since the title is used as well as label * packages/xowf/lib/inclass-exam.wf: reduce the max interval between screen captures from 60s to 30s during proctoring 2021-03-25 antoniop * packages/xotcl-core/tcl/01-debug-procs.tcl: Fix typo 2021-03-24 gustafn * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/postgresql/acs-objects-create.sql: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d30-5.10.0d31.sql: added constraint acs_objects_context_id_ck to avoid certain simple loops on context_ids * packages/acs-content-repository/acs-content-repository.info: * packages/acs-content-repository/sql/oracle/content-create.sql: * packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.0d12-5.10.0d13.sql: * packages/acs-content-repository/sql/postgresql/content-create.sql: * packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d12-5.10.0d13.sql: added constraint cr_items_parent_id_ck to avoid certain simple loops on parent_ids An item must not be equal to its own parent. Note that this constraint is not guaranteed to avoid all loops; it is still possible to create indirect recursive loops but excludes some real-world problems. * packages/acs-kernel/sql/oracle/acs-objects-create.sql: * packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d30-5.10.0d31.sql: added oracle upgrade scripts for new check constraints 2021-03-24 gernst * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/oracle/site-nodes-create.sql: * packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d31-5.10.0d32.sql: * packages/acs-kernel/sql/postgresql/site-nodes-create.sql: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d31-5.10.0d32.sql: Added constraint site_nodes_parent_id_ck to table "site_nodes" to avoid certain simple loops on parent_ids 2021-03-24 antoniop * packages/xowiki/tcl/includelet-procs.tcl: Fix typos * packages/xowiki/tcl/includelet-procs.tcl: Minimize quoting, return content in one sweep * packages/acs-templating/tcl/data-procs.tcl: Whitespace changes 2021-03-23 hectorr * packages/acs-templating/tcl/list-procs.tcl: Add minimal proc doc. Fixes 'documentation__check_proc_doc' test case * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: Increase test coverage * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Make '::acs::test::login' public, as it is used in other packages. Fixes 'callgraph__bad_library_calls' test case * packages/acs-authentication/tcl/authentication-procs.tcl: Make 'auth::verify_account_status' public, as it is used in other packages. Fixes 'callgraph__bad_page_calls' test case * packages/acs-templating/tcl/parse-procs.tcl: Make 'template::adp_init' public, as it is used in other packages. Fixes 'callgraph__bad_library_calls' test case * packages/survey/www/admin/process-response.tcl: * packages/survey/www/process-response.tcl: Remove obsolete code * packages/survey/tcl/survey-procs.tcl: * packages/survey/www/admin/one-respondent.tcl: * packages/survey/www/one-respondent.tcl: Replace deprecated proc 'survey_answer_summary_display' * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: * packages/acs-templating/tcl/list-procs.tcl: Whitespace changes 2021-03-23 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: CrClass->instance_select_query: return context_id of cr_item unless it is explicitly asked differently. Before, calls like get_folder_children returned items having the context_id of the revision. Since this attribute is ignored by most applications, it did not harm. However, a recent bugfix for honoring different context_ids caused troubles. In the worst case, one can end up with items having its own item_id as context id, which in turn causes permission queries to loop. * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/06-package-procs.tcl: improve spelling 2021-03-22 gustafn * packages/acs-tcl/tcl/security-procs.tcl: Improve robustness over invalid configurations Previously, the configuration of invalid hostnames (i.e. hostnames, which cannot be resolved via the OS means) for a network driver lead to runtime errors under certain conditions. * packages/xowf/lib/inclass-exam.wf: allow opening the exam-review also for exams, which are not autogradable * packages/xowiki/tcl/form-field-procs.tcl: change for exam_review: omit subquestion summary in cases, where no subquestion has a correct when condition * packages/xotcl-request-monitor/www/ip-info.tcl: restrict permissions of ip-info page * packages/xotcl-request-monitor/www/index.adp: * packages/xotcl-request-monitor/www/ip-info.adp: * packages/xotcl-request-monitor/www/ip-info.tcl: strengthen page contract, add breadcrums 2021-03-19 gustafn * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: added functionality to prevent opening the same exam in multiple tabs * packages/xowf/tcl/test/xowf-test-procs.tcl: perform proper login for all tests * packages/xowiki/tcl/test/xowiki-test-procs.tcl: perform proper login for web regression test * packages/xowf/tcl/test/test-item-procs.tcl: remove unneeded line * packages/xowf/tcl/test/xowf-test-procs.tcl: whitespace changes 2021-03-19 antoniop * packages/acs-tcl/tcl/site-nodes-procs.tcl: Fix typo, many thanks to Nathan Coulter * packages/acs-tcl/tcl/site-nodes-procs.tcl: Fix typos (many thanks to Nathan Coulter) * packages/dotlrn/catalog/dotlrn.it_IT.ISO-8859-1.xml: * packages/dotlrn/dotlrn.info: Make italian translation of "term" consistent with other occurrences in .LRN ("sessione") * packages/dotlrn-forums/catalog/dotlrn-forums.it_IT.ISO-8859-1.xml: * packages/dotlrn-forums/dotlrn-forums.info: * packages/dotlrn-portlet/catalog/dotlrn-portlet.it_IT.ISO-8859-1.xml: * packages/dotlrn-portlet/dotlrn-portlet.info: * packages/forums-portlet/catalog/forums-portlet.it_IT.ISO-8859-1.xml: * packages/forums-portlet/forums-portlet.info: * packages/static-portlet/catalog/static-portlet.it_IT.ISO-8859-1.xml: * packages/static-portlet/static-portlet.info: * packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml: * packages/xowf/xowf.info: * packages/xowiki/catalog/xowiki.it_IT.ISO-8859-1.xml: * packages/xowiki/xowiki.info: Update italian localization 2021-03-18 hectorr * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: Delete duplicated message keys * packages/acs-templating/catalog/acs-templating.es_ES.ISO-8859-1.xml: Update message key * packages/acs-templating/catalog/acs-templating.de_DE.ISO-8859-1.xml: * packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml: * packages/acs-templating/catalog/acs-templating.es_ES.ISO-8859-1.xml: * packages/chat/catalog/chat.en_US.ISO-8859-1.xml: * packages/chat/catalog/chat.es_ES.ISO-8859-1.xml: * packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.es_ES.ISO-8859-1.xml: Update message keys 2021-03-18 gustafn * packages/xowf/tcl/test/test-item-procs.tcl: Perform proper login with the test user such that session_ids and cookies are correctly setup * packages/xowiki/tcl/form-field-procs.tcl: fix function of formfield numeric: convert_to_internal_value * packages/xowf/lib/inclass-exam-answer.wf: fix passing of question number 2021-03-18 antoniop * packages/dotlrn-bootstrap3-theme/catalog/dotlrn-bootstrap3-theme.it_IT.ISO-8859-1.xml: * packages/dotlrn-bootstrap3-theme/dotlrn-bootstrap3-theme.info: Localize package in italian * packages/acs-tcl/tcl/proxy-procs.tcl: Port of downstream fix: make sure the encoding for the proxied interpreter is the same as the main interpreter Fixes acs-tcl.exec_binary_input automated test Many thanks to Nathan Coulter * packages/acs-tcl/tcl/test/proxy-test-procs.tcl: Port of new automated test exposing that with certain system encodings, proxied exec will not behave as the regular exec with respect to line translation Many thanks to Nathan Coulter * packages/openacs-bootstrap3-theme/catalog/openacs-bootstrap3-theme.it_IT.ISO-8859-1.xml: * packages/openacs-bootstrap3-theme/openacs-bootstrap3-theme.info: Remove leftover translation * packages/chat/catalog/chat.it_IT.ISO-8859-1.xml: * packages/chat/chat.info: * packages/dotlrn/catalog/dotlrn.it_IT.ISO-8859-1.xml: * packages/dotlrn/dotlrn.info: Update italian localization * packages/acs-templating/acs-templating.info: * packages/acs-templating/catalog/acs-templating.it_IT.ISO-8859-1.xml: Update italian message keys 2021-03-17 gernst * packages/news/news.info: * packages/news/sql/postgresql/news-package-create.sql: * packages/news/sql/postgresql/upgrade/upgrade-5.10.0d3-5.10.0d4.sql: Use "latest_revision" as revision_id for the newly created news-item when it is created with "is_live_p" set to false 2021-03-16 gustafn * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: Added substitution values for short text answers This change adds the possibility to provide randomized substitution values to short text questions via value sets. Value sets are a means for a content developer to provide multiple matching answers which are inserted into the text before an exercise is shown to the end user. One can e.g. provide for a calculation exercise several input and some output values, such that the students get different calculation exercises provided. These values can also be used for the correct-when clauses. The content developer can use percent-code delimited elements when defining the exercise: --- Assume, you want to download a %x.what% with the size of %x.size% over a %x.type% connection with a rate of %x.rate% from %univ%. --- and also in "correct when" --- %x.secs% --- the value sets can be provided via an extra field for the short-text questions and have the form of a Tcl dict: --- univ {WU-Vienna TU-Vienna "University of Vienna"} x { {type "ADSL" rate "256 kbit/s" size "235 MB" secs 5300 what "Powerpoint file"} {type "ADSL" rate "512 kbit/s" size "5.6 MB" secs 91 what "PDF file"} {type "4G" rate "80 Mbit/s" size "270 MB" secs 27 what "PDF file"} {type "4G" rate "40 Mbit/s" size "650 MB" secs 32 what "Lecturecast Video" } {type "5G" rate "1 Gbit/s" size "520 MB" secs 4 what "Powerpoint file" } {type "5G" rate "1 Gbit/s" size "1.5 GB" secs 12 what "Lecturecast Video" } } --- In this example, every student will get a randomly chosen value for the university (%univ%) and matching elements containing the answer (e.g. download time of "270 MB" over "80 Mbit/s" is 27 seconds). The download time is used in the correct when part, such that auto-correction can be applied. When a student answers this exercise, the system provides random choices that are substituted in the text. For every variable ("univ", "x", ..) different random values are used for the student. Certainly, for other students, other numbers and results will be provided. Note that this value sets can be used for numeric a non-numeric exercises. Current limitations: - only defined for short-text questions (can be in general also for other question types) - no elaborate user interface for entering value sets (or a thorough validator) is provided. * packages/xooauth/www/admin/lti-test.tcl: avoid call to deprecated function, simplify code * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: extend regression test: check, whether pages call deprecated code or private functions of other packages * packages/xowiki/tcl/xowiki-utility-procs.tcl: improve comment * packages/acs-developer-support/tcl/acs-developer-support-procs.tcl: * packages/acs-templating/tcl/list-procs.tcl: make procs public, since these have to be called from pages of other packages * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: make tcl_to_html public * packages/xotcl-core/tcl/cr-procs.tcl: provide default value for storage_type for in-memory created items 2021-03-16 antoniop * packages/proctoring-support/tcl/proctoring-procs.tcl: Do not treat invalid integers as if they were the empty string * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Mention covered api * packages/rss-support/tcl/rss-support-procs.tcl: * packages/rss-support/tcl/rss-support-procs.xql: Merge queries together * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Provide an API to delete proctoring folders, extend regression tests 2021-03-15 hectorr * packages/rss-support/tcl/rss-support-procs.tcl: Check if the subscription exists before deletion 2021-03-15 gustafn * packages/xowiki/tcl/package-procs.tcl: add debugging output for migration phase * packages/xowiki/tcl/test/api-test-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: * packages/xowiki/xowiki.info: added function "xowiki::randomized_index" extended regression test bumped version to 5.10.0d75 * packages/xowiki/tcl/xowiki-procs.tcl: added instance variable storage_type * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: reduce font sizes * packages/xowf/tcl/test/test-item-procs.tcl: * packages/xowf/tcl/test/xowf-test-procs.tcl: use test user_id instead of current user for running tests 2021-03-14 gustafn * packages/xowiki/tcl/upgrade/upgrade.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/xowiki.info: added storage_type to xowiki_form_instance_item_view 2021-03-13 gustafn * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/prototypes/TestItemReorder.form.page: * packages/xowiki/tcl/form-field-procs.tcl: Added two types of grading schemes (in addition to "exact") to ordering exercises: - "position": count elements as correct, when these are on the correct position - "relative": count elements as correct, if the neighboring element is correctly before the actual element The results are adjusted by the same guessing correction as in the "ggw" scheme for MC exercises. Example: - desired order: 1,2,3,4 - provided answer: 3,1,2,4 - scheme "exact": 0% - scheme "position": 0 0 0 1 - scheme "relative": 0 1 1 (correctly ordered 1<2 and 2<4) A minor refactoring was also performed to ease code reuse. * packages/acs-automated-testing/www/admin/index.adp: * packages/acs-automated-testing/www/admin/index.tcl: * packages/acs-automated-testing/www/resources/tests.css: include totals in test case listing, use proper thead and tfoot elements 2021-03-12 hectorr * packages/openacs-bootstrap3-theme/www/resources/css/main.css: Deal with 'search' input types, that are not in the 'form-control' class, in Bootstrap 3. See CSS comment for details. * packages/openacs-bootstrap3-theme/resources/widgets/search.adp: Use input type 'search' in search widget * packages/openacs-bootstrap3-theme/resources/widgets/search.adp: Whitespace changes 2021-03-12 gustafn * packages/acs-datetime/tcl/acs-calendar-procs.tcl: make "dt_get_info" public since it is used from other packages * packages/acs-tcl/tcl/text-html-procs.tcl: make "util_close_html_tags" public since it is called from public pages 2021-03-12 antoniop * packages/xooauth/lib/authorize.tcl: Add basic include contract * packages/xooauth/www/admin/lti-test.tcl: Aolserver/Naviserver builtin ns-parsequery already embeds URL decoding * packages/acs-tcl/tcl/http-client-procs.tcl: Remove extra decoding ns_parsequery provides it already * packages/acs-tcl/tcl/utilities-procs.tcl: Remove extra url decoding, ns_parsequery embeds it already * packages/xooauth/tcl/oauth-client-procs.tcl: * packages/xooauth/tcl/oauth-procs.tcl: Revert usage of builtin commands, as we need a specific decoding for oauth, not the urldecoding ns_parsequery embeds 2021-03-11 hectorr * packages/file-storage/tcl/test/file-storage-procs.tcl: Add 'fs_create_folder_using_api' test case, covering the 'fs::get_root_folder', 'fs::new_folder', 'fs::get_folder', 'fs::folder_p', 'fs::delete_folder', 'fs::rename_folder' and 'fs_get_folder_name' procs * packages/acs-templating/acs-templating.info: * packages/acs-templating/tcl/widget-procs.tcl: Add new ad_form input types * packages/acs-templating/tcl/widget-procs.tcl: Fix typo * packages/acs-templating/tcl/widget-procs.tcl: Remove duplicated code * packages/acs-templating/tcl/widget-procs.tcl: Use the 'search' input type in the search widget * packages/acs-subsite/lib/login.tcl: * packages/acs-subsite/www/register/recover-password.tcl: * packages/openacs-bootstrap3-theme/resources/templates/packages/acs-subsite/lib/login.tcl: Use the new 'email' input type widget * packages/acs-authentication/acs-authentication.info: * packages/acs-authentication/tcl/authentication-procs.tcl: * packages/acs-subsite/lib/user-info.tcl: * packages/acs-subsite/www/members/member-invite.tcl: Use the new 'url' and 'email' input type widgets * packages/acs-admin/www/auth/authority.tcl: * packages/xooauth/www/admin/lti-test.tcl: Use the new 'url' input type widget * packages/calendar/calendar.info: * packages/calendar/www/cal-item-new.tcl: Use the new 'url' input type widget. Bump version number for dependency * packages/calendar/calendar.info: * packages/calendar/www/cal-item-create-recurrence.tcl: * packages/calendar/www/view-list-display.tcl: Use the new ad_form 'number' input field. Bump version number for dependency. * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: * packages/acs-subsite/www/members/member-invite.tcl: * packages/acs-subsite/www/register/recover-password.tcl: * packages/calendar/www/cal-item-create-recurrence.tcl: * packages/openacs-bootstrap3-theme/resources/templates/packages/acs-subsite/lib/login.tcl: Whitespace changes * packages/faq/www/admin/q-and-a-add-edit.tcl: Whitespace changes, breaking overlong lines, and removal of old *SQL* 2021-03-11 antoniop * packages/acs-datetime/tcl/acs-calendar-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/xooauth/tcl/oauth-client-procs.tcl: * packages/xooauth/tcl/oauth-procs.tcl: * packages/xooauth/www/admin/lti-test.tcl: Use naviserver api to parse URL variables 2021-03-10 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/richtext-ckeditor4/tcl/ckfinder-procs.tcl: * packages/xotcl-core/tcl/30-widget-procs.tcl: Use built-in "ns_parsequery" instead of manual parsing of query parameters * packages/xowf/www/prototypes/assessment-index.page: include "topic-assignment.wf" in list of displayed workflow types * packages/oacs-dav/tcl/oacs-dav-procs.tcl: * packages/oacs-dav/tcl/oacs-dav-procs.xql: prefer using API over query in package for common data model 2021-03-10 antoniop * packages/categories/www/categories-browse.tcl: Cleanup var, break overlong line * packages/categories/categories.info: * packages/categories/sql/oracle/categories-init.sql: * packages/categories/sql/oracle/upgrade/upgrade-1.1.5d3-1.1.5d4.sql: * packages/categories/sql/postgresql/categories-drop.sql: * packages/categories/sql/postgresql/categories-init.sql: * packages/categories/sql/postgresql/upgrade/upgrade-1.1.5d3-1.1.5d4.sql: * packages/categories/www/doc/o.adp: * packages/categories/www/doc/o.html: Final phasing out of acs_named_objects - remove table creation - update documentation - provide an optional upgrade script to delete the table and the object type (commented out by default, as people might have defined object subtypes downstream). Context: this table and the related machinery were created at a time where acs_objects where not as mature as they are now and would not include the "title" information. To retrieve the object name, the only option was the stored procedure acs_object.name, which was not scalable. From an excerpt of the Changelog file: ..... 2004-03-31 jeffd ...... * packages/categories/tcl/category-trees-procs-oracle.xql: * packages/categories/tcl/category-trees-procs-postgresql.xql: acs_named_objects superfluous now that title is in acs_objects. need to fix the rest of the occurrences though ...... This tells us that the phasing out has already been decided back in 2004, but delayed. One technical reason, could be that the acs_named_objects table would also materialize the translation, while the title column would store sometimes a message key, that would need to be translated manually. This is helpful when e.g. sorting by name in SQL. However, only the faq and categories package would seem to make any use of the table and only the faq package would seem to maintain its values... This would make some UIs in the categories package practically useless since a long time. * packages/faq/www/admin/faq-delete.tcl: * packages/faq/www/admin/q-and-a-add-edit.tcl: Phase out usage of obsolete acs_named_objects table * packages/categories/www/categories-browse-oracle.xql: * packages/categories/www/categories-browse-postgresql.xql: * packages/categories/www/categories-browse.adp: * packages/categories/www/categories-browse.tcl: * packages/categories/www/categories-browse.xql: Rework of category UI: - phase out usage of acs_named_objects, use object title instead - rework pagination using builtin template::list features - reduce hardcoded styling and markup - rework strange database idioms - remove divergency between oracle and postgres codebase * packages/faq/www/admin/q-and-a-add-edit.tcl: Whitespace cleanup 2021-03-09 hectorr * packages/acs-templating/tcl/widget-procs.tcl: Add new 'url' input type to 'ad_form' * packages/file-storage/file-storage.info: * packages/file-storage/www/admin/upload-size-limit.tcl: Refactoring of the upload-size-limit admin page of the file-storage. Sets a default value of 2GB when no maxinput is found in the config file, and uses the new 'number' ad_form widget. Bump version for the widget dependency * packages/file-storage/www/simple-add.tcl: * packages/file-storage/www/simple-edit.tcl: Use the new 'url' input type * packages/file-storage/www/admin/upload-size-limit.tcl: * packages/file-storage/www/simple-add.tcl: * packages/file-storage/www/simple-edit.tcl: Whitespace changes 2021-03-09 gustafn * packages/xotcl-core/tcl/context-procs.tcl: * packages/xotcl-core/tcl/test/api-test-procs.tcl: Use built-in "ns_parsequery" instead of manual parsing of query parameters. Note that this change might alter query processing, since previously query parameter without explicit values were treated as boolean values (like in HTML), now these are treated like "x=" before. The new version is about 10x faster. Furthermore, new tests of the regression tests were added for query parameter processing. * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: fixed description of test file 2021-03-09 antoniop * packages/categories/www/categories-browse.tcl: Formatting change * packages/categories/www/cadmin/category-usage-oracle.xql: * packages/categories/www/cadmin/category-usage-postgresql.xql: * packages/categories/www/cadmin/category-usage.adp: * packages/categories/www/cadmin/category-usage.tcl: Refactor of category mapping UI: - remove reference to obsolete and unmaintained acs_named_objects, which was preventing the UI to work in practice - rework pagination and other idioms to long standing template::list best practices - reduce hardcoded styling 2021-03-08 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: perform conditional updates of context_id, fetch now storage_type as well to streamline code in the future 2021-03-08 antoniop * packages/cookie-consent/tcl/test/cookie-consent-test-procs.tcl: Fix typo * packages/proctoring-support/www/resources/proctored-page.js: Make sure that in case of errors that are also detected as timeouts, we do not reschedule the failed picture twice 2021-03-07 gustafn * packages/xowf/tcl/test/test-item-procs.tcl: extend regression test: provide tests of the basic life-cycle steps of the inclass-exam * packages/xowf/tcl/test/test-item-procs.tcl: fix typo 2021-03-06 gustafn * packages/acs-tcl/tcl/test/object-test-case-procs.tcl: add tests for "acs_object::get ... -element"; use "string equal" instead of "string match" (since the latter is semantically incorrect) * packages/cookie-consent/tcl/test/cookie-consent-test-procs.tcl: added new regression test * packages/acs-content-repository/tcl/test/content-item-test-procs.tcl: * packages/acs-content-repository/tcl/test/content-revision-test-procs.tcl: extend regression test * packages/cookie-consent/tcl/test/cookie-consent-test-procs.tcl: fix typo * packages/acs-tcl/tcl/object-procs.tcl: improve code orthogonality: support "acs_object::get ... -element" similar to "party::get"; return dict from acs_object::get * packages/acs-subsite/tcl/plsql-utility-procs.tcl: * packages/acs-subsite/tcl/subsite-procs.tcl: * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: improve test coverage * packages/acs-content-repository/tcl/content-item-procs.tcl: mark unused "content::item::get_context" deprecated, since it should be called on "acs_object" * packages/xowiki/tcl/form-field-procs.tcl: provide friendly error message in error.log in case provided answer-values (for e.g. MC) are invalid * packages/notifications/tcl/delivery-method-procs.tcl: * packages/notifications/tcl/notification-email-procs.tcl: * packages/notifications/tcl/reply-sweep-procs.tcl: * packages/notifications/tcl/sweep-procs.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-install-procs.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl: reduce public footprint * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: reduce verbosity * packages/xowiki/tcl/test/test-procs.tcl: relax creator check, return package instance name in result dict * packages/xotcl-core/tcl/01-debug-procs.tcl: support messages with multiple arguments 2021-03-05 gustafn * packages/xowf/tcl/test/test-item-procs.tcl: added test cases, improved test coverage * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/online-exam-answer.wf: don't use numbers as object names for actions; don't show "1" for navigation, when there is a single question * packages/xowf/lib/edit-interaction.wf: edit-item workflow: remove "view" form swa actions * packages/xowf/lib/inclass-exam.wf: fix typo 2021-03-04 gustafn * packages/xowiki/tcl/form-field-procs.tcl: added parameter "-parent_id" for "abstract_page" to allow a developer to point to a single folder * packages/acs-content-repository/tcl/doc-procs.tcl: remove leftover from ancient times (set it -deprecated and -private) 2021-03-03 hectorr * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: Add 'acs_api_browser_search' test case, covering the API proc search of the 'api-doc' webpage * packages/xowiki/tcl/test/xowiki-test-procs.tcl: Cleanup after test * packages/xowiki/tcl/test/xowiki-test-procs.tcl: Create a test user for the 'create_form_with_form_instance' test case, instead of using the current one, and use its 'user_info' in the calls to 'acs::test::http' * packages/forums/tcl/test/forums-procs.tcl: * packages/forums/tcl/test/webtest-procs.tcl: Prefer using 'user_info' over 'user_id' when calling 'acs::test::http' * packages/xowiki/tcl/test/xowiki-test-procs.tcl: Remove redundant 'apm_package_instance_delete' 2021-03-03 gustafn * packages/xowiki/tcl/test/test-procs.tcl: ::xowiki::test::create_form_page improve ease-ness to work with autonamed entries: return request dict containing page_info * packages/xowf/tcl/test/test-item-procs.tcl: added test case creating a text- and MC-item and an inclass exam * packages/acs-api-browser/www/proc-search.tcl: adjust to recent changes * packages/acs-automated-testing/tcl/aa-test-procs.tcl: bug fix: do not swallow errors in "aa_run_with_teardown" when -rollback s activated * packages/acs-admin/tcl/apm-admin-procs.tcl: * packages/acs-authentication/tcl/sync-procs.tcl: * packages/acs-developer-support/tcl/acs-developer-support-procs.tcl: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: reduce public footprint * packages/xowf/tcl/test/xowf-test-procs.tcl: reduce verbosity * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/general-comments/general-comments.info: * packages/general-comments/tcl/general-comments-procs.tcl: remove dependency of general-comments on acs-mail-lite * packages/acs-content-repository/www/doc/package.adp: * packages/acs-content-repository/www/doc/package.tcl: remove obsolete files * packages/acs-tcl/tcl/01-database-procs.tcl: whitespace changes: break overlong lines 2021-03-03 antoniop * packages/acs-authentication/tcl/authentication-procs.tcl: Creating a user without a username is possible if the authority is local, include the test authority among those for which we generate a username, as it is also local as in "hosted locally" Fixes acs-authentication.auth_use_email_for_login_p automated test * packages/acs-authentication/tcl/authentication-procs.tcl: Fix var name * packages/acs-content-repository/tcl/test/content-search-procs.tcl: Piggyback some more api to existing tests * packages/acs-authentication/tcl/authentication-procs.tcl: Port of downstream logic: do not use a hardcoded list of local authorities, but rather check if the authority implementation is local, which would handle also other downstream local authorities Rework the idiom to perform cheap checks first and improve documentation * packages/acs-content-repository/tcl/test/content-search-procs.tcl: Whitespace cleanup 2021-03-02 hectorr * packages/acs-templating/tcl/widget-procs.tcl: Add 'template::widget::number', a widget for the form input type 'number' * packages/acs-api-browser/lib/search.adp: Add IDs to the different forms * packages/acs-api-browser/www/proc-search.tcl: Adjust page contract to reality. 'name_weight' can be the string 'exact' * packages/acs-tcl/tcl/apm-xml-procs.tcl: Avoid trailing whitespace on info file creation * packages/acs-templating/acs-templating.info: Bump version number, so packages making use of the new input type 'template::widget::number' can depend on this particular version * packages/chat/chat.info: * packages/chat/www/room-edit.tcl: Change input widget to 'number' and use a maximum value for 'messages_time_window' that can be validated in the browser. Bump version number, and add dependency to the 'acs-templating' version providing with the new 'number' widget * packages/acs-tcl/tcl/apm-xml-procs.tcl: * packages/search/search.info: Whitespace changes 2021-03-02 gustafn * packages/acs-automated-testing/tcl/coverage-procs.tcl: adjust luminosity calculation to the 2020 standard for UHDTV and HDR * packages/acs-automated-testing/tcl/coverage-procs.tcl: fix typo * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: fixed bug: exception in test case auth_use_email_for_login_p caused test to terminate By adding an "ad_try", we can see that the intention to create a user with no username failed. Probably this was working at some time, not sure, if it still should. This is could be a general problem with "aa_run_with_teardown" to terminate too early in such cases. * packages/acs-automated-testing/www/admin/index.adp: * packages/acs-automated-testing/www/admin/index.tcl: improve navigation when multiple packages are selected * packages/search/tcl/search-procs.tcl: improve spelling * packages/acs-content-repository/tcl/content-procs.tcl: * packages/acs-content-repository/tcl/revision-procs.tcl: reduce public footprint * packages/search/sql/oracle/search-packages-create.sql: * packages/search/sql/oracle/upgrade/upgrade-5.10.0d3-5.10.0d4.sql: remove spurious parens * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.xql: * packages/evaluation/tcl/evaluation-procs.tcl: * packages/file-storage/tcl/file-storage-procs.tcl: * packages/file-storage/tcl/file-storage-search-procs-postgresql.xql: * packages/file-storage/tcl/file-storage-search-procs.tcl: * packages/oacs-dav/tcl/test/oacs-dav-procs.tcl: * packages/oacs-dav/tcl/test/oacs-dav-procs.xql: * packages/search/tcl/search-procs.tcl: replace low-level cr_fs_path by higher level interface content::revision::get_cr_file_path 2021-03-01 hectorr * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Add 'acs_subsite_attribute_datatypes' test case, covering 'attribute::translate_datatype' and 'attribute::datatype_validator_exists_p' procs * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Add 'attribute::value_add' and 'attribute::value_delete' to the 'acs_subsite_attributes' test case * packages/acs-subsite/tcl/attribute-procs.tcl: Remove unnecessary aliases 2021-03-01 gustafn * packages/acs-bootstrap-installer/acs-bootstrap-installer.info: * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/01-database-procs.tcl: Cleanup of low-level DB-interface: use dict instead of list with fixed positions * packages/search/search.info: * packages/search/sql/oracle/search-packages-create.sql: * packages/search/sql/oracle/upgrade/upgrade-5.10.0d3-5.10.0d4.sql: * packages/search/sql/postgresql/search-packages-create.sql: * packages/search/sql/postgresql/upgrade/upgrade-5.10.0d3-5.10.0d4.sql: Handle potential race condition in search observer queue maintenance In some cases, when e.g. objects are quicky deleted after updates, the object might be already be deleted when being tried to trigger a DELETE operation in the search queue. as a consequence, one can sometimes observer errors like the one below. The new code double-checks now, if the object for the DELETE operation still exists. ERROR: insert or update on table "search_observer_queue" violates foreign key constraint "search_observer_queue_object_id_fk" : DETAIL: Key (object_id)=(497509146) is not present in table "acs_objects". : CONTEXT: SQL statement "insert into search_observer_queue ( * packages/xowf/lib/inclass-exam.wf: calculate total points based on points and not on minutes * packages/acs-automated-testing/tcl/coverage-procs.tcl: * packages/acs-automated-testing/www/admin/index.adp: * packages/acs-automated-testing/www/admin/index.tcl: compute for and background colors from percentage to guarantee good contrast * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: fix entry in listing of covered procs * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: improve comments * packages/acs-bootstrap-installer/installer/index.tcl: * packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl: improve spelling * packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl: improve test coverage * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: move function db_current_rdbms to acs-bootstrap installer to improve code locality * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: reduce the number of locks (nsv-accesses) for OACS_FULLQUERIES by a factor of 3 when NaviServer is used. OACS_FULLQUERIES is one of the 3 most intensively locked nsv arrays for busy implementation * packages/xotcl-core/tcl/06-package-procs.tcl: reduce verbosity * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: reduce visibility of internal functions * packages/search/tcl/search-procs.tcl: white space changes: break overlong lines * packages/search/tcl/syndicate-procs.tcl: whitespace changes * packages/search/tcl/search-procs.tcl: whitespace changes: break overlong lines 2021-02-28 gustafn * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: add test cases for db_list* * packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl: added new test cases for testing page contract filters * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: added test cases for db_0or1row and db_1row * packages/acs-automated-testing/www/admin/index.adp: * packages/acs-automated-testing/www/admin/index.tcl: * packages/acs-automated-testing/www/admin/proc-coverage.tcl: * packages/acs-automated-testing/www/admin/testcase.adp: * packages/acs-automated-testing/www/admin/testcase.tcl: ease navigation: provide links to coverage pages * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: extended regression test: increase coverage of page contract filters * packages/acs-tcl/tcl/utilities-procs.tcl: fix util::external_url_p when security::locations returns empty element * packages/acs-automated-testing/tcl/aa-test-procs.tcl: * packages/acs-automated-testing/www/admin/index.adp: * packages/acs-automated-testing/www/admin/index.tcl: * packages/acs-automated-testing/www/admin/testcase.adp: * packages/acs-automated-testing/www/admin/testcase.tcl: improve navigation structure (context bar) and actions labeling the reousrce actions is not necessary, since rerun performs an automatic resources * packages/acs-tcl/tcl/01-database-procs.tcl: reduce usage of ad_arg_parser by using c-level implementation; fixes as well broken cases of bind-var handling * packages/acs-tcl/tcl/test/doc-check-procs.tcl: reduce verbosity * packages/acs-automated-testing/tcl/aa-test-procs.tcl: remove debug code * packages/acs-automated-testing/tcl/filter-procs.tcl: simplify and modernize Tcl code * packages/acs-automated-testing/tcl/coverage-procs.tcl: * packages/acs-automated-testing/tcl/example-procs.tcl: * packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl: * packages/acs-automated-testing/www/admin/index.tcl: * packages/acs-automated-testing/www/admin/proc-coverage.tcl: * packages/acs-automated-testing/www/admin/record-test.tcl: * packages/acs-automated-testing/www/index.tcl: * packages/acs-automated-testing/www/server.tcl: * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: whitespace changes 2021-02-27 hectorr * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Remove leftovers 2021-02-27 gustafn * packages/acs-api-browser/acs-api-browser.info: * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: * packages/acs-bootstrap-installer/acs-bootstrap-installer.info: * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/form-processing-procs.tcl: * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Added support for trailing non-positional arguments The change makes the old hack with the own trailing-argument-parser "ad_arg_parser" obsolete by using directly the c-level argument parser which is anyhow capable of handling trailing arguments. A few changes were necessary for api doc to handle there trailing arguments as well. The proc "db_string" is already converted to use native arguments. * packages/acs-bootstrap-installer/acs-bootstrap-installer.info: * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/01-database-procs.tcl: Fix for issue #3442 to support range types in .xql files PostgreSQL supports range types since 9.5. When using range types, square braces have to be used in SQL statements. Since OpenACS uses always Tcl substitution in .xql files, and OpenACS does NOT allow backslash substitution in these files, square brackets could not be escaped and therefore not be used in .xql files so far. This change allows now a developer to deactivate the substitution by passing e.g. "-subst none" to the db_* command using the .xql file. Valid values for "-subst" are "all", "none", "vars", and "commands", default is "all" which is exactly the behavior of before. Therefore, this change is fully backward compatible. * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: added a comment about the usefulness of ad_arg_parser * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: added test case for db_string with various bind options * packages/xotcl-core/tcl/03-doc-procs.tcl: * packages/xotcl-core/xotcl-core.info: adjust to api-browser changes for trailing non-positional arguments * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: * packages/acs-service-contract/tcl/test/acs-service-contract-procs.tcl: * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl: * packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl: * packages/acs-tcl/tcl/test/community-core-test-procs.tcl: * packages/acs-tcl/tcl/test/file-test-procs.tcl: * packages/acs-tcl/tcl/test/http-client-procs.tcl: * packages/acs-tcl/tcl/test/navigation-procs.tcl: * packages/acs-tcl/tcl/test/object-test-case-procs.tcl: * packages/acs-tcl/tcl/test/test-permissions-procs.tcl: * packages/general-comments/tcl/test/general-comments-procs.tcl: * packages/xowf/tcl/test/xowf-test-procs.tcl: * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: * packages/xowiki/tcl/test/xowiki-link-test-procs.tcl: complete listing of covered procs in test cases * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: move db-test case to db-regression test files * packages/xotcl-core/tcl/cr-procs.tcl: remove unneeded method * packages/acs-automated-testing/tcl/coverage-procs.tcl: * packages/acs-automated-testing/www/admin/index.adp: * packages/acs-automated-testing/www/admin/index.tcl: use fine-grade percentage to color mapping * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: whitespace changes 2021-02-26 hectorr * packages/dotlrn/tcl/test/club-procs.tcl: Add 'dotlrn_club_new' test case, covering 'dotlrn_club::new', 'dotlrn_club::community_type' and 'dotlrn_community::get_community_type_from_community_id' procs * packages/new-portal/tcl/test/new-portal-test-procs.tcl: Add 'portal::list_pages_tcl_list' and 'portal::get_portal_template_id' to the 'create_portal_from_template' test case * packages/dotlrn/tcl/test/club-procs.tcl: Add editor hints * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Add new test 'acs_subsite_attributes' covering the 'attribute::add', 'attribute::exists_p' and 'attribute::delete' procs * packages/dotlrn/tcl/test/dotlrn-procs.tcl: Add trivial test 'dotlrn_community_types', covering 'dotlrn::community_type', 'dotlrn_class::community_type' and 'dotlrn_club::community_type' procs * packages/new-portal/tcl/test/new-portal-test-procs.tcl: Delete extra pages * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: * packages/dotlrn/tcl/test/dotlrn-procs.tcl: Whitespace changes 2021-02-26 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/www/prototypes/select_question.form.page: add option to show student IP address during the exam * packages/xotcl-core/tcl/cr-procs.tcl: improve consistency of interface: use instance variable when no folder_id is provided * packages/xotcl-core/tcl/50-protocol-handler-procs.tcl: * packages/xotcl-core/tcl/doc-procs.tcl: * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: improve test coverage * packages/acs-content-repository/tcl/image-procs.tcl: * packages/acs-tcl/tcl/apm-install-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/test/navigation-procs.tcl: * packages/calendar/tcl/apm-callback-procs.tcl: * packages/file-storage/tcl/test/webtest-procs.tcl: * packages/notifications/tcl/apm-callback-procs.tcl: * packages/search/tcl/apm-callback-procs.tcl: * packages/xowiki/tcl/menu-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: mark private functions as private * packages/xowf/tcl/test-item-procs.tcl: use absolute time for computing beeps * packages/xotcl-core/tcl/05-db-procs.tcl: whitespace changes 2021-02-25 hectorr * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: Add 'index_unindex' test case, covering 'tsearch2::index', 'tsearch2::unindex' and 'tsearch2::update_index' procs * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: Add categories to build_query test case * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: Add simple test case for 'tsearch2::summary' * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: Add trivial test case for 'tsearch2::driver_info' * packages/new-portal/tcl/test/new-portal-test-procs.tcl: Remove leftovers * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: Test explicitly 'tsearch2::build_query_tcl', now that 'tsearch2::build_query' uses different methods yielding different results, and slight refactoring of the test, using 'aa_equals' instead of 'aa_true' for string comparison * packages/dotlrn-assessment/tcl/test/dotlrn-assessment-test-procs.tcl: * packages/dotlrn-chat/tcl/test/dotlrn-chat-test-procs.tcl: * packages/dotlrn-evaluation/tcl/test/dotlrn-evaluation-test-procs.tcl: * packages/dotlrn-faq/tcl/test/dotlrn-faq-test-procs.tcl: * packages/dotlrn-forums/tcl/test/dotlrn-forums-test-procs.tcl: * packages/dotlrn-news/tcl/test/dotlrn-news-test-procs.tcl: * packages/dotlrn-static/tcl/test/dotlrn-static-test-procs.tcl: * packages/static-portlet/tcl/test/static-portlet-procs.tcl: Use 'portal::exists_p' instead of custom idioms * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: Whitespace changes 2021-02-25 antoniop * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-callback-procs.tcl: Add a new subsite::parameter_changed implementation for xowiki, reacting to the switching of the use_hstore parameter This way it won't be necessary for other packages to generate the hstore manually using private api * packages/dotlrn-portlet/tcl/dotlrn-members-portlet-procs.tcl: Add documentation * packages/dotlrn-portlet/tcl/dotlrn-members-staff-portlet-procs.tcl: Make api public * packages/xowiki/tcl/xowiki-utility-procs.tcl: Reinstate api as private, downstream cases need to be adapted 2021-02-24 trenner * packages/tsearch2-driver/tcl/tsearch2-driver-init.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl: * packages/tsearch2-driver/tsearch2-driver.info: Add PostgreSQL integrated websearch_to_tsquery builder, which can be activated via PackageParameter UseWebSearch 2021-02-24 hectorr * packages/dotlrn/tcl/spam-procs.tcl: * packages/dotlrn/www/admin/users-spam.tcl: Adapt spam variable name to what is advertised to the user * packages/dotlrn-portlet/tcl/test/dotlrn-portlet-procs.tcl: Add 'dotlrn_members_portlet::get_my_name' to the 'dotlrn_portlet_links_names_keys' test case * packages/new-portal/tcl/test/new-portal-test-procs.tcl: Add 'portal::exists_p' to 'create_portal_from_template' test case * packages/dotlrn/tcl/spam-procs.tcl: Replace spam::interpolate with 'string map' 2021-02-24 gustafn * packages/acs-messaging/acs-messaging.info: * packages/acs-messaging/sql/postgresql/acs-messaging-packages.sql: * packages/acs-messaging/sql/postgresql/upgrade/upgrade-5.10.0d1-5.10.0d2.sql: Avoid calling deprecated content_item__new/17, call content_item__new/21 instead * packages/tsearch2-driver/tcl/tsearch2-driver-init.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl: do not rely on xo::dc in packages not depending on xotcl-core * packages/general-comments/tcl/test/general-comments-procs.tcl: * packages/general-comments/www/file-add-2.tcl: improve spelling * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: * packages/acs-bootstrap-installer/tcl/20-db-bootstrap-procs.tcl: * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: reduce the size of the public interface 2021-02-24 antoniop * packages/assessment/tcl/as-item-procs.tcl: * packages/dotlrn-portlet/tcl/dotlrn-members-portlet-procs.tcl: * packages/new-portal/tcl/portal-procs.tcl: Make api public * packages/xowiki/tcl/xowiki-callback-procs.tcl: Make api public: downstream xowiki-like packages use it to extend uninstantiation logics * packages/dotlrn/tcl/community-procs.tcl: Make api public: uses public api internally and downstream packages use it * packages/xowiki/tcl/xowiki-utility-procs.tcl: Make proc public: many downstream packages use it e.g. in their upgrade scripts 2021-02-23 hectorr * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: Deprecate acs_mail_lite::message_interpolate in favor of 'string map' * packages/bulk-mail/tcl/bulk-mail-procs.tcl: Deprecate bulk_mail::interpolate in favor of 'string map' * packages/dotlrn/tcl/spam-procs.tcl: Deprecate spam::interpolate in favor of 'string map' 2021-02-23 gustafn * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: improve test coverage * packages/xotcl-core/tcl/05-db-procs.tcl: small performance improvement 2021-02-23 antoniop * packages/acs-tcl/tcl/install-procs.tcl: Do not invoke service contract implementations directly, use the public interface * packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl: Fix api: upstream dotlrn mounts dotlrn-forums at /dotlrn/forums/, but testcase dotlrn_forums__applet_portlet (dotlrn-forums) deletes such node and replaces it with a new one at /dotlrn/applets/forums/. As site_node::get_package_url does not get flushed, the API will expect to find the mounted instance at the old URL, which now resolves to the parent dotlrn instead! Fix this by not relying on the cache to retrieve the applet node id. * packages/acs-tcl/tcl/acs-permissions-procs.tcl: Flush also the threaded cache whenever we flush the permission cache, so that one does not need to call this private api directly * packages/acs-messaging/tcl/acs-messaging-procs-oracle.xql: * packages/acs-messaging/tcl/acs-messaging-procs-postgresql.xql: Formatting changes * packages/calendar-portlet/tcl/calendar-full-portlet-procs.tcl: * packages/calendar-portlet/tcl/calendar-list-portlet-procs.tcl: * packages/dotlrn-portlet/tcl/dotlrn-portlet-procs.tcl: Make api public as other packages might need to retrieve the portlet name * packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl: * packages/new-portal/tcl/portal-procs.tcl: Provide a cached public api, reinstate uncached api as private, replace occurrences * packages/general-comments/tcl/general-comments-procs.tcl: * packages/xowiki/tcl/xowiki-callback-procs.tcl: Provide a public general-comments solution to empty messages from a specific package: other xowiki-like packages downstream would otherwise need to call an xowiki private api * packages/acs-messaging/tcl/acs-messaging-procs-oracle.xql: * packages/acs-messaging/tcl/acs-messaging-procs-postgresql.xql: * packages/acs-messaging/tcl/acs-messaging-procs.tcl: Reduce divergency between oracle and postgres codebase * packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl: * packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl: * packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl: * packages/dotlrn/tcl/dotlrn-procs.tcl: Reinstate get_portal_id_not_cached as private, flush the cache before calling public api instead * packages/dotlrn-static/tcl/dotlrn-static-procs.tcl: * packages/dotlrn/tcl/community-procs.tcl: Reinstate get_portal_id_not_cached as private, replace occurrences with public api * packages/dotlrn/www/spam.xql: We cannot use bind variables here, as the query is not executed at this time, but later at bulk mail sweeping * packages/general-comments/tcl/general-comments-procs.tcl: Whitespace cleanup 2021-02-22 hectorr * packages/acs-tcl/tcl/test/text-html-procs.tcl: Make length greater than 0 in 'ad_pad' test case 2021-02-22 gustafn * packages/acs-content-repository/tcl/acs-content-repository-init-oracle.xql: * packages/acs-content-repository/tcl/acs-content-repository-init-postgresql.xql: * packages/acs-content-repository/tcl/acs-content-repository-init.tcl: * packages/acs-content-repository/tcl/acs-content-repository-procs-oracle.xql: * packages/acs-content-repository/tcl/acs-content-repository-procs-postgresql.xql: * packages/acs-content-repository/tcl/acs-content-repository-procs.tcl: * packages/acs-content-repository/tcl/content-item-procs.tcl: * packages/acs-content-repository/tcl/content-procs-postgresql.xql: * packages/acs-content-repository/tcl/content-procs.tcl: * packages/acs-content-repository/tcl/content-revision-procs-oracle.xql: * packages/acs-content-repository/tcl/content-revision-procs-postgresql.xql: * packages/acs-content-repository/tcl/content-revision-procs.tcl: * packages/acs-content-repository/tcl/deprecated-procs.tcl: * packages/acs-content-repository/tcl/revision-procs-oracle.xql: * packages/acs-content-repository/tcl/revision-procs-postgresql.xql: * packages/acs-content-repository/tcl/revision-procs.tcl: * packages/acs-content-repository/tcl/search-procs.tcl: Refactor content repository backend The refactored code is a first step to become able to provide plugins for backends for storing content in different systems. Instead of using switch statements to distinguish between backends "file", "lob" and "text", procs with a suffix of the storage name are provided now. Essentially, by providing process with additional suffixes can be used to provide additional storage systems. In addition, the deletion handling was also refactored such that the non-scalable functions iterating over all items (such as "cr_check_orphaned_files") will become obsolete. This is imporant for content repositories with double and triple digit terabytes. * packages/search/tcl/search-init.tcl: * packages/search/tcl/search-procs.tcl: avoid setting of unneeded function, reduce access to nsvs * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: * packages/acs-tcl/tcl/test/file-test-procs.tcl: make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages * packages/acs-tcl/tcl/apm-procs.tcl: * packages/search/tcl/search-init.tcl: provide a flushing interface to apm_package_id cache to avoid the need to call the uncached code directly * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: whitespace changes: break overlong lines 2021-02-22 antoniop * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: * packages/acs-authentication/tcl/local-procs.tcl: * packages/acs-authentication/tcl/test-authority-procs.tcl: * packages/acs-automated-testing/tcl/authority-procs.tcl: - Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK - Reinstate authentication service contracts as private - Move test authority implementation to acs-authentication to remove intra-package dependency acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued * packages/acs-mail-lite/tcl/acs-mail-lite-callback-procs.tcl: * packages/acs-mail-lite/tcl/legacy-inbound-procs.tcl: * packages/acs-tcl/tcl/ad-functional-procs.tcl: Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test * packages/new-portal/tcl/portal-procs.tcl: Make api public, complies with acs-api-browser.graph__bad_calls * packages/acs-authentication/tcl/authentication-procs.tcl: * packages/acs-authentication/tcl/local-procs.tcl: * packages/acs-bootstrap-installer/tcl/20-db-bootstrap-procs.tcl: * packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl: * packages/acs-content-repository/tcl/content-procs.tcl: * packages/acs-developer-support/tcl/acs-developer-support-procs.tcl: * packages/acs-lang/tcl/lang-message-procs.tcl: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/apm-file-procs.tcl: * packages/acs-tcl/tcl/apm-install-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/apm-xml-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/acs-templating/tcl/filter-procs.tcl: * packages/calendar-portlet/tcl/calendar-portlet-procs.tcl: * packages/dotlrn/tcl/community-procs.tcl: * packages/dotlrn/tcl/dotlrn-procs.tcl: * packages/new-portal/tcl/datasource-procs.tcl: * packages/rss-support/tcl/rss-generation-service-procs.tcl: Make api public, complies with acs-api-browser.graph__bad_calls automated test * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: Make proc public (it is used in a test is acs-tcl) Complies with acs-api-browser.callgraph__bad_calls * packages/acs-authentication/tcl/local-procs.tcl: Make service contract implementation public Complies with acs-api-browser.callgraph__bad_calls * packages/acs-datetime/tcl/acs-calendar-2-procs.tcl: Reinstate apis as public, as they hold the current definition of an all-day event * packages/acs-tcl/tcl/apm-procs.tcl: * packages/search/tcl/search-init.tcl: * packages/search/www/search.tcl: Reinstate proc as private, remove dependency to such proc in external package * packages/forums/tcl/forums-install-procs.tcl: * packages/forums/tcl/forums-sc-procs.tcl: Skip deprecated api that is neutralized by the next upgrade, reinstate deprecated api just for upgrade purposes, complies with acs-api-browser.graph__bad_calls automated test * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: * packages/acs-tcl/tcl/apm-xml-procs.tcl: * packages/dotlrn/tcl/dotlrn-procs.tcl: * packages/forums/tcl/forums-sc-procs.tcl: Whitespace cleanup 2021-02-19 hectorr * packages/assessment/tcl/test/as-assessment-procs.tcl: * packages/assessment/tcl/test/as-item-procs.tcl: Add proc names to the list of covered procs in assessment tests * packages/oacs-dav/tcl/test/oacs-dav-procs.tcl: Add proc names to the list of covered procs in oacs-dav tests * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: Fix extra brace * packages/assessment/tcl/test/as-assessment-procs.tcl: * packages/assessment/tcl/test/as-item-procs.tcl: * packages/oacs-dav/tcl/test/oacs-dav-procs.tcl: Whitespace changes 2021-02-19 gustafn * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: - fixed mis-classification of "max", "min" and "random" in "tclcode_to_html" - added new test case "callgraph__bad_calls" to check for a) calls to deprecated procs b) direct calls to private procs from other packages ("private" means "packakge private" * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: added "content_type" to the list of specially handled calls. this fixes two more cases in Test case callgraph__bad_calls * packages/oacs-dav/tcl/test/oacs-dav-procs.tcl: added more covered procs to the list of tested procs * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: include package key in proc info * packages/bm-portlet/tcl/bm-portlet-procs.tcl: moved helper proc "portlet_exists_p" from test cases to library * packages/calendar/tcl/cal-item-procs.tcl: * packages/calendar/tcl/test/calendar-procs.tcl: reduce verbosity, add covered calls in test cases * packages/acs-developer-support/tcl/acs-developer-support-procs.tcl: * packages/acs-lang/tcl/lang-message-procs.tcl: * packages/acs-tcl/tcl/apm-file-procs.tcl: * packages/acs-tcl/tcl/defs-procs.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-templating/tcl/parse-procs.tcl: * packages/xotcl-core/tcl/01-debug-procs.tcl: remove protection "private", since function has to be called from other packages * packages/xotcl-core/tcl/05-db-procs.tcl: replace call to deprecated function 2021-02-18 hectorr * packages/calendar/tcl/test/calendar-procs.tcl: Add 'calendar_basic_api' test case, covering 'calendar::new', 'calendar::delete', 'calendar::rename' and 'calendar::name' * packages/new-portal/tcl/test/new-portal-test-procs.tcl: Add covered procs to test case * packages/new-portal/tcl/test/new-portal-test-procs.tcl: Extend 'create_portal_from_template' test case to cover 'portal::delete', 'portal::page_delete', 'portal::page_count', 'portal::get_page_id', 'portal::get_page_pretty_name', 'portal::set_page_pretty_name' and 'portal::first_page_p' * packages/calendar/tcl/test/calendar-procs.tcl: Fix extra braces * packages/new-portal/tcl/test/new-portal-test-procs.tcl: Whitespace changes 2021-02-18 gustafn * packages/acs-lang/tcl/lang-message-procs.tcl: * packages/acs-lang/tcl/localization-procs.tcl: * packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl: bring test coverage to >50% by adding test cases and marking only locally called functions as private * packages/acs-tcl/tcl/test/site-nodes-test-procs.tcl: * packages/news/tcl/test/news-db-test-init.tcl: improve listing of test coverage * packages/acs-admin/tcl/acs-admin-procs.tcl: * packages/acs-automated-testing/tcl/aa-test-procs.tcl: * packages/acs-automated-testing/tcl/example-procs.tcl: * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: * packages/acs-core-docs/tcl/acs-core-docs-procs.tcl: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: * packages/acs-mail-lite/tcl/email-inbound-procs.tcl: * packages/acs-mail-lite/tcl/legacy-inbound-procs.tcl: * packages/acs-mail-lite/tcl/utils-procs.tcl: * packages/acs-messaging/tcl/acs-messaging-procs.tcl: * packages/acs-service-contract/tcl/contract-procs.tcl: * packages/acs-service-contract/tcl/msg-type-procs.tcl: * packages/acs-tcl/tcl/acs-kernel-procs.tcl: * packages/acs-tcl/tcl/form-processing-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/security-procs.tcl: mark functions called only internally as private * packages/acs-lang/tcl/lang-message-procs.tcl: mark unused function "_mr" as deprecated * packages/categories/www/cadmin/master.tcl: remove dependency on ad_ns_set_keys 2021-02-17 gustafn * packages/xowiki/tcl/form-field-procs.tcl: Fix correct-when test of empty input when constraint is "<" or "<=". Many thanks for Florian Mosböck for finding this. * packages/acs-tcl/tcl/sql-statement-procs.tcl: deprecate unused and untested code * packages/acs-tcl/tcl/sql-statement-procs.tcl: don't load deprecated code unless explicitly required * packages/acs-content-repository/tcl/deprecated-procs.tcl: fix deprecated function * packages/acs-tcl/tcl/security-procs.tcl: improve comment * packages/dotlrn/tcl/community-procs.tcl: * packages/survey/tcl/survey-procs.tcl: * packages/survey/www/admin/one.tcl: make clear that get_community_id_from_url needs connection in case no URL is provided; provide shortcut, when determined package_id is empty * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: make use of built-in reverse proxy mode of newer versions of NaviServer * packages/acs-tcl/tcl/apm-procs.tcl: mark functions as private * packages/acs-automated-testing/tcl/aa-test-procs.tcl: mark in log-file begin and end of test cases, support multiple msg arguments in aa_log (similar to ns_log) * packages/acs-tcl/tcl/text-html-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: mark unused functions as deprecated * packages/dotlrn/tcl/community-procs.tcl: overwork get_community_id once more. provide a shortcut is hopless situations, reduce potential warnings and improve comments * packages/acs-admin/tcl/apm-admin-procs.tcl: * packages/acs-subsite/tcl/plpgsql-utility-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/search/tcl/extra-args-procs.tcl: prefer ns_dbquotevalue over db_quote, mark latter as deprecated * packages/xowiki/tcl/import-procs.tcl: provide more details in log message * packages/acs-automated-testing/tcl/coverage-procs.tcl: reduce verbosity * packages/acs-tcl/lib/page-error.tcl: remove call to deprecated proc * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: removed leftover from debugging * packages/xotcl-request-monitor/www/index.tcl: use tcl "max" idiom 2021-02-16 trenner * packages/forums/tcl/form-procs.tcl: consider subject field restriction from the database also in the ui 2021-02-16 hectorr * packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl: Add default to avoid empty values. Fixes 'acs_mail_lite_inbound_procs_check' test case 2021-02-16 gustafn * packages/acs-admin/tcl/test/acs-admin-procs.tcl: * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: * packages/acs-authentication/tcl/test/sync-test-procs.tcl: * packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl: * packages/acs-content-repository/tcl/test/acs-content-repository-procs.tcl: * packages/acs-content-repository/tcl/test/content-image-test-procs.tcl: * packages/acs-content-repository/tcl/test/content-item-test-procs.tcl: * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: * packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl: * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: * packages/acs-tcl/tcl/test/html-conversion-procs.tcl: * packages/categories/tcl/test/categories-procs.tcl: * packages/file-storage/tcl/test/file-storage-procs.tcl: * packages/forums/tcl/test/forums-procs.tcl: * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: * packages/xotcl-core/tcl/test/xotcl-test-procs.tcl: * packages/xowf/tcl/test/xowf-test-procs.tcl: * packages/xowiki/tcl/test/api-test-procs.tcl: * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: * packages/xowiki/tcl/test/xowiki-link-test-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: improve listing of test coverage * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: * packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl: just avoid tilde substitution, do not perform sanitizing sanitizing can lead to filename clashes in case the names without tilde exists, and they are OS specific. The intention of "ad_file" is just to be a tilde-proof "file" replacement * packages/acs-tcl/tcl/test/file-test-procs.tcl: reduce verbosity * packages/acs-lang/tcl/locale-procs.tcl: use per_thread_cache for flushing rather than raw variables 2021-02-15 hectorr * packages/calendar-portlet/calendar-portlet.info: * packages/calendar-portlet/tcl/apm-callback-procs.tcl: * packages/calendar-portlet/tcl/apm-callback-procs.xql: Adjust naming to openacs conventions. Fixes 'naming__proc_naming' test case. * packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl: Make 'ad_file' test case deterministic * packages/calendar-portlet/calendar-portlet.info: * packages/calendar-portlet/tcl/apm-callback-procs.tcl: Whitespace changes 2021-02-15 gustafn * packages/acs-admin/tcl/test/acs-admin-procs.tcl: * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: * packages/acs-authentication/tcl/test/sync-test-procs.tcl: * packages/acs-content-repository/tcl/test/content-extlink-procs.tcl: * packages/acs-content-repository/tcl/test/content-search-procs.tcl: * packages/acs-datetime/tcl/test/acs-datetime-procs.tcl: * packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl: * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: * packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl: * packages/acs-tcl/tcl/test/application-data-link-procs.tcl: * packages/acs-tcl/tcl/test/community-core-test-procs.tcl: * packages/acs-tcl/tcl/test/datamodel-test-procs.tcl: * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: * packages/acs-tcl/tcl/test/doc-check-procs.tcl: * packages/acs-tcl/tcl/test/file-test-procs.tcl: * packages/acs-tcl/tcl/test/http-client-procs.tcl: * packages/acs-tcl/tcl/test/navigation-procs.tcl: * packages/acs-tcl/tcl/test/object-test-case-procs.tcl: * packages/acs-tcl/tcl/test/security-procs.tcl: * packages/acs-tcl/tcl/test/site-nodes-test-procs.tcl: * packages/acs-tcl/tcl/test/test-membership-rel-procs.tcl: * packages/acs-tcl/tcl/test/test-permissions-procs.tcl: * packages/acs-templating/tcl/test/date-procs.tcl: make listing of tested procs more complete 2021-02-15 antoniop * packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl: Automated test for ad_file exposing a blind spot with files starting with the '~' character * packages/file-storage/www/folder-zip-add.tcl: Do not allow backslashes in folders created via zipfile upload As the folder name is used also for looking up for existing folders, the safest approach is to block the user: the risk with an automatic sanitization would be to overwrite existing folders without the user realizing * packages/file-storage/www/folder-zip-add.tcl: Fix typo * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: Sanitize all trailing tildes from the filename, mapping them to the current folder Fixes acs-bootstrap-installer.ad_file automated test 2021-02-14 gustafn * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: * packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl: * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: * packages/forums/www/message-view.tcl: * packages/news/tcl/test/news-db-test-init.tcl: improve spelling * packages/xowiki/tcl/package-procs.tcl: improve warning message * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/test/doc-check-procs.tcl: make code slightly more regular * packages/acs-automated-testing/tcl/aa-test-procs.tcl: * packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl: * packages/acs-automated-testing/www/admin/testcase.tcl: * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: * packages/acs-templating/tcl/test/spell-checker-procs.tcl: * packages/file-storage/tcl/test/file-storage-procs.tcl: * packages/xotcl-core/tcl/test/xotcl-test-procs.tcl: * packages/xowf/tcl/test/xowf-test-procs.tcl: * packages/xowiki/tcl/test/api-test-procs.tcl: * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: * packages/xowiki/tcl/test/xowiki-link-test-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: make listing of tested procs more complete * packages/new-portal/new-portal.info: * packages/new-portal/tcl/apm-callback-procs.tcl: * packages/new-portal/tcl/apm-callback-procs.xql: no need to use extra namespace for callback * packages/xowiki/tcl/xowiki-www-procs.tcl: provide better error message * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/06-package-procs.tcl: provide warning about deprecated location * packages/acs-tcl/tcl/community-core-procs.tcl: * packages/xotcl-core/tcl/03-doc-procs.tcl: * packages/xotcl-core/tcl/xotcl-init.tcl: reduce verbosity * packages/acs-authentication/tcl/authentication-procs-naviserver.tcl: set default value only in case of failure * packages/xowiki/tcl/xowiki-form-procs.tcl: use ad_proc -private * packages/acs-authentication/tcl/authentication-procs.tcl: whitespace changes 2021-02-13 gustafn * packages/acs-tcl/tcl/community-core-procs.tcl: 2 new API functions acs_user::promote_person_to_user and acs_user::demote_user (see issue #3461) acs_user::promote_person_to_user Promotes a person/party to an ACS user. @param person_id the person_id in the acs system that should be promoted to a user. @param username the username to be used for this user. Defaults to the person's email @param password the password to be used for this user. Defaults to a randomly generated password. @param authority_id the authority that will be used for the user. @param locale locale to be used in user preferences. Defaults to the site wide locale is taken. @return The user_id of the person promoted to user @error An error is thrown if the username is already in use, or the person_id has no email address, or if person_id is not in the persons table. acs_user::demote_user Demotes an ACS user to a person/party. This will fail if other tables have content referencing the users table. It is probably best for tables created in other packages to reference persons, parties, or acs_objects instead. This proc could be extended with an option to find all referenced tables and remove rows referencing this user. See the following FK relationship in basic OpenACS installations: TABLE "acs_objects" CONSTRAINT "acs_objects_creation_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id) TABLE "acs_objects" CONSTRAINT "acs_objects_modifying_user_fk" FOREIGN KEY (modifying_user) REFERENCES users(user_id) TABLE "ad_locale_user_prefs" CONSTRAINT "ad_locale_user_prefs_users_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE TABLE "auth_batch_job_entries" CONSTRAINT "auth_batch_job_entries_user_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE SET NULL TABLE "auth_batch_jobs" CONSTRAINT "auth_batch_jobs_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id) ON DELETE SET NULL TABLE "cr_news" CONSTRAINT "cr_news_approval_user_fk" FOREIGN KEY (approval_user) REFERENCES users(user_id) TABLE "email_images" CONSTRAINT "email_images_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) TABLE "forums_messages" CONSTRAINT "forums_mess_last_poster_fk" FOREIGN KEY (last_poster) REFERENCES users(user_id) TABLE "forums_messages" CONSTRAINT "forums_mess_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) TABLE "forums_reading_info" CONSTRAINT "forums_read_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) TABLE "lang_messages_audit" CONSTRAINT "lang_messages_audit_ou_fk" FOREIGN KEY (overwrite_user) REFERENCES users(user_id) TABLE "lang_messages" CONSTRAINT "lang_messages_creation_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id) TABLE "lang_user_timezone" CONSTRAINT "lang_user_timezone_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE TABLE "notification_replies" CONSTRAINT "notif_repl_from_fk" FOREIGN KEY (from_user) REFERENCES users(user_id) TABLE "notification_user_map" CONSTRAINT "notif_user_map_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE TABLE "notifications" CONSTRAINT "notifications_notif_user_fk" FOREIGN KEY (notif_user) REFERENCES users(user_id) TABLE "notification_requests" CONSTRAINT "notifications_request_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE TABLE "proctoring_examination_statement_acceptance" CONSTRAINT "proctoring_examination_statement_acceptance_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE TABLE "user_portraits" CONSTRAINT "user_portraits_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) TABLE "user_preferences" CONSTRAINT "user_preferences_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) TABLE "xowiki_tags" CONSTRAINT "xowiki_tags_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(user_id) * packages/acs-tcl/tcl/community-core-procs.tcl: remove race condition from user/person/party cache management 2021-02-12 antoniop * packages/assessment/www/asm-admin/item-add.tcl: * packages/assessment/www/asm-admin/item-edit-general.tcl: Fix https://openacs.org/bugtracker/openacs/bug?bug_number=3454, many thanks to Maurizio Martignano 2021-02-11 hectorr * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: Fix tested proc name. ::xo::db::Class get_instance_from_db is defined using ad_proc instead of instproc. Fixes the acs_api_browser_api_get_body test case. 2021-02-11 antoniop * packages/xowiki/tcl/xowiki-init.tcl: Creating the site wide xowiki instance cannot half fail, as it might leave the subsite in an inconsistent state Fixes acs-admin.acs_admin_require_site_wide automated test * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: Fix typo 2021-02-10 antoniop * packages/bulk-mail/tcl/bulk-mail-procs.tcl: Cast both value and default value * packages/bulk-mail/bulk-mail.info: * packages/bulk-mail/sql/oracle/bulk-mail-create.sql: * packages/bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d2-2.10.0d3.sql: * packages/bulk-mail/sql/postgresql/bulk-mail-create.sql: * packages/bulk-mail/sql/postgresql/upgrade/upgrade-2.10.0d2-2.10.0d3.sql: * packages/bulk-mail/tcl/bulk-mail-procs.tcl: Introduce a new 'to_display_name' column enabling to specify a display name with which qualify recipients of a bulk mail as e.g. "Members of Group 1" This is useful to inform the user about who else should be expected to have received the same communication * packages/bulk-mail/tcl/bulk-mail-procs.tcl: Make sure recipient is enclosed in a list to avoid ambiguity with values containing spaces * packages/bulk-mail/tcl/bulk-mail-procs-oracle.xql: * packages/bulk-mail/tcl/bulk-mail-procs-postgresql.xql: * packages/bulk-mail/tcl/bulk-mail-procs.tcl: * packages/bulk-mail/tcl/bulk-mail-procs.xql: Move a bit away from the heavyweight stored-procedure-based standard to schedule bulk_mails, in preparation to accommodate for new metadata 2021-02-09 gustafn * packages/xowf/tcl/test-item-procs.tcl: add "btwn" to precise correct-when specs * packages/xowf/tcl/test-item-procs.tcl: deactivate autocorrection for short_text questions, when correct when is not precise * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: form-field "range": added optional output text box for displaying the actual value * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/prototypes/select_question.form.page: * packages/xowf/xowf.info: inclass-exam: Added configurability for time budget and display of minutes and/or points during exam 2021-02-09 antoniop * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: Handle to_addr specified as "DisplayName ": keep the display name in the header value and strip it in the RCPT TO 2021-02-08 hectorr * packages/dotlrn/tcl/community-procs.tcl: Fix log message, as ad_log supports only one message as argument. 2021-02-08 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: support multiple argument messages for ad_log to improve compatibility with ns_log 2021-02-08 antoniop * packages/forums/www/mark-all-read-oracle.xql: * packages/forums/www/mark-all-read-postgresql.xql: * packages/forums/www/mark-all-read.tcl: Reduce divergency between Oracle and Postgres codebase 2021-02-07 gustafn * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: * packages/xotcl-core/tcl/test/xotcl-test-procs.tcl: extend test coverage * packages/xowf/tcl/test/xowf-test-procs.tcl: * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: improve listing of tested procs * packages/acs-automated-testing/tcl/aa-test-procs.tcl: improve spelling * packages/acs-automated-testing/tcl/coverage-procs.tcl: remove objects and class objects and auto-generated code form coverage statistics * packages/xotcl-core/tcl/cr-procs.tcl: whitespace changes 2021-02-06 gustafn * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: address issue #3460 * packages/acs-tcl/tcl/acs-permissions-procs.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: avoid array notation for per_thread caches to ease flushing 2021-02-05 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: follow naming convention as used in other places as well start key with the package name, use array notation * packages/xowiki/tcl/xowiki-www-procs.tcl: no need to use volatile, since these pages are marked for cleanup in some combinations of tcl and nsf, these volatile operations might lead to crashes * packages/xowiki/tcl/form-field-procs.tcl: overhaul of formfield of type numeric - use connection locale for localization per default - accept always numbers in en_US - support keeping optional the original user string (good for exams) - use this new combination in textfields numeric type. 2021-02-04 gustafn * packages/dotlrn/tcl/community-procs.tcl: Add "-url" as optional argument to "get_community_id" to ease usage in non-connection threads. in background threads, get_community_id can be called with either the package_id, or with the argument. Otherwise, the function is not background-safe * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: added new form-field type: comp_correct_when added conjunctive answer-check adde answer-check "contains-not" The new form-field type offers a graphical user interface for input of correct when clauses. When comp_correct_when is used with the repeat flag it produces conjunctive (AND connected) clauses. The answer-check "contains-not" is more or less the same a "contains", but highlights such words in red. bump version number to 5.10.0d71 * packages/xowf/tcl/test-item-procs.tcl: added support for composite correct-when for text_interaction * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/form-generator.css: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: added support for gui and multiple correct-when clauses bump version number to 5.10.0d32 * packages/acs-templating/tcl/wizard-procs.tcl: * packages/new-portal/tcl/portal-procs.tcl: improve spelling * packages/acs-admin/tcl/apm-admin-procs.tcl: in newer versions of tar, the option "-C" is position dependent * packages/xowiki/tcl/form-field-procs.tcl: reduce verbosity, add statements to ease debugging 2021-02-03 gustafn * packages/xotcl-core/tcl/30-widget-procs.tcl: handle bulk-actions and hidden-fields in cvs exports * packages/xowiki/tcl/xowiki-procs.tcl: use "ad_try" instead of plain "try" in include_content 2021-02-02 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: allow action exam_review only when autocorrect is possible * packages/acs-tcl/tcl/ad-functional-procs.tcl: mark f::reverse as deprecated. There is no evident reason, why not the built-in "lreverse" is used * packages/xowf/tcl/test-item-procs.tcl: revert escaped development version 2021-02-01 trenner * packages/xowiki/tcl/form-field-procs.tcl: fix typo: list element '1' is the upper limit * packages/xowiki/tcl/form-field-procs.tcl: mark end of switches to improve robustness, to support '-' in word variable 2021-02-01 gustafn * packages/dotlrn/tcl/community-procs.tcl: * packages/dotlrn/www/community-edit-2.tcl: * packages/dotlrn/www/dotlrn-master-kelp.tcl: * packages/dotlrn/www/dotlrn-master.tcl: * packages/dotlrn/www/subcommunity-new.tcl: improve spelling * packages/acs-admin/tcl/test/acs-admin-procs.tcl: * packages/acs-admin/www/users/user-batch-add-2.tcl: * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: * packages/acs-content-repository/tcl/content-item-procs.tcl: * packages/acs-content-repository/tcl/doc-procs.tcl: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: * packages/acs-mail-lite/tcl/utils-procs.tcl: * packages/acs-subsite/tcl/group-procs.tcl: * packages/acs-subsite/tcl/plsql-utility-procs.tcl: * packages/acs-subsite/tcl/subsite-procs.tcl: * packages/acs-subsite/www/admin/themes/view.tcl: * packages/acs-subsite/www/members/user-batch-add-2.tcl: * packages/acs-subsite/www/permissions/grant.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/adp-parser-procs.tcl: * packages/acs-tcl/tcl/apm-install-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/deprecated-procs.tcl: * packages/acs-tcl/tcl/html-procs.tcl: * packages/acs-tcl/tcl/install-procs.tcl: * packages/acs-tcl/tcl/json-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/stack-trace-procs.tcl: * packages/acs-tcl/tcl/tcltrace-procs.tcl: * packages/acs-tcl/tcl/test/doc-check-procs.tcl: * packages/acs-tcl/tcl/test/http-client-procs.tcl: * packages/acs-tcl/tcl/text-html-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/acs-tcl/tcl/xml-0-sgml-procs.tcl: * packages/acs-tcl/tcl/xml-1-dom-procs.tcl: * packages/acs-tcl/tcl/xml-2-procs.tcl: * packages/acs-templating/tcl/acs-integration-procs.tcl: * packages/acs-templating/tcl/date-procs.tcl: * packages/acs-templating/tcl/deprecated-procs.tcl: * packages/acs-templating/tcl/doc-procs.tcl: * packages/acs-templating/tcl/doc-tcl-procs.tcl: * packages/acs-templating/tcl/file-procs.tcl: * packages/acs-templating/tcl/form-procs.tcl: * packages/acs-templating/tcl/list-procs.tcl: * packages/acs-templating/tcl/parse-procs.tcl: * packages/acs-templating/tcl/request-procs.tcl: * packages/acs-templating/tcl/spellcheck-procs.tcl: * packages/acs-templating/tcl/table-procs.tcl: * packages/acs-templating/tcl/tag-init.tcl: * packages/acs-templating/tcl/wizard-procs.tcl: * packages/acs-templating/www/admin/test/include.tcl: * packages/acs-templating/www/resources/xinha-nightly/plugins/OacsFs/popups/file-selector.tcl: * packages/acs-templating/www/scripts/xinha/attach-file.tcl: * packages/acs-templating/www/scripts/xinha/file-selector.tcl: * packages/dotlrn/tcl/navigation-procs.tcl: * packages/dotlrn/tcl/spam-procs.tcl: * packages/dotlrn/www/manage-memberships.tcl: * packages/file-storage/lib/folder-links.tcl: * packages/file-storage/tcl/file-storage-procs.tcl: * packages/file-storage/www/index.tcl: * packages/file-storage/www/search.tcl: * packages/forums/lib/search/search-chunk.tcl: * packages/forums/tcl/forums-callback-procs.tcl: * packages/forums/tcl/messages-procs.tcl: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/www/long-calls.tcl: make end of options explicit * packages/xotcl-core/tcl/03-doc-procs.tcl: * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/30-widget-procs.tcl: * packages/xotcl-core/tcl/ical-procs.tcl: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/menu-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/tree-procs.tcl: * packages/xowiki/tcl/xowiki-form-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/www/xinha/file-selector.tcl: make end of resub options explicit 2021-01-29 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: util_return_headers: align the behavior under AOLserver with NaviServer * packages/acs-tcl/tcl/utilities-procs.tcl: util_return_headers: set default charset for text content (in case none is specified and none is set in the config file) to utf-8 (was iso-8850-1) 2021-01-28 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/xowiki.info: cache failed name lookups in a per-request cache (flushing maybe overly conservative) 2021-01-27 gustafn * packages/acs-tcl/tcl/acs-cache-procs.tcl: added method "get" for "LockfreeCache" (somewhat similar to nsv_get) * packages/acs-tcl/acs-tcl.info: bump version number 2021-01-27 antoniop * packages/xowf/tcl/test-item-procs.tcl: Add basic doc, fixes acs-tcl.documentation__check_proc_doc automated test 2021-01-26 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: add unmapping of slow-pool request for requests mapped via scheduled procedures 2021-01-25 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: undo slow-pool mapping after some time (default 12h) 2021-01-25 antoniop * packages/acs-tcl/tcl/test/security-procs.tcl: Hack to force user agents logging in via the test api to exhibit a cookie based authentication 2021-01-24 gustafn * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/cr-procs.tcl: Added support for row-level lock modes of PostgreSQL; used in "save" method of cr-items This change is necessary to avoid potential dead-locks in concurrent "save" operations * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: improve spelling 2021-01-22 gustafn * packages/acs-tcl/tcl/security-procs.tcl: make call more robust in case "location" is not provided via config file 2021-01-20 antoniop * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Add message keys, they are meant for use in downstream UI * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Add missing message key * packages/proctoring-support/sql/postgresql/upgrade-1.3.1-1.4.1.sql: Add missing upgrade script * packages/proctoring-support/proctoring-support.info: * packages/proctoring-support/sql/postgresql/proctoring-support-create.sql: * packages/proctoring-support/sql/postgresql/upgrade-1.2.3-1.3.1.sql: * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Extend the proctoring configuration datamodel to store and manage also information about whether we want to record combination of camera and desktop * packages/proctoring-support/proctoring-support.info: * packages/proctoring-support/sql/postgresql/proctoring-support-create.sql: * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Handle as well the already existing possibility that audio is not recorded 2021-01-19 gustafn * packages/acs-subsite/tcl/subsite-procs.tcl: address issue #3456 * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: make comment more precise 2021-01-19 antoniop * packages/calendar/sql/postgresql/upgrade/upgrade-2.10.0d6-2.10.0d7.sql: Add a precautional "if not exists" 2021-01-18 trenner * packages/xowf/lib/inclass-exam-answer.wf: fix typo 2021-01-18 gustafn * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/www/resources/xowiki-bootstrap3-specific.css: * packages/xowiki/www/resources/xowiki.css: Improved styling of delete buttons Added code to configure file-upload button (for now deactivated) * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/form-generator.css: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: Updates for upload_interaction: - allow lecturer to specify number of file, which can be uploaded - handle singular/plural labels for attachment/attachments - handle singular/plural labels for Students submitting files - styling improvements - bump version number to get as well message catalog updates from xowiki * packages/xowiki/xowiki.info: bump version number to force update of message catalog * packages/acs-subsite/tcl/subsite-procs.tcl: fix for issue #3455 * packages/acs-subsite/tcl/subsite-procs.tcl: fix typos * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/repeat-procs.tcl: form-field repeat: make "add another" label configurable per form-field type * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: * packages/xowiki/tcl/tree-procs.tcl: * packages/xowiki/tcl/xowiki-form-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: improve spelling * packages/xowiki/tcl/xowiki-www-procs.tcl: improve spelling and comments 2021-01-18 antoniop * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: New test to enforce that catalog files are valid XML 2021-01-17 gustafn * packages/acs-admin/www/users/one.adp: * packages/acs-admin/www/users/one.tcl: Let admin manage notifications of a user Otherwise, we have currently no user-interface to e.g. unsubscribe the notifications of a user to avoid sending mails to a domain (which might be in user by some other organization). * packages/notifications/www/manage.adp: * packages/notifications/www/manage.tcl: make clear from the user-interface that admin is managing the notifications of someone else 2021-01-15 gustafn * packages/xowf/lib/inclass-exam-answer.wf: Improve handling of cases, where the exam was closed, but some exam-takers have not submitted their results. Essentially this change avoids an error message and repeated messages, which might come form autosaving or other ajax calls. * packages/acs-tcl/tcl/test/00-icanuse-procs.tcl: provide compatibility for Tcl versions before tcl 8.6.2 2021-01-14 hectorr * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Fix proc name 2021-01-14 gustafn * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/test/00-icanuse-procs.tcl: Revert to previous strategy of determining available subcommands. Running the provided subcommand is dangerous, since the command might have side effects, might require connections, etc. The feature test for "ns_http run" was incorrect, since it was not introduced with 4.99.15 (as the comment suggested), but already with 4.99.4 (2017)... but at this time, the command did not return a dict, which is assumed in the http-client procs. One can use "ns_http stats" as an indicator for this feature, which was introduced at the time when "ns_http run" was starting to return dicts as results. Provide a more precise name for the feature test of ns_http returning dicts (naming the feature simply "ns_http" is not a good idea, since the command could of course be used already before the feature change). * packages/acs-tcl/tcl/security-init.tcl: don't create a cache, which is not needed * packages/acs-tcl/tcl/security-procs.tcl: use 'self' for "security::csp::require object-src" instead of 'none' since the latter is non-incremental 2021-01-14 antoniop * packages/acs-tcl/tcl/00-icanuse-procs.tcl: Change the regexp so that we catch multiple kinds of error pattern indicating the subcommand does not exist: NaviServer and Tcl return slightly different error messages * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead * packages/acs-tcl/tcl/test/00-icanuse-procs.tcl: Extend test to expose that we need a better idiom to detect also NaviServer commands * packages/acs-tcl/tcl/test/00-icanuse-procs.tcl: Fix wording * packages/acs-tcl/tcl/test/00-icanuse-procs.tcl: New test for acs::cmd_has_subcommand exposing how flags at the beginning and end of the error message are not properly recognized * packages/acs-tcl/tcl/00-icanuse-procs.tcl: Use a different idiom to detect if a command supports a subcommand, fixing acs-tcl.acs__command_has_subcommand automated test 2021-01-13 trenner * packages/xowf/tcl/test-item-procs.tcl: add the original filename to the generated url, so that it is also delivered to the user 2021-01-13 hectorr * packages/acs-tcl/tcl/apm-file-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: Fix webserver version check using 'apm_version_names_compare' for rc versions. Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest. As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future. 2021-01-13 gustafn * packages/xowiki/tcl/includelet-procs.tcl: ensure that the minimal set of controls is provided, also, when there are hidden form fields * packages/xowiki/tcl/form-field-procs.tcl: improve spelling * packages/xowf/tcl/test-item-procs.tcl: since the form-field "file" supports the file multiple attribute, the internal representation is as well a list. this change takes now as file-name for the local renderer as well the first filename list element. 2021-01-13 antoniop * packages/acs-tcl/tcl/http-client-procs.tcl: Avoid markup in documentation * packages/acs-tcl/tcl/http-client-procs.tcl: Doc formatting changes * packages/acs-tcl/tcl/http-client-procs.tcl: Fix version check * packages/acs-tcl/tcl/http-client-procs.tcl: Keep supporting the previous proc signature, throwing a warning * packages/acs-tcl/tcl/http-client-procs.tcl: Reduce people expectations * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/test/http-client-procs.tcl: Tear down a lot of boilerplate used to support native HTTP API on Naviserver versions < 4.99.15, which will now fallback to curl * packages/acs-tcl/tcl/apm-file-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: util::http should provide enough fallback via curl already without targeting specific Naviserver versions, use other fallbacks only when no implementation is available 2021-01-12 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: improve documentation 2021-01-12 antoniop * packages/acs-tcl/tcl/security-procs.tcl: Fix acs-tcl.logout_from_everywhere test case and support again invalidating of all existing user logins, useful e.g. to make sure no device still holds a valid login when we change our password on a device * packages/acs-tcl/tcl/test/security-procs.tcl: Test the use case supposedly supported by sec_change_user_auth_token: invalidate all existing login cookies (e.g. when the users change their password) so that all devices need to log in again the test exposes a long standing regression (~17 years) where this was broken in order to support persistent login. See e.g. https://openacs.org/forums/message-view?message_id=1691183#ms g_1691183 2021-01-11 trenner * packages/xowf/lib/inclass-exam.wf: use proper user_id 2021-01-11 gustafn * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-procs.tcl: Added text-attachment Ny using text-attachments, a lecturer can attach files to the exercise text for the student to download when solving the exercise. * packages/xowiki/tcl/xowiki-www-procs.tcl: improved comments 2021-01-08 gustafn * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: change tcl arrays into dicts * packages/xowf/lib/inclass-exam-answer.wf: enable question-form resolving again. * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: provide export interface 2021-01-07 gustafn * packages/xowiki/tcl/form-field-procs.tcl: break overlong lines * packages/xowf/lib/inclass-exam-answer.wf: improve comment 2021-01-05 gustafn * packages/openacs-bootstrap3-theme/resources/templates/packages/acs-admin/www/apm/repository-channel-index.adp: Include download link for .apm files * packages/acs-kernel/sql/postgresql/groups-create.sql: * packages/acs-kernel/sql/postgresql/test/rel-segments-test-types-create.sql: * packages/acs-subsite/sql/postgresql/user-profiles-create.sql: * packages/dotlrn/sql/postgresql/class-memberships-create.sql: * packages/dotlrn/sql/postgresql/upgrade/upgrade-2.0a3-2.0.2.sql: add explicit cast to all max_n_rels with value null to increase readability and to ease function disambiguation * packages/xotcl-core/tcl/01-debug-procs.tcl: fix spelling * packages/acs-core-docs/www/apm-design.adp: * packages/acs-core-docs/www/apm-requirements.adp: * packages/acs-core-docs/www/configuring-new-site.adp: * packages/acs-core-docs/www/eng-standards-versioning.adp: * packages/acs-core-docs/www/ext-auth-requirements.adp: * packages/acs-core-docs/www/groups-requirements.adp: * packages/acs-core-docs/www/i18n-introduction.adp: * packages/acs-core-docs/www/i18n-requirements.adp: * packages/acs-core-docs/www/individual-programs.adp: * packages/acs-core-docs/www/install-ldap-radius.adp: * packages/acs-core-docs/www/install-next-add-server.adp: * packages/acs-core-docs/www/install-openacs-inittab.adp: * packages/acs-core-docs/www/install-php.adp: * packages/acs-core-docs/www/install-qmail.adp: * packages/acs-core-docs/www/install-redhat.adp: * packages/acs-core-docs/www/maint-performance.adp: * packages/acs-core-docs/www/maintenance-deploy.adp: * packages/acs-core-docs/www/object-system-design.adp: * packages/acs-core-docs/www/openacs.adp: * packages/acs-core-docs/www/oracle.adp: * packages/acs-core-docs/www/packages.adp: * packages/acs-core-docs/www/packages.html: * packages/acs-core-docs/www/parties.adp: * packages/acs-core-docs/www/permissions-design.adp: * packages/acs-core-docs/www/permissions.adp: * packages/acs-core-docs/www/permissions.html: * packages/acs-core-docs/www/release-notes.adp: * packages/acs-core-docs/www/requirements-template.adp: * packages/acs-core-docs/www/rp-design.adp: * packages/acs-core-docs/www/security-design.adp: * packages/acs-core-docs/www/security-notes.adp: * packages/acs-core-docs/www/snapshot-backup.adp: * packages/acs-core-docs/www/style-guide.adp: * packages/acs-core-docs/www/subsites.adp: * packages/acs-core-docs/www/tutorial-admin-pages.adp: * packages/acs-core-docs/www/tutorial-categories.adp: * packages/acs-core-docs/www/tutorial-database.adp: * packages/acs-core-docs/www/tutorial-debug.adp: * packages/acs-core-docs/www/tutorial-notifications.adp: * packages/acs-core-docs/www/unit-testing-guide/index.adp: * packages/acs-core-docs/www/update-translations.adp: * packages/acs-core-docs/www/upgrade-4.5-to-4.6.adp: * packages/acs-core-docs/www/upgrade-4.6.3-to-5.adp: * packages/acs-core-docs/www/upgrade-5-0-dot.adp: * packages/acs-core-docs/www/upgrade-openacs-files.adp: * packages/acs-core-docs/www/xml/developers-guide/packages.xml: * packages/acs-core-docs/www/xml/developers-guide/permissions.xml: improve documentation (follow LDP guidelines) * packages/acs-admin/www/auth/login-attempts.tcl: improve line-breaks * packages/xotcl-core/tcl/30-widget-procs.tcl: improve robustness of table sort links, when called without connection * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/context-procs.tcl: improve spelling * packages/acs-mail-lite/www/doc/imap-install.adp: * packages/acs-tcl/lib/check-installed.adp: * packages/acs-tcl/tcl/memoize-procs-naviserver.tcl: * packages/acs-tcl/tcl/parameter-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/xml-1-dom-procs.tcl: * packages/acs-templating/www/doc/TclDocs/publish.adp: * packages/acs-templating/www/doc/appendices/memory.adp: * packages/acs-templating/www/doc/developer-guide.adp: * packages/acs-templating/www/doc/exercise/ats-for-designers.adp: * packages/acs-templating/www/doc/exercise/slave-sample-3.adp: * packages/acs-templating/www/doc/guide/composite.adp: * packages/acs-templating/www/doc/guide/search.adp: * packages/acs-templating/www/doc/guide/tcl.adp: * packages/acs-templating/www/doc/guide/wizard-procs-doc.adp: * packages/acs-templating/www/doc/no-quote-upgrade.adp: improve spelling (follow LDP) * packages/acs-admin/tcl/apm-admin-procs.tcl: show HEAD branch and oacs-5-10 development branch 2021-01-01 gustafn * packages/xowf/tcl/xowf-procs.tcl: fix typo 2020-12-27 gustafn * packages/xowf/lib/inclass-exam-answer.wf: Undo change from 15 Dec, since it breaks shuffling 2020-12-26 gustafn * packages/acs-tcl/tcl/security-procs.tcl: "ns_driver info" has no key "host", but "address" (which might be multiple addresses) * packages/acs-tcl/tcl/security-procs.tcl: Don't rely on configured "location" value of driver, since this does not work for virtual hosting Instead, get the "host", "port" and "defaultport" directly from "ns_driver info" when available * packages/acs-tcl/tcl/memoize-procs-naviserver.tcl: * packages/acs-tcl/tcl/test/memoizing-procs.tcl: fix for issue #3448 * packages/acs-tcl/tcl/memoize-procs-naviserver.tcl: perform a more sane test to check, whether the util_memoize cache was created already * packages/acs-tcl/tcl/test/utilities-procs.tcl: the Linux Documentation Project recommends to write "lowercase" as a single word 2020-12-18 trenner * packages/xowf/lib/edit-interaction.wf: ensure workflow actions are updated properly, depending on the user role 2020-12-18 gustafn * packages/xowiki/tcl/xowiki-form-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: fix propagation of validate results in old-style (ad_form-based) forms. One should really switch to FormPages soon. * packages/xotcl-core/tcl/context-procs.tcl: * packages/xotcl-core/tcl/generic-procs.tcl: improve comments * packages/xowiki/tcl/xowiki-procs.tcl: stylistic changes 2020-12-16 gustafn * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: * packages/richtext-ckeditor4/www/sitewide-admin/index.adp: * packages/richtext-ckeditor4/www/sitewide-admin/index.tcl: adding support for downloading different packages per ckeditor version * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: stick to standard package as default (as we had over many years) 2020-12-16 antoniop * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: Add missing parameter in doc * packages/acs-lang/tcl/lang-message-procs.tcl: Define arguments so that documentation__check_parameters automated test does find -varname flag correctly * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Exclude deprecated procs from the test * packages/acs-admin/tcl/site-wide-procs.tcl: Fix typo in proc doc 2020-12-15 hectorr * packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl: Fix priority check in 'acs_mail_lite_inbound_procs_check' test case * packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl: Fix typos 2020-12-15 gustafn * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/xowiki.info: Improved handling of link and child resources of forms - test-item-procs: use resolve context to resolve e.g. images in the context of the original form (many thanks to Thomas Renner for the suggestion) - added extra argument "-context_obj" to substitute_markup to ease client code - inclass-exam-answer.wf: reduced the db interactions by using form_info for form generation * packages/xowf/lib/inclass-exam.wf: * packages/xowf/lib/inclass-quiz.wf: moved span inside button (as suggested by Monika Andergassen) * packages/xowiki/tcl/form-field-procs.tcl: remove empty descriptions from display, remove deactivated CSS class. * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: warn about unexpected entries (typos) in EmailDeliveryMode 2020-12-14 antoniop * packages/acs-mail-lite/acs-mail-lite.info: * packages/acs-mail-lite/sql/postgresql/acs-mail-lite-create.sql: * packages/acs-mail-lite/sql/postgresql/upgrade/upgrade-5.10.0d11-5.10.0d12.sql: Index acs_mail_lite_queue(package_id) * packages/calendar/calendar.info: * packages/calendar/sql/postgresql/cal-item-create.sql: * packages/calendar/sql/postgresql/upgrade/upgrade-2.10.0d7-2.10.0d8.sql: New index on cal_items(on_which_calendar, item_type_id) * packages/chat/chat.info: * packages/chat/tcl/xotcl-chat-procs.tcl: New index on chat_transcripts(room_id) * packages/rss-support/rss-support.info: * packages/rss-support/sql/postgresql/rss-generation-create.sql: * packages/rss-support/sql/postgresql/upgrade/upgrade-0.5d1-0.5d2.sql: New index on on rss_gen_subscrs(lastbuild) 2020-12-11 gustafn * packages/calendar/sql/postgresql/upgrade/upgrade-2.10.0d6-2.10.0d7.sql: added missing upgrade script * packages/calendar/calendar.info: * packages/calendar/sql/postgresql/calendar-create.sql: create a partial index on public calendars * packages/xowiki/tcl/xowiki-procs.tcl: don't clobber xo::cc url when already initialized * packages/xotcl-request-monitor/sql/postgresql/upgrade/upgrade-0.60-0.61.sql: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/xotcl-request-monitor.info: drop FK on community_id for cases, where communities are frequently dropped. we do not want to loose statistics in these cases 2020-12-11 antoniop * packages/acs-templating/tcl/head-procs.tcl: Add missing substitution 2020-12-10 antoniop * packages/acs-tcl/tcl/test/utilities-procs.tcl: Include tests with string containing an extension, put also a ß in the mix * packages/xowf/tcl/atjob-procs.tcl: Make sure url varuiable is set 2020-12-09 antoniop * packages/acs-tcl/tcl/utilities-procs.tcl: Add semicolon ";" to the list of forbidden characters to be stripped when a filename is sanitized It is not allowed to create a filename with a semicolon on Windows, but it is e.g. on macOS and Linux, creating a possible interoperability issue * packages/xowiki/tcl/form-field-procs.tcl: Apply a mild filename sanitization to the file formfield * packages/acs-tcl/tcl/test/utilities-procs.tcl: Basic test for ad_sanitize_filename * packages/acs-tcl/tcl/00-icanuse-procs.tcl: Bring existing doc in the API-doc, so that documentation__check_proc_doc test case does not complain * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: Fix typo spotted by acs_api_browser_api_get_body automated test * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: Whitespace cleanup 2020-12-08 gustafn * packages/acs-templating/acs-templating.info: * packages/acs-templating/lib/body_scripts.adp: * packages/acs-templating/lib/body_scripts.tcl: * packages/acs-templating/tcl/head-procs.tcl: Added support for streaming HTML + javascript body procs Previously, the API for bodyscripts (e.g. template::add_body_script, template::add_event_listener, template::add_body_handler, template::add_script with the right flags) was not usable for streaming HTML pages, since the full processing of such scripts was handled in blank-master.{tcl,adp}, which is not in use for streaming HTML. Now the function template::collect_body_scripts was added, which can be used at arbitrary time to collect the body scripts and translate those to HTML. This function can be used in streaming mode to output these function when new HTML chunks become available. * packages/xowf/lib/inclass-exam.wf: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: added a print button the works with event handler also in HTML streaming mode * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/00-icanuse-procs.tcl: added backward compatibility proc for AOLserver "ns_trim" * packages/acs-tcl/tcl/01-database-procs.tcl: don't throw error message on transaction rollbacks (these are no errors, but use the same exception handling) * packages/xotcl-core/tcl/06-package-procs.tcl: improve comments and rise warning, when best-effort url is generated * packages/rss-support/tcl/rss-generation-service-procs.tcl: improve robustness in case parameter is not (yet) set * packages/xowf/tcl/test/xowf-test-procs.tcl: * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: include public methods called via the web interface in listing of tested methods. * packages/xowf/tcl/atjob-procs.tcl: * packages/xowf/www/prototypes/atjob-form.page: include url in atjob form. This change eases the atjob execution substantially, since the package and connection context can be recreated based on this information * packages/xowiki/tcl/xowiki-callback-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: mark functions for administrative proposes as private * packages/xowf/tcl/xowf-procs.tcl: pass _nls_language to batch-jobs to avoid invalid value in name normalization white-space changes * packages/xotcl-core/tcl/bgdelivery-procs.tcl: provide explicit url when manually creating a connection context * packages/xowf/tcl/test-item-procs.tcl: redice verbosity * packages/xotcl-core/tcl/context-procs.tcl: replace array by dict, provide error message, when someone tries to setup a connection context without a proper url * packages/rss-support/tcl/rss-generation-service-procs.tcl: whitespace changes: break overlong line * packages/acs-tcl/tcl/01-database-procs.tcl: whitespace changes: break overlong lines 2020-12-08 antoniop * packages/xowiki/tcl/xowiki-procs.tcl: Provide a URL when requiring a connection context 2020-12-07 gustafn * packages/xowiki/tcl/form-field-procs.tcl: generalize correct_when handling: allow for every modifier a "-nocase" option * packages/file-storage/www/folder-chunk.tcl: * packages/news-portlet/www/news-portlet.tcl: * packages/news/www/admin/index.tcl: * packages/news/www/index.tcl: improve robustness in case parameter is not (yet) set * packages/xowiki/tcl/form-field-procs.tcl: report points from text_fields (used in short-text questions) when available 2020-12-07 antoniop * packages/xotcl-core/tcl/context-procs.tcl: Provide a fallback empty URL when one tries to require the connection context without one and outside of a connection 2020-12-06 gustafn * packages/xooauth/www/admin/lti-test.adp: * packages/xooauth/www/admin/lti-test.tcl: added LTI test page * packages/acs-tcl/tcl/request-processor-init.tcl: added commit for extending usage of OpenACS filters for other HTTP methods (e.g. in the REST context) * packages/proctoring-support/lib/proctored-page.tcl: added editor hints * packages/xotcl-core/tcl/01-debug-procs.tcl: added missing eval statement * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl: * packages/xotcl-core/tcl/context-procs.tcl: * packages/xotcl-core/tcl/http-client-procs.tcl: * packages/xotcl-core/tcl/install-check-procs.tcl: improve spelling * packages/acs-tcl/tcl/acs-cache-procs.tcl: improved wording in comment * packages/xowf/tcl/test-item-procs.tcl: make grading scheme explicit (prepare for potentially other schemes) * packages/acs-tcl/tcl/html-procs.tcl: modernize Tcl code: replace array by dict * packages/xowiki/tcl/form-field-procs.tcl: provide a short hint how to allow swa always pasting * packages/xowiki/tcl/menu-procs.tcl: reduce verbosity * packages/xotcl-core/tcl/06-package-procs.tcl: refactor code and use caching to reduce (maybe overly cautious) flushes on site_nodes_id_cache-* * packages/xowiki/tcl/form-field-procs.tcl: reorder_box: provide correction_data * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: switch default package selection to "full" * packages/xotcl-core/tcl/cr-procs.tcl: whitespace changes 2020-12-04 hectorr * packages/file-storage/file-storage.info: * packages/file-storage/www/folder-chunk.adp: * packages/file-storage/www/folder-chunk.tcl: Disable RSS offering in file-storage if the RSS generation service is disabled in rss-support. Bump version numbers and fix dependencies, as the RssGenActiveP parameter is only available in latest rss-support. * packages/news-portlet/news-portlet.info: * packages/news-portlet/www/news-portlet.adp: * packages/news-portlet/www/news-portlet.tcl: * packages/news/news.info: * packages/news/www/admin/index.adp: * packages/news/www/admin/index.tcl: * packages/news/www/index.adp: * packages/news/www/index.tcl: Disable RSS offering in news and news-portlet if the RSS generation service is disabled in rss-support. Bump version numbers and fix dependencies, as the RssGenActiveP parameter is only available in latest rss-support. * packages/file-storage/www/folder-chunk.tcl: * packages/news-portlet/news-portlet.info: * packages/news-portlet/www/news-portlet.tcl: * packages/news/news.info: * packages/news/www/admin/index.adp: * packages/news/www/admin/index.tcl: * packages/news/www/index.adp: * packages/news/www/index.tcl: Whitespace changes 2020-12-03 hectorr * packages/rss-support/rss-support.info: * packages/rss-support/tcl/rss-generation-service-procs.tcl: Add parameter RssGenActiveP to the rss-support package, to enable/disable the RSS generation service. Bump version number. * packages/rss-support/rss-support.info: * packages/rss-support/tcl/rss-generation-service-procs.tcl: Whitespace changes 2020-12-03 antoniop * packages/acs-subsite/www/admin/rel-segments/elements-display.tcl: Add include contract * packages/acs-subsite/www/admin/rel-segments/elements-display.tcl: Add missing var * packages/categories/lib/map.tcl: Use page contract * packages/categories/lib/map.tcl: Whitespace cleanup 2020-12-01 gustafn * packages/acs-tcl/tcl/apm-procs.tcl: fix typo * packages/acs-tcl/tcl/site-nodes-procs.tcl: reduce verbosity 2020-11-27 gustafn * packages/acs-tcl/tcl/tcltrace-init.tcl: added example line to ease spotting of the creation of unnamed mutexes * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: provide name for mutexes to ease spotting potential locks * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: reduce verbosity (set verbose_blocking per default to 0), improve speed of dump creation 2020-11-26 antoniop * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: New method to cleanup all data associated with a community in the throttle object: if a community is deleted when a user is accessing it, some leftover information will be kept in the object. At the next request this will be interpreted as the community having been left and the system will try to track this event into request_monitor_community_activities. Depending on who comes first, we might try to insert a tuple in the table for an object that does not exist anymore. Hence, we use this method to cleanup all community info before the actual deletion in dotlrn (happening only downstream). 2020-11-25 hectorr * packages/dotlrn/tcl/community-procs.tcl: Fix expression logic 2020-11-25 gustafn * packages/xowiki/tcl/form-field-procs.tcl: allow points computation in cases, where some grading schemes fail. Before, the grading code was overly conservative and refused to compute achieved points in such cases 2020-11-24 gustafn * packages/acs-tcl/tcl/security-procs.tcl: avoid burst cache hits by using nsvs instead of ns_cache for secret token caching The problem with the prevision version was that ns_cache has no equivalent to nsv_array to get in an atomic fashion all key value pairs from the cache. therefore, for the per-thread caching, a tight loop was used processing the result of ns_cache_keys. If this was necessary in a high number of threads, higher lock times were possible (~100ms). The new version should not face this problem. 2020-11-24 antoniop * packages/dotlrn/tcl/community-procs.tcl: Add missing arguments * packages/dotlrn/tcl/community-procs.tcl: Constrain further the characters we allow in the community_key: makes sense upstream as this will become part of a URL, but is even more important downstream, as we implement the community_key as a ltree and therefore we are limited in the type of characters we can allow (See https://www.postgresql.org/docs/current/ltree.html) * packages/dotlrn/tcl/community-procs.tcl: Don't be so strict upstream, as here we do not restrict community_key to ltree * packages/dotlrn/tcl/community-procs.tcl: Fix typo * packages/dotlrn/tcl/community-procs.tcl: * packages/dotlrn/tcl/community-procs.xql: Rework dotlrn_community::check_community_key_valid_p so that we check also for the community key to not have spaces Logics have been moved to private api that might or might not become the preferable api at some point, as it also returns the specific error message together with the boolean 2020-11-23 gustafn * packages/xowiki/tcl/form-field-procs.tcl: candidate_box_select: provide optional the feature to keep the user selected order The change is fully backward compatible. Per default, the order in the actual selected values is the same as in the candidate selection box. When the new parameter "keep_order" is provided, the order of the selected values is kept as selected by the user. * packages/xowiki/www/resources/xowiki.css: candidate_box_select: provide per default larger boxed (easier for dnd) * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/answer-single-question.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/www/resources/xowiki.css: fixed ckeditor form field for inline mode. use inline mode for editing test items added a describe function for MC items * packages/acs-automated-testing/acs-automated-testing.info: * packages/acs-automated-testing/tcl/aa-test-procs.tcl: * packages/file-storage/file-storage.info: * packages/file-storage/tcl/test/webtest-procs.tcl: * packages/xowiki/tcl/test/test-procs.tcl: * packages/xowiki/xowiki.info: move xowiki::test::get_url_from_location to automated testing handle updaed query-handling in ns_parseurl remoe dependency from file-storage tests to xowiki * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/form-generator.css: * packages/xowf/xowf.info: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: new form-field class: boolean_checkbox behaves like boolean, but provdes just a single checkbox instead of yes/no radio in "boolean" the output is full compatible with "boolean". The boolean_checkbox is used in test-item procs for a more slim correct/incorrect specification * packages/richtext-ckeditor4/richtext-ckeditor4.info: * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: upgrade to CKEditor 4.15.1 * packages/xowf/www/prototypes/quiz-select_question.form.page: * packages/xowf/www/prototypes/select_question.form.page: use "keep_order=true" for test-item selection boxes * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/edit-interaction.wf: use term "Preview" for testing single test items 2020-11-23 gernst * packages/new-portal/new-portal.info: * packages/new-portal/sql/oracle/portal-core-create.sql: * packages/new-portal/sql/oracle/upgrade/upgrade-2.10.0d3-2.10.0d4.sql: * packages/new-portal/sql/postgresql/portal-core-create.sql: * packages/new-portal/sql/postgresql/upgrade/upgrade-2.10.0d3-2.10.0d4.sql: Package new-portal: additional database indices for tables "portal_element_map", "portal_element_parameters" and "portal_datasource_def_params"; bumped package version to 2.10.0d4 2020-11-23 antoniop * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: Important, although very simple reform in the page-contract filters: do not kill the case in the filter specs, or filters such as "w:oneof(One|Two)" or "locale:oneof(en_US|de_DE)" would not have a chance to match Note that this makes the contracts stricter with respect to case, which might break obscure use cases... * packages/acs-subsite/www/register/user-join.tcl: Port of downstream customization: don't lose the return URL when one tries to join a community before login * packages/acs-subsite/www/register/user-join.tcl: Remove irrelevant comment * packages/acs-subsite/www/register/user-join.tcl: Whitespace cleanup 2020-11-21 gustafn * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: allow value checkers in ad_procs * packages/acs-tcl/tcl/request-processor-procs.tcl: avoid to try to return an error to client in request processor when connection was already closed * packages/xotcl-core/tcl/policy-procs.tcl: improve wording * packages/xotcl-core/tcl/policy-procs.tcl: provide minimal feedback when enforce permission fails in background operation * packages/xotcl-request-monitor/tcl/callback-proc.tcl: * packages/xotcl-request-monitor/tcl/callback-procs.tcl: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/xotcl-request-monitor.info: request monitor overhaul: - new parameter "do_double_click_prevention" (default: on) When turned off, double click prevention can be selectively turned off. - new parameter "monitor_urls" (default: / /register/ /dotlrn/) track for these URLs performance via minin responsetime plugin - added upgrade script for removing old parameters - bump version to 0.60 2020-11-20 gustafn * packages/acs-tcl/tcl/apm-procs.tcl: add hook to write changed blueprints * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: fix typo 2020-11-19 gustafn * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/xowiki.info: added value checker from page filters to slots: "nohtml" and "html" Made flowplayer more secure by reject markup in argument * packages/xowiki/tcl/includelet-procs.tcl: perform checking on input variable 2020-11-19 antoniop * packages/proctoring-support/www/resources/proctored-page.js: Address a problem encountered already with proctoring uploads: in cases that count both as timeouts and errors, the rescheduling of the request would happen twice. If the condition persists, the number of requests can grow out of control * packages/xowiki/tcl/form-field-procs.tcl: Localize already at the pretty value, otherwise things such as the wikicmds will not be evaluated 2020-11-18 gustafn * packages/acs-admin/www/users/one-contributions.adp: * packages/acs-admin/www/users/one-contributions.tcl: * packages/acs-admin/www/users/one.adp: * packages/acs-admin/www/users/one.tcl: Split up basic user information (one.tcl) and the users contributions (one-contributions) Without this change, one.tcl becomes unusable for large sites, where some users have literally millions of objects (e.g. admins migrating some data). We have seen the query running for several hours. Maybe, one should limit also in the split case the number of presented contributions 2020-11-17 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: improve spelling * packages/acs-tcl/tcl/apm-procs.tcl: report changes in blueprint size when reloading files * packages/acs-tcl/tcl/proxy-procs.tcl: whitespace changes 2020-11-14 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: let watchdog send mail to webmaster with data of active requests 2020-11-13 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-init.tcl: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: pool_remap_watchdog: new watchdog for potentially stuck processes This watchdog checks every minute the running jobs and maps very slow requests to the slow pool (if configured) to avoid that the default pool is getting filled up with more stuck requests. This ensures the livelyness of a server. 2020-11-12 hectorr * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: Remove the 'dot-stuffing' from 'acs-mail-lite', as this is done directly on 'nssmtpd' and 'ns_smtp' now. See https://bitbucket.org/naviserver/naviserver/commits/4bdbd53a3 c36f60b8ec0c4e400de1b69bf3e19e5 and https://bitbucket.org/naviserver/nssmtpd/commits/d484ba5d4136 4c1a0ab8e2437c5311a6d5d7e986 2020-11-11 hectorr * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: Add a second period to new lines starting with one ('dot-stuffing'), as defined by RFC 5321 section 4.5.2, before sending mail via nssmptd. According to the RFC: - "Before sending a line of mail text, the SMTP client checks the first character of the line. If it is a period, one additional period is inserted at the beginning of the line." - "When a line of mail text is received by the SMTP server, it checks the line. If the line is composed of a single period, it is treated as the end of mail indicator. If the first character is a period and there are other characters on the line, the first character is deleted." This change adds the second period at the beginning of a line suggested in the first paragraph, preventing nssmptd from deleting dots by acting as mentioned in the second one. In the case of lines comprised of just a single period, '::mime::qp_encode' already takes care of them by converting the '.' into '=2E', so they are not affected by this. * packages/acs-tcl/tcl/test/text-html-procs.tcl: Fix test category misplacement 2020-11-10 hectorr * packages/acs-tcl/tcl/test/text-html-procs.tcl: Set tests as 'production_safe' * packages/acs-tcl/tcl/test/text-html-procs.tcl: Take care of string values when these are longer than the randomized length * packages/acs-tcl/tcl/test/text-html-procs.tcl: Whitespace changes 2020-11-10 gernst * packages/xooauth/tcl/oauth-procs.tcl: * packages/xooauth/tcl/package-procs.tcl: Removed instmixin specification from the ::xo::oauth::Package creation statement as the to-be-mixed-in classes no longer exist; Fixed varname 2020-11-09 antoniop * packages/notifications/tcl/sweep-procs.tcl: Remove colon that gets confused as a bind variable 2020-11-08 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/www/ip-info.tcl: reduce verbosity 2020-11-07 gustafn * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: FormPage->field_names: in case, not form is given, fall back for the needed field names to the field_name provided by form_constraints * packages/acs-tcl/tcl/00-icanuse-procs.tcl: add i-can-use rule for "ns_urlencode -part oauth1" * packages/xowiki/tcl/form-field-procs.tcl: additional form-field class "localized_richtext" This class is very similar to localized_text, but for richtext widgets (internationalized text with richtext markup) instead of plain text * packages/xowiki/tcl/form-field-procs.tcl: improve comment * packages/xooauth/lib/authorize.adp: * packages/xooauth/lib/authorize.tcl: * packages/xooauth/lib/index.adp: * packages/xooauth/tcl/oauth-client-procs.tcl: * packages/xooauth/tcl/oauth-procs.tcl: * packages/xooauth/tcl/oauth-server-procs.tcl: * packages/xooauth/tcl/package-procs.tcl: * packages/xooauth/tcl/test/xooauth-test-procs.tcl: * packages/xooauth/www/index.vuh: * packages/xooauth/xooauth.info: initial checkin of xooauth With the friendly permissions of Knowledge Markets https://km.at/ * packages/xowiki/tcl/form-field-procs.tcl: move localized_richtext to the right place in the file to ensure initial loading make localizer insensitive, when main input field is insensitive 2020-11-06 antoniop * packages/notifications/sql/postgresql/upgrade/upgrade-5.10.0d6-5.10.0d7.sql: Add missing semicolon * packages/notifications/notifications.info: * packages/notifications/sql/postgresql/upgrade/upgrade-5.10.0d6-5.10.0d7.sql: * packages/notifications/tcl/sweep-procs.tcl: * packages/notifications/tcl/sweep-procs.xql: Solve a potential issue when one would cleanup "dynamic" notification requests: this was done directly on the table and could therefore leave dangling acs_objects around - cleanup all acs_objects of type 'notification_request' that do not have a corresponding entry in the table (~35000 downstream) - embed logic of delete_dynamic_requests query inside select_invalid_request_ids query, as there the deletion is done properly 2020-11-05 hectorr * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Cleanup after each individual test 2020-11-05 antoniop * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: Reinstate retrieval of the package_id from the connection context in child-resources, the problem was that, when we required a connection context in create_form_page_instance, we did with no information whatsoever, which was then retrieved by e.g. ns_conn, sometimes wrongly (e.g. when one is running under the test package) 2020-11-04 hectorr * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Cleanup temporary XOTcl objects after test run * packages/xowiki/tcl/xowiki-procs.tcl: Ensure a minimal connection context before checking for user_id * packages/xotcl-core/tcl/test/xotcl-avail-procs.tcl: Remove 'check_xotcl_xocc' test case, as it has served its purpose already 2020-11-04 antoniop * packages/xowiki/tcl/folder-procs.tcl: child-resources has already a package_id, getting it from the connection context makes the includelet susceptible to e.g. package initializations from the outside (see e.g. xowiki link_tests automated test) 2020-11-02 hectorr * packages/xotcl-core/tcl/test/xotcl-avail-procs.tcl: Add 'check_xotcl_xocc' test case, checking for 'xo::cc'. The intention of this test is to expose the destruction of the '::xo::cc' object, as a side effect of the 'check_xotcl' test. The test will fail if executed after it, and succeed otherwise. The object destruction affects other tests executed in the same batch, and breaks in particular xowf's 'create_folder_with_page'. The 'check_xotcl' test runs the 'Serializer all' method, which is calling 'xo::at_cleanup', destroying the '::xo::cc' object. 2020-11-01 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/www/prototypes/select_question.form.page: * packages/xowf/www/resources/test-item.css: - added detailed proctoring options - accordion style exam options - allow restart in "done" state only for SWAs * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/proxy-procs.tcl: make proxy exec more compatible with tcl exec: support flags "-ignorestderr" and "--" * packages/acs-tcl/tcl/apm-procs.tcl: revert escaped change * packages/xowf/lib/edit-interaction.wf: show "view" button only, when workflow instance with the current name was already created. * packages/xowf/lib/edit-interaction.wf: show action "view" only, when user is swa 2020-10-31 gustafn * packages/proctoring-support/www/resources/proctoring.js: fix bug in javascript, when only the screen-stream should be recorded * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/tcl/proctoring-procs.tcl: improve spelling 2020-10-29 hectorr * packages/acs-tcl/tcl/test/navigation-procs.tcl: Do rollback after test run 2020-10-28 trenner * packages/xowf/lib/edit-interaction.wf: remove the view action - for the moment we do not need it 2020-10-28 hectorr * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: Fix message key for SC/MC question alternatives. Many thanks to Stephan Adelsberger * tcl/0-acs-init.tcl: Prefer 'namespace which' over 'info commands' * packages/acs-admin/tcl/acs-admin-procs.tcl: * packages/acs-admin/tcl/apm-admin-init.tcl: * packages/acs-admin/tcl/site-wide-procs.tcl: * packages/acs-admin/www/apm/version-callback-add-edit.tcl: * packages/acs-admin/www/install/install-3.tcl: * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: * packages/acs-api-browser/www/proc-view.tcl: * packages/acs-automated-testing/tcl/aa-test-procs.tcl: * packages/acs-bootstrap-installer/installer/index.tcl: * packages/acs-bootstrap-installer/installer/tcl/0-acs-init.tcl: * packages/acs-bootstrap-installer/installer/www/blank-master.tcl: * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: * packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl: * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: * packages/acs-content-repository/tcl/image-procs.tcl: * packages/acs-content-repository/tcl/publish-procs.tcl: * packages/acs-content-repository/tcl/revision-procs.tcl: * packages/acs-developer-support/tcl/acs-developer-support-procs.tcl: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: * packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl: * packages/acs-service-contract/tcl/acs-service-contract-procs.tcl: * packages/acs-service-contract/www/binding-display.tcl: * packages/acs-subsite/tcl/apm-callback-procs.tcl: * packages/acs-subsite/tcl/attribute-procs.tcl: * packages/acs-subsite/www/shared/ajax/chat.tcl: * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/10-charset-compat-procs.tcl: * packages/acs-tcl/tcl/20-memoize-init.tcl: * packages/acs-tcl/tcl/30-xml-utils-procs.tcl: * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/acs-permissions-procs.tcl: * packages/acs-tcl/tcl/apm-file-procs.tcl: * packages/acs-tcl/tcl/apm-install-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/callback-procs.tcl: * packages/acs-tcl/tcl/deprecated-procs.tcl: * packages/acs-tcl/tcl/ds-stub-procs.tcl: * packages/acs-tcl/tcl/exception-procs.tcl: * packages/acs-tcl/tcl/form-processing-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/memoize-procs-aolserver.tcl: * packages/acs-tcl/tcl/memoize-procs-naviserver.tcl: * packages/acs-tcl/tcl/proxy-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-tcl/tcl/site-nodes-init.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: * packages/acs-tcl/tcl/text-html-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/acs-tcl/tcl/xml-2-procs.tcl: * packages/acs-templating/tcl/0-acs-templating-procs.tcl: * packages/acs-templating/tcl/data-procs.tcl: * packages/acs-templating/tcl/element-procs.tcl: * packages/acs-templating/tcl/head-init.tcl: * packages/acs-templating/tcl/parse-procs.tcl: * packages/acs-templating/tcl/richtext-procs.tcl: * packages/acs-templating/tcl/tag-init.tcl: Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter. 2020-10-28 gustafn * packages/xowiki/tcl/repeat-procs.tcl: * packages/xowiki/www/resources/xowiki.css: Use usual delete symbol for deleting repeat elements * packages/xotcl-core/tcl/01-debug-procs.tcl: added NSF version to reported version numbers * packages/xowf/lib/inclass-exam.wf: fix error message generation * packages/xowiki/www/resources/xowiki.css: improve styling of nested repeated fields (less frames) * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: stay closer to QTI, use more appropriate labels 2020-10-27 antoniop * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Fix overquoting in english message key 2020-10-25 gustafn * packages/xowf/lib/answer-single-question.wf: * packages/xowf/lib/edit-interaction.wf: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/www/prototypes/answer-single-question.wf.page: added preview/testrun to edit item workflow * packages/faq/sql/postgresql/faq-sc-create.sql: make FAQ package installable under PG 13+ * packages/acs-mail-lite/sql/postgresql/acs-mail-lite-create.sql: * packages/faq/sql/postgresql/faq-sc-create.sql: make packages in principle installable under PG 13+ * packages/xowf/tcl/test-item-procs.tcl: * packages/xowiki/tcl/menu-procs.tcl: provide explicit flag to disable menu-entries disable the menu-entries for "Online Exam" and "Inclass Quiz" for the time being * packages/xowf/tcl/xowf-procs.tcl: reduce verbosity 2020-10-23 hectorr * packages/acs-admin/tcl/acs-admin-procs.tcl: Fix proc doc 2020-10-23 gustafn * packages/acs-tcl/tcl/site-nodes-procs-postgresql.xql: Fix for issue #3446 This fixes a bug, where the ordering of the site-nodes in the answer set of the select_child_site_nodes query in site_node::update_cache led to disappearing entries in the site map, when additional items were added. This bug happened in the old-style (nsv-based) site-node implementation, which is used, when no xotcl is available. Many thanks to Keith Paskett for debugging and the fix. * packages/acs-admin/www/apm/packages/index-oracle.xql: * packages/acs-admin/www/apm/version-edit-2.xql: * packages/acs-content-repository/tcl/deprecated-procs.xql: * packages/acs-content-repository/tcl/revision-procs-oracle.xql: * packages/assessment/tcl/as-item-type-sa-procs.xql: * packages/evaluation-portlet/www/evaluation-evaluations-portlet-postgresql.xql: * packages/evaluation/www/view/index-postgresql.xql: * packages/file-storage/tcl/file-storage-procs-oracle.xql: * packages/file-storage/tcl/file-storage-procs-postgresql.xql: * packages/forums/www/moderate/move-thread-oracle.xql: * packages/forums/www/moderate/move-thread-postgresql.xql: * packages/forums/www/moderate/move-thread.xql: * packages/general-comments/www/file-add-2-oracle.xql: * packages/general-comments/www/file-add-2-postgresql.xql: * packages/rss-support/tcl/rss-generation-service-procs-oracle.xql: * packages/rss-support/tcl/rss-generation-service-procs-postgresql.xql: * packages/theme-zen/www/doc/lists/index-postgresql.xql: use bind variables instead of Tcl variable substitution in xql fullqueries 2020-10-22 trenner * packages/xotcl-core/tcl/30-widget-procs.tcl: skip hidden fields to avoid empty td elements for the user 2020-10-22 hectorr * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Fix parameter names 2020-10-22 antoniop * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/www/resources/proctored-page.js: * packages/proctoring-support/www/resources/proctoring.js: Allow in the include to selectively disable combinations of audio, camera and desktop recording (at least one stream needs to be enabled for proctoring to happen) This allows to better tailor proctoring behavior to the user needs and privacy requirements 2020-10-21 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: added total points (in addition to total minutes) to the exam overview * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/xowf.info: perform cleanup of WorkflowContainer after 10 minutes 2020-10-20 hectorr * packages/acs-tcl/tcl/apm-procs.tcl: Ignore singleton packages that are already instantiated on 'apm_package_instance_new', preventing the execution of the after-instantiate callbacks * packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl: Rework of the 'test_apm_parameter__register' and 'test_apm_package_instance__new' test cases. Ignored disabled packages in both tests. Check all enabled packages in 'test_apm_package_instance__new', instead of picking just one randomly, so all issues instantiating packages are found at once. Indentation changes. 2020-10-20 gustafn * packages/acs-tcl/tcl/security-procs.tcl: Convert content of host header field to lowercase, since domain names are case insensitive 2020-10-19 hectorr * packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl: Adapt tests to the new behaviour of 'apm_parameter_unregister' * packages/acs-tcl/tcl/test/navigation-procs.tcl: Do not add admin_node to the component bars if it is empty * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: Reduce error level to warning in the nullchat test case, as the issue is driver related 2020-10-19 gustafn * packages/xowf/tcl/test-item-procs.tcl: comment public methods 2020-10-19 antoniop * packages/acs-tcl/tcl/apm-procs.tcl: Keep tolerating parameter_id specified as unnamed argument in legacy code and warn about deprecation 2020-10-17 gustafn * packages/acs-tcl/tcl/text-html-procs.tcl: Allow in testing mode always a "form" tag, independent of the antispam parameter settings This addresses an issue, when one is running the regression test for xowiki on installations with plain dotlrn, where otherwise the validator complains about the form tag in a form. There should be a nicer way of doing this... * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: add missing German message keys * packages/xotcl-core/tcl/01-debug-procs.tcl: address the update_attribute_from_slot problem for extended slots by registering manual forwarders * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/apm-procs.xql: allow calling apm_parameter_unregister without "parameter_id" previously, it was allowed to call it with an empty parameter_id, but not without it * packages/xowiki/tcl/upgrade/upgrade.tcl: * packages/xowiki/xowiki.info: get rid of ancient parameters BootstrapCSS BootstrapJS, if these still exist * packages/xowf/tcl/test-item-procs.tcl: improve documentation * packages/acs-tcl/tcl/security-procs.tcl: improve warning message in case invalid characters are passed in * packages/acs-subsite/tcl/group-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: prefer db_0or1row for exists-queries * packages/acs-bootstrap-installer/installer/install.tcl: * packages/acs-subsite/www/admin/users/new.tcl: * packages/acs-subsite/www/shared/parameters.tcl: * packages/assessment/tcl/as-apm-action-procs.tcl: remove calls to deprecated proc acs_lookup_magic_object (use acs_magic_object instead) * packages/xowiki/tcl/link-procs.tcl: * packages/xowiki/www/resources/xowiki-bootstrap3-specific.css: * packages/xowiki/www/resources/xowiki-yui-specific.css: remove spans for file-links and external links * packages/cookie-consent/cookie-consent.info: * packages/cookie-consent/tcl/cookie-consent-procs.tcl: upgrade to upstream version 3.1.1 don't include for bots bump version to 0.7 2020-10-15 hectorr * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Fix '::acs::test::require_package_instance' query for cases when the site_node exists but no package is mounted * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Fix null check 2020-10-15 gustafn * packages/xowiki/tcl/tree-procs.tcl: * packages/xowiki/tcl/yui-init.tcl: added URNs for top-level YUI js files * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.es_ES.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.it_IT.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.ru_RU.utf-8.xml: * packages/xowiki/www/admin/portal-element-add.tcl: * packages/xowiki/xowiki.info: fix message key * packages/xowiki/www/resources/xowiki-bootstrap3-specific.css: * packages/xowiki/www/resources/xowiki-yui-specific.css: * packages/xowiki/www/resources/xowiki.css: improve stylability: add glyphicons for external and file links Many thanks to Monika Andergasse for the help! * packages/xowiki/tcl/includelet-procs.tcl: remove colons before object_id, otherwise there is an error from general comments 2020-10-14 hectorr * packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl: * packages/dotlrn-forums/tcl/test/dotlrn-forums-test-procs.tcl: Delete site_node after unmount in 'dotlrn_forums::remove_applet' * packages/dotlrn-static/tcl/dotlrn-static-procs.tcl: * packages/dotlrn-static/tcl/test/dotlrn-static-test-procs.tcl: Delete site_node after unmount in 'dotlrn_static::remove_applet' 2020-10-14 gernst * packages/new-portal/www/place-element-other-page.tcl: * packages/new-portal/www/place-element.tcl: Change from ad_page_contract to ad_include_contract; removed unused arguments 2020-10-13 hectorr * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: Care about the parameter cache after test case * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: Fix typo * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: Merge 'auth_authority_api' and 'auth_authority_delete' test cases, covering almost the same api * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: Set a bunch of test cases to 'production_safe' * packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl: Use only 100 objects for the test, as in large instances this can take several minutes 2020-10-13 gustafn * packages/xowf/tcl/test-item-procs.tcl: allow test items with 0 points * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: turn off rounding to full points for exams with very little points 2020-10-12 hectorr * packages/categories/tcl/test/categories-procs.tcl: Add 'category_tree_procs' test case, covering multiple category_tree::... procs * packages/categories/tcl/test/categories-procs.tcl: Add private procs for checking category existence in tests 2020-10-10 gustafn * packages/openacs-bootstrap3-theme/resources/masters/plain-master.tcl: The W3C validator (Nu HTML Checker) throws an error on meta-tag content-style-type * packages/openacs-bootstrap3-theme/tcl/resource-init.tcl: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.4.1.js: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.4.1.min.js: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.5.1.js: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.5.1.min.js: fix fallback version of jquery (in case no other URN is available) 2020-10-09 hectorr * packages/categories/tcl/categories-procs.tcl: Adapt proc doc to the implementation * packages/categories/tcl/test/categories-procs.tcl: Add 'category_get_procs' test case, covering multiple category::get... procs * packages/categories/tcl/categories-procs.tcl: Fix 'category::get_id' and 'category::get_id_by_object_title' queries, that apparently got mixed up in the past * packages/categories/tcl/categories-procs.tcl: Fix 'category::get_id' query * packages/categories/tcl/test/categories-procs.tcl: Fix typo * packages/categories/tcl/test/categories-procs.tcl: Set categories for tests * packages/categories/tcl/categories-procs.tcl: * packages/categories/tcl/test/categories-procs.tcl: Whitespace changes 2020-10-09 gustafn * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/06-param-procs.tcl: * packages/xotcl-core/tcl/xotcl-init.tcl: fix installation from scratch (actually phase immediately after installing via apm) 2020-10-08 hectorr * packages/dotlrn-static/tcl/test/dotlrn-static-test-procs.tcl: Add trivial 'dotlrn_static_pretty_name' test case * packages/acs-tcl/tcl/test/datamodel-test-procs.tcl: Fix typo in library doc * packages/static-portlet/tcl/static-portal-content-procs.tcl: Fix typo in proc doc * packages/static-portlet/tcl/static-portal-content-procs.tcl: Remove unused and not working query * packages/static-portlet/tcl/static-portal-content-procs.tcl: Whitespace changes 2020-10-08 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: mark unused function "proc_source_file_full_path" as deprecated. * packages/acs-tcl/tcl/utilities-procs.tcl: simplify code 2020-10-08 antoniop * packages/proctoring-support/www/resources/proctored-page.js: Handle the case where the iframe URL points to an external website: just skip the iframe-loop check * packages/acs-tcl/tcl/utilities-procs.tcl: Humanize indentation * packages/xowiki/tcl/import-procs.tcl: Reduce hardcoded execs: the util might be improved to avoid them at some point * packages/search/www/search.tcl: Whitespace cleanup 2020-10-07 hectorr * packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl: Add 'dotlrn_homework_portlet_add_remove_from_page' test case, covering 'dotlrn_homework_portlet::add_self_to_page', 'dotlrn_homework_portlet::remove_self_from_page', 'dotlrn_homework_portlet::add_self_to_page' and 'dotlrn_homework_portlet::remove_self_from_page' * packages/dotlrn-static/tcl/test/dotlrn-static-test-procs.tcl: Add 'dotlrn_static__applet_portlet' test case, covering 'dotlrn_static::add_applet', 'dotlrn_static::add_portlet', 'dotlrn_static::add_portlet_helper', 'dotlrn_static::remove_portlet' and 'dotlrn_static::remove_applet' * packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl: Fix proc names * packages/dotlrn-static/tcl/dotlrn-static-procs.tcl: Implement 'dotlrn_static::remove_applet' and 'dotlrn_static::remove_portlet', and make 'dotlrn_static::add_portlet' return the element_id after adding the portlet to the portal * packages/faq/tcl/test/tclwebtest-procs.tcl: Set procs in the 'faq::twt' namespace as private * packages/file-storage/tcl/test/tclwebtest-procs.tcl: Set procs in the 'file_storage::twt' namespace as private 2020-10-07 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: New public method for the renaming form loader: name_to_question_obj_dict Provide quick mapping from the mangled attribute name to the question obj * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/table-widget-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/www/admin/bulk-delete.tcl: * packages/xowiki/www/admin/export.tcl: * packages/xowiki/www/admin/import.tcl: * packages/xowiki/www/admin/test.tcl: Use common interface for object reference in bulk actions - use same interface in child-resources and form-usages (when bulk-actions are used) - move "get_ids_for_bulk_actions" from page to package (to make in usable in www/admin) - use consistently "get_ids_for_bulk_actions" (also in www/admin/*.tcl) - provide backward compatibility (still support "name" and "-parent_id") * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: added detail info for xowf::test_item::answer_manager achieved_points the result dict of this method has now a key "details" containing information about the query object, the achieved points and the achievable points for this test item. Previously, just the sums were reported. * packages/xowf/lib/inclass-exam-answer.wf: added example-usage of set_css_property -querySelector 2020-10-07 antoniop * packages/proctoring-support/www/resources/proctored-page.js: Always make sure to clear any previously scheduled upload, before scheduling another one This handles the case when a connection times out (readyState 4 and status = 0). In this case both the rescheduling in the readystatechange handler and in the timeout handler would be executed. * packages/proctoring-support/www/resources/proctoring.js: Check stream refactoring: break down better the various error situations so they can be reported to the user * packages/proctoring-support/www/resources/proctoring.js: Enforce also that, after proctoring has successfully started, captured videos do not stop anymore This could mean that the video entered some invalid state, as we had already defined an event handler to restart a paused video... * packages/proctoring-support/www/resources/proctoring.js: Improve error message * packages/proctoring-support/www/resources/proctored-page.js: Include stream name in the error message 2020-10-06 hectorr * packages/calendar-portlet/tcl/test/calendar-portlet-procs.tcl: Add 'calendar_full_portlet::get_pretty_name' and 'calendar_portlet::get_pretty_name' to the 'calendar_portlet_links_names' test case * packages/calendar-portlet/tcl/test/calendar-portlet-procs.tcl: Add 'calendar_portlet_add_remove_from_page' test case, covering 'calendar_portlet::add_self_to_page', 'calendar_portlet::remove_self_from_page', 'calendar_list_portlet::add_self_to_page', 'calendar_list_portlet::remove_self_from_page', 'calendar_full_portlet::add_self_to_page', 'calendar_full_portlet::remove_self_from_page', 'calendar_admin_portlet::add_self_to_page', and 'calendar_admin_portlet::remove_self_from_page' * packages/dotlrn-portlet/tcl/test/dotlrn-portlet-procs.tcl: Add 'dotlrn_portlet::get_pretty_name' to the 'dotlrn_portlet_links_names_keys' test case * packages/dotlrn-portlet/tcl/test/dotlrn-portlet-procs.tcl: Add 'dotlrn_portlet_add_remove_from_page' test case, covering 'dotlrn_portlet::add_self_to_page', 'dotlrn_portlet::remove_self_from_page', 'dotlrn_members_portlet::add_self_to_page', 'dotlrn_members_portlet::remove_self_from_page', 'dotlrn_members_staff_portlet::add_self_to_page', 'dotlrn_members_staff_portlet::remove_self_from_page', 'dotlrn_admin_portlet::add_self_to_page' and 'dotlrn_admin_portlet::remove_self_from_page' * packages/evaluation-portlet/tcl/test/evaluation-portlet-procs.tcl: Add 'evaluation_portlet_add_remove_from_page' test case, covering 'evaluation_evaluations_portlet::add_self_to_page', 'evaluation_evaluations_portlet::remove_self_from_page', 'evaluation_assignments_portlet::add_self_to_page', 'evaluation_assignments_portlet::remove_self_from_page', 'evaluation_admin_portlet::add_self_to_page' and 'evaluation_admin_portlet::remove_self_from_page' * packages/fs-portlet/tcl/test/fs-portlet-procs.tcl: Add 'fs_portlet::get_pretty_name' to the 'fs_portlet__names' test case * packages/fs-portlet/tcl/test/fs-portlet-procs.tcl: Add 'fs_portlet_add_remove_from_page' test case, covering 'fs_portlet::add_self_to_page', 'fs_portlet::remove_self_from_page', 'fs_contents_portlet::add_self_to_page', 'fs_contents_portlet::remove_self_from_page', 'fs_admin_portlet::add_self_to_page' and 'fs_admin_portlet::remove_self_from_page' * packages/static-portlet/tcl/test/static-portlet-procs.tcl: Add 'static_portlet_add_remove_from_page' test case, covering 'static_portlet::add_self_to_page', 'static_portlet::remove_self_from_page', 'static_admin_portlet::add_self_to_page' and 'static_admin_portlet::remove_self_from_page' * packages/static-portlet/tcl/static-portlet-procs.tcl: Fix 'portal::remove_element' call * packages/static-portlet/tcl/static-portlet-procs.tcl: Whitespace changes 2020-10-06 gustafn * packages/acs-templating/tcl/head-procs.tcl: template::set_css_property: support flag "-querySelector" (in addition to the leass powerful "-class") 2020-10-06 antoniop * packages/proctoring-support/www/resources/proctored-page.js: Avoid suddent request bursts when e.g. connectivity resumes * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/proctoring-support.info: * packages/proctoring-support/www/resources/proctored-page.js: Include the technical error message in the popup to the user when missing stream error occurs * packages/forums/forums.info: * packages/forums/sql/postgresql/forums-reading-info-create.sql: * packages/forums/sql/postgresql/upgrade/upgrade-1.4d2-1.4d3.sql: New index on the forums_reading_info table * packages/proctoring-support/www/resources/proctoring.js: Store the previous picture by a deep value copy, rather than by reference, as the original canvas is going to be watermarked * packages/forums/sql/postgresql/forums-reading-info-create.sql: Whitespace cleanup 2020-10-05 hectorr * packages/assessment-portlet/tcl/test/assessment-portlet-procs.tcl: Add 'assessment_portlet_add_remove_from_page' test case, covering 'assessment_portlet::add_self_to_page', 'assessment_portlet::remove_self_from_page', 'assessment_admin_portlet::add_self_to_page' and 'assessment_admin_portlet::remove_self_from_page' * packages/faq-portlet/tcl/test/faq-portlet-procs.tcl: Add 'faq_portlet_add_remove_from_page' test case, covering 'faq_portlet::add_self_to_page', 'faq_portlet::remove_self_from_page', 'faq_admin_portlet::add_self_to_page' and 'faq_admin_portlet::remove_self_from_page' * packages/forums-portlet/tcl/test/forums-portlet-procs.tcl: Add 'forums_portlet_add_remove_from_page' test case, covering 'forums_portlet::add_self_to_page' and 'forums_portlet::remove_self_from_page' * packages/news-portlet/tcl/test/news-portlet-procs.tcl: Add 'news_portlet::get_pretty_name' to the 'news_portlet_links_names' test case * packages/news-portlet/tcl/test/news-portlet-procs.tcl: Add 'news_portlet_add_remove_from_page' test case, covering 'news_portlet::add_self_to_page', 'news_portlet::remove_self_from_page', 'news_admin_portlet::add_self_to_page' and 'news_admin_portlet::remove_self_from_page' * packages/news-portlet/tcl/test/news-portlet-procs.tcl: Add 'news_portlet_get_summary_length' test case, covering 'news_portlet::get_summary_length' 2020-10-02 hectorr * packages/chat-portlet/tcl/test/chat-portlet-procs.tcl: Add 'chat_portlet_add_remove_from_page' test case, covering 'chat_portlet::add_self_to_page', 'chat_portlet::remove_self_from_page', 'chat_admin_portlet::add_self_to_page' and 'chat_admin_portlet::remove_self_from_page' * packages/bm-portlet/tcl/bm-portlet-procs.tcl: Add missing parameters to 'bm_portlet::remove_self_from_page' * packages/new-portal/tcl/portal-procs.tcl: Fix proc doc * packages/dotlrn-faq/tcl/test/dotlrn-faq-test-procs.tcl: Fix test name and description 2020-10-02 antoniop * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/xowf.info: Fix typo in message key 2020-10-01 hectorr * packages/dotlrn-assessment/tcl/test/dotlrn-assessment-test-procs.tcl: Add 'dotlrn_assessment__applet_portlet' test case, covering 'dotlrn_assessment::add_applet', 'dotlrn_assessment::add_portlet', 'dotlrn_assessment::add_portlet_helper', 'dotlrn_assessment::remove_portlet' and 'dotlrn_assessment::remove_applet' * packages/dotlrn-evaluation/tcl/test/dotlrn-evaluation-test-procs.tcl: Add 'dotlrn_evaluation__applet_portlet' test case, covering 'dotlrn_evaluation::add_applet', 'dotlrn_evaluation::add_portlet', 'dotlrn_evaluation::add_portlet_helper', 'dotlrn_evaluation::remove_portlet' and 'dotlrn_evaluation::remove_applet' * packages/dotlrn-faq/tcl/test/dotlrn-faq-test-procs.tcl: Add 'dotlrn_faq__applet_portlet' test case, covering 'dotlrn_faq::add_applet', 'dotlrn_faq::add_portlet', 'dotlrn_faq::add_portlet_helper', 'dotlrn_faq::remove_portlet' and 'dotlrn_faq::remove_applet' * packages/dotlrn-forums/tcl/test/dotlrn-forums-test-procs.tcl: Add 'dotlrn_forums__applet_portlet' test case, covering 'dotlrn_forums::add_applet', 'dotlrn_forums::add_portlet', 'dotlrn_forums::add_portlet_helper', 'dotlrn_forums::remove_portlet' and 'dotlrn_forums::remove_applet' * packages/dotlrn-news/tcl/test/dotlrn-news-test-procs.tcl: Add 'dotlrn_news__applet_portlet' test case, covering 'dotlrn_news::add_applet', 'dotlrn_news::add_portlet', 'dotlrn_news::add_portlet_helper', 'dotlrn_news::remove_portlet' and 'dotlrn_news::remove_applet' * packages/dotlrn-faq/tcl/dotlrn-faq-procs.tcl: Fix arguments * packages/dotlrn-faq/tcl/dotlrn-faq-procs.tcl: Implement 'dotlrn_faq::remove_applet' * packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl: Implement 'dotlrn_forums::remove_applet' * packages/dotlrn-dotlrn/tcl/dotlrn-members-procs.tcl: Implement 'dotlrn_members::remove_applet' * packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl: Unmount applet on removal * packages/dotlrn-assessment/tcl/dotlrn-assessment-procs-oracle.xql: * packages/dotlrn-assessment/tcl/dotlrn-assessment-procs-postgresql.xql: * packages/dotlrn-assessment/tcl/dotlrn-assessment-procs.tcl: * packages/dotlrn-evaluation/tcl/dotlrn-evaluation-procs-oracle.xql: * packages/dotlrn-evaluation/tcl/dotlrn-evaluation-procs-postgresql.xql: * packages/dotlrn-evaluation/tcl/dotlrn-evaluation-procs.tcl: Use 'dotlrn_applet::remove_applet_from_dotlrn', now that it is implemented * packages/dotlrn-evaluation/tcl/test/dotlrn-evaluation-test-procs.tcl: Whitespace changes 2020-10-01 antoniop * packages/acs-developer-support/www/admin/index.tcl: Add ad_page_contract * packages/new-portal/www/place-element-other-page.tcl: * packages/new-portal/www/themes/kelp-theme/dotlrn/dotlrn-master-kelp.tcl: Add page contract * packages/new-portal/tcl/portal-procs.tcl: * packages/xowf/tcl/xowf-procs.tcl: Fix typos reported by documentation__check_typos automated test * packages/new-portal/www/themes/kelp-theme/dotlrn/dotlrn-master-kelp.tcl: Whitespace cleanup 2020-09-30 gustafn * packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml: improve message wording for message key 2020-09-30 antoniop * packages/acs-subsite/www/admin/group-types/groups-list.tcl: Add page contract * packages/xowf/lib/inclass-exam.wf: Fix glob flag 2020-09-29 trenner * packages/xowiki/tcl/xowiki-www-procs.tcl: distinguish between url and item_ref 2020-09-28 gustafn * packages/xowf/tcl/xowf-procs.tcl: add safety-guard in case, someone tries to call action via hacking form hacking * packages/xowiki/tcl/xowiki-procs.tcl: add transtional code to support semi-upgraded folders (having no description field set) * packages/acs-authentication/tcl/authentication-procs.tcl: * packages/acs-subsite/www/admin/configure.tcl: * packages/acs-tcl/lib/page-error.tcl: * packages/acs-tcl/tcl/navigation-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/acs-templating/tcl/deprecated-procs.tcl: * packages/acs-templating/tcl/richtext-procs.tcl: * packages/xotcl-core/tcl/context-procs.tcl: * packages/xowiki/tcl/chat-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/syndicate-procs.tcl: don't rely on uppercase header field names * packages/acs-tcl/tcl/security-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: whitespace changes 2020-09-27 gustafn * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: provide additional configuration hooks when creating new pages - p.source (copy variables from that site-wide page upon creation) - p.configure (call a method for configuration of the page) * packages/acs-tcl/tcl/xml-0-sgml-procs.tcl: provide better argument name * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-procs.tcl: provide configuration for exam folder * packages/xowiki/www/prototypes/folder.form.page: provide mimetype to "text" field (otherwise form is incorrectly displayed in browser) * packages/acs-subsite/tcl/group-procs.tcl: support passing a dict as argument to "group::update" (not only array) * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/www/admin/configure.tcl: * packages/acs-subsite/www/admin/subsite-add.tcl: * packages/acs-tcl/tcl/install-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/xowiki.info: switch to simple new group::update call with dict as argument This change fixes as well a bug in install::xml::action::set-join-policy since group::get returns a member "text" which is not accepted by group::update. * packages/acs-tcl/tcl/xml-0-sgml-procs.tcl: whitespace cleanup 2020-09-26 gustafn * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: added "ad_conn bot_p" to check, whether request was initiated by a bot This feature is based on a simple heuristic based on the user-agent (which can be certainly extended). It is useful to avoid e.g. Google bot to run into "notifications subscribe" + login attempts, which are useful for not-logged-in user, but not for bots. These attempts lead to failures in google statistics that might reduce the google ranking of a web site. * packages/acs-admin/www/auth/batch-job.tcl: fix listing of batch run - make links clickable - modernize Tcl code * packages/xowf/tcl/test-item-procs.tcl: improve debug message * packages/xowf/tcl/xowf-procs.tcl: provide a default menu config via proc The setup of the menu of xowf instances can be now configured via {config -use xowf}, new instances are created with this setup * packages/acs-admin/www/auth/batch-job.tcl: reduce debugging output * packages/acs-tcl/tcl/security-procs.tcl: relax default samesite setting for login and session cookies to lax This change was made because otherwise the "keep me logged in" is often lost, e.g. also with top-level navigation requests (e.g. when navigating to the site via Google) * packages/forums/forums.info: * packages/forums/www/forum-view.adp: * packages/forums/www/forum-view.tcl: * packages/forums/www/message-view.adp: * packages/forums/www/message-view.tcl: show notification controls only, when the request is not from a bot * packages/xotcl-core/tcl/06-package-procs.tcl: support folder instances as prototype pages 2020-09-25 trenner * packages/xowiki/tcl/xowiki-www-procs.tcl: add check if item_id exists * packages/xowiki/tcl/xowiki-www-procs.tcl: fix typo in log statement * packages/xowiki/tcl/xowiki-www-procs.tcl: relax url detection 2020-09-25 antoniop * packages/xowiki/tcl/xowiki-procs.tcl: Port of downstream behavior: create_link instproc is supposed to return an object. In case of error, just crash and let the anchor insproc handle the exception, instead of trying to use the error message as an object. * packages/proctoring-support/www/resources/proctored-page.js: Try to ask the browser to disable noise suppression on the microphone, so that silence detection won't trigger in case of "normal" environmental silence 2020-09-24 hectorr * packages/acs-tcl/tcl/ad-functional-procs.tcl: Deprecate 'f::lambda' in favor of tcllib implementation * packages/acs-tcl/tcl/ad-functional-procs.tcl: Whitespace changes 2020-09-24 antoniop * packages/news/www/admin/revision-add.tcl: Remove leftover text_file reference from revision add: reform happened in http://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adonb%3A200 91230231336 11 years ago discontinued this feature 2020-09-23 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: Added points in addition to minutes to test items and inclass-exam workflows 2020-09-23 antoniop * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/www/resources/proctored-page.js: Allow to turn off the actual upload of proctored files e.g. to implement a test page or when proctoring should just be used as a deterrent 2020-09-22 gustafn * packages/acs-admin/www/ip-info.adp: * packages/acs-admin/www/ip-info.tcl: * packages/acs-admin/www/users/one.adp: * packages/acs-admin/www/users/one.tcl: added last_contribution based on last created object * packages/acs-tcl/tcl/01-database-procs.tcl: fix broken support for explicit bindvars to db_foreach * packages/xowf/lib/inclass-exam.wf: improve source code documentation * packages/xowf/tcl/test-item-procs.tcl: remove personal-message dialog when user has finished her exam * packages/acs-admin/www/users/one.adp: remove stray "from" in last visit information we have in table "users" no last IP, we could just fall back to a last contribution field * packages/xowiki/tcl/form-field-procs.tcl: return raw value for form-fields of type label, when disableOutputEscaping is set 2020-09-21 gustafn * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/utilities-procs-naviserver.tcl: use common "icanuse" idioms 2020-09-21 antoniop * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: Fix typo * packages/proctoring-support/lib/proctored-page.adp: Increase threshold to 5Kb * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: Update proctoring upload URL to the new one 2020-09-16 trenner * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: fix typos in message keys * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: update message key Exam_mode_message 2020-09-16 hectorr * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: Fix typo 2020-09-15 trenner * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: add missing spaces * packages/proctoring-support/www/resources/proctored-page.js: fix condition: blob can either be null or the size of blob is below the threshold 2020-09-09 gustafn * packages/xowiki/tcl/chat-procs.tcl: factor out script wrappers * packages/xowiki/tcl/includelet-procs.tcl: no need to subst * packages/xowiki/tcl/form-field-procs.tcl: reduce verbosity * packages/xowiki/tcl/folder-procs.tcl: resolve message keys in titles * packages/xowiki/tcl/xowiki-init.tcl: * packages/xowiki/www/prototypes/folder.form.page: * packages/xowiki/www/prototypes/link.page: use localized_text for folders and links 2020-09-08 trenner * packages/xowiki/tcl/form-field-procs.tcl: fix typo 2020-09-06 gustafn * packages/acs-tcl/tcl/request-processor-init.tcl: Keep nsv variable "rp_properties request_count" The nsv "rp_properties request_count" is still needed for bootstart loader. Set it at the end of rp initialization * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: New form-field class: localized_text This class can be used to provide an interface for specifying internationalized text strings saved in message keys via input from a form. When editing the content provided via the input field is saved together with an item-specific message keys in the message key tables via lang::util::convert_to_i18n. This formfield class is especially useful for xowiki items which have no language-prefix (e.g. folders or links). In other cases it is probably still a better idea to create same named pages with different language prefixes. * packages/xowiki/tcl/includelet-procs.tcl: improve spelling * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: undo recent changes on too global localizations The new form-field class localized_text text solves the goals of for providing a formfield interface to message keys in a loca fashion rather than altering the behavior of all form field and of all property interfaces. 2020-09-04 trenner * packages/xowf/tcl/xowf-procs.tcl: search the form also in the site_wide_pages 2020-09-04 gustafn * packages/acs-tcl/tcl/request-processor-init.tcl: remove misleading comment. there should be no re-init 2020-09-03 gustafn * packages/acs-authentication/tcl/authentication-procs.tcl: * packages/acs-subsite/tcl/attribute-procs.tcl: * packages/dotlrn/tcl/test/community-procs.tcl: * packages/new-portal/tcl/portal-procs.tcl: prefer db_0or1row +"where exists" over db_string + "select case" * packages/xotcl-core/tcl/05-db-procs.tcl: reduce usage of idiom "select 1 from dual where exists" when not necessary * packages/xotcl-request-monitor/tcl/throttle_mod-init.tcl: send also HEAD requests to the request monitor * packages/xotcl-core/tcl/06-param-procs.tcl: some packages have high number of instances: no need to aggregate over these 2020-09-03 antoniop * packages/xowiki/tcl/form-field-procs.tcl: Disable any conversion on the _name property (:name Page instance variable): this property is special and receives already its necessary conversion at validation time, happening before conversion time and should not be overridden * packages/xotcl-core/tcl/ical-procs.tcl: Fix missing column in SQL statement * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: Implement 'language_specific' formfields and 'localized' FormPage properties: - properties can be stored and retrieved specifying a -localized flag: this flag will make transparently store and retrieve the property value from a custom message key created in the acs-translations package referencing the FormPage. This localization mechanism is additional to that of language-prefixed pages and can address the need of multi-language content for non-prefixable objects such as folders - via specifying language_specific in the formfield spec, one can enable this new localization mechanism when interacting with the FormPage via an xowiki::Form TODO: handle export/import of pages (e.g. serializing available translation and generate the new message keys for the imported page), add some nicer UI to make the user aware of e.g. current translation context * packages/proctoring-support/lib/proctored-page.adp: Reduce the threshold for images to be considered black: in the wild it has happened that borderline-legitimate pictures of 7kbytes have triggered the check. 2020-09-02 gustafn * packages/xowf/tcl/xowf-procs.tcl: prefer ad_try, since it is silent, when action is ended by a script_abort 2020-09-02 antoniop * packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d13-5.10.0d14.sql: * packages/acs-lang/sql/postgresql/upgrade/upgrade-5.10.0d13-5.10.0d14.sql: Do not insert object_ids that do not exist in acs_object (leftover group message keys) * packages/acs-lang/tcl/lang-util-procs.tcl: Pass missing object_id flag * packages/xotcl-core/tcl/05-db-procs.tcl: Replace limit with portable idiom 2020-09-01 antoniop * packages/proctoring-support/lib/proctoring-upload.tcl: Add a new flag to disable check on proctoring start/end time for applications that do not store this info in the package datamodel, improve doc * packages/proctoring-support/www/resources/proctored-page.js: Add semicolon (just for consistency, code was working before as well) * packages/acs-tcl/tcl/site-nodes-procs.tcl: Avoid the not portable limit idiom, just kill the recursive part using the flag instead ...although one should point out that Oracle does not support the boolean type... * packages/acs-content-repository/tcl/content-revision-procs.xql: Cleanup leftover query * packages/xowf/lib/inclass-exam.wf: Disable proctored-session expiration check based on proctoring-support datamodel using the new flag, enable preview as before (upstream code has it disabled by default), disable examination statement as intended * packages/acs-content-repository/tcl/test/content-extlink-procs.tcl: * packages/dotlrn/tcl/dotlrn-security-procs.tcl: * packages/dotlrn/tcl/test/community-procs.tcl: Fix missing end * packages/xotcl-core/tcl/05-db-procs.tcl: Fix oracle query as for most recent version limit is not supported * packages/xowf/lib/inclass-exam.wf: Fix retrieving the template * packages/xotcl-core/tcl/06-param-procs.tcl: Go straight to the database with a portable query * packages/dotlrn/tcl/test/community-procs.tcl: Im prove sql portability * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: Improve portability of test code * packages/acs-admin/www/auth/authority-set-sort-order.tcl: Improve portability, fetch idiom should be supported by "modern Oracle" * packages/acs-admin/www/apm/parameter-add.tcl: * packages/acs-content-repository/tcl/test/content-extlink-procs.tcl: * packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl: * packages/acs-mail-lite/tcl/email-inbound-procs.tcl: * packages/acs-mail-lite/tcl/imap-inbound-procs.tcl: * packages/acs-service-contract/tcl/acs-service-contract-procs.tcl: * packages/acs-subsite/tcl/attribute-procs.tcl: * packages/acs-subsite/tcl/group-procs.tcl: * packages/acs-subsite/tcl/group-type-procs.tcl: * packages/acs-subsite/tcl/subsite-procs.tcl: * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: * packages/dotlrn/tcl/dotlrn-security-procs.tcl: * packages/dotlrn/www/communities-chunk.tcl: * packages/file-storage/www/folder-chunk.tcl: * packages/forums/www/admin/subscribe-others-2.tcl: * packages/new-portal/tcl/portal-procs.tcl: * packages/new-portal/tcl/portal-procs.xql: * packages/xowiki/tcl/form-field-procs.tcl: Improve sql portability * packages/acs-authentication/tcl/authentication-procs.tcl: Improve sql portability: oracle cannot select a boolean directly using exists * packages/proctoring-support/www/upload.adp: * packages/proctoring-support/www/upload.tcl: Pass check_active_p from the including page * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/www/resources/proctored-page.js: Pass the check_active_p flag down to the backend from the proctored page, update doc * packages/acs-authentication/tcl/test/acs-authentication-procs-oracle.xql: * packages/acs-authentication/tcl/test/acs-authentication-procs-postgresql.xql: * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: Reduce divergencies between oracle and postgres codebase * packages/acs-api-browser/www/index-oracle.xql: * packages/acs-api-browser/www/index-postgresql.xql: * packages/acs-api-browser/www/index.tcl: Reduce divergency between oracle and postgres codebase * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.xql: Replace limit (pg only) with fetch idiom, which should be portable on "modern" Oracle * packages/assessment/tcl/as-apm-action-procs-oracle.xql: * packages/assessment/tcl/as-apm-action-procs-postgresql.xql: * packages/assessment/tcl/as-apm-action-procs.tcl: Replace limit idiom with portable idiom * packages/acs-subsite/tcl/group-procs.tcl: Replace limit with a portable idiom * packages/notifications/tcl/notification-callback-procs.tcl: * packages/notifications/tcl/notification-callback-procs.xql: Rewrite idiom to be portable (limit is psql only) * packages/acs-tcl/tcl/site-nodes-procs.tcl: Whitespace cleanup 2020-08-31 hectorr * packages/dotlrn-chat/tcl/test/dotlrn-chat-test-procs.tcl: Add 'dotlrn_chat__applet_portlet' test case, covering 'dotlrn_chat::add_applet', 'dotlrn_chat::add_portlet', 'dotlrn_chat::add_portlet_helper', 'dotlrn_chat::remove_portlet' and 'dotlrn_chat::remove_applet' * packages/dotlrn/tcl/applets-procs.tcl: * packages/dotlrn/tcl/applets-procs.xql: Implement the 'dotlrn_applet::remove_applet_from_dotlrn' proc, called from different remove_applet procs, but never implemented 2020-08-31 gustafn * packages/rss-support/tcl/rss-utilities-procs.xql: * packages/xowiki/tcl/package-procs.tcl: prefer SQL max() function over sort and limit 1 2020-08-31 antoniop * packages/acs-tcl/tcl/site-nodes-procs.tcl: Fix typo * packages/acs-tcl/tcl/site-nodes-procs.tcl: Maintain also the has_child cache when mounting a package * packages/acs-subsite/tcl/apm-callback-procs.tcl: * packages/acs-subsite/tcl/subsite-procs.tcl: Make apm callbacks private and move them together with the others * packages/news/tcl/news-apm-callback-procs.tcl: Make installation procs private * packages/xowf/lib/inclass-exam.wf: * packages/xowf/lib/proctored-page.adp: * packages/xowf/lib/proctored-page.tcl: * packages/xowf/lib/proctoring-upload.tcl: * packages/xowf/www/resources/proctoring/gif.js: * packages/xowf/www/resources/proctoring/gif.js.map: * packages/xowf/www/resources/proctoring/gif.worker.js: * packages/xowf/www/resources/proctoring/gif.worker.js.map: * packages/xowf/www/resources/proctoring/proctoring.js: Replace xowf proctoring implementation with that coming from proctoring-support TODO: nicer detection of whether proctoring-support package is actually installed 2020-08-28 antoniop * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Cover more group api this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect. * packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl: Improve test * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Increase proc coverage * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/proctoring-support.info: * packages/proctoring-support/www/resources/proctored-page.js: Move examination statement acceptance as last step of the proctoring wizard, localize the accept button, bind ajax logging of acceptance to the actual clicking of the accept button * packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl: New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc * packages/acs-content-repository/tcl/content-item-procs-oracle.xql: * packages/acs-content-repository/tcl/content-item-procs-postgresql.xql: Reinstate lost queries for content::item::content_is_null * packages/acs-subsite/tcl/group-procs.tcl: When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice 2020-08-27 trenner * packages/xowiki/tcl/weblog-procs.tcl: remove unnecessary parameter package_id 2020-08-27 gustafn * packages/richtext-ckeditor4/richtext-ckeditor4.info: * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: Upgrade CKEditor to 4.14.1 * packages/acs-tcl/tcl/site-nodes-procs.tcl: cache method "has_children" to avoid frequent (but cheap) DB calls * packages/xowiki/tcl/includelet-procs.tcl: fix comment and missing argument * packages/acs-tcl/tcl/request-processor-procs.tcl: improve handling of errors, which are triggered by the error template 2020-08-27 antoniop * packages/acs-lang/tcl/lang-message-procs.tcl: Fix typo * packages/xowiki/tcl/xowiki-procs.tcl: Improve doc and minor refactoring to reduce the diff with possible upcoming change * packages/acs-lang/tcl/lang-message-procs.tcl: * packages/acs-lang/tcl/lang-util-procs.tcl: acs-lang reform: when calling lang::util::convert_to_i18n, do not always register a en_US translation, which will be otherwise always overridden. Instead, let lang::message::register make sure that a en_US message exists and create it only when needed as a fallback. Before, lang::message::register would return an error when e.g. a new message keys was registered for de_DE and no en_US was there. Now the en_US will be just created on the fly. This does not break current automated tests 2020-08-26 gustafn * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/resources/templates/oacs-view.adp: * packages/xowiki/resources/templates/oacs-view2.adp: * packages/xowiki/resources/templates/oacs-view3-bootstrap3.adp: * packages/xowiki/resources/templates/oacs-view3.adp: * packages/xowiki/resources/templates/view-book-no-ajax.adp: * packages/xowiki/resources/templates/view-book.adp: * packages/xowiki/resources/templates/view-default.adp: * packages/xowiki/resources/templates/view-links.adp: * packages/xowiki/resources/templates/view-plain-master.adp: * packages/xowiki/resources/templates/view-plain.adp: * packages/xowiki/tcl/adp-generator-procs.tcl: * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/menu-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/www/resources/xowiki.css: * packages/xowiki/xowiki.info: MenuBar reform - MenuBars are now easier programmatically extensible (easier to maintain) - refactored code, reduced scatted definitions (all configurations at the same place) - unified templating: use body property @body.folderHTML@ instead of @folderhtml@ From the former API calls only "update_items" has changed, all existing configurations (i.e. via folders or package parameter) should continue to work. == Changes: One can now extend menubars via menu entry definition {config -use YOURCONFIG -class YOURCLASS} in two directions: a) subclassing define your own menubar class YOURCLASS, which should be a subclass of ::xowiki::MenuBar b) provide your own configuration method to provide a more tailored configuration. This is performed by defining a method "config=YOURCONFIG" for ::xowiki::MenuBar The latter method is used for test-items, which can define a test item folder by using -- extra_menu_entries --- {config -use test-items} instead of -- extra_menu_entries --- {entry -name New.Item.TextInteraction -form en:edit-interaction.wf -query p.item_type=Text} {entry -name New.Item.ShortTextInteraction -form en:edit-interaction.wf -query p.item_type=ShortText} {entry -name New.Item.SCInteraction -form en:edit-interaction.wf -query p.item_type=SC} {entry -name New.Item.MCInteraction -form en:edit-interaction.wf -query p.item_type=MC} {entry -name New.Item.ReorderInteraction -form en:edit-interaction.wf -query p.item_type=Reorder} {entry -name New.Item.UploadInteraction -form en:edit-interaction.wf -query p.item_type=Upload} {entry -name New.App.OnlineExam -form en:online-exam.wf} {entry -name New.App.InclassQuiz -form en:inclass-quiz.wf} {entry -name New.App.InclassExam -form en:inclass-exam.wf} See below for the definition of the "test-items" configuration method, which is based on the default definitions. In general, the definition in this method can be performed via menu-entries (same syntax as in other menu entries) or via the MenuBar API (e.g. calling ":add_menu_item ..."). All configurations follow the following definition order where later entries can refine earlier entries: - package level: package parameter ExtraMenuEntries - configuration method: use standard or tailored confguration methods - per-folder definition: content of the extra_menu_entries Note that the menu entry definition language supports as well adding/clearing menus, etc., so almost everything can be refined. I've noticed that the tlf* code has several scattered menu definitions, which are as well done in every case differently. By these definition one can define e.g. a learning-app folder (where "New" can be used to define new app folders), and the app folders can provide their own "New" entries, e.g. for clickers and others. E.g. For "clickers" there is already on non-oo definition to achieve similar things (which should be altered to the new method), but on other places, there are some hard-coded definitions for root folders, etc. The menubars of the learning-apps should be made this way more consistent with the rest (e.g. using "New", supporting "table of contents" for clipboard interactions, etc.) namespace eval ::xowiki { ::xowiki::MenuBar instproc config=test-items { {-bind_vars {}} -current_page:required -package_id:required -folder_link:required -return_url } { :config=default \ -bind_vars $bind_vars \ -current_page $current_page \ -package_id $package_id \ -folder_link $folder_link \ -return_url $return_url return { {clear_menu -menu New} {entry -name New.Item.TextInteraction -form en:edit-interaction.wf -query p.item_type=Text} {entry -name New.Item.ShortTextInteraction -form en:edit-interaction.wf -query p.item_type=ShortText} {entry -name New.Item.SCInteraction -form en:edit-interaction.wf -query p.item_type=SC} {entry -name New.Item.MCInteraction -form en:edit-interaction.wf -query p.item_type=MC} {entry -name New.Item.ReorderInteraction -form en:edit-interaction.wf -query p.item_type=Reorder} {entry -name New.Item.UploadInteraction -form en:edit-interaction.wf -query p.item_type=Upload} {entry -name New.App.OnlineExam -form en:online-exam.wf} {entry -name New.App.InclassQuiz -form en:inclass-quiz.wf} {entry -name New.App.InclassExam -form en:inclass-exam.wf} } } } * packages/acs-core-docs/www/acs-admin.adp: * packages/acs-core-docs/www/acs-package-dev.adp: * packages/acs-core-docs/www/acs-plat-dev.adp: * packages/acs-core-docs/www/analog-install.adp: * packages/acs-core-docs/www/analog-setup.adp: * packages/acs-core-docs/www/aolserver.adp: * packages/acs-core-docs/www/aolserver4.adp: * packages/acs-core-docs/www/apm-design.adp: * packages/acs-core-docs/www/apm-requirements.adp: * packages/acs-core-docs/www/automated-backup.adp: * packages/acs-core-docs/www/automated-testing-best-practices.adp: * packages/acs-core-docs/www/backup-recovery.adp: * packages/acs-core-docs/www/backups-with-cvs.adp: * packages/acs-core-docs/www/bootstrap-acs.adp: * packages/acs-core-docs/www/complete-install.adp: * packages/acs-core-docs/www/configuring-configuring-packages.adp: * packages/acs-core-docs/www/configuring-configuring-permissions.adp: * packages/acs-core-docs/www/configuring-install-packages.adp: * packages/acs-core-docs/www/configuring-mounting-packages.adp: * packages/acs-core-docs/www/configuring-new-site.adp: * packages/acs-core-docs/www/credits.adp: * packages/acs-core-docs/www/cvs-guidelines.adp: * packages/acs-core-docs/www/cvs-tips.adp: * packages/acs-core-docs/www/database-management.adp: * packages/acs-core-docs/www/db-api-detailed.adp: * packages/acs-core-docs/www/db-api.adp: * packages/acs-core-docs/www/dev-guide.adp: * packages/acs-core-docs/www/doc-standards.adp: * packages/acs-core-docs/www/docbook-primer.adp: * packages/acs-core-docs/www/eng-standards-constraint-naming.adp: * packages/acs-core-docs/www/eng-standards-filenaming.adp: * packages/acs-core-docs/www/eng-standards-plsql.adp: * packages/acs-core-docs/www/eng-standards-versioning.adp: * packages/acs-core-docs/www/eng-standards.adp: * packages/acs-core-docs/www/ext-auth-requirements.adp: * packages/acs-core-docs/www/filename.adp: * packages/acs-core-docs/www/files/acs-start.adp: * packages/acs-core-docs/www/files/dotlrn-style-2.adp: * packages/acs-core-docs/www/files/openacs-start.adp: * packages/acs-core-docs/www/for-everyone.adp: * packages/acs-core-docs/www/form-builder.adp: * packages/acs-core-docs/www/general-documents.adp: * packages/acs-core-docs/www/groups-design.adp: * packages/acs-core-docs/www/groups-requirements.adp: * packages/acs-core-docs/www/high-avail.adp: * packages/acs-core-docs/www/how-do-I.adp: * packages/acs-core-docs/www/i18n-convert.adp: * packages/acs-core-docs/www/i18n-design.adp: * packages/acs-core-docs/www/i18n-introduction.adp: * packages/acs-core-docs/www/i18n-overview.adp: * packages/acs-core-docs/www/i18n-requirements.adp: * packages/acs-core-docs/www/i18n-translators.adp: * packages/acs-core-docs/www/i18n.adp: * packages/acs-core-docs/www/index.adp: * packages/acs-core-docs/www/individual-programs.adp: * packages/acs-core-docs/www/install-cvs.adp: * packages/acs-core-docs/www/install-daemontools.adp: * packages/acs-core-docs/www/install-full-text-search-tsearch2.adp: * packages/acs-core-docs/www/install-ldap-radius.adp: * packages/acs-core-docs/www/install-more-software.adp: * packages/acs-core-docs/www/install-next-add-server.adp: * packages/acs-core-docs/www/install-next-backups.adp: * packages/acs-core-docs/www/install-next-nightly-vacuum.adp: * packages/acs-core-docs/www/install-nsopenssl.adp: * packages/acs-core-docs/www/install-nspam.adp: * packages/acs-core-docs/www/install-openacs-delete-tablespace.adp: * packages/acs-core-docs/www/install-openacs-inittab.adp: * packages/acs-core-docs/www/install-openacs-keepalive.adp: * packages/acs-core-docs/www/install-origins.adp: * packages/acs-core-docs/www/install-overview.adp: * packages/acs-core-docs/www/install-pam-radius.adp: * packages/acs-core-docs/www/install-php.adp: * packages/acs-core-docs/www/install-qmail.adp: * packages/acs-core-docs/www/install-redhat.adp: * packages/acs-core-docs/www/install-resources.adp: * packages/acs-core-docs/www/install-squirrelmail.adp: * packages/acs-core-docs/www/install-ssl.adp: * packages/acs-core-docs/www/install-steps.adp: * packages/acs-core-docs/www/install-tclwebtest.adp: * packages/acs-core-docs/www/ix01.adp: * packages/acs-core-docs/www/kernel-doc.adp: * packages/acs-core-docs/www/kernel-overview.adp: * packages/acs-core-docs/www/mac-installation.adp: * packages/acs-core-docs/www/maint-performance.adp: * packages/acs-core-docs/www/maintenance-deploy.adp: * packages/acs-core-docs/www/maintenance-web.adp: * packages/acs-core-docs/www/nxml-mode.adp: * packages/acs-core-docs/www/object-identity.adp: * packages/acs-core-docs/www/object-system-design.adp: * packages/acs-core-docs/www/object-system-requirements.adp: * packages/acs-core-docs/www/objects.adp: * packages/acs-core-docs/www/openacs-overview.adp: * packages/acs-core-docs/www/openacs-unpack.adp: * packages/acs-core-docs/www/openacs.adp: * packages/acs-core-docs/www/oracle.adp: * packages/acs-core-docs/www/os-install.adp: * packages/acs-core-docs/www/os-security.adp: * packages/acs-core-docs/www/packages.adp: * packages/acs-core-docs/www/parties.adp: * packages/acs-core-docs/www/permissions-design.adp: * packages/acs-core-docs/www/permissions-requirements.adp: * packages/acs-core-docs/www/permissions-tediously-explained.adp: * packages/acs-core-docs/www/permissions.adp: * packages/acs-core-docs/www/postgres.adp: * packages/acs-core-docs/www/profile-code.adp: * packages/acs-core-docs/www/programming-with-aolserver.adp: * packages/acs-core-docs/www/psgml-for-emacs.adp: * packages/acs-core-docs/www/psgml-mode.adp: * packages/acs-core-docs/www/release-notes.adp: * packages/acs-core-docs/www/releasing-openacs-core.adp: * packages/acs-core-docs/www/releasing-openacs.adp: * packages/acs-core-docs/www/releasing-package.adp: * packages/acs-core-docs/www/remote-postgres.adp: * packages/acs-core-docs/www/request-processor.adp: * packages/acs-core-docs/www/requirements-template.adp: * packages/acs-core-docs/www/rp-design.adp: * packages/acs-core-docs/www/rp-requirements.adp: * packages/acs-core-docs/www/security-design.adp: * packages/acs-core-docs/www/security-notes.adp: * packages/acs-core-docs/www/security-requirements.adp: * packages/acs-core-docs/www/snapshot-backup.adp: * packages/acs-core-docs/www/style-guide.adp: * packages/acs-core-docs/www/subsites-design.adp: * packages/acs-core-docs/www/subsites-requirements.adp: * packages/acs-core-docs/www/subsites.adp: * packages/acs-core-docs/www/tcl-doc.adp: * packages/acs-core-docs/www/templates.adp: * packages/acs-core-docs/www/tutorial-admin-pages.adp: * packages/acs-core-docs/www/tutorial-advanced.adp: * packages/acs-core-docs/www/tutorial-caching.adp: * packages/acs-core-docs/www/tutorial-categories.adp: * packages/acs-core-docs/www/tutorial-comments.adp: * packages/acs-core-docs/www/tutorial-css-layout.adp: * packages/acs-core-docs/www/tutorial-cvs.adp: * packages/acs-core-docs/www/tutorial-database.adp: * packages/acs-core-docs/www/tutorial-debug.adp: * packages/acs-core-docs/www/tutorial-distribute.adp: * packages/acs-core-docs/www/tutorial-etp-templates.adp: * packages/acs-core-docs/www/tutorial-future-topics.adp: * packages/acs-core-docs/www/tutorial-hierarchical.adp: * packages/acs-core-docs/www/tutorial-html-email.adp: * packages/acs-core-docs/www/tutorial-newpackage.adp: * packages/acs-core-docs/www/tutorial-notifications.adp: * packages/acs-core-docs/www/tutorial-pages.adp: * packages/acs-core-docs/www/tutorial-parameters.adp: * packages/acs-core-docs/www/tutorial-schedule-procs.adp: * packages/acs-core-docs/www/tutorial-second-database.adp: * packages/acs-core-docs/www/tutorial-specs.adp: * packages/acs-core-docs/www/tutorial-upgrade-scripts.adp: * packages/acs-core-docs/www/tutorial-upgrades.adp: * packages/acs-core-docs/www/tutorial-vuh.adp: * packages/acs-core-docs/www/tutorial-wysiwyg-editor.adp: * packages/acs-core-docs/www/tutorial.adp: * packages/acs-core-docs/www/unit-testing-guide/index.adp: * packages/acs-core-docs/www/unix-installation.adp: * packages/acs-core-docs/www/update-repository.adp: * packages/acs-core-docs/www/update-translations.adp: * packages/acs-core-docs/www/upgrade-4.5-to-4.6.adp: * packages/acs-core-docs/www/upgrade-4.6.3-to-5.adp: * packages/acs-core-docs/www/upgrade-5-0-dot.adp: * packages/acs-core-docs/www/upgrade-openacs-files.adp: * packages/acs-core-docs/www/upgrade-overview.adp: * packages/acs-core-docs/www/upgrade-supporting.adp: * packages/acs-core-docs/www/upgrade.adp: * packages/acs-core-docs/www/uptime.adp: * packages/acs-core-docs/www/variables.adp: * packages/acs-core-docs/www/win2k-installation.adp: fix link such it works without a redirect * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/import-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/syndicate-procs.tcl: * packages/xowiki/tcl/test/test-procs.tcl: * packages/xowiki/tcl/test/xowiki-link-test-procs.tcl: * packages/xowiki/tcl/weblog-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-uploader-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: * packages/xowiki/xowiki.info: make "instantiate_forms" a method of packages this reads better than the previous variant based on the Weblog class. * packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl: prefer name resolver over "my" call * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: use package based instantiate_forms method * packages/xowiki/resources/templates/view-book-no-ajax.tcl: * packages/xowiki/resources/templates/view-book.tcl: * packages/xowiki/tcl/category-procs.tcl: * packages/xowiki/tcl/menu-procs.tcl: * packages/xowiki/tcl/notification-procs.tcl: * packages/xowiki/tcl/test/test-procs.tcl: * packages/xowiki/tcl/upgrade/upgrade.tcl: * packages/xowiki/tcl/xowiki-callback-procs.tcl: * packages/xowiki/tcl/xowiki-init.tcl: * packages/xowiki/tcl/xowiki-mode-procs.tcl: * packages/xowiki/www/admin/delete-type.tcl: * packages/xowiki/www/admin/index.tcl: * packages/xowiki/www/ckeditor-images/delete.tcl: * packages/xowiki/www/xinha/insert-ilink.tcl: * packages/xowiki/www/xinha/insert-image.tcl: whitespace changes * packages/xotcl-core/tcl/10-recreation-procs.tcl: * packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl: * packages/xotcl-core/tcl/cluster-init.tcl: * packages/xotcl-core/tcl/cluster-procs.tcl: * packages/xotcl-core/tcl/http-client-procs.tcl: * packages/xotcl-core/tcl/install-check-procs.tcl: * packages/xotcl-core/tcl/test/xotcl-avail-procs.tcl: * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: * packages/xotcl-core/www/index.tcl: * packages/xotcl-core/www/show-class-graph.tcl: * packages/xotcl-core/www/version-numbers.tcl: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-includelet-procs.tcl: whitespace cleanup 2020-08-26 antoniop * packages/acs-content-repository/tcl/test/content-item-test-procs.tcl: Complete content::folder api coverage * packages/acs-content-repository/tcl/content-extlink-procs.tcl: Fix content::extlink::delete: this actually just means to delete the content item * packages/acs-content-repository/tcl/test/content-extlink-procs.tcl: Test public content::extlink api: this test will expose that content::extlink::delete is broken (wrong stored procedure called) * packages/acs-content-repository/tcl/test/content-item-test-procs.tcl: Whitespace cleanup 2020-08-25 antoniop * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Cleanup test message key * packages/acs-lang/acs-lang.info: * packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d12-5.10.0d13.sql: * packages/acs-lang/sql/postgresql/upgrade/upgrade-5.10.0d12-5.10.0d13.sql: Create index on the new lang_message_keys.object_id column * packages/acs-content-repository/tcl/filter-procs.tcl: Deprecate a proc broken since we have memory of it (~17 years) * packages/acs-content-repository/tcl/content-folder-procs.tcl: * packages/assessment/tcl/as-assessment-procs.tcl: Deprecate content::folder::get_folder_from_package as it assumes there will be one folder per package, not true in general Replace its only occurrence in the codebase with a local reimplementation (expecting the assessment package to comply with this restriction and not have more than 1 folder per package instance) * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Fix typo * packages/acs-content-repository/tcl/apm-callback-procs.tcl: Make apm callback private * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: New test checking that no leftover groups localizations are still there on the system * packages/acs-content-repository/tcl/content-permission-procs.tcl: Remove leftover public api: the underlying database api was obsolete and removed 5 years ago by git commit d91c99f522588a41bd8614ba815162a81940b08a * packages/acs-lang/acs-lang.info: * packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d13-5.10.0d14.sql: * packages/acs-lang/sql/postgresql/upgrade/upgrade-5.10.0d13-5.10.0d14.sql: Take also care to populate the newly created column with the group ids coming from automatically generated message keys * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: Test covering the automagical localization of group pretty names * packages/acs-content-repository/tcl/test/content-folder-test-procs.tcl: Whitespace cleanup * packages/acs-lang/acs-lang.info: * packages/acs-lang/sql/oracle/message-catalog.sql: * packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql: * packages/acs-lang/sql/postgresql/message-catalog.sql: * packages/acs-lang/sql/postgresql/upgrade/upgrade-5.10.0d11-5.10.0d12.sql: * packages/acs-lang/tcl/lang-message-procs.tcl: * packages/acs-lang/tcl/lang-message-procs.xql: * packages/acs-lang/tcl/lang-util-procs.tcl: * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/tcl/group-procs.tcl: acs-lang reform Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key. This is useful for groups that automatically define a message key for their pretty name. Tcl API was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN. Other future usages for this new feature might be the automatic localization of xowiki FormPage properties. 2020-08-24 hectorr * packages/evaluation-portlet/tcl/test/evaluation-portlet-procs.tcl: Add 'evaluation_admin_portlet::get_pretty_name', 'evaluation_assignments_portlet::get_pretty_name' and 'evaluation_evaluations_portlet::get_pretty_name' to the 'evaluation_portlet_links_names' test * packages/static-portlet/tcl/test/static-portlet-procs.tcl: Add 'static_portal_content::add_to_portal' 'static_portal_content::update' and 'static_portal_content::remove_all_from_portal' to the 'static_portal_content__procs' test * packages/dotlrn-assessment/tcl/test/dotlrn-assessment-test-procs.tcl: Add test case 'dotlrn_assessment__names' * packages/dotlrn-bm/tcl/test/dotlrn-bm-test-procs.tcl: Add test case 'dotlrn_bm__names' * packages/dotlrn-calendar/tcl/test/dotlrn-calendar-test-procs.tcl: Add test case 'dotlrn_calendar__names' * packages/dotlrn-chat/tcl/test/dotlrn-chat-test-procs.tcl: Add test case 'dotlrn_chat__names' * packages/dotlrn-dotlrn/tcl/test/dotlrn-dotlrn-test-procs.tcl: Add test case 'dotlrn_dotlrn__names' * packages/fs-portlet/tcl/test/fs-portlet-procs.tcl: Add test case 'fs_portlet__names' * packages/static-portlet/tcl/test/static-portlet-procs.tcl: Add test case 'static_portal_content__procs' * packages/static-portlet/tcl/static-portal-content-procs.tcl: Fix query name, detected by 'static_portal_content__procs' test case * packages/new-portal/tcl/portal-procs.tcl: Fix typo * packages/dotlrn-bm/tcl/dotlrn-bm-procs.tcl: Set 'dotlrn-bm' procs without current implementation to private * packages/dotlrn-chat/tcl/dotlrn-chat-procs.tcl: Set 'dotlrn-chat' procs without current implementation to private * packages/dotlrn-dotlrn/tcl/dotlrn-dotlrn-procs.tcl: * packages/dotlrn-dotlrn/tcl/dotlrn-members-procs.tcl: * packages/dotlrn-dotlrn/tcl/dotlrn-members-staff-procs.tcl: Set 'dotlrn-dotlrn' procs without current implementation to private * packages/dotlrn-evaluation/tcl/dotlrn-evaluation-procs.tcl: Set 'dotlrn-evaluation' procs without current implementation to private * packages/dotlrn-faq/tcl/dotlrn-faq-procs.tcl: Set 'dotlrn-faq' procs without current implementation to private * packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl: Set 'dotlrn-forums' procs without current implementation to private * packages/dotlrn-homework/tcl/dotlrn-homework-applet-procs.tcl: * packages/dotlrn-homework/tcl/dotlrn-homework-notifications.tcl: Set 'dotlrn-homework' procs without current implementation to private * packages/dotlrn-static/tcl/dotlrn-static-procs.tcl: Set 'dotlrn-static' procs without current implementation to private * packages/dotlrn-assessment/tcl/dotlrn-assessment-procs.tcl: * packages/dotlrn-bm/tcl/dotlrn-bm-procs.tcl: * packages/dotlrn-chat/tcl/dotlrn-chat-procs.tcl: * packages/dotlrn-dotlrn/tcl/dotlrn-members-staff-procs.tcl: * packages/dotlrn-evaluation/tcl/dotlrn-evaluation-procs.tcl: * packages/dotlrn-faq/tcl/dotlrn-faq-procs.tcl: * packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl: * packages/dotlrn-homework/tcl/dotlrn-homework-applet-procs.tcl: * packages/dotlrn-homework/tcl/dotlrn-homework-portlet-procs.tcl: * packages/dotlrn-homework/tcl/dotlrn-homework-procs.tcl: Whitespace changes 2020-08-24 gustafn * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: accept as page_ref for an object as well an item_id This change simplify resolving items. raw ids seem fine, since the listing are not persisted or moved between OpenACS instances. * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/test/openacs-kernel-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/xowiki/tcl/table-widget-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: improve comments * packages/xowiki/tcl/menu-procs.tcl: reduce usage of anonymous arrays 2020-08-23 gustafn * packages/acs-subsite/tcl/attribute-procs.xql: fix for issue #3445 a broken query (without a table alias) was in the .xql file, where the correct query was in the source (where it was ignored). This can be quite confusing. It is probably a good idea to improve code locality and use .xql just in cases, where the query is NOT included in the source. I took the opportunity to fix more such cases in this file. Many thanks to Tony Kirkham for the bug report. 2020-08-22 gustafn * packages/openacs-bootstrap3-theme/www/resources/js/jquery-1.11.3.min.js: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-1.12.3.min.js: remove obsolete files 2020-08-21 hectorr * packages/assessment-portlet/tcl/test/assessment-portlet-procs.tcl: Add 'assessment_admin_portlet::get_pretty_name' and 'assessment_portlet::get_pretty_name' to 'assessment_portlet_links_names' test case * packages/calendar-portlet/tcl/test/calendar-portlet-procs.tcl: Add 'calendar_admin_portlet::get_pretty_name' and 'calendar_list_portlet::get_pretty_name' to 'calendar_portlet_links_names' test case * packages/chat-portlet/tcl/test/chat-portlet-procs.tcl: Add 'chat_admin_portlet::get_pretty_name' and 'chat_portlet::get_pretty_name' to 'chat_portlet_links_names' test case * packages/dotlrn-forums/tcl/test/dotlrn-forums-test-procs.tcl: Add 'dotlrn_forums::get_pretty_name' and 'dotlrn_forums_admin_portlet::get_pretty_name' to the 'dotlrn_forums_portlet_links_names' test * packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl: Add 'dotlrn_homework_admin_portlet::get_pretty_name', 'dotlrn_homework_applet::get_pretty_name' and 'dotlrn_homework_portlet::get_pretty_name' to the 'dotlrn_homework_portlet_links_names' test * packages/dotlrn-portlet/tcl/test/dotlrn-portlet-procs.tcl: Add 'dotlrn_members_staff_portlet::get_pretty_name', 'dotlrn_members_portlet::get_pretty_name', 'dotlrn_admin_portlet::get_pretty_name' and 'dotlrn_admin_portlet::my_package_key' to 'dotlrn_portlet_links_names_keys' test case * packages/dotlrn-xowiki/tcl/test/xowiki-applet-procs.tcl: Add 'dotlrn_xowiki_names_keys' testcase, to test different _key and _name procs in 'dotlrn-xowiki' * packages/faq-portlet/tcl/test/faq-portlet-procs.tcl: Add 'faq_admin_portlet::get_pretty_name' and 'faq_portlet::get_pretty_name' to 'faq_portlet_links_names' test case * packages/forums-portlet/tcl/test/forums-portlet-procs.tcl: Add 'forums_admin_portlet::get_pretty_name' and 'forums_portlet::get_pretty_name' to 'forums_portlet_links_names' test case * packages/news-portlet/tcl/test/news-portlet-procs.tcl: Add 'news_admin_portlet::get_pretty_name' to 'news_portlet_links_names' test case * packages/static-portlet/tcl/test/static-portlet-procs.tcl: Add 'static_portlet::get_pretty_name' to the 'static_portlet_links_names' test * packages/dotlrn-forums/tcl/test/dotlrn-forums-test-procs.tcl: Add simple test for 'dotlrn_forums_admin_portlet::link' * packages/dotlrn-news/tcl/test/dotlrn-news-test-procs.tcl: Add test case 'dotlrn_news__names' * packages/dotlrn-evaluation/tcl/test/dotlrn-evaluation-test-procs.tcl: Add test for 'dotlrn_evaluation::get_pretty_name' * packages/dotlrn-faq/tcl/test/dotlrn-faq-test-procs.tcl: Add test for 'dotlrn_faq::get_pretty_name' * packages/dotlrn-fs/tcl/test/dotlrn-fs-procs.tcl: Add test for 'dotlrn_fs::get_pretty_name' * packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl: Add test for 'dotlrn_homework::get_file_storage_url' * packages/theme-zen/tcl/apm-callback-procs.tcl: Fix typo * packages/dotlrn-news/tcl/dotlrn-news-procs.tcl: Set 'dotlrn-news' procs without current implementation to private * packages/dotlrn-xowiki/tcl/xowiki-applet-procs.tcl: Set 'dotlrn-xowiki' procs without a current implementation to private, for the time being * packages/dotlrn-bootstrap3-theme/tcl/apm-callback-procs.tcl: * packages/openacs-bootstrap3-theme/tcl/apm-callback-procs.tcl: * packages/openacs-default-theme/tcl/apm-callback-procs.tcl: Set theme install/uninstall/uninstantiate callbacks as private * packages/dotlrn-xowiki/tcl/xowiki-applet-procs.tcl: Use '@return' instead of 'return' in proc doc, and 'ad_proc' instead of proc for 'applet_key' and 'my_package_key' procs * packages/dotlrn-bootstrap3-theme/tcl/apm-callback-procs.tcl: * packages/dotlrn-news/tcl/dotlrn-news-procs.tcl: Whitespace changes 2020-08-21 gustafn * packages/xowiki/tcl/includelet-procs.tcl: fix broken variable reference (pg changed?) 2020-08-21 antoniop * packages/proctoring-support/www/examination-statement-export.adp: * packages/proctoring-support/www/examination-statement-export.tcl: Add trivial web-accessible page using examination-statement-export include, enforcing admin permissions on the proctored object, so that packages do not have to create their own * packages/proctoring-support/lib/examination-statement-export.tcl: Get rid of tmpfile * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Update message keys from downstream, bump version number to reflect new exam statement export feature 2020-08-20 hectorr * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: Add 'nullchar' test, which uncovers a bug transmitting the null character to postgres. Many thanks to Nathan Coulter for finding out and creating the test as well. * packages/acs-automated-testing/www/resources/tests.css: Improve contrast and readability on proc coverage cells * packages/ref-timezones/ref-timezones.info: * packages/ref-timezones/tcl/apm-callback-procs.tcl: Rename and set to private callback. * packages/evaluation-portlet/tcl/apm-callback-procs.tcl: Set install/uninstall callbacks to private * packages/theme-zen/tcl/apm-callback-procs.tcl: Set install/upgrade/uninstall callbacks to private * packages/ref-countries/tcl/apm-callback-procs.tcl: * packages/ref-countries/tcl/ref-countries-procs.tcl: * packages/ref-timezones/tcl/apm-callback-procs.tcl: * packages/theme-zen/tcl/apm-callback-procs.tcl: Whitespace changes * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: Whitespace changes + editor hints 2020-08-20 gustafn * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: Use full URL paths for bulk actions. This change allows one to mark items from multiple child-resources displayed on one page and add these to the clipboard. Use the same logic for bluk-delete and bulk adding to the clipboard. * packages/xowiki/tcl/table-widget-procs.tcl: avoid warning for "hidden" table widget columns, used e.g. for sorting * packages/acs-subsite/www/resources/core.js: fix cleanup typo * packages/acs-tcl/tcl/request-processor-procs.tcl: fix typo * packages/acs-subsite/www/resources/core.js: flag that submission is coming via ajax * packages/acs-tcl/tcl/tcltrace-init.tcl: * packages/acs-tcl/tcl/tcltrace-procs.tcl: make debug output more compact (shorten long arguments, remove line-breaks) * packages/acs-subsite/www/resources/core.js: new function: acs_ListBulkActionMultiFormClick() // // The function acs_ListBulkActionMultiFormClick() is similar to // acs_ListBulkActionClick() but it iterates over all forms with the // same name and submits the input elements of all such forms. // * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: replace array by dict * packages/acs-subsite/www/resources/core.js: whitespace changes * packages/xowiki/tcl/xowiki-www-procs.tcl: www-clipboard-add: allow object to be fully qualified old conventions continue to work 2020-08-20 antoniop * packages/proctoring-support/lib/examination-statement-export.tcl: Port examination statement acceptance csv export include to upstream 2020-08-19 hectorr * packages/dotlrn-dotlrn/tcl/test/dotlrn-dotlrn-test-procs.tcl: Add 'dotlrn_members' and 'dotlrn_members_staff' keys to 'dotlrn_dotlrn__keys' testcase * packages/acs-datetime/tcl/test/acs-datetime-procs.tcl: Add 'dt_localized_procs' testcase, for 'acs-datetime' procs that return localized results: 'dt_month_names', 'dt_month_abbrev', 'dt_ansi_to_pretty', 'dt_prev_month_name' and 'dt_next_month_name' * packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl: Add simple test cases for link and key procs in 'dotlrn-homework' * packages/assessment-portlet/tcl/test/assessment-portlet-procs.tcl: Add simple test cases for link procs in 'assessment-portlet' * packages/calendar-portlet/tcl/test/calendar-portlet-procs.tcl: Add simple test cases for link procs in 'calendar-portlet' * packages/chat-portlet/tcl/test/chat-portlet-procs.tcl: Add simple test cases for link procs in 'chat-portlet' * packages/dotlrn-portlet/tcl/test/dotlrn-portlet-procs.tcl: Add simple test cases for link procs in 'dotlrn-portlet' * packages/evaluation-portlet/tcl/test/evaluation-portlet-procs.tcl: Add simple test cases for link procs in 'evaluation-portlet' * packages/faq-portlet/tcl/test/faq-portlet-procs.tcl: Add simple test cases for link procs in 'faq-portlet' * packages/forums-portlet/tcl/test/forums-portlet-procs.tcl: Add simple test cases for link procs in 'forums-portlet' * packages/fs-portlet/tcl/test/fs-portlet-procs.tcl: Add simple test cases for link procs in 'fs-portlet' * packages/news-portlet/tcl/test/news-portlet-procs.tcl: Add simple test cases for link procs in 'news-portlet' * packages/static-portlet/tcl/test/static-portlet-procs.tcl: Add simple test cases for link procs in 'static-portlet' * packages/acs-datetime/tcl/test/acs-datetime-procs.tcl: Add testcase for 'dt_first_day_of_month' * packages/acs-datetime/tcl/test/acs-datetime-procs.tcl: Add testcase for 'dt_interval_check' * packages/acs-datetime/tcl/acs-datetime-procs.tcl: Fix discrepancies between proc doc and implementation * packages/calendar-portlet/tcl/test/calendar-portlet-procs.tcl: Remove duplicated code * packages/acs-datetime/tcl/acs-datetime-procs.tcl: Trim month numbers on 'dt_prev_month_name' and 'dt_next_month_name' to avoid octal misinterpretation. Fixes 'dt_localized_procs' testcase * packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl: * packages/evaluation-portlet/tcl/test/evaluation-portlet-procs.tcl: Whitespace changes 2020-08-19 antoniop * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-form-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: Make ::xowiki::Package default_locale react to changes in the connection locale by caching only when the parameter use_connection_locale is not set, use ::xowiki::Package default_locale result instead of always the connection locale to determine nls_language for new Pages and FormPages, so that default language for a particular xowiki instance is decided by use_connection_locale parameter * packages/xowiki/tcl/package-procs.tcl: Make :folder_id available as a package instance variable immediately, in a way that if the folder instantiation needs e.g. to fetch a parameter, the folder_id will be there to determine the right parameter page, which otherwise would be looked up e.g. in the site-wide pages and cached with wrong values for the cache lifetime * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Use parameterical system name in english message keys as well, left out for some reason... 2020-08-18 hectorr * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: Avoid testing all site nodes on 'site_node_get_children', if the number of them is too large, as it can take too long * packages/acs-datetime/tcl/test/acs-datetime-procs.tcl: Increase test coverage of 'acs-datetime' by adding tests for 'dt_sysdate', 'dt_systime', 'dt_prev_month' and 'dt_next_month' * packages/acs-datetime/tcl/test/acs-datetime-procs.tcl: Refactor tests in 'acs-datetime' package * packages/acs-datetime/tcl/acs-datetime-procs.tcl: Trim month numbers on 'dt_prev_month' and 'dt_next_month' to avoid octal misinterpretation. Fixes 'dt_prev_next_month' testcase 2020-08-18 antoniop * packages/proctoring-support/www/resources/proctoring.js: Increase the threshold to trigger volume too low message from experience in the wild, reset the counter for the grace period, so that user does not receive immediately a new error * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Replace leftover double quotes... * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/proctoring-support.info: * packages/proctoring-support/www/resources/proctored-page.js: Update new message keys from downstream, make system name come from parameter, reactivate volume too low error message 2020-08-14 hectorr * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: Set some tests as 'production_safe' 2020-08-14 gustafn * packages/xowf/tcl/test-item-procs.tcl: drop line commented out * packages/xowiki/tcl/chat-procs.tcl: reduce number of locks when NaviServer is used * packages/xowf/www/prototypes/index.page: specify field names explicitly in default xowf index page (maybe move this to site-wide pages) 2020-08-13 hectorr * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Fix var name * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Make 'aa_log_result' return gracely if called outside a test. 2020-08-13 gustafn * packages/xotcl-core/tcl/06-package-procs.tcl: form_unify: use switch instead of boolean flag; iterate over single forms * packages/xotcl-core/tcl/06-package-procs.tcl: form_usages: add revisions and full path to output * packages/xowf/tcl/xowf-procs.tcl: * packages/xowiki/tcl/form-field-procs.tcl: improve debugging messages * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/test/test-procs.tcl: * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: improve wording * packages/xowf/tcl/test-item-procs.tcl: provide compatibility for legacy mc_interaction * packages/xowf/tcl/xowf-form-field-procs.tcl: whitespace changes and typo 2020-08-13 antoniop * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/www/resources/proctored-page.js: Bring together the thresholds in black picture checks to one value * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Make so that the proctoring folder can be assumed existing when retrieved, update automated tests * packages/xowf/tcl/test-item-procs.tcl: Reduce red in acs-tcl.documentation__check_proc_doc automated test * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Refine test again so that no folder is created where real objects are supposed to be * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Refine test so it cleans after itself * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Remove LEARN references from message keys This change should be merged upstream so that the old ones are not overridden! 2020-08-12 hectorr * packages/acs-mail-lite/acs-mail-lite.info: * packages/acs-mail-lite/sql/postgresql/acs-mail-lite-create.sql: * packages/acs-mail-lite/sql/postgresql/acs-mail-lite-drop.sql: * packages/acs-mail-lite/sql/postgresql/upgrade/upgrade-5.10.0d10-5.10.0d11.sql: Drop duplicate index 'acs_mail_lite_from_external_aml_email_id_idx'. Postgres creates automatically indexes for unique constraints and primary keys, this index duplicates 'acs_mail_lite_from_external_pkey' * packages/acs-mail-lite/acs-mail-lite.info: * packages/acs-mail-lite/sql/postgresql/acs-mail-lite-create.sql: * packages/acs-mail-lite/sql/postgresql/acs-mail-lite-drop.sql: * packages/acs-mail-lite/sql/postgresql/upgrade/upgrade-5.10.0d9-5.10.0d10.sql: Drop duplicate index 'acs_mail_lite_send_msg_id_map_msg_id_idx'. Postgres creates automatically indexes for unique constraints and primary keys, this index duplicates 'acs_mail_lite_send_msg_id_map_pkey' * packages/acs-mail-lite/sql/postgresql/upgrade/upgrade-5.10.0d9-5.10.0d10.sql: Fix typo in description * packages/acs-mail-lite/sql/postgresql/acs-mail-lite-create.sql: * packages/acs-mail-lite/sql/postgresql/acs-mail-lite-drop.sql: Whitespace changes 2020-08-12 gustafn * packages/xotcl-core/tcl/06-package-procs.tcl: use the same defaults for the "-forms" switch in form_usages and form_unify 2020-08-12 antoniop * packages/general-comments/tcl/test/general-comments-procs.tcl: Complete api coverage for general-comments * packages/xowf/tcl/test-item-procs.tcl: Reduce red in acs-tcl.documentation__check_proc_doc automated test * packages/dotlrn/tcl/test/community-procs.tcl: Rework communities_security_inherit test: just check for existence, no need for a loop, no need to rollback anything * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: Treat callback hooks and implementations as private api * packages/dotlrn/tcl/test/community-procs.tcl: Turn the phrase around, as in other tests * packages/news/tcl/news-apm-callback-procs.tcl: Whitespace changes * packages/acs-datetime/tcl/test/acs-datetime-procs.tcl: * packages/dotlrn/tcl/test/community-procs.tcl: Whitespace cleanup * packages/news/tcl/news-callback-procs.tcl: Whitespace cleanup, normalize indentation 2020-08-11 gustafn * packages/xowiki/tcl/includelet-procs.tcl: add modification_date as default hidden field for sorting of form-usages * packages/acs-admin/www/apm/version-files.tcl: * packages/acs-admin/www/users/one.tcl: * packages/acs-automated-testing/www/admin/record-test.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xowiki/tcl/syndicate-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/www/portlets/weblog-mini-calendar.tcl: improve spelling * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: move "unify_forms" to xotcl-core, rename it to "form_unify", added "form_usages" * packages/xowiki/tcl/table-widget-procs.tcl: provide better warning message 2020-08-11 antoniop * packages/proctoring-support/proctoring-support.info: Add leftover info file to package * packages/proctoring-support/tcl/test/proctoring-test-procs.tcl: Automated tests for proctoring api * packages/general-comments/tcl/test/general-comments-procs.tcl: Cover some more api * packages/xowiki/tcl/import-procs.tcl: Don't assume save_new will return an item_id, object should come out of it "already baked" * packages/forums/tcl/messages-procs.tcl: * packages/proctoring-support/lib/proctoring-upload.tcl: * packages/proctoring-support/tcl/proctoring-procs.tcl: Fix typo * packages/proctoring-support/lib/proctoring-upload.tcl: Fix typo again * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/proctoring-support.info: Improve localization * packages/proctoring-support/lib/proctoring-enforce.adp: * packages/proctoring-support/lib/proctoring-enforce.tcl: Porting of proctoring-enforce include, which can be used to forcefully redirect users to the proctored URL whenever they enter a certain area of the website (e.g. a subsite) in a captive-portal fashion * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/www/resources/proctored-page.js: Remove unneeded error message * packages/general-comments/tcl/test/general-comments-procs.tcl: Start testing general comments 2020-08-10 antoniop * packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml: * packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml: * packages/proctoring-support/lib/examination-statement-accept.tcl: * packages/proctoring-support/lib/proctored-page.adp: * packages/proctoring-support/lib/proctored-page.tcl: * packages/proctoring-support/lib/proctoring-upload.tcl: * packages/proctoring-support/sql/postgresql/proctoring-support-create.sql: * packages/proctoring-support/sql/postgresql/proctoring-support-drop.sql: * packages/proctoring-support/tcl/proctoring-procs.tcl: * packages/proctoring-support/www/examination-statement-accept.adp: * packages/proctoring-support/www/examination-statement-accept.tcl: * packages/proctoring-support/www/resources/audiowave.js: * packages/proctoring-support/www/resources/gif.js: * packages/proctoring-support/www/resources/gif.js.map: * packages/proctoring-support/www/resources/gif.worker.js: * packages/proctoring-support/www/resources/gif.worker.js.map: * packages/proctoring-support/www/resources/proctored-page.css: * packages/proctoring-support/www/resources/proctored-page.js: * packages/proctoring-support/www/resources/proctoring.js: * packages/proctoring-support/www/upload.adp: * packages/proctoring-support/www/upload.tcl: An own package for proctoring support. What is there - adp includes implementing the main proctoring user interaction: desired page can be enclosed in an iframe that will send shaphots taken from browser's camera and microphone at random intervals. Various options can be specified, including custom UI messages and the include can be integrated in custom pages or as part xowiki/xowf object methods - wizard-based step-by-step configuration of user's setup - english and german localization - default proctoring upload endpoints upon package mount - configuration data-model and API What is missing - reporting UI includes (porting from downstream should come shortly) - some message key is WU specific (but can be customized) - further parameters/customization - ... 2020-08-08 gustafn * packages/acs-subsite/lib/user-new.tcl: * packages/acs-subsite/tcl/package-procs.tcl: * packages/acs-tcl/tcl/memoize-procs-aolserver.tcl: * packages/acs-tcl/tcl/memoize-procs-naviserver.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/test/html-conversion-procs.tcl: * packages/acs-tcl/tcl/test/test-permissions-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/assessment/tcl/as-qti-procs.tcl: * packages/assessment/tcl/test/as-assessment-procs.tcl: * packages/forums/tcl/messages-procs.tcl: * packages/forums/www/user-history.tcl: * packages/news/www/doc/requirements.adp: * packages/news/www/doc/requirements.html: * packages/openacs-bootstrap3-theme/resources/templates/packages/acs-subsite/lib/login.tcl: * packages/openacs-bootstrap3-theme/tcl/init-procs.tcl: * packages/xotcl-core/tcl/03-doc-procs.tcl: * packages/xotcl-core/www/show-class-graph.tcl: * packages/xotcl-core/www/show-object.tcl: * packages/xowf/tcl/test/xowf-test-procs.tcl: * packages/xowiki-portlet/tcl/xowiki-admin-portlet-procs.tcl: * packages/xowiki/tcl/bootstrap-procs.tcl: * packages/xowiki/tcl/notification-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/www/admin/samples/ajax-chat.tcl: improve spelling 2020-08-07 gustafn * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: * packages/acs-lang/www/doc/i18n-requirements.adp: * packages/acs-lang/www/doc/i18n-requirements.html: * packages/xowiki/tcl/tree-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: improve spelling 2020-08-06 gustafn * packages/xotcl-core/tcl/05-db-procs.tcl: Provide fallback for easing upgrade form OpenACS 5.9.1 (or earlier) to 5.10 * packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml: * packages/acs-core-docs/www/xml/engineering-standards/eng-standards-versioning.xml: * packages/acs-core-docs/www/xml/for-everyone/acs-faq.xml: * packages/acs-core-docs/www/xml/kernel/ext-auth-design.xml: * packages/acs-core-docs/www/xml/kernel/ext-auth.xml: * packages/acs-core-docs/www/xml/kernel/i18n-requirements.xml: * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/ad-functional-procs.tcl: * packages/acs-tcl/tcl/deprecated-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/text-html-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/dotlrn/tcl/community-procs.tcl: improve spelling * packages/xotcl-core/tcl/http-client-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: improve wording * packages/acs-tcl/tcl/00-icanuse-procs.tcl: provide a hint to make potential upgrade problems more clear * packages/xowf/lib/proctored-page.tcl: * packages/xowiki/tcl/personal-notification-procs.tcl: * packages/xowiki/tcl/resource-info-procs.tcl: whitespace changes * packages/acs-tcl/tcl/admin-init.tcl: * packages/acs-tcl/tcl/cluster-init.tcl: * packages/acs-tcl/tcl/community-core-init.tcl: * packages/acs-tcl/tcl/tcltrace-init.tcl: * packages/acs-tcl/tcl/utilities-init.tcl: whitespace changes in *init files 2020-08-04 gustafn * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/personal-notification-procs.tcl: * packages/xowiki/xowiki.info: - added support for personal notifications (as used by inclass exam): The notification system has the following features: . lecturer can send individual messages to participants of an ongoing exam . message is sent by clicking on a participants name in the participant list . student can receive one or many notification messages . notification messages have to be confirmed, otherwise they are displayed always . non-confirmed notification messages are sticky, i.e. the are displayed also when a user changes to some other question. . three different urgency levels for messages . built around an includelet - bumped version number to 5.10.0d59 * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-includelet-procs.tcl: * packages/xowf/xowf.info: - integration of inclass-exam with personal notifications - new (comnposite) includelet "exam-top-includelet" - new www-calls for workflows: * inclass-exam.wf: . send-participant-message * inclass-exam-answer.wf: . message-poll . message-dismiss - bumped version number to 5.10.0d23 * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: added support call for unifying forms * packages/xotcl-request-monitor/www/whos-online.tcl: fix filtering logic * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/www/prototypes/ical.page: fix typo * packages/xowiki/tcl/package-procs.tcl: handle top-level and other forms as well * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/test/navigation-procs.tcl: * packages/acs-tcl/tcl/util-diff-procs.tcl: * packages/acs-tcl/tcl/xml-0-sgml-procs.tcl: * packages/acs-tcl/tcl/xml-2-procs.tcl: improve spelling * packages/xowiki/tcl/xowiki-utility-procs.tcl: variable constraint "integer" not supported in xotcl 2020-08-04 antoniop * packages/search/tcl/search-init.tcl: As the doc says, use the uncached version to retrieve the package instance 2020-08-03 trenner * packages/acs-subsite/www/admin/site-map/unmounted.tcl: provide scalable version for managing unmounted instances for pg12 2020-07-31 antoniop * packages/xowiki/tcl/resource-info-procs.tcl: * packages/xowiki/tcl/resource-init.tcl: * packages/xowiki/www/sitewide-admin/download.tcl: * packages/xowiki/www/sitewide-admin/index.tcl: Comply with acs-tcl.naming__proc_naming automated test 2020-07-30 antoniop * packages/chat/tcl/xotcl-chat-procs.tcl: Fix typo * packages/xotcl-core/tcl/01-debug-procs.tcl: Look for the truth * packages/calendar/calendar.info: * packages/calendar/tcl/apm-callback-procs.tcl: Port of downstream feature: cleanup properly everything related with a calendar package instance before deleting (e.g. calendar item types) This might be superseded by just plain referential integrity, taking care also of the oracle part, in a future moment * packages/bulk-mail/bulk-mail.info: * packages/bulk-mail/sql/oracle/bulk-mail-create.sql: * packages/bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d1-2.10.0d2.sql: * packages/bulk-mail/sql/postgresql/bulk-mail-create.sql: * packages/bulk-mail/sql/postgresql/upgrade/upgrade-2.10.0d1-2.10.0d2.sql: Redefine foreign keys as on delete cascade to avoid having callbacks around to delete bulk mail messages on package deletion 2020-07-29 hectorr * packages/acs-tcl/tcl/apm-install-procs.tcl: Avoid skipping datamodel scripts during initial installation * packages/acs-tcl/tcl/apm-install-procs.tcl: Skip upgrade attempts when the package is installed and disabled 2020-07-29 gustafn * packages/xowf/lib/edit-interaction.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/lib/online-exam.wf: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/www/prototypes/assessment-index.page: * packages/xowf/www/prototypes/edit-interaction.wf.page: * packages/xowf/www/prototypes/quiz-select_question.form.page: * packages/xowf/www/prototypes/select_question.form.page: Added edit-workflows for test items: edit-interaction.wf This change eases tailorization of actions of editing workflow and makes it possible to address all types of testitems via a single term -form en:edit-interaction.wf instead of having to enumerate the relevant types explicitly as it was before -form en:TestItemText.form|en:TestItemShortText.form|en:TestItemMC. form|en:TestItemSC.form|... For backward compatibility, the old enumeration is kept for a while. New test items should be created over the new workflow, as e.g. in {entry -name New.Item.TextInteraction -form en:edit-interaction.wf -query p.item_type=Text} * packages/xowiki/tcl/resource-info-procs.tcl: * packages/xowiki/tcl/resource-init.tcl: * packages/xowiki/www/sitewide-admin/download.tcl: * packages/xowiki/www/sitewide-admin/index.adp: * packages/xowiki/www/sitewide-admin/index.tcl: Added sitewide-admin pages for downloading bootstrap-treeview This change makes it possible to use xowiki/xowf with the folder tree even when having no internet connection (i.e. also without CDN). * packages/xowiki/www/prototypes/folder.form.page: Improve tailorability of folder.form via _description field Similar to what's used on the wi-book site * packages/xowiki/tcl/folder-procs.tcl: added/improved debugging hooks * packages/xowf/lib/edit-interaction.wf: fix typo * packages/xowiki/tcl/xowiki-www-procs.tcl: improve log messages 2020-07-28 gustafn * packages/acs-tcl/tcl/http-client-procs.tcl: added support for SNI servers * packages/acs-tcl/tcl/deprecated-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: fix loading and Don't move non-deprectated proc to deprecated-procs * packages/acs-tcl/lib/check-installed.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: util::resources::download: fix handling of empty/multiple downloadURLs 2020-07-27 gustafn * packages/xowf/lib/proctored-page.adp: allo starting proctored exams even when there is no handler for examination_statement_url installed * packages/xotcl-core/tcl/cr-procs.tcl: improve comment * packages/xowf/lib/inclass-exam.wf: improve source-code documentation * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xotcl-core/xotcl-core.info: provide a helper to fix the package_id of site-wide pages which were moved to the global instance from some other package 2020-07-24 antoniop * packages/acs-admin/tcl/test/acs-admin-procs.tcl: Basic automated test for acs_admin::require_site_wide_subsite and acs_admin::require_site_wide_package * packages/acs-tcl/tcl/deprecated-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Move deprecated stuff in util-procs to deprecated-procs This has the advantage that their loading can be disabled in the settings * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: * packages/acs-tcl/tcl/deprecated-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Reduce acs-tcl.documentation__check_deprecated_see test warnings * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: Unset the right nsv in the test or leftover dummy proc names will make acs-tcl.naming__proc_naming test fail 2020-07-23 gustafn * packages/xotcl-core/tcl/01-debug-procs.tcl: Fix for earlier premeature escaped change * packages/acs-tcl/tcl/00-icanuse-procs.tcl: provdide "icanuse" support for "ns_ictl trace idle" 2020-07-22 hectorr * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d29-5.10.0d30.sql: Fix attribute datatype discrepancy * packages/dotlrn/www/admin/community-members-add-to-community.tcl: * packages/dotlrn/www/deregister.tcl: Whitespace changes 2020-07-22 antoniop * packages/xotcl-core/tcl/01-debug-procs.tcl: Comment debug code working only on latest Naviserver * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/acs-permissions-procs.tcl: Implement a flush method for ::acs::acs::LockfreeCache and use it to reimplement permission::permission_thread_cache_flush This fixes ad_proc_permission_grant_and_revoke test case * packages/acs-lang/tcl/locale-procs.tcl: Keep using ad_conn in lang::conn::timezone as set_get_timezone needs to simulate lack of connection and ad_conn allows one to override the "real" value * packages/acs-tcl/tcl/00-icanuse-procs.tcl: Provide doc for ns_dbquotelist when is tcl implemented as fallback (fixes documentation__check_proc_doc automated test) 2020-07-21 hectorr * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: Refactor 'locale_language_fallback' testcase, using 'aa_run_with_teardown' and preventing errors when the 'en_GB' locale is not enabled 2020-07-21 gustafn * packages/acs-authentication/tcl/password-procs.tcl: * packages/acs-lang/tcl/lang-message-procs.tcl: * packages/acs-lang/tcl/lang-util-procs.tcl: * packages/acs-lang/tcl/locale-procs.tcl: * packages/acs-lang/tcl/localization-procs.tcl: * packages/acs-subsite/tcl/application-group-procs.tcl: * packages/acs-subsite/tcl/package-procs.tcl: * packages/acs-subsite/tcl/rel-segments-procs.tcl: * packages/acs-subsite/tcl/subsite-procs.tcl: * packages/acs-tcl/tcl/membership-rel-procs.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl: * packages/forums/tcl/forums-callback-procs.tcl: * packages/forums/tcl/forums-sc-procs.tcl: * packages/forums/tcl/messages-procs.tcl: * packages/notifications/tcl/notification-procs.tcl: * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state * packages/acs-subsite/tcl/subsite-navigation-procs.tcl: * packages/acs-subsite/tcl/subsite-procs.tcl: * packages/acs-subsite/www/doc/image-doc.tcl: * packages/acs-subsite/www/shared/portrait-bits.tcl: * packages/file-storage/file-storage.info: * packages/file-storage/tcl/file-storage-dav-procs.tcl: * packages/file-storage/tcl/file-storage-procs.tcl: * packages/file-storage/www/copy.tcl: * packages/file-storage/www/download-zip.tcl: * packages/file-storage/www/file-add.tcl: * packages/file-storage/www/folder-add.tcl: * packages/file-storage/www/folder-chunk.tcl: * packages/file-storage/www/folder-zip-add.tcl: use "ad_file" as a means to avoid unexpected tilde substitution in filenames 2020-07-17 gustafn * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: generalize handling of langstrings this change updates yesterday's change with ml_title. It generalizes the code by introducing an instproc named "update_langstring_property" that generalizes setting of arbitrary "properties" based on a property "langstring" that contains a dict of attributes in multiple languages (which are part of the page, make it suitable also when the enduser cannot enter message keys). * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: move comments around and improve it * packages/xotcl-core/tcl/01-debug-procs.tcl: xo::broadcast: auto-cleanup for threads that disappeared 2020-07-16 trenner * packages/acs-subsite/www/admin/site-map/index-postgresql.xql: fix performance problem with pg12 by using permission_p_recursive_array 2020-07-16 gustafn * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/xotcl-core.info: added a flag "-keep_existing_objects" to "instantiate_objects" * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/xowiki.info: added the flag "-language_specific" to child-resources to support different content per folder for user with different language settings 2020-07-15 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/www/long-calls.adp: * packages/xotcl-request-monitor/www/long-calls.tcl: added pool to long-calls statistics (requires at least NaviServer 4.99.5, May 2013) * packages/xotcl-request-monitor/www/long-calls.adp: * packages/xotcl-request-monitor/www/long-calls.tcl: avoid double loading of bootstrap * packages/acs-tcl/tcl/apm-install-procs.tcl: ignore upgrade attempt for disabled package 2020-07-14 gustafn * packages/xowf/lib/proctored-page.adp: * packages/xowf/lib/proctored-page.tcl: * packages/xowf/lib/proctoring-upload.tcl: * packages/xowf/www/resources/proctoring/gif.js: * packages/xowf/www/resources/proctoring/gif.js.map: * packages/xowf/www/resources/proctoring/gif.worker.js: * packages/xowf/www/resources/proctoring/gif.worker.js.map: * packages/xowf/www/resources/proctoring/proctoring.js: add proctoring code as used by xowf * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xotcl-core/tcl/bgdelivery-procs.tcl: * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xotcl-core/tcl/install-check-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/www/long-calls.tcl: * packages/xotcl-request-monitor/xotcl-request-monitor.info: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/xowf.info: use "ad_file" as a means to avoid unexpected tilde substitution in filenames 2020-07-13 gustafn * packages/acs-bootstrap-installer/acs-bootstrap-installer.info: * packages/acs-bootstrap-installer/installer.tcl: * packages/acs-bootstrap-installer/installer/tcl/zz-postload.tcl: * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: * packages/acs-bootstrap-installer/tcl/20-db-bootstrap-procs.tcl: * packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl: * packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/acs-kernel-procs.tcl: * packages/acs-tcl/tcl/adp-parser-procs.tcl: * packages/acs-tcl/tcl/apm-file-procs.tcl: * packages/acs-tcl/tcl/apm-install-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/apm-xml-procs.tcl: * packages/acs-tcl/tcl/deprecated-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/json-procs.tcl: * packages/acs-tcl/tcl/pdf-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: * packages/acs-tcl/tcl/tcltrace-procs.tcl: * packages/acs-tcl/tcl/test/file-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/xowiki/resources/templates/oacs-view.adp: * packages/xowiki/resources/templates/oacs-view2.adp: * packages/xowiki/resources/templates/oacs-view3-bootstrap3.adp: * packages/xowiki/resources/templates/oacs-view3.adp: * packages/xowiki/resources/templates/view-book-no-ajax.adp: * packages/xowiki/resources/templates/view-book.adp: * packages/xowiki/resources/templates/view-default.adp: * packages/xowiki/resources/templates/view-links.adp: * packages/xowiki/resources/templates/view-plain-master.adp: * packages/xowiki/resources/templates/view-plain.adp: * packages/xowiki/tcl/adp-generator-procs.tcl: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/notification-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/resource-init.tcl: * packages/xowiki/tcl/upgrade/upgrade.tcl: * packages/xowiki/tcl/xowiki-form-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/tcl/yui-init.tcl: * packages/xowiki/www/admin/samples/ajax-chat.tcl: * packages/xowiki/www/ckeditor-images/upload_image.tcl: * packages/xowiki/www/portlets/include.tcl: * packages/xowiki/www/xinha/attach-file.tcl: * packages/xowiki/www/xinha/file-selector.tcl: * packages/xowiki/www/xinha/insert-file.tcl: * packages/xowiki/xowiki.info: introduced "ad_file" as a means to avoid unexpected tilde substitution in filenames 2020-07-11 gustafn * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: deprecate unused function 2020-07-10 gustafn * packages/xowf/tcl/xowf-procs.tcl: added a safety belt and a warning message, when someone tries to create a shared wf container on an object with no valid revision id * packages/xotcl-core/tcl/06-param-procs.tcl: reduce verbosity 2020-07-06 antoniop * packages/acs-templating/tcl/util-procs.tcl: Document current preferred idiom to quote database lists, without official deprecation, for the time being 2020-07-03 gustafn * packages/acs-content-repository/tcl/content-folder-procs.tcl: * packages/acs-content-repository/tcl/content-item-procs.tcl: * packages/acs-content-repository/tcl/content-procs.tcl: * packages/acs-content-repository/tcl/content-revision-procs.tcl: * packages/acs-content-repository/tcl/filter-procs.tcl: * packages/acs-content-repository/tcl/image-procs.tcl: * packages/acs-content-repository/tcl/publish-procs.tcl: * packages/acs-content-repository/tcl/revision-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/apm-file-procs.tcl: * packages/acs-tcl/tcl/apm-install-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/apm-xml-procs.tcl: * packages/acs-tcl/tcl/http-client-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: * packages/acs-tcl/tcl/test/memoizing-procs.tcl: * packages/acs-tcl/tcl/text-html-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/acs-tcl/tcl/widgets-procs.tcl: * packages/acs-tcl/tcl/xml-0-sgml-procs.tcl: * packages/acs-templating/tcl/acs-integration-procs.tcl: * packages/acs-templating/tcl/currency-procs.tcl: * packages/acs-templating/tcl/data-procs.tcl: * packages/acs-templating/tcl/date-procs.tcl: * packages/acs-templating/tcl/list-procs.tcl: * packages/acs-templating/tcl/parse-procs.tcl: * packages/acs-templating/tcl/util-procs.tcl: * packages/acs-templating/www/resources/xinha-nightly/plugins/OacsFs/popups/file-selector.tcl: * packages/acs-templating/www/scripts/xinha/attach-file.tcl: * packages/acs-templating/www/scripts/xinha/attach-image.tcl: * packages/acs-templating/www/scripts/xinha/file-selector.tcl: * packages/boomerang/tcl/boomerang-procs.tcl: * packages/calendar/www/doc/requirements.adp: * packages/calendar/www/doc/requirements.html: * packages/categories/www/doc/o.adp: * packages/categories/www/doc/o.html: * packages/chat/tcl/xotcl-chat-procs.tcl: * packages/chat/www/doc/requirements.html: * packages/cookie-consent/tcl/cookie-consent-procs.tcl: * packages/dotlrn/tcl/community-procs.tcl: * packages/dotlrn/www/admin/users-bulk-upload.adp: * packages/dotlrn/www/community-edit-2.tcl: * packages/dotlrn/www/community-edit.tcl: * packages/dotlrn/www/help/en/Files.adp: * packages/dotlrn/www/subcommunity-new.tcl: * packages/notifications/tcl/notification-procs.tcl: * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: * packages/richtext-xinha/www/resources/xinha-nightly/plugins/OacsFs/popups/file-selector.tcl: * packages/search/www/help/basics.html: improve spelling: move closer to the linux documentation recommendations * packages/acs-authentication/tcl/apm-callback-procs.tcl: * packages/acs-authentication/tcl/authentication-procs.tcl: * packages/acs-authentication/tcl/sync-procs.tcl: * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: * packages/acs-authentication/tcl/test/sync-test-procs.tcl: * packages/acs-authentication/www/doc/ext-auth-pam-install.adp: * packages/acs-authentication/www/doc/ext-auth-pam-install.html: * packages/acs-developer-support/lib/toolbar.adp: * packages/acs-lang/tcl/lang-catalog-procs.tcl: * packages/acs-lang/tcl/localization-procs.tcl: * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: * packages/acs-lang/www/admin/export-locale-to-files.tcl: * packages/acs-lang/www/admin/import-locale-from-files.tcl: * packages/acs-lang/www/doc/i18n-design.adp: * packages/acs-lang/www/doc/i18n-design.html: * packages/acs-lang/www/doc/i18n-requirements.adp: * packages/acs-lang/www/doc/i18n-requirements.html: * packages/acs-mail-lite/tcl/acs-mail-lite-callback-procs.tcl: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: * packages/acs-mail-lite/tcl/email-inbound-procs.tcl: * packages/acs-mail-lite/tcl/legacy-inbound-procs.tcl: * packages/acs-mail-lite/www/doc/incoming-email-legacy-notes.adp: mprove spelling: move closer to the linux documentation recommendations * packages/acs-admin/www/apm/package-add.tcl: * packages/acs-admin/www/apm/version-files.tcl: * packages/acs-admin/www/apm/version-view.tcl: * packages/acs-admin/www/install/index.adp: * packages/acs-admin/www/install/install-3.tcl: * packages/acs-admin/www/install/install-4.tcl: * packages/acs-admin/www/install/install.adp: * packages/acs-admin/www/install/install.tcl: * packages/acs-admin/www/users/member-state-change.tcl: * packages/acs-subsite/tcl/attribute-procs.tcl: * packages/acs-subsite/tcl/group-procs.tcl: * packages/acs-subsite/tcl/package-procs.tcl: * packages/acs-subsite/tcl/plsql-utility-procs.tcl: * packages/acs-subsite/tcl/subsite-procs.tcl: * packages/acs-subsite/www/admin/site-map/new.tcl: * packages/acs-subsite/www/admin/users/new.tcl: * packages/acs-subsite/www/pvt/alerts.tcl: * packages/new-portal/tcl/portal-procs.tcl: * packages/new-portal/www/render_styles/all_in_one/render-element.tcl: * packages/new-portal/www/render_styles/individual/render-element.tcl: mprove spelling: move closer to the linux documentation recommendations, standardize variable names 2020-07-02 gustafn * packages/acs-core-docs/www/xml/developers-guide/db-api.xml: * packages/acs-core-docs/www/xml/developers-guide/i18n.xml: * packages/acs-core-docs/www/xml/developers-guide/packages.xml: * packages/acs-core-docs/www/xml/developers-guide/permissions-tediously-explained.xml: * packages/acs-core-docs/www/xml/developers-guide/permissions.xml: * packages/acs-core-docs/www/xml/developers-guide/subsites.xml: * packages/acs-core-docs/www/xml/developers-guide/tutorial-debug.xml: * packages/acs-core-docs/www/xml/engineering-standards/requirements-template.xml: * packages/acs-core-docs/www/xml/for-everyone/release-notes.xml: * packages/acs-core-docs/www/xml/install-guide/configuring.xml: * packages/acs-core-docs/www/xml/install-guide/maintenance.xml: * packages/acs-core-docs/www/xml/install-guide/openacs.xml: * packages/acs-core-docs/www/xml/install-guide/oracle.xml: * packages/acs-core-docs/www/xml/install-guide/other-software.xml: * packages/acs-core-docs/www/xml/install-guide/recovery.xml: * packages/acs-core-docs/www/xml/install-guide/red-hat.xml: * packages/acs-core-docs/www/xml/install-guide/software.xml: * packages/acs-core-docs/www/xml/install-guide/upgrade.xml: * packages/acs-core-docs/www/xml/kernel/apm-design.xml: * packages/acs-core-docs/www/xml/kernel/apm-requirements.xml: * packages/acs-core-docs/www/xml/kernel/ext-auth-design.xml: * packages/acs-core-docs/www/xml/kernel/ext-auth.xml: * packages/acs-core-docs/www/xml/kernel/groups-requirements.xml: * packages/acs-core-docs/www/xml/kernel/i18n-requirements.xml: * packages/acs-core-docs/www/xml/kernel/object-system-design.xml: * packages/acs-core-docs/www/xml/kernel/object-system-req.xml: * packages/acs-core-docs/www/xml/kernel/rp-design.xml: * packages/acs-core-docs/www/xml/kernel/security-design.xml: * packages/acs-core-docs/www/xml/releasing-openacs.xml: * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/bgdelivery-procs.tcl: * packages/xotcl-core/tcl/generic-procs.tcl: * packages/xotcl-core/tcl/http-client-procs.tcl: * packages/xotcl-core/tcl/ical-procs.tcl: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: improve spelling: move closer to the linux documentation recommendations 2020-07-01 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: add more query details to logged query * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: fix typos * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/atjob-procs.tcl: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/test/xowf-test-procs.tcl: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/test/check-method-procs.tcl: * packages/xowiki/tcl/test/test-procs.tcl: * packages/xowiki/tcl/test/xowiki-test-procs.tcl: * packages/xowiki/tcl/xowiki-form-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-uploader-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/www/admin/import.tcl: * packages/xowiki/www/ckeditor-images/upload_image.tcl: * packages/xowiki/www/xinha/attach-file.tcl: * packages/xowiki/www/xinha/file-selector.tcl: * packages/xowiki/www/xinha/insert-file.tcl: improve spelling 2020-06-29 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: whitespace changes * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: whitespce changes 2020-06-20 gustafn * packages/acs-tcl/tcl/security-procs.tcl: fine tuing for ad_log vs ns_log * packages/acs-tcl/tcl/security-procs.tcl: report peeraddr and URL in warning, add comment 2020-06-18 hectorr * packages/assessment/tcl/as-checks-procs.tcl: Whitespace changes 2020-06-18 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: add entries to longcalls as well when filtertime > 1s, or queuetime > 0.5s * packages/xowf/lib/inclass-exam.wf: fix editing bug (many thanks to georg krommer for reporting and thomas renner for fixing it) * packages/acs-lang/tcl/lang-util-procs.tcl: improve error message 2020-06-17 gustafn * packages/xowf/tcl/xowf-procs.tcl: added atjob-form to site-wide pages of xowf * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/prototypes/select_question.form.page: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: added support for inclass-exam for scheduled opening and closing of exams * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: added time_span form field (based on HTML5) bumped version to 5.10.0d57 * packages/acs-lang/tcl/lang-message-procs.tcl: avoid repeated lookup for the same locale * packages/xowiki/tcl/test/check-method-procs.tcl: fixed test (nsv entries do not strt with leading ::) simplified filtering * packages/xowf/tcl/atjob-procs.tcl: make sure, every job has an xo::cc defined * packages/xowiki/tcl/package-procs.tcl: perform lookup for site-wide-pages along the inheritance path of the package class * packages/acs-lang/tcl/lang-util-procs.tcl: provide a more friendly error message for broken configurations * packages/xowf/tcl/xowf-procs.tcl: provide method "util_user_message" to be able to use util_user_message also in background jobs * packages/acs-lang/www/admin/index.tcl: remove quotes from quoted vars 2020-06-17 antoniop * packages/assessment/tcl/as-checks-procs.tcl: Comment out seemingly useless computation which has been detected running > 18s in some case on the live system * packages/assessment/tcl/as-checks-procs.tcl: Whitespace cleanup 2020-06-15 gustafn * packages/xotcl-core/tcl/01-debug-procs.tcl: undo a recent change and comment situation 2020-06-14 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/prototypes/select_question.form.page: add ability to use x out of y questions (when order randomization is used) * packages/xowf/tcl/xowf-init.tcl: make init-procs more robust in case of broken setups 2020-06-12 gustafn * packages/notifications/tcl/notification-email-procs.tcl: fix an at least 11 year old bug... not sure, why this was not discovered earlier 2020-06-11 gustafn * packages/xowf/www/resources/test-item.css: no need to limit the width of a form label in vertical forms 2020-06-10 hectorr * packages/xotcl-core/tcl/06-param-procs.tcl: Check existence when resetting package parameters. Many thanks to Markus Moser 2020-06-10 antoniop * packages/acs-tcl/tcl/utilities-procs.tcl: Reinstate check, add a note why 2020-06-09 gustafn * packages/xowiki/tcl/form-field-procs.tcl: add property to textara and text_fields to disallow cut&paste * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/prototypes/select_question.form.page: optionally disallow cut&paste in multi-line form fields 2020-06-09 gernst * packages/xotcl-core/tcl/06-param-procs.tcl: Remove unnecessary parameter 2020-06-08 gustafn * packages/xowf/lib/inclass-exam-answer.wf: disallow auto-save when exam is closed * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/www/resources/autosave-text.js: handle cases, where autosave was rejected * packages/xowf/tcl/test-item-procs.tcl: improve wording 2020-06-06 gustafn * packages/xotcl-core/tcl/06-param-procs.tcl: * packages/xotcl-core/xotcl-core.info: - based xo::parameter on nsv_dict when available - bumped version number to 5.10.0d31 * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/00-icanuse-procs.tcl: - icanuse: added nsv_dict - bumped version number to 5.10.0d37 * packages/acs-lang/acs-lang.info: * packages/acs-lang/tcl/lang-message-procs.tcl: - simplifying one more expression - bump version number to 5.10.0d11 * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: cleanup (generalize and simplify code) * packages/xotcl-core/tcl/06-param-procs.tcl: do not try to load site-wide parameters in xo::parameters * packages/acs-tcl/tcl/acs-cache-init.tcl: * packages/boomerang/tcl/boomerang-procs.tcl: fix typo * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: improve comments * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/test/html-conversion-procs.tcl: * packages/acs-tcl/tcl/test/naviserver-api-procs.tcl: improve comments and spelling * packages/acs-lang/tcl/lang-message-procs.tcl: reduced the number of mutex locks for message keys lookup by a factor of two by using naviserver commands * packages/acs-tcl/tcl/utilities-init.tcl: remove unused mutex * packages/acs-templating/tcl/query-procs.tcl: remove unused nsv variables * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/lib/user-info.tcl: use "-varname" parameter for message_exists_p 2020-06-03 gustafn * packages/xowf/tcl/test-item-procs.tcl: countdown alarm: add audible alarm when the countdown timer reaches expiration. Per default, the audible alarm is turned off, but the user sees a mute symbol. When the user activates the audible alarm, the browser will announce the nearing end by beep signals in increasingly shorter periods before its expiration (default settings: 60, 30, 20, 10, 5, 2s; these values can be changed via HTML). Once a user has activated the audio signals, these are preseved between page changes via a cookie. On some browsers (e.g. Chrome), the audioContext settings are so restrictive, that the full reload requires a new activation of the alarm via a "user gesture" (i.e. clicking on the audio symbol). It would be not surprising, if some other browsers show different behavior, but the code follows the relatively new recommendations. The code was tested with Chrome/Chromium 83 and Firefox 77). * packages/xowf/www/resources/test-item.css: styling for count-down alarm 2020-06-03 antoniop * packages/acs-tcl/tcl/utilities-procs.tcl: Avoid useless check * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: Expose a regression after changes for bug #3437 * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: Extend test * packages/notifications/tcl/apm-callback-procs.tcl: Whitespace cleanup * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: ad_urlencode_url: add a slash to the path when this is not empty, fix test case 2020-06-02 gustafn * packages/xowf/tcl/test-item-procs.tcl: don't try to compute points from starred results * packages/xowf/tcl/test-item-procs.tcl: whitespace cleanup 2020-05-29 antoniop * packages/forums/tcl/messages-procs.tcl: Do not kill localization for moderator notifications, as they contain indeed message keys to be localized * packages/forums/tcl/messages-procs.tcl: Kill message key translation only when the original user message is included in the notification 2020-05-26 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: - fix remove_non_persistent_vars (ignored specified pattern) - update_attribute_from_slot: make sure the instance variable is also updated * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/www/resources/autosave-text.js: * packages/xowiki/www/resources/xowiki.css: - textarea: added attribute "autosave" - set autosave attributes in text_fields, when "multiple_lines" was specified. - remove for the time being "hkey" from "non_cached_instance_var_patterns", since this was recently fixed (TODO: check regression test and reactivate it later) - new Externally callable method: autosave-attribute: this is a simplified version of "save-attributes", but which does NOT perform input validation, which might be a problem in case of partial input - add "autosave-attribute" to all policies, where "save-attributes" was set 2020-05-25 hectorr * packages/xotcl-core/tcl/01-debug-procs.tcl: Fix regression in '::xo::system_stats' proc 'recordtimes' introduced during array to dict conversion. Name and tid of the thread were excluded from the 'i' dict, breaking the call to ':thread_classify' * packages/xotcl-core/tcl/01-debug-procs.tcl: Whitespace changes 2020-05-25 gustafn * packages/acs-content-repository/tcl/content-procs.tcl: Fix for plausible file checking in cr_delete_orphans The code checks for files, which are not conforming to the naming conventions, and intends to skip these. ... but a "continue" was missing. Many thanks to Franz Penz * packages/xowiki/tcl/test/xowiki-test-procs.tcl: add test cases for slot interactions * packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl: make test more robust against extending attributes * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: more more fix for issue #3441 As Keith reported, there is was one more issue concerning missing column_names and empty query results. This is now as well fixed in oacs-5-10. Also, the regression test was extended to handle these cases as well. * packages/xotcl-core/tcl/01-debug-procs.tcl: preserver slot, such that updating extended slots (e.g. "description") via update_attribute_from_slot works * packages/acs-tcl/tcl/request-processor-procs.tcl: provide better recovery from internal redirects, where ::ad_conn is not available 2020-05-25 antoniop * packages/xowiki/www/resources/streaming-chat.js: Status is actually a number 2020-05-23 gustafn * packages/acs-tcl/tcl/acs-cache-init.tcl: fix typo * packages/acs-bootstrap-installer/bootstrap.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: improve loading times and blueprint size, when acs-automated testing is deactivated For details, see: https://openacs.org/forums/message-view?message_id=5452350 * packages/acs-tcl/tcl/request-processor-procs.tcl: provide better handling of deactivated packages 2020-05-22 gustafn * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/www/admin/host-node-map/index.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/acs-cache-init.tcl: * packages/acs-tcl/tcl/security-procs.tcl: don't depend on the node-id cache, which is only available, when xotcl-core is loaded * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: fix for issue #3441 2020-05-22 antoniop * packages/xowiki/www/resources/streaming-chat.js: Do not try to reconnect upon client side errors (e.g. 403 forbidden responses when the chat room has been closed) 2020-05-21 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: make on/off logic less confusing 2020-05-20 gustafn * packages/acs-templating/www/doc/tagref/property.adp: * packages/acs-templating/www/doc/tagref/property.html: add missing documentation of the "adp" attribute of the "property" tag * packages/acs-templating/www/doc/TclDocs/content.html: * packages/acs-templating/www/doc/TclDocs/pagination.html: * packages/acs-templating/www/doc/tagref/property.adp: * packages/acs-templating/www/doc/tagref/property.html: * packages/acs-templating/www/doc/widgets/input.adp: * packages/acs-templating/www/doc/widgets/input.html: improve spelling 2020-05-19 gustafn * packages/acs-admin/acs-admin.info: * packages/acs-admin/tcl/site-wide-procs.tcl: * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/tcl/package-procs.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/acs-permissions-procs.tcl: * packages/acs-tcl/tcl/defs-procs.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: acs::per_request_cache: standardize per-request caching - added per-request cache verfsy similar to acs::per_thread_cache - use per-request-cache on several occasions - bump version number of acs-tcl to 5.10.0d35 * packages/chat/catalog/chat.en_US.ISO-8859-1.xml: add one more missing message key * packages/chat/catalog/chat.en_US.ISO-8859-1.xml: * packages/chat/chat.info: added missing message key, whitespace cleanup * packages/xowiki/tcl/includelet-procs.tcl: fix overquoting 2020-05-18 gustafn * packages/acs-lang/acs-lang.info: * packages/acs-lang/tcl/lang-util-procs.tcl: * packages/acs-lang/tcl/locale-procs.tcl: * packages/acs-lang/tcl/localization-procs.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/object-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/notifications/notifications.info: * packages/notifications/tcl/notification-type-procs.tcl: * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xotcl-core/xotcl-core.info: acs::per_thread_cache: standardize per-thread caching - added per-thread cache based on namespaced Tcl variables. - use per-thread-cache on several occasions - bump version number of acs-tcl to 5.10.0d34 * packages/acs-tcl/tcl/00-icanuse-procs.tcl: fix ugly typo * packages/openacs-bootstrap3-theme/tcl/init-procs.tcl: * packages/openacs-bootstrap3-theme/tcl/resource-init.tcl: improve handling with CDN and CSP * packages/acs-automated-testing/tcl/aa-test-procs.tcl: improve wording * packages/acs-mail-lite/acs-mail-lite.info: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: improve wording for package parameters * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: make minus sign optional again * packages/tsearch2-driver/tcl/tsearch2-driver-procs-postgresql.xql: remove spurious parens * packages/acs-lang/tcl/lang-util-procs.tcl: * packages/acs-lang/tcl/locale-procs.tcl: * packages/acs-lang/tcl/localization-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/apm-procs.tcl: * packages/acs-tcl/tcl/object-procs.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/notifications/tcl/notification-type-procs.tcl: * packages/xotcl-core/tcl/01-debug-procs.tcl: * packages/xotcl-core/tcl/06-package-procs.tcl: use dot instead of colon as separator between package name and cache key to ease readability 2020-05-17 gustafn * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: Make number checking more strict (allow just number literals, which are OK for Tcl and SQL) * packages/xowiki/tcl/package-procs.tcl: add documentation * packages/acs-tcl/tcl/security-procs.tcl: * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: fix typos * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: inclass-exam: report state durations on overview page (published, exam_review) 2020-05-13 gustafn * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: fix for issue #3437, extend regression test * packages/acs-admin/tcl/apm-admin-procs.tcl: * packages/acs-admin/tcl/site-wide-procs.tcl: * packages/acs-admin/www/apm/packages-install.tcl: improve acs-admin//apm/packages-install - use usual user interaction for select/unselect all - add proper handling of no upgrades - improve HTML markup - improve code orthogonality * packages/acs-tcl/tcl/apm-procs.tcl: improve wording * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/www/admin/host-node-map/index.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/security-procs.tcl: move ad_get_host_node_map and security-locations-host-names from db_cache_pool to partitioned cache * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: move code pieces around to centralize concerns * packages/acs-tcl/tcl/acs-cache-procs.tcl: no need to provide separate hash method, which hinders actually for the hashkey partitioned cache 2020-05-13 antoniop * packages/forums/forums.info: * packages/forums/tcl/forums-install-procs.tcl: * packages/forums/tcl/messages-procs.tcl: * packages/forums/www/forum-view.adp: * packages/forums/www/forum-view.tcl: * packages/forums/www/message-view.adp: * packages/forums/www/message-view.tcl: * packages/forums/www/resources/forums.css: Implement a new type of "Moderator" notification type for forums This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message. * packages/forums/www/forum-view.adp: Make clear where paragraph ends * packages/notifications/lib/notification-widget.adp: Provide a css class hook to customize styling according to notification type * packages/notifications/lib/notification-widget.tcl: Provide an include flag to hide the list of subscribers 2020-05-12 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/xowiki.info: address issue #3423: Move is_package_root_folder up in class hierarchy to CrItem follow user wish 2020-05-12 antoniop * packages/forums/tcl/messages-procs.tcl: Comment unused computations * packages/forums/tcl/messages-procs.tcl: Fix typo * packages/forums/tcl/messages-procs.tcl: Small refactoring * packages/forums/tcl/messages-procs.tcl: Step in the direction of implementing a new kind of "moderator notification": move current notification behavior in a private api, remove dependency on message approval in message::new (also avoids a query) 2020-05-11 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/prototypes/TestItemMC.form.page: * packages/xowf/www/prototypes/TestItemReorder.form.page: * packages/xowf/www/prototypes/TestItemSC.form.page: * packages/xowf/www/prototypes/TestItemShortText.form.page: * packages/xowf/www/prototypes/TestItemText.form.page: * packages/xowf/www/prototypes/TestItemUpload.form.page: - added name validator for site-wide pages - updated site-wide pages * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d29-5.10.0d29.sql: * packages/acs-kernel/sql/postgresql/utilities-create.sql: add as well support for schema name to util__table_column_exists and util__view_exists * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d29-5.10.0d29.sql: * packages/acs-kernel/sql/postgresql/utilities-create.sql: address issue #3436: support for schema name in util__table_exists TODO: Oracle version is missing * packages/xowiki/www/resources/xowiki-bootstrap3-specific.css: * packages/xowiki/www/resources/xowiki-yui-specific.css: * packages/xowiki/www/resources/xowiki.css: fix CSS formatting with bootstrap for validation errors * packages/acs-tcl/lib/progress-bar.adp: fix for issue #3438 * packages/xotcl-core/tcl/06-package-procs.tcl: improve spelling * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: make monitor URLs easier configurable don't use request-blocking on embedded items * packages/xotcl-core/tcl/05-db-procs.tcl: remove legacy code * packages/xotcl-core/tcl/policy-procs.tcl: use {} instead of [list] command * packages/acs-kernel/sql/postgresql/utilities-create.sql: white-space changes * packages/xowiki/tcl/form-field-procs.tcl: whitespace changes * packages/xowf/www/resources/form-generator.css: widen field width for numeric values 2020-05-08 gustafn * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/test/db-proc-test-procs.tcl: fix for issue #3440: problem with SQL queries in db_transactions after some db_multirows the was a problem with with db_handle management in complex setups, where a db_multirow iterating over more than one tuple causes some other queries in the transaction to fail. See as well the new test case added to the regression test. Many thanks to Keith Paskett for reporting and the good test case! https://openacs.org/bugtracker/openacs/bug?format=table&bug_n umber=3440 * packages/acs-tcl/tcl/security-procs.tcl: update comments concerning CSP "report-to" directive 2020-05-07 gustafn * packages/xowiki/www/resources/jquery/jquery-3.4.0.js: * packages/xowiki/www/resources/jquery/jquery-3.4.0.min.js: * packages/xowiki/www/resources/jquery/jquery-3.4.1.js: * packages/xowiki/www/resources/jquery/jquery-3.4.1.min.js: * packages/xowiki/www/resources/jquery/jquery.js: * packages/xowiki/www/resources/jquery/jquery.min.js: update jquery versions * packages/xowiki/tcl/resource-init.tcl: * packages/xowiki/www/resources/jquery/jquery-3.5.1.js: * packages/xowiki/www/resources/jquery/jquery-3.5.1.min.js: update jquery versions (part 2) 2020-05-07 antoniop * packages/forums/forums.info: * packages/forums/tcl/forums-install-procs.tcl: * packages/forums/tcl/forums-sc-procs.tcl: Complete a long standing transition (before 5.5): rely on callbacks instead of service contracts to implement FTS datasource logics in the forums package * packages/forums/sql/oracle/forums-notifications-init.sql: * packages/forums/sql/oracle/forums-notifications-sanitize.sql: * packages/forums/sql/postgresql/forums-notifications-init.sql: * packages/forums/sql/postgresql/forums-notifications-sanitize.sql: * packages/forums/tcl/forums-install-procs.tcl: Move logics to create forum notification type to tcl to: - reduce code duplication - make it simpler to extend forums with new notification types This reform was triggered by a downstream request, where users would like a new kind of notification for forum moderators that triggers also when a forum message has not been approved 2020-05-04 hectorr * packages/forums-portlet/forums-portlet.info: Fix typo in version number * packages/forums-portlet/forums-portlet.info: Whitespace changes 2020-05-03 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: add grading table and grading stats * packages/acs-admin/www/users/search.tcl: add multiple to page contract * packages/acs-lang/acs-lang.info: * packages/acs-lang/www/admin/set-system-timezone.tcl: * packages/assessment/assessment.info: * packages/assessment/lib/session-items.tcl: * packages/assessment/tcl/callback-procs.tcl: * packages/assessment/www/asm-admin/catalog-browse.tcl: * packages/categories/categories.info: * packages/categories/lib/contributions.tcl: * packages/categories/tcl/category-trees-procs.tcl: * packages/categories/www/cadmin/category-link-add-3.tcl: * packages/categories/www/cadmin/category-link-add-4.tcl: * packages/categories/www/cadmin/category-link-delete-2.tcl: * packages/categories/www/cadmin/category-link-delete.tcl: * packages/categories/www/cadmin/synonym-delete-2.tcl: * packages/faq-portlet/faq-portlet.info: * packages/faq-portlet/www/faq-portlet.tcl: * packages/file-storage/file-storage.info: * packages/file-storage/lib/folder-links.tcl: * packages/forums-portlet/forums-portlet.info: * packages/forums-portlet/www/forums-portlet.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl: * packages/tsearch2-driver/tsearch2-driver.info: * packages/xowf/tcl/atjob-procs.tcl: * packages/xowf/xowf.info: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/syndicate-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: * packages/xowiki/xowiki.info: improve SQL quoting * packages/xowiki/tcl/xowiki-utility-procs.tcl: improve SQL quoting and source code documentation * packages/acs-tcl/tcl/00-icanuse-procs.tcl: improve documentation * packages/xowiki/tcl/references-graph-procs.tcl: improve quoting * packages/acs-admin/www/index.tcl: * packages/acs-admin/www/subsites.tcl: improve variable names * packages/acs-subsite/tcl/subsite-procs.tcl: prefer dict over array * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/01-database-procs.tcl: provide compatibility function ns_dbquotelist, which is available in newer versions of NaviServer * packages/acs-admin/www/users/search.tcl: use "ns_dbquotelist" to quote tcl list * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/www/admin/themes/index.tcl: use ns_dbquotelist * packages/acs-admin/acs-admin.info: * packages/acs-admin/www/index.tcl: * packages/acs-admin/www/subsites.tcl: use ns_dbquotelist to convert Tcl list to sql * packages/faq-portlet/www/faq-portlet.tcl: whitespace changes * packages/assessment-portlet/www/assessment-portlet.tcl: * packages/forums-portlet/www/forums-portlet.tcl: whitespace cleanup 2020-05-02 gustafn * packages/xowf/www/resources/test-item.css: improve print output 2020-04-29 gustafn * packages/xowf/lib/inclass-exam.wf: initialize variable always 2020-04-28 hectorr * packages/acs-content-repository/acs-content-repository.info: * packages/acs-content-repository/sql/common/mime-type-data.sql: * packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql: * packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d11-5.10.0d12.sql: Add HEIC and HEIF mimetypes. See: https://www.iana.org/assignments/media-types/image/heic https://www.iana.org/assignments/media-types/image/heic-seque nce * packages/acs-content-repository/sql/common/mime-type-data.sql: Fix typo 2020-04-28 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: add autograding table (not functional yet) * packages/xowf/lib/inclass-exam.wf: add grading statistics to exam protocol * packages/xowf/tcl/test-item-procs.tcl: deactivate grading in tabular view * packages/xowf/lib/inclass-exam.wf: fix typo * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: handle dfferent time setting between server and client (browser) * packages/xowf/www/resources/test-item.css: protect against over-aggressive downstream styling * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: refactor code to keep workflow definition shorter 2020-04-27 gustafn * packages/xowf/lib/inclass-exam.wf: added more details (synchronized/not) for exam management page * packages/xowf/tcl/xowf-procs.tcl: reduce verbosity 2020-04-26 gustafn * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: - base percentage on results on total points, - add confirm dialog on submit exam - show audio on more browsers properly * packages/xowiki/tcl/form-field-procs.tcl: fix typo in make_correct * packages/xowf/tcl/test-item-procs.tcl: improve robustness of percentage computaiton, in case there are 0 points in total * packages/acs-templating/acs-templating.info: * packages/acs-templating/catalog/acs-templating.de_DE.ISO-8859-1.xml: * packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml: * packages/acs-templating/tcl/head-procs.tcl: internationalize confirm message * packages/acs-templating/catalog/acs-templating.de_DE.ISO-8859-1.xml: * packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml: * packages/acs-templating/tcl/head-procs.tcl: white-space changes 2020-04-25 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/lib/online-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: added participants list to inclass exam * packages/xowf/www/resources/form-generator.css: reduce width of horizontal input field 2020-04-23 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: improve performance of perDayCleanup significantly by not persisting Users.hits * packages/xowiki/tcl/table-widget-procs.tcl: provide support for addressing instance variables in component structures (one level 1) 2020-04-23 antoniop * packages/xowiki/www/resources/streaming-chat.js: When streaming chat implementation is in use, try reconnecting to the chat 10s after connection is closed 2020-04-22 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: Added grading info to exam protocol, when autograding is active. Added information about reasonable settings for shuffling in an exam Added information for teacher whether student exam review is possible Added correct solution hints for SC and MC (to be displayed in exam protocol) * packages/xowf/tcl/test-item-procs.tcl: improve robustness, in case user delete minutes from test item 2020-04-20 gustafn * packages/xowf/lib/inclass-exam.wf: activate live update * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: added support for solution hints on checkbox and radio questions * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: remove all of /shared from request blocking 2020-04-19 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: added a state for exam review for students * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: fix accidentally dropped message keys * packages/xowf/www/resources/test-item.css: keep height of timer constant, also, when its empty * packages/xowf/lib/inclass-exam-answer.wf: remove header in answer workflow, when parent workflow has proctoring enables * packages/xowf/lib/inclass-exam.wf: remove return button for student exam review 2020-04-18 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: detail-view: show images up to the selected revision * packages/xowf/lib/inclass-exam.wf: initialized dict in proctoring variant, in case some manages to sumit an exam without images * packages/xowf/tcl/test-item-procs.tcl: provide always proper quoting * packages/xowf/lib/inclass-exam.wf: provide meta-data about exam in "created" state 2020-04-17 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: - added points calculation in addition to score - added student feedback sheet (view-my-exam) - added view of proctored exams * packages/xowiki/tcl/form-field-procs.tcl: - name test-item specific form-fields for "in_position" and "minute" with a "test_item_" prefix - added points calculation in addition to score * packages/xotcl-core/tcl/bgdelivery-procs.tcl: base compatibility test on "icanuse" * packages/acs-tcl/tcl/site-nodes-procs.tcl: fix broken dict * packages/xotcl-core/tcl/01-debug-procs.tcl: make it possible to activate/deactivae rss tracing via reload 2020-04-16 trenner * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: fix typo 2020-04-16 gustafn * packages/acs-tcl/tcl/site-nodes-procs.tcl: added per-thread caching for "static" sitenotes. In case these will change (never saw a system where this happened), either a broadcast flush or a restart is needed. * packages/acs-tcl/tcl/site-nodes-procs.tcl: delete cut&pate error * packages/acs-tcl/tcl/00-icanuse-procs.tcl: extend icanuse cases * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: make blocked request easily detectable in monitoring tools like elasticsearch by using 429 as HTTP result code 2020-04-14 gustafn * packages/xotcl-core/tcl/01-debug-procs.tcl: add support for tracking changes in the memory size 2020-04-12 gustafn * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/oracle/groups-create.sql: * packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d27-5.10.0d28.sql: * packages/acs-kernel/sql/postgresql/groups-create.sql: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d27-5.10.0d28.sql: Added index on foreign key column to reduce sequential reads on delete operations, since the optimizer brain fart ((c)Don Baccus) that existed 17 years ago in pg 7.2 seems to be gone (https://openacs.org/forums/message-view?message_id=142769) * packages/notifications/notifications.info: * packages/notifications/sql/oracle/notifications-core-create.sql: * packages/notifications/sql/oracle/upgrade/upgrade-5.10.0d4-5.10.0d5.sql: * packages/notifications/sql/postgresql/notifications-core-create.sql: * packages/notifications/sql/postgresql/upgrade/upgrade-5.10.0d4-5.10.0d5.sql: Added index on foreign key columns * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/xotcl-request-monitor.info: added connection pool management TODO: improved parameterization 2020-04-10 gustafn * packages/xowf/lib/inclass-exam-answer.wf: add seeds for per-item randomization * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: added support for position dependent randomization * packages/xowiki/tcl/form-field-procs.tcl: added support for randomization not only per user, but as well per position * packages/xowiki/xowiki.info: bump version number to 5.10.0d53 * packages/xowiki/tcl/link-procs.tcl: whitespace changes 2020-04-09 hectorr * packages/chat/chat.info: Bump version number because of the change in message keys * packages/chat/catalog/chat.de_DE.ISO-8859-1.xml: * packages/chat/catalog/chat.en_US.ISO-8859-1.xml: Modify message keys 2020-04-09 gustafn * packages/xowiki/tcl/xowiki-procs.tcl: don't set href for rejected link to empty over the deprecated interface, but unset the href * packages/xowiki/tcl/form-field-procs.tcl: if "shuffle" finds precomputed seeds, used these to improve randomization * packages/xowf/lib/inclass-exam-answer.wf: provide randomized seeds 2020-04-08 hectorr * packages/chat/chat.info: * packages/xowiki/www/resources/chat-skins/chat-minimal.css: * packages/xowiki/www/resources/chat-skins/chat-minimal.js: Add new chat skin 'minimal'. Specially designed to be embedded in other pages, it provides a clean look without user list, full screen button, or anything else aside from the avatar, timestamp, username and message. * packages/chat/tcl/chat-ajax-procs.tcl: Allow passing chat skin to 'chat::Chat login' * packages/chat/tcl/chat-ajax-procs.tcl: Fix var name 2020-04-08 gustafn * packages/acs-mail-lite/acs-mail-lite.info: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: add EmailDeliveryMode 'ignore'. Similar to 'log' but less verbose. use 'ignore' in case 'redirect' is set without a value for EmailRedirectTo 2020-04-07 hectorr * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: Fix parameter name in acs-mail-lite 2020-04-07 gustafn * packages/xowiki/tcl/form-field-procs.tcl: CompoundField->value: return always the value from get_compound_value * packages/acs-tcl/tcl/tcltrace-init.tcl: add one more sample combination of traced commands * packages/acs-mail-lite/catalog/acs-mail-lite.tr_TR.utf-8.xml: add turkish message catalog * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: fall back to 'log' mode, when EmailDeliveryMode "redirect" is used without "EmailRedirectTo" value * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: fix variable name (many thanks to Franz Penz) * packages/acs-tcl/tcl/acs-cache-procs.tcl: new method PartitionedCache->flush_all_pattern to iterate over all partiations to perform a glob-style deletion from the cache * packages/acs-tcl/tcl/acs-cache-procs.tcl: provide a clearer name for method (flush_pattern_in_all_partitions) and make it protected * packages/acs-tcl/tcl/site-nodes-procs.tcl: whitespace and spelling changes 2020-04-06 gustafn * packages/acs-mail-lite/acs-mail-lite.info: * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: - acs_mail_lite::send_immediately: new switch for "-force_delivery_mode" to force delivery mode for a single call (ignoring package parameter "EmailDeliveryMode") - New potential value for "EmailDeliveryMode": "nssmtpd" When this parameter is specified, the behavior is like "smtp", but the code tries use the SMTP implementation of the nssmtpd NaviServer module. - It is also possible to combine "nssmtpd" with the delivery methods "filter" or "redirect" simply by writing e.g. "filter nssmtpd" - some refactoring to avoid repeated code * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/xotcl-request-monitor.info: Try to avoid double-counting in request statistics, when a user logs in. Previously, when a user logs in, the user was counted once as un-authenticated user, and once as authenticated one. TODO: when this works sufficiently well, the same should be done as well for the 24h statistics. * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/www/active-communities.tcl: * packages/xotcl-request-monitor/www/flush-url-statistics.tcl: * packages/xotcl-request-monitor/www/ip-info.tcl: * packages/xotcl-request-monitor/www/last-requests.tcl: * packages/xotcl-request-monitor/www/last100.tcl: * packages/xotcl-request-monitor/www/last101.tcl: * packages/xotcl-request-monitor/www/long-calls.tcl: * packages/xotcl-request-monitor/www/running.tcl: * packages/xotcl-request-monitor/www/throttle-statistics.tcl: * packages/xotcl-request-monitor/www/users-in-community.tcl: * packages/xotcl-request-monitor/www/whos-online-today.tcl: * packages/xotcl-request-monitor/www/whos-online.tcl: add support for deleted users, handle this case centrally * packages/xotcl-request-monitor/tcl/callback-procs.tcl: * packages/xotcl-request-monitor/tcl/throttle_mod-init.tcl: whitespace cleanup 2020-04-05 gustafn * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: Use optionally nssmtpd as different mail delivery agent when the "-experimental" flag is provided to acs_mail_lite::send_immediately, and the NaviServer nssmtpd modules is installed. * packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl: * packages/acs-mail-lite/tcl/legacy-inbound-procs.tcl: whitespace changes 2020-04-04 gustafn * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: changes for inclass-exam: - open test run in a different frame - use tailored proctoring code, when available - improve screen after final exam submission 2020-04-03 hectorr * packages/xowiki/www/resources/chat-common.js: Improve comment * packages/xowiki/www/resources/chat-common.js: Remove debug console logging * packages/xowiki/www/resources/chat-common.js: Remove unnecessary check * packages/chat/www/chat.adp: * packages/xowiki/www/resources/chat-common.js: Show the "Enable notifications" button in the chat only if the user has not accepted, or explicitly denied, notifications yet 2020-04-02 hectorr * packages/chat/catalog/chat.en_US.ISO-8859-1.xml: * packages/chat/catalog/chat.es_ES.ISO-8859-1.xml: * packages/chat/chat.info: * packages/chat/www/chat.adp: * packages/xowiki/www/resources/chat-common.js: Add "Web notifications" for new messages in the chat. See: https://www.w3.org/TR/notifications/ "You should only request consent to display notifications in response to a user gesture (e.g. clicking a button). This is not only best practice — you should not be spamming users with notifications they didn't agree to — but going forward browsers will explicitly disallow notification permission requests not triggered in response to a user gesture. Firefox is already doing this from version 72, for example, and Safari has done it for some time." https://developer.mozilla.org/en-US/docs/Web/API/Notification s_API/Using_the_Notifications_API * packages/xowiki/www/resources/chat-common.js: Add simple chat notifications. Modify the title of the browser tab, when it is inactive, showing the number of new messages. This is cleared up when the tab is active again. * packages/xowiki/www/resources/chat-common.js: Remove code leftovers 2020-04-02 gustafn * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: - do not require to make generic create-or-use public for non-admins in proctor mode * packages/xotcl-core/tcl/05-db-procs.tcl: added support for time fractions (needed e.g. for more precise countdown timers) * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: delete duplicated entry * packages/xotcl-core/tcl/01-debug-procs.tcl: improve output of xo::show_stack * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/prototypes/select_question.form.page: new features for inclass exam workflow: - additional flag "synchronized", can be specified on "create exam" page - provide info about exam publication time and duration since publication time to the details view of the exam protocol * packages/xotcl-core/tcl/context-procs.tcl: * packages/xotcl-core/tcl/cr-procs.tcl: whitespace changes 2020-04-01 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/prototypes/select_question.form.page: added skeleton for proctoring support * packages/xowf/lib/inclass-exam.wf: fix typo * packages/acs-templating/tcl/head-procs.tcl: template::set_css_propert: generalize function 2020-03-31 gustafn * packages/acs-templating/tcl/test/head-test-procs.tcl: improve readability * packages/acs-templating/tcl/head-procs.tcl: template::hide: new API function to hide certain CSS classes via javascript 2020-03-30 gustafn * packages/acs-tcl/tcl/00-icanuse-procs.tcl: * packages/acs-tcl/tcl/acs-cache-procs.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: Added HashKeyPartitionedCache: This is type of cache is like a "KeyPartitionedCache" but works as well with strings as keys while the "KeyPartitionedCache" requires numeric keys. * packages/acs-tcl/tcl/object-procs.tcl: mark "acs_lookup_magic_object" explicit as deprecated, use "acs_magic_object" instead (which is per-thread cached) 2020-03-27 gustafn * packages/acs-tcl/tcl/tcltrace-procs.tcl: fix output from tcltrace procs 2020-03-26 gustafn * packages/xowiki/tcl/form-field-procs.tcl: add optional text descriptions to short_text fields * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: added optional field for expected solution 2020-03-25 hectorr * packages/chat/catalog/chat.de_DE.ISO-8859-1.xml: * packages/chat/chat.info: * packages/chat/www/chat.adp: * packages/xowiki/www/resources/chat-common.js: Show number of active users in chat. Many thanks to Monika Andergassen 2020-03-25 gustafn * packages/xowf/tcl/xowf-procs.tcl: add support to get revisions with instance variables * packages/xowf/lib/inclass-exam-answer.wf: do not show count-down timer always * packages/xowf/lib/inclass-exam.wf: don't show results of "marked" right now * packages/xowiki/tcl/form-field-procs.tcl: generalize modifier handling in "correct_when" * packages/xowiki/tcl/form-field-procs.tcl: prefer "string map" over "regsub" 2020-03-23 gustafn * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-includelet-procs.tcl: * packages/xowf/www/resources/test-item.css: Added count-down timer for inclass-exam-answer.wf - new API call Question_manager.exam_target_time - new includelet "countdown-timer" (based on answer_manager.countdown_timer) * packages/xowf/tcl/test-item-procs.tcl: allow minimal number of selected alternatives of 1 (does not always make sense, but it is useful for text exercises) * packages/xowf/lib/inclass-exam.wf: shorten date info in title, since it is redundant 2020-03-22 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: Improved display and interaction with print-answers: - added explicit display of displayed revision and submitted revision - added option to change live revision * packages/xowf/tcl/test-item-procs.tcl: Improved display for print-answers: - added link from exam protocol to single (more detailed) view - display in exam protocol answer times up to the live-revision (and not over all elements) * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: Improved display of print-answers: - added information about current page of student - improved display of submission state - made message key capitalization more consistent * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: Improved display of print-answers: - provided API function "runtime_panel" for answer_manager - added revision handling of submitted exams * packages/xowf/lib/inclass-exam-answer.wf: whitespace cleanup * packages/xowiki/tcl/xowiki-www-procs.tcl: www-make-live-revision: add support for "local_return_url" (when "return_url" is not specified) 2020-03-21 gustafn * packages/xowf/tcl/test-item-procs.tcl: Add support for Answer_manager.result_table to return either abjects in "done" state (as before) or all objects * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: Improve display of print-answers: - provide API functions "get_duration" and "get_IPs" for ans - added info box "runtime-data" in inclass-exam.wf about changed submissions (number of revisions, duration, all IP addresses of the submission) - added message keys for "nr_changes" and "duration" - updated CSS to handle "runtime-data" - bump version number to 5.10.0d16 * packages/xowf/tcl/xowf-procs.tcl: New API method WorkflowPage.get_revision_sets Collect information about the revisions of the current workflow instance as a list of ns_sets. * packages/xowf/tcl/test-item-procs.tcl: add "source_dependent" in case, some package extend e.g. the test_item class * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: add duration, handle cases, where the exam was not submitted * packages/xotcl-core/tcl/context-procs.tcl: * packages/xotcl-core/xotcl-core.info: add new API command for the connection context (e.g. xo:cc): eval_as_user {-user_id:integer cmd} * packages/xowiki/tcl/form-field-procs.tcl: autocorrection: support *lower* float for correct_when=in * packages/xowf/tcl/test-item-procs.tcl: avoid potential exceptions for empty submissions * packages/xowiki/tcl/form-field-procs.tcl: avoid potential tilde substitution (many thanks to Markus Moser) stick to varnames used on many other places for the same information * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/www/resources/xowiki.css: deal with overaggressive downstream styles * packages/xowf/lib/inclass-exam.wf: * packages/xowf/www/resources/feedback.css: * packages/xowf/www/resources/test-item.css: improve styling * packages/xowf/lib/inclass-exam-answer.wf: reduce verbosity * packages/xowf/lib/inclass-exam-answer.wf: return full result in reporting modes 2020-03-20 gustafn * packages/xowiki/tcl/link-procs.tcl: Improve last change and document it properly. Set outdated HTML attributes as deprecated. * packages/xowf/tcl/test-item-procs.tcl: call table data formatter, when available * packages/xowf/lib/inclass-exam.wf: perform per-user rendering for the exam protocol. A more general solution will follow soon. * packages/xowiki/tcl/form-field-procs.tcl: provide pretty-print methods for tabular data views 2020-03-20 antoniop * packages/chat/www/room-enter.tcl: Handle the case when one is trying to access a non-existing room * packages/faq/faq.info: * packages/faq/sql/postgresql/faq-create.sql: * packages/faq/sql/postgresql/faq-package-create.sql: * packages/faq/sql/postgresql/upgrade/upgrade-5.10.0d7-5.10.0d8.sql: Redefine faq questions and answers as text, the same as downstream, then redefine all database function api so that argument types are taken from table definition 2020-03-18 gustafn * packages/xowf/tcl/test-item-procs.tcl: - make repeatable formfields better configurable (provde max number for repeated elements via parameter) - improve robustness, when a form field does not provide a "correction" instance variable after "make_correct" - improve documentation * packages/xowf/lib/inclass-exam-answer.wf: omit question title in inclass-exam * packages/xowiki/tcl/form-field-procs.tcl: support show_max for short_text answers 2020-03-18 antoniop * packages/xowiki/tcl/link-procs.tcl: Remove href from the variables we inspect the item for in a file link: this variable is most likely set, therefore, embed_options will be nonempty and most links downstream will be rendered via instead than a plain link. Furthermore, it does appear as non standard according to e.g. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/emb ed and would probably conflict with the src attribute, which is always set. 2020-03-17 antoniop * packages/chat/tcl/xotcl-chat-procs.tcl: Keep returning 0 when no transcript is created, as the code expects * packages/chat/www/transcript-view.adp: * packages/chat/www/transcript-view.tcl: Remove lefrover files * packages/chat/lib/current-messages.adp: * packages/chat/lib/current-messages.tcl: * packages/chat/lib/transcript-view.adp: * packages/chat/tcl/xotcl-chat-procs.tcl: * packages/chat/www/transcript-entry.adp: * packages/chat/www/transcript-new-2.tcl: * packages/chat/www/transcript-new.tcl: Uniform the quoting criteria when dealing with transcripts: - transcripts are stored as they are, no quoting in the data we store (and therefore HTML should be avoided) - transcripts are displayed quoted, therefore, disabling any effect from HTML eventually present in the content - bring the logics to build transcript content in the API to avoid duplication - avoid sending the transcript content to transcript-new-2, as we can generate it server side Note: storing transcripts as a pre-formatted chunk of text is probably not the best approach, as any changes to the formatting cannot be applied to pre-existing data without a delicate upgrade. This new approach will make
tags inside older transcripts visible... 2020-03-14 gustafn * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/postgresql/groups-body-create.sql: * packages/acs-kernel/sql/postgresql/site-nodes-create.sql: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d26-5.10.0d27.sql: - Convert frequently used functions from plpgsql to strict and stable SQL functions, which allow the PostgreSQL more optimizations * acs_group__member_p/3 * site_node__url/1 - bump version number to 5.10.0d27 * packages/acs-kernel/sql/postgresql/groups-body-create.sql: * packages/acs-kernel/sql/postgresql/site-nodes-create.sql: add editor hints, whitespace changes * packages/acs-content-repository/acs-content-repository.info: * packages/acs-content-repository/sql/postgresql/content-folder.sql: * packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d10-5.10.0d11.sql: use SQL functions (instead of plpgsql) defined as stabe and strict for * content_folder__is_folder * content_folder__is_sub_folder, and * content_folder__is_empty ... having as well more sane constructs returning boolean values * packages/acs-kernel/sql/postgresql/groups-body-create.sql: * packages/acs-kernel/sql/postgresql/site-nodes-create.sql: whitespace changes 2020-03-13 trenner * packages/acs-content-repository/acs-content-repository.info: * packages/acs-content-repository/sql/postgresql/content-folder.sql: * packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d9-5.10.0d10.sql: improve performance of content_folder__is_sub_folder 2020-03-13 antoniop * packages/chat/tcl/chat-ajax-procs.tcl: Fix typo * packages/chat/tcl/chat-ajax-procs.tcl: Try to handle the case of a user accessing a non-existing chat without throwing a log error 2020-03-12 antoniop * packages/chat/www/index.tcl: * packages/chat/www/toggle-active.tcl: Allow to toggle chat active state from the chat list 2020-03-11 antoniop * packages/forums/forums.info: * packages/forums/sql/postgresql/forums-forums-create.sql: * packages/forums/sql/postgresql/upgrade/upgrade-1.3.1d16-1.3.1d17.sql: Redefine forum charter as text, therefore, without length limit 2020-03-10 hectorr * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: Use '&' instead of '&' in message key, to avoid xml parsing issues during import 2020-03-10 gustafn * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: allow list on folder in all default policies 2020-03-10 gernst * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: Fix typo in message-key name 2020-03-09 hectorr * packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml: Update 'es_ES' message keys 2020-03-09 gustafn * packages/xotcl-core/tcl/06-package-procs.tcl: fix brain blackout * packages/xotcl-core/tcl/06-package-procs.tcl: fix typo 2020-03-09 antoniop * packages/tsearch2-driver/tcl/tsearch2-driver-procs-postgresql.xql: Make sure object_id is still a valid acs_object by the time it gets to the indexer: it can happen that objects meant to be indexed are in fact short-lived (e.g. xowiki-based objects created, scheduled for indexing and deleted shortly after) * packages/xowf/tcl/xowf-init.tcl: Provide value for flag 2020-03-08 gustafn * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xotcl-core/xotcl-core.info: - PackageMgr.require_site_wide_pages: add flag -refetch_if_modified When the flag is used, site-wide pages are automatically updated, when the file in the prototypes directory changes - improved source code documentation - bumped version number to 5.10.0d27 * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/lib/online-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-init.tcl: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/www/prototypes/TestItemReorder.form.page: * packages/xowf/www/prototypes/assessment-index.page: * packages/xowf/www/prototypes/quiz-select_question.form.page: * packages/xowf/www/prototypes/select_question.form.page: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: - test-items: added ordering item type (short_text_interaction) - simplified code by using ':get_named_sub_component_value -from_repeat ...' - refetch site-wide pages, when the source code of the site-wide pages changes. - bumped version number to 5.10.0d16 * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/xowiki-init.tcl: * packages/xowiki/tcl/xowiki-mode-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: improve spelling 2020-03-07 gustafn * packages/xowiki/tcl/form-field-procs.tcl: add flag "-from_repeat" to CompoundField.get_named_sub_component_value In case the named component is from a repeated field, this can be used to skip the template element from the return value * packages/xowiki/tcl/xowiki-procs.tcl: reduce verbosity 2020-03-06 hectorr * packages/dotlrn/tcl/apm-callback-procs.tcl: Whitespace changes 2020-03-06 gustafn * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/www/resources/xowiki.css: * packages/xowiki/xowiki.info: - new form_field class: reorder_box, which can be used e.g. in ordering exercises in e-assessments - better handling of disabled_as_div (when feedback is provided via input highlighting) * packages/xowiki/tcl/form-field-procs.tcl: fix typo 2020-03-05 hectorr * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d25-5.10.0d26.sql: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d25-5.10.0d26.sql: Attribute discrepancy fix for object_types in OpenACS. Some attributes are not created for new instances since 2006, but an upgrade script deleting the already existing ones was never done. Original datatype change: https://fisheye.openacs.org/changelog/OpenACS?cs=MAIN%3Avicto rg%3A20060727200933 https://github.com/openacs/openacs-core/commit/7e30fa270483dc bc866ffbf6f5cf4f30447987cb * packages/assessment/tcl/as-install-procs.tcl: Check for existence before deleting attribute * packages/assessment/assessment.info: * packages/assessment/tcl/as-install-procs.tcl: Delete attribute 'survey_p', as it was replaced by 'type' in 2006 and is not created in new instances. It is unclear if the 'survey_p' column of the 'as_assessments' table can also be dropped. Original attribute replacement commit: https://github.com/openacs/assessment/commit/433463faf6d50140 fe26f848ab2f28662e0acc85#diff-cff15be6842f249cef812f983e064e7 8 https://fisheye.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb %3A20060926002244 * packages/acs-admin/www/users/member-state-change.tcl: Replace 'ad_url' with 'ad_conn subsite_url' * packages/dotlrn-bootstrap3-theme/catalog/dotlrn-bootstrap3-theme.es_ES.ISO-8859-1.xml: * packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml: * packages/xowiki-portlet/catalog/xowiki-portlet.es_ES.ISO-8859-1.xml: Update 'es_ES' message keys * packages/assessment/tcl/as-install-procs.tcl: Whitespace changes 2020-03-05 gustafn * packages/xowf/www/prototypes/select_question.form.page: fix typo * packages/xowiki/tcl/folder-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: fix typos and whitespace changes 2020-03-04 trenner * packages/xowf/lib/online-exam.wf: ensure menu variable is set for the case that no answers are available 2020-03-04 hectorr * packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.0d8-5.10.0d9.sql: * packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d24-5.10.0d25.sql: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d24-5.10.0d25.sql: Add oracle upgrade logic for previous attribute datatype discrepancy package upgrades, and fix typo in postgres upgrade script * packages/acs-content-repository/acs-content-repository.info: * packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d8-5.10.0d9.sql: * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d24-5.10.0d25.sql: Fix attribute datatype discrepancy, introduced in 2006 but never fixed for already existing instances. Original datatype change: https://fisheye.openacs.org/changelog/OpenACS?cs=MAIN%3Avicto rg%3A20060727200933 https://github.com/openacs/openacs-core/commit/7e30fa270483dc bc866ffbf6f5cf4f30447987cb 2020-03-04 gustafn * packages/xowiki/tcl/form-field-procs.tcl: don't omit output escaping for "render_as_div". Not sure, why this was set. 2020-03-03 hectorr * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/tcl/apm-callback-procs.tcl: * packages/acs-subsite/tcl/group-type-procs.tcl: * packages/acs-subsite/tcl/group-type-procs.xql: Do not convert into uppercase the 'id_column' attribute in 'acs_object_types' for group types. This attribute was uppercase, both in oracle and postgres, causing a discrepancy with the column real name, found by the 'datamodel__acs_object_type_check' test case. The package upgrade fixes the already existing attributes in postgres. * packages/acs-developer-support/www/request-info.tcl: Fix request duration time * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/tcl/apm-callback-procs.tcl: Normalize case of 'table_name' attribute in 'acs_object_types' for group types to lowercase, in postgres. This attribute was created in uppercase, causing a discrepancy with the table real name. As this is now fixed by a previous commit, this package upgrade fixes the already existing attributes. * packages/acs-subsite/tcl/group-type-procs-oracle.xql: * packages/acs-subsite/tcl/group-type-procs.tcl: Only convert table names to uppercase, during group type creation, on oracle. This was producing case mixed issues on postgres installations, where the table_name attribute on 'acs_object_types' was upppercase, while the real table name was lowercase, as detected by the 'datamodel__acs_object_type_check' test case. * packages/acs-subsite/tcl/apm-callback-procs.tcl: Restrict upgrade logic to postgres, as mentioned in previous commit * packages/acs-developer-support/www/request-info.tcl: * packages/acs-subsite/tcl/group-type-procs-oracle.xql: Whitespace changes 2020-03-02 gustafn * packages/xotcl-request-monitor/www/index.tcl: - provide compatibility with Highcharts v8 - remove dependency on jquery 2020-03-02 antoniop * packages/xotcl-request-monitor/www/index.tcl: Highcharts: specify latest stable 7 as the version we support, as default is as today 8.0.1 , which is not compatible with current code * packages/xowiki/tcl/resource-init.tcl: Specify version 7 as version of highcharts we support, as 8.0.1 we get by default as today introduces regressions in our code 2020-02-28 hectorr * packages/acs-tcl/tcl/application-data-link-procs.tcl: Remove ID size restriction in regexp 2020-02-28 gustafn * packages/xowiki/tcl/bootstrap-procs.tcl: * packages/xowiki/tcl/resource-init.tcl: * packages/xowiki/www/admin/index.tcl: * packages/xowiki/www/admin/list.tcl: * packages/xowiki/xowiki.info: - fix broken glyphicons, when "bootstrap" is the preferred toolkit, but theme does not include it. - register CSPs for URNs - bump version to 5.10.0d51 * packages/acs-templating/acs-templating.info: * packages/acs-templating/tcl/head-procs.tcl: support registration of csp rules for URNs 2020-02-27 hectorr * packages/acs-tcl/tcl/application-data-link-procs.tcl: Increase the id length check by regexp in 'application_data_link::scan_for_links' * packages/acs-tcl/tcl/test/community-core-test-procs.tcl: Use 'acs_testing' authority in 'party_procs_test' test case * packages/acs-tcl/tcl/test/community-core-test-procs.tcl: Use 'acs_testing' authority in 'person_procs_test' tet case 2020-02-27 gustafn * packages/acs-tcl/tcl/site-nodes-procs.tcl: flush per_request_cache also when patterns are flushed * packages/xotcl-core/tcl/06-package-procs.tcl: get rid of two xowiki::* calls and improve handling of bootstrapping issues via empty package_id * packages/acs-admin/tcl/site-wide-procs.tcl: reduce dependency on xí::db:: calls; still not perfect, since we need a special cache flush, but better than before 2020-02-26 hectorr * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Fix '::acs::test::set_user' for cases when 'address' is not an IP, but a hostname. The address, if not provided by the TestURL parameter, is parsed from 'ns_conn location', and in both cases it can be hostname instead of an IP. The 'address' is later compared against 'ns_conn peeraddr' in security proc's 'sec_handler', which is always an IP, preventing login on those cases. To avoid this, we try to resolve the address in advance. 2020-02-26 gustafn * packages/xowiki/tcl/package-procs.tcl: fix variable name in log message * packages/xotcl-core/tcl/06-package-procs.tcl: provide an xo::cc when needed (e.g. during bootstrap) * packages/xowiki/tcl/parameter-page-procs.tcl: provide more detailed error message when require_parameter_page fails * packages/xowf/www/prototypes/TestItemText.form.page: provide required value for "-text" in prototype page definition * packages/acs-admin/tcl/site-wide-procs.tcl: revert commit with escaped debugging output * packages/acs-admin/tcl/site-wide-procs.tcl: * packages/acs-admin/www/apm/packages-install-4.tcl: when installation runs into an error, show the error message preformatted * packages/acs-admin/www/apm/packages-install-4.tcl: * packages/xowiki/tcl/parameter-page-procs.tcl: whitespace changes 2020-02-26 antoniop * packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml: Normalize typographical style in italian localization: only the first word is capitalized * packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml: Update italian localization 2020-02-25 hectorr * packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml: Fix typo in message key. * packages/forums/tcl/test/webtest-procs.tcl: Prefer acs::test::reply_has_status_code over manually checking status code in the reply 2020-02-25 antoniop * packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.it_IT.ISO-8859-1.xml: Update italian localization 2020-02-21 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-exam-answer.wf: * packages/xowf/lib/inclass-exam.wf: * packages/xowf/lib/inclass-quiz-answer.wf: * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/lib/online-exam-answer.wf: * packages/xowf/lib/online-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/tcl/xowf-init.tcl: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/www/prototypes/TestItemMC.form.page: * packages/xowf/www/prototypes/TestItemSC.form.page: * packages/xowf/www/prototypes/TestItemShortText.form.page: * packages/xowf/www/prototypes/TestItemText.form.page: * packages/xowf/www/prototypes/TestItemUpload.form.page: * packages/xowf/www/prototypes/assessment-index.page: * packages/xowf/www/prototypes/inclass-exam.wf.page: * packages/xowf/www/prototypes/inclass-quiz.wf.page: * packages/xowf/www/prototypes/online-exam.wf.page: * packages/xowf/www/prototypes/quiz-select_question.form.page: * packages/xowf/www/prototypes/select_question.form.page: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: - new assessment workflow for in-class exam lib/inclass-exam-answer.wf lib/inclass-exam.wf - Defined common superclass for Assessments (AssessmentInterface) to provide common infrastructure (assertion methods), and define other interface classes as subclasses (Renaming_form_loader, Answer_manager, Question_manager). - extended message keys - new prototype pages: www/prototypes/TestItemMC.form.page www/prototypes/TestItemSC.form.page www/prototypes/TestItemShortText.form.page www/prototypes/TestItemText.form.page www/prototypes/TestItemUpload.form.page www/prototypes/assessment-index.page www/prototypes/inclass-exam.wf.page www/prototypes/inclass-quiz.wf.page www/prototypes/online-exam.wf.page www/prototypes/quiz-select_question.form.page www/prototypes/select_question.form.page - Defined to following pages as site-wide: Package site_wide_pages { Workflow.form TestItemText.form TestItemShortText.form TestItemMC.form TestItemSC.form TestItemUpload.form online-exam.wf inclass-quiz.wf inclass-exam.wf quiz-select_question.form select_question.form } - Ensure availability of site-wide pages at startup of server. - bumped version number to 5.10.0d15 * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xotcl-core/xotcl-core.info: provide a default for "-pages" in require_site_wide_pages, bump version to 5.10.0d26 2020-02-20 hectorr * packages/categories/catalog/categories.en_US.ISO-8859-1.xml: * packages/categories/catalog/categories.es_ES.ISO-8859-1.xml: Delete obsolete message key * packages/assessment/catalog/assessment.en_US.ISO-8859-1.xml: * packages/assessment/catalog/assessment.es_ES.ISO-8859-1.xml: Update es_ES message keys, and add placeholders for empty message keys 2020-02-20 gustafn * packages/xowiki/tcl/package-procs.tcl: allow protpype pages to be inserted into folders * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: move "get_nls_language_from_lang" to metaclass to make it usable from packages different to xowiki as well * packages/xowiki/tcl/package-procs.tcl: prefer variable resolver over method call * packages/xowiki/tcl/form-field-procs.tcl: reduce verbosity * packages/xowiki/tcl/package-procs.tcl: search for site-wide pages along package hierarchy * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/xowiki.info: xotcl-core - move list of site_wide pages to meta-class, such that every derived class might have different ones. - bump version number to 5.10.0d25 xowiki - provide explicit site_wide pages - bump version number to 5.10.0d49 2020-02-19 stefans * packages/xowiki/tcl/table-widget-procs.tcl: Remove brace protection from dynamic expr arg to if * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/table-widget-procs.tcl: Remove superfluous expr in first-arg to if 2020-02-19 hectorr * packages/acs-templating/catalog/acs-templating.es_ES.ISO-8859-1.xml: * packages/assessment/catalog/assessment.es_ES.ISO-8859-1.xml: * packages/chat/catalog/chat.es_ES.ISO-8859-1.xml: * packages/dotlrn-homework/catalog/dotlrn-homework.es_ES.ISO-8859-1.xml: * packages/dotlrn/catalog/dotlrn.es_ES.ISO-8859-1.xml: * packages/news/catalog/news.es_ES.ISO-8859-1.xml: * packages/static-portlet/catalog/static-portlet.es_ES.ISO-8859-1.xml: * packages/xotcl-core/catalog/xotcl-core.es_ES.ISO-8859-1.xml: * packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.es_ES.ISO-8859-1.xml: Update es_ES message keys 2020-02-19 antoniop * packages/calendar/tcl/cal-item-procs.tcl: Reform 'all_day_event' private interface: now we consider all day events only those where the time component of both start and end date is set at midnight. This is more restrictive that the previous criteria, which would allow also events where start and end date were equals, or the date component was different, regardless of time, to be considered all day events. In practice, the user interface would already make so that an event created as "all day event" would be set with midnight as the time for start and end date. calendar::item::get would already return time_p in the array to indicate whether this was an event with time or not. No time would mean "all day event". For convenience, we now return also the straight all_day_event_p flag in the array. * packages/calendar/tcl/cal-item-procs.tcl: Remove blind catch, this proc is actually robust to bogus values 2020-02-18 hectorr * packages/acs-lang/www/admin/message-list.adp: Fix alt text of image * packages/forums/lib/message/attachment-list.adp: Fix close tag * packages/acs-lang/catalog/acs-lang.es_ES.ISO-8859-1.xml: * packages/acs-subsite/catalog/acs-subsite.es_ES.ISO-8859-1.xml: Update es_ES message keys 2020-02-18 gustafn * packages/acs-templating/tcl/parse-procs.tcl: * packages/acs-templating/tcl/richtext-procs.tcl: * packages/acs-templating/tcl/wizard-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: improve wording and fix typos * packages/xotcl-core/tcl/06-package-procs.tcl: reduce verbosity * packages/xotcl-core/tcl/30-widget-procs.tcl: * packages/xowiki/tcl/folder-procs.tcl: revert change, since this breaks applications if the distinction is needed, a better change is required, either via configuration of a prefix, or via subclassing. * packages/xowiki/tcl/xowiki-procs.tcl: use more descriptive variable name 2020-02-18 antoniop * packages/xowiki/tcl/folder-procs.tcl: Fix memory leak 2020-02-17 hectorr * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: Fix typo in proc doc 2020-02-17 gustafn * packages/acs-tcl/tcl/site-nodes-procs.tcl: reduce verbosity 2020-02-15 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: fix message keys * packages/xowf/lib/online-exam.wf: improve documentation 2020-02-14 gustafn * packages/xowiki/tcl/folder-procs.tcl: - added support for forcing publish_status line when "publish_status" is passed as a value for "columns" Previously, publish status was automatically displayed, when target publish_status was different to "ready" * packages/acs-admin/acs-admin.info: * packages/acs-admin/tcl/site-wide-procs.tcl: * packages/xotcl-core/tcl/06-package-procs.tcl: * packages/xotcl-core/xotcl-core.info: * packages/xowf/tcl/xowf-callback-procs.tcl: * packages/xowf/tcl/xowf-init.tcl: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowf/www/prototypes/Parameter.form.page: * packages/xowf/xowf.info: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/parameter-page-procs.tcl: * packages/xowiki/tcl/upgrade/upgrade.tcl: * packages/xowiki/www/prototypes/Parameter.form.page: * packages/xowiki/www/prototypes/table-of-contents.page: * packages/xowiki/xowiki.info: Crosscutting reform to ease configurability of xo* applications acs-admin - Provide support for site-wide packages Site-wide packages can be used to provide a common place for site-wide admins to configure application packages and for testing purposes. These packages are mounted on a special subsite (named "site-die") under acs-admin/ to avoid confusions for end-users of the site. The site-wide subsite can be used as well for creating testing instances or for other testing purposes. - bump version number to 5.10.0d9 xotcl-core - Added support for site-wide packages. Packages can define, how site-wide packages should be configured - Changed Package-level procs into instprocs of the meta-class. This way, generic code can be provided for common handling across packages. This effects: - configure_fresh_instance - get_site_wide_page - import_prototype_page - lookup_side_wide_page - require_site_wide_info - require_site_wide_pages - bump version number to 5.10.0d24 xowiki - provide configurable configuration info for new packages (including site-wide packages) - search for prototype pages along inheritance path - moved Parameter.page prototype here - added "table-of-contents" prototype page - perform refactoring due to moving methods to the meta-class - reduce usage of anonymous arrays - bump version number to 5.10.0d49 xowf - simplify apm callback and use new infrastructure - provide configurable configuration info for new packages (including site-wide packages) - bump version number to 5.10.0d14 * packages/xowiki/tcl/menu-procs.tcl: * packages/xowiki/tcl/weblog-procs.tcl: fix typo * packages/xowiki/tcl/menu-procs.tcl: simplify and document behavior of mapping of default menu entry labels 2020-02-14 antoniop * packages/xowiki/tcl/table-widget-procs.tcl: Continue to allow sorting by hidden columns * packages/xotcl-core/tcl/06-package-procs.tcl: Fix typos * packages/xowiki/tcl/folder-procs.tcl: Name the child resources object consistently in order to differentiate it from other includelets * packages/xotcl-core/tcl/30-widget-procs.tcl: Try to avoid interference between two different table widgets rendered on the same page: fetch sorting column by prefixing by the table name 2020-02-13 trenner * packages/xowiki/www/admin/list.tcl: make confirmation message optional 2020-02-13 gustafn * packages/acs-subsite/www/shared/parameters.tcl: * packages/acs-tcl/tcl/parameter-procs.tcl: add callback invocation into parameter::set_global_value and parameter::set_value to achieve a more consistent behavior 2020-02-12 trenner * packages/xowiki/www/admin/list.tcl: add confirmation message before deleting a page 2020-02-12 gustafn * packages/xowf/tcl/test-item-procs.tcl: * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/form-field-procs.tcl: add file upload to short_field type * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: fix case for message key 2020-02-11 hectorr * packages/acs-tcl/tcl/test/http-client-procs.tcl: Fallback to 'util_current_location' when 'ad_url' returns an empty string, such in cases when the SystemUrl is not set, on the util_http_json_encoding testcase * packages/news/tcl/test/news-test-procs.tcl: Fix proc and testcase names. The original 'news_pretty_status_key' proc was renamed to 'news_pretty_status' around 16 years ago. 2020-02-11 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: added support for upload interaction * packages/categories/www/cadmin/object-map.adp: bugfix: when the property is set, creating a new category tree results in a error: ... supplied two values for 'locale' * packages/xowf/lib/online-exam.wf: don't poll in "initial" or "created" state * packages/xowiki/tcl/form-field-procs.tcl: fix and document answer_check=answer_words * packages/xowiki/tcl/form-field-procs.tcl: implementation of feature request #3431 * packages/xowiki/tcl/form-field-procs.tcl: prefer accessing variable consistently via variable resolver check= methods * packages/xowf/lib/online-exam.wf: * packages/xowiki/tcl/menu-procs.tcl: reduce verbosity * packages/xowiki/tcl/form-field-procs.tcl: trim submitted value in answer_check=answer_words * packages/categories/lib/tree-form.tcl: whitespace cleanup 2020-02-09 gustafn * packages/calendar/tcl/calendar-callback-hooks-procs.tcl: * packages/calendar/tcl/calendar-compatibility-procs.tcl: * packages/calendar/www/mini-calendar.tcl: * packages/calendar/www/view-print-display.tcl: * packages/chat-portlet/tcl/chat-admin-portlet-procs.tcl: * packages/chat-portlet/tcl/chat-portlet-procs.tcl: * packages/chat-portlet/www/chat-admin-portlet.tcl: * packages/chat-portlet/www/chat-portlet.tcl: * packages/chat/lib/current-messages.tcl: * packages/chat/lib/transcript-view.tcl: * packages/chat/lib/transcripts.tcl: * packages/chat/tcl/apm-callback-procs.tcl: * packages/chat/tcl/xotcl-chat-procs.tcl: * packages/cookie-consent/tcl/callback-procs.tcl: * packages/cookie-consent/www/sitewide-admin/download.tcl: * packages/cookie-consent/www/sitewide-admin/index.tcl: * packages/dotlrn-bootstrap3-theme/resources/masters/dotlrn-master.tcl: * packages/dotlrn-bootstrap3-theme/resources/masters/dotlrn-streaming-head.tcl: * packages/dotlrn-bootstrap3-theme/tcl/apm-callback-procs.tcl: * packages/dotlrn-bootstrap3-theme/tcl/theme-procs.tcl: * packages/dotlrn-chat/tcl/dotlrn-chat-procs.tcl: * packages/file-storage/tcl/test/webtest-procs.tcl: * packages/forums/tcl/test/webtest-procs.tcl: * packages/intermedia-driver/tcl/intermedia-init.tcl: * packages/new-portal/tcl/portal-init.tcl: * packages/openacs-default-theme/tcl/apm-callback-procs.tcl: * packages/openacs-default-theme/tcl/theme-procs.tcl: * packages/richtext-ckeditor4/tcl/richtext-init.tcl: * packages/richtext-ckeditor4/www/sitewide-admin/download.tcl: * packages/richtext-ckeditor4/www/sitewide-admin/index.tcl: * packages/richtext-tinymce/tcl/richtext-init.tcl: * packages/richtext-xinha/tcl/richtext-init.tcl: * packages/survey/lib/portlet.tcl: * packages/survey/tcl/survey-notification-procs.tcl: * packages/survey/tcl/survey-procs.tcl: * packages/survey/www/admin/description-edit.tcl: * packages/survey/www/admin/index.tcl: * packages/survey/www/admin/modify-responses-2.tcl: * packages/survey/www/admin/modify-responses.tcl: * packages/survey/www/admin/name-edit.tcl: * packages/survey/www/admin/one-respondent.tcl: * packages/survey/www/admin/one.tcl: * packages/survey/www/admin/process-response.tcl: * packages/survey/www/admin/question-active-toggle.tcl: * packages/survey/www/admin/question-add-2.tcl: * packages/survey/www/admin/question-add-3.tcl: * packages/survey/www/admin/question-add.tcl: * packages/survey/www/admin/question-copy.tcl: * packages/survey/www/admin/question-delete.tcl: * packages/survey/www/admin/question-modify-text.tcl: * packages/survey/www/admin/question-modify.tcl: * packages/survey/www/admin/question-required-toggle.tcl: * packages/survey/www/admin/question-swap.tcl: * packages/survey/www/admin/respond.tcl: * packages/survey/www/admin/respondents.tcl: * packages/survey/www/admin/response-delete.tcl: * packages/survey/www/admin/response-drill-down.tcl: * packages/survey/www/admin/response-editable-toggle.tcl: * packages/survey/www/admin/response-limit-toggle.tcl: * packages/survey/www/admin/responses-export.tcl: * packages/survey/www/admin/responses.tcl: * packages/survey/www/admin/send-mail.tcl: * packages/survey/www/admin/site-wide-survey.tcl: * packages/survey/www/admin/survey-category-add.tcl: * packages/survey/www/admin/survey-copy.tcl: * packages/survey/www/admin/survey-create-choice.tcl: * packages/survey/www/admin/survey-create-confirm.tcl: * packages/survey/www/admin/survey-create.tcl: * packages/survey/www/admin/survey-delete.tcl: * packages/survey/www/admin/survey-display-type-edit.tcl: * packages/survey/www/admin/survey-preview.tcl: * packages/survey/www/admin/survey-toggle.tcl: * packages/survey/www/admin/user-responses-delete.tcl: * packages/survey/www/admin/view-text-responses.tcl: * packages/survey/www/index.tcl: * packages/survey/www/one-respondent.tcl: * packages/survey/www/one-survey.tcl: * packages/survey/www/process-response.tcl: * packages/survey/www/respond.tcl: * packages/survey/www/view-attachment.tcl: * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: * packages/xowiki-portlet/www/xowiki-portlet.tcl: * packages/xowiki/resources/templates/error-template.tcl: added editor hints and white-space cleanup * packages/acs-bootstrap-installer/installer/www/SYSTEM/csp-collector.tcl: * packages/acs-core-docs/tcl/acs-core-docs-init.tcl: * packages/acs-mail-lite/www/doc/analysis-notes.tcl: * packages/acs-mail-lite/www/doc/glossary.tcl: * packages/acs-mail-lite/www/doc/imap-install.tcl: * packages/acs-mail-lite/www/doc/imap-test.tcl: * packages/acs-mail-lite/www/doc/inbound-message-bot.tcl: * packages/acs-mail-lite/www/doc/inbound.tcl: * packages/acs-mail-lite/www/doc/incoming-email-legacy-notes.tcl: * packages/acs-mail-lite/www/doc/incoming-email.tcl: * packages/acs-mail-lite/www/doc/index.tcl: * packages/acs-mail-lite/www/doc/maildir-actives-reset.tcl: * packages/acs-mail-lite/www/doc/maildir-install.tcl: * packages/acs-mail-lite/www/doc/maildir-test.tcl: * packages/acs-mail-lite/www/doc/outbound.tcl: * packages/acs-mail-lite/www/doc/setup.tcl: * packages/acs-subsite/tcl/group-init.tcl: * packages/acs-tcl/tcl/acs-permissions-init.tcl: * packages/acs-tcl/tcl/community-core-init.tcl: * packages/acs-tcl/tcl/html-procs.tcl: * packages/acs-tcl/tcl/test/http-client-procs.tcl: added missing editor hints * packages/boomerang/tcl/boomerang-init.tcl: * packages/boomerang/tcl/callback-procs.tcl: * packages/boomerang/www/sitewide-admin/compress.tcl: * packages/boomerang/www/sitewide-admin/index.tcl: added missing editor hints and whitespace cleanup * packages/survey/www/admin/survey-toggle.tcl: improve spelling * packages/forums/www/forum-view.tcl: * packages/forums/www/message-view.tcl: * packages/forums/www/resources/forums.css: * packages/forums/www/resources/print.css: remove print.css and include its content in forums.css * packages/acs-tcl/tcl/apm-install-procs.tcl: * packages/acs-tcl/tcl/request-processor-init.tcl: * packages/forums/www/forum-view.tcl: whitespace changes 2020-02-07 hectorr * packages/acs-authentication/tcl/test/acs-authentication-procs.tcl: Add missing authority_id on the 'auth_authenticate' testcase * packages/acs-authentication/tcl/test/sync-test-procs.tcl: Fallback to 'util_current_location' when 'ad_url' returns an empty string, such in cases when the SystemUrl is not set, on the sync_http_get_document testcase 2020-02-07 gustafn * packages/xotcl-core/www/admin/toggle-debug.tcl: * packages/xowf/tcl/xowf-procs.tcl: * packages/xowiki-portlet/www/xowiki-admin-portlet.tcl: * packages/xowiki/tcl/resource-init.tcl: * packages/xowiki/tcl/test/xowiki-link-test-procs.tcl: * packages/xowiki/www/admin/export.tcl: * packages/xowiki/www/admin/list.tcl: * packages/xowiki/www/admin/portal-element-add.tcl: * packages/xowiki/www/ckeditor-images/delete.tcl: * packages/xowiki/www/ckeditor-images/preview.tcl: * packages/xowiki/www/ckeditor-images/thumb-view.tcl: * packages/xowiki/www/ckeditor-images/upload_image.tcl: * packages/xowiki/www/ckeditor-images/view.tcl: * packages/xowiki/www/xinha/attach-file.tcl: * packages/xowiki/www/xinha/insert-file.tcl: * packages/xowiki/www/xinha/insert-wlink.tcl: whitespace changes and editor hints for all xo* packages 2020-02-06 gustafn * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: - set sanitize on logfile writer per default to 0 - change cleanup interval from 1h to 71min, since on the hour interval, there are already many things going on in OpenACS * packages/xotcl-core/tcl/30-widget-procs.tcl: * packages/xowiki/tcl/bootstrap-procs.tcl: add safety-belt for missing CSSclass attributes * packages/acs-templating/tcl/head-procs.tcl: check, if container resource is really loaded * packages/acs-templating/tcl/head-procs.tcl: fix typo in variable name * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: reduce string operations slightly * packages/xowiki/tcl/form-field-procs.tcl: reduce verbosity 2020-02-06 antoniop * packages/bulk-mail/tcl/bulk-mail-procs.tcl: Whitespace cleanup 2020-02-05 gustafn * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/lib/online-exam.wf: * packages/xowiki/tcl/menu-procs.tcl: - foster standardized message keys for menu entries - provide message key for interaction types 2020-02-04 trenner * packages/tsearch2-driver/tcl/test/tsearch2-driver-procs.tcl: * packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl: support 'AND' and 'OR' at the end of the search string + extend automated tests 2020-02-04 gustafn * packages/xowf/tcl/test-item-procs.tcl: * packages/xowiki/tcl/form-field-procs.tcl: added "starred" grading scores, which should not be treated as final without teacher interaction 2020-02-04 antoniop * packages/forums/tcl/messages-procs.tcl: Fix typo 2020-02-03 hectorr * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: Add 'case' to the list of Tcl keywords. The command is obsolete, deprecated, not documented anymore and slated for removal in Tcl 9.0, but still exists and makes the api_doc confused and unhappy. * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Add an exception for the 'berkdb' command, defined in the global namespace by the Berkeley DB Tcl extension, to the 'naming__proc_naming testcase' * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Add exceptions for some commands defined in the global namespace by the 'Trf' Tcl extension to the 'naming__proc_naming testcase' * packages/acs-automated-testing/tcl/aa-test-procs.tcl: * packages/acs-automated-testing/tcl/selenium-procs.tcl: * packages/acs-automated-testing/tcl/test/selenium-procs.tcl: Rename 'Se', the selenium driver, to '::acs::test::selenium::Se', and repack it into an ad_proc, deprecating the former one and adding the comments on the file proc doc. 2020-02-03 gustafn * packages/xowf/lib/online-exam.wf: - added public method "result_table" - added "back" button to result table and exam protocol * packages/xowf/tcl/test-item-procs.tcl: - added public method "result_table" to answer_manager - added mixin class for handling "form_field.pretty_value" in tables - reduce verbosity * packages/xowiki/tcl/bootstrap-procs.tcl: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/www/resources/xowiki.css: add support in form-fields to add css class for td in TableWidget * packages/xotcl-core/tcl/30-widget-procs.tcl: add support in form-fields to add css class for td in TableWidget and whitespace changes * packages/xowf/xowf.info: bump version number to 5.10.0d13 and update dependencies * packages/xotcl-core/xotcl-core.info: bump version number to 5.10.0d23 * packages/xowiki/xowiki.info: bump version number to 5.10.0d48 and update dependencies * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: extend message catalog * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/table-widget-procs.tcl: factor out table-widget-procs from includelet procs * packages/evaluation/catalog/evaluation.en_US.ISO-8859-1.xml: * packages/file-storage/catalog/file-storage.en_AU.ISO-8859-1.xml: * packages/file-storage/catalog/file-storage.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/form-field-procs.tcl: improve spelling * packages/xotcl-core/tcl/30-widget-procs.tcl: improve stylability * packages/xowiki/tcl/form-field-procs.tcl: provide "pretty_value" for text_fields, sort components of compound fields in "pretty_value" * packages/xowiki/www/resources/xowiki.css: provide CSS classes for alignment in table widgets * packages/acs-api-browser/www/proc-browse.tcl: use value checker "token" for "orderby" (usual checker) * packages/xowf/lib/online-exam-answer.wf: use same style as in online-exam.wf * packages/xowiki/tcl/bootstrap-procs.tcl: whitespace changes 2020-02-02 gustafn * packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl: add method for deep copy of ordered composites * packages/xotcl-core/tcl/context-procs.tcl: add method for saving/restoring perconnection_parameters * packages/xowiki/tcl/xowiki-procs.tcl: don't return @cr_fields ad form_field by create_form_fields_from_form_constraints * packages/xowf/lib/online-exam.wf: fix handling of return_url for www-delete. * packages/xotcl-core/tcl/30-widget-procs.tcl: fix indentation, make it easier to grep for definition of namespaced classes 2020-02-01 gustafn * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: encode includelet key to achieve higher robustness and preserve url-parameter checking * packages/xotcl-core/tcl/context-procs.tcl: make sure that parseargs treats argument as a single one * packages/acs-tcl/tcl/utilities-procs.tcl: provide compatibility wrappers for AOLserver and NaviServer before 4.99.17 * packages/xowf/lib/online-exam-answer.wf: set MenuBar property only during rendering (not on initialization) * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: split up large method into three * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: the includelet_key (as defined) may contain arbitrary characters. Maybe, the key should be encoded in the future, but for now we keep this for compatibility with potential applications 2020-01-31 hectorr * packages/xotcl-core/tcl/30-widget-procs.tcl: * packages/xotcl-request-monitor/www/last101.tcl: * packages/xowiki/resources/templates/view-plain-master.adp: * packages/xowiki/tcl/xowiki-www-procs.tcl: Add 'require_html_procs' to the ::xo namespace in order to be compliant with OpenACS naming standards * packages/xowiki/resources/templates/view-plain-master.adp: Remove conflict leftovers * packages/xotcl-core/tcl/html-procs.tcl: Rename 'require_html_procs' * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: Restrict switches to not negative Tcl numbers, and avoid non-printable characters as well 2020-01-30 gustafn * packages/xowf/lib/online-exam-answer.wf: * packages/xowf/lib/online-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: - distinguish between item_nr (for displaying item number) and position (from available items) - provide hint for clearning menu - activate live updates for online exam * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: improve message keys (grading scheme) * packages/xowf/www/resources/test-item.css: make sure displayed matches are spaced 2020-01-29 hectorr * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Add xml-rpc system.* methods as exceptions in the naming__proc_naming test. The xml-rpc package defines procs of the form system.*, that not only pollute the root namespace, but also contain the '.' character, which is not allowed by OpenACS naming standards. The package is designed in a way that XML-RPC methods are implemented as 'ad_procs' of the same name (see package doc), and the system.* methods are standard XML-RPC methods (see XML-RPC spec). One could also expect current users of the package to have their own local 'whatever.verb' methods/ad_procs in the root namespace as well. Until future refactoring of the package to decouple XML-RPC method and proc names is done, this exception is added. 2020-01-29 gustafn * packages/xowf/tcl/test-item-procs.tcl: answer_manager get_wf_instances: pass "orderby" to xowiki.get_form_entries * packages/xowf/lib/online-exam.wf: print-answers: sort answers by username * packages/xowf/www/resources/test-item.css: provide simple CSS file for printing 2020-01-27 gustafn * packages/xowf/lib/online-exam-answer.wf: improve spelling 2020-01-26 gustafn * packages/xowf/lib/online-exam-answer.wf: add comment to clarify meaning of "current_position" * packages/xowf/tcl/test-item-procs.tcl: add support for multiple grading schemes * packages/acs-tcl/tcl/defs-procs.tcl: fix for issue #3387: ad_return_complaint can reveal error call stacks to end users * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: fix issue #3373 * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/lib/online-exam.wf: improve example menu in comment to include a separator after items * packages/acs-tcl/tcl/utilities-procs.tcl: improve spelling * packages/xowiki/tcl/form-field-procs.tcl: include selected grading score in feedback * packages/xowiki/tcl/includelet-procs.tcl: includelet form-usages: support additional button "slim_publish_status" for display similar to child-resource * packages/xowf/lib/online-exam-answer.wf: * packages/xowiki/resources/templates/oacs-view.adp: * packages/xowiki/resources/templates/oacs-view2.adp: * packages/xowiki/resources/templates/oacs-view3-bootstrap3.adp: * packages/xowiki/resources/templates/oacs-view3.adp: * packages/xowiki/resources/templates/view-book-no-ajax.adp: * packages/xowiki/resources/templates/view-book.adp: * packages/xowiki/resources/templates/view-default.adp: * packages/xowiki/resources/templates/view-links.adp: * packages/xowiki/resources/templates/view-plain-master.adp: * packages/xowiki/resources/templates/view-plain.adp: * packages/xowiki/tcl/adp-generator-procs.tcl: remove spurious colons * packages/acs-tcl/tcl/security-procs.tcl: remove useless semicolon * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/lib/online-exam-answer.wf: use explicit "create" statements * packages/xowiki/tcl/form-field-procs.tcl: whitespace changes 2020-01-25 gustafn * packages/xowf/lib/online-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/xowf.info: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/tcl/package-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: * packages/xowiki/xowiki.info: add item shuffling for test item procs and do some minor refactoring * packages/xotcl-request-monitor/www/whos-online-today.tcl: provide nicer relative times * packages/xotcl-request-monitor/www/last-requests.tcl: * packages/xotcl-request-monitor/www/stat-details.tcl: * packages/xotcl-request-monitor/www/whos-online-today.tcl: strengthen page contracts * packages/xotcl-request-monitor/www/last-requests.tcl: * packages/xotcl-request-monitor/www/last100.tcl: * packages/xotcl-request-monitor/www/last101.tcl: * packages/xotcl-request-monitor/www/stat-details.tcl: * packages/xotcl-request-monitor/www/throttle-statistics.tcl: * packages/xotcl-request-monitor/www/users-in-community.tcl: * packages/xotcl-request-monitor/www/whos-online-today.tcl: * packages/xotcl-request-monitor/www/whos-online.tcl: whitespace cleanup 2020-01-24 hectorr * packages/acs-api-browser/tcl/api-doc-init.tcl: Whitespace changes + editor hints 2020-01-23 hectorr * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: Add 'exit' to the list of Tcl keywords, so it is properly managed by the API-doc logic * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: Avoid looking for proc names in comments after a semicolon or an opening curly brace, so common words in comments are not included in the API-doc as calls to procs with the same name 2020-01-22 hectorr * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: Add 'unknown' to the list of Tcl keywords, so it is properly managed by the API-doc logic 2020-01-21 hectorr * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Add an exception for the 'dom' proc, defined in tDom, to the 'naming__proc_naming' test case * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Add an exception for the operators implemented as procs in the context of the functional programming logic, on 'acs-tcl/tcl/ad-functional-procs.tcl', to the 'naming__proc_naming' test case. While some of them have names that are not compliant with OpenACS naming conventions, like '-' or '/', replacing them with other symbols is non-trivial and could make things more confusing * packages/acs-bootstrap-installer/bootstrap.tcl: Rename the private proc 'bootstrap_fatal_error' to 'acs_bootstrap_fatal_error', to comply with OpenACS naming standards * packages/acs-bootstrap-installer/bootstrap.tcl: Whitespace changes 2020-01-21 antoniop * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: Include more mentioned api * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: List directly mentioned api as tested 2020-01-20 hectorr * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: Fix typo * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Remove extra colon * packages/xotcl-core/tcl/03-doc-procs.tcl: Remove leading colons in XOTcl methods while adding them to the documentation nsvs, to keep coherence among the different ways of adding proc doc in the system and avoid duplication 2020-01-20 antoniop * packages/acs-lang/tcl/locale-procs.tcl: Fix typo * packages/xowiki/tcl/xowiki-procs.tcl: Fix typo, doc changes * packages/xowiki/tcl/xowiki-procs.tcl: Make ::xowiki::Page pretty_link explicitly private, as should be called only after package initialization ::xowiki::Package pretty_link is the public api to generate links * packages/xowiki/tcl/xowiki-procs.tcl: Refer doc to where most of the magic happens 2020-01-19 gustafn * packages/acs-lang/acs-lang.info: bump version number to 5.10.0d8 * packages/acs-lang/tcl/locale-procs.tcl: make lang::conn::language able to run running disconnected; improve documentation * packages/acs-lang/tcl/locale-procs.tcl: make lang::conn::locale more robust when running disconnected * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: simplify handling of setting language for ckeditor * packages/xowiki/tcl/xowiki-procs.tcl: undo change which invites to call pretty_link on uninitialized packages 2020-01-18 gustafn * packages/acs-bootstrap-installer/installer/www/blank-master.adp: * www/blank-master.adp: address issue #3435 (many thanks to Michael Aram) 2020-01-17 hectorr * packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl: Remove private proc 'number_p', used only in 'ad_proc_valid_switch_p', and simplify logic of the latter 2020-01-17 gustafn * packages/xowf/tcl/test-item-procs.tcl: revert incorrect change from some downstream code 2020-01-16 hectorr * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Add an exception for procs defined inside ns/aolserver modules, such as h264*, on the 'naming__proc_naming' test case * packages/xowf/tcl/test-item-procs.tcl: Change message key notation (many thanks to Monika Andergassen) 2020-01-15 trenner * packages/xowiki/tcl/includelet-procs.tcl: ensure nonce is substituted in subst 2020-01-15 antoniop * packages/xowiki/tcl/xowiki-procs.tcl: Improve doc * packages/xowiki/tcl/xowiki-procs.tcl: Improve documentation * packages/xowiki/tcl/xowiki-procs.tcl: Make sure package is initialized, as we do downstream * packages/xowiki/tcl/xowiki-procs.tcl: Make sure page template is instantiated as we do downstream 2020-01-14 trenner * packages/xowiki/tcl/form-field-procs.tcl: check for connection and provide fallback for ckeditor language * packages/acs-tcl/tcl/text-html-procs.tcl: fix typo - deprecated proc should be defined with the old naming convention 2020-01-13 antoniop * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: Introduce two new export_vars tests exposing that, when base URL ends with a ?, result is not what the user should expect * packages/acs-admin/www/apm/package-add.tcl: * packages/acs-admin/www/apm/packages-install-4.tcl: * packages/acs-admin/www/apm/version-edit.tcl: * packages/acs-admin/www/install/install-3.tcl: * packages/acs-tcl/tcl/defs-procs.tcl: * packages/acs-templating/tcl/paginator-procs.tcl: * packages/acs-templating/tcl/richtext-or-file-procs.tcl: * packages/acs-templating/tcl/richtext-procs.tcl: * packages/xowiki/tcl/chat-procs.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/link-procs.tcl: Prefer api to retrieve csp nonce, as it performs useful existence checks * packages/acs-tcl/tcl/utilities-procs.tcl: Trim trailing ? to normalize -base URL, if variables are there to be exported, the question mark will be added properly 2020-01-09 mischa * packages/cookie-consent/tcl/cookie-consent-procs.tcl: Fix typo in example in comment * packages/cookie-consent/tcl/cookie-consent-procs.tcl: Fix typo in package key 2020-01-09 antoniop * packages/acs-tcl/tcl/test/http-client-procs.tcl: Fix util_http_json_encoding automated test: - fix typo - make sure file is spooled when sampling GET request by setting max body size to 0 * packages/acs-tcl/tcl/test/http-client-procs.tcl: Improve test results visibility * packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl: Port "The Secret XoWiki Tests" to acs-automated-testing A level of abstraction for test operations was already put in place, which was sufficient to plug to aa_* API * packages/acs-tcl/tcl/test/navigation-procs.tcl: Relax the test by enforcing the locale from the system, rather than that from the client context * packages/acs-tcl/tcl/http-client-procs.tcl: Satisfy acs-tcl.postman_echo test case for curl http client implementation: as with curl we always spool the body of requests into a file, we need to convert to the proper encoding even when this is already that of the system 2020-01-08 antoniop * packages/chat-portlet/tcl/chat-admin-portlet-procs.tcl: * packages/chat-portlet/tcl/chat-portlet-procs.tcl: Add doc for public procs * packages/dotlrn-homework/dotlrn-homework.info: * packages/dotlrn-homework/tcl/apm-callback-procs.tcl: * packages/dotlrn-homework/tcl/dotlrn-homework-procs.tcl: Port leftover after-instantiate callback to the "new standard" so that it can comply with OpenACS naming convention * packages/acs-subsite/tcl/subsite-procs.tcl: Qualify 'callback' proc in the global namespace, lest it might conflict with 'subsite::callback' * packages/acs-subsite/tcl/attribute-procs-oracle.xql: * packages/acs-subsite/tcl/attribute-procs-postgresql.xql: * packages/acs-subsite/tcl/attribute-procs.tcl: * packages/new-portal/tcl/portal-procs-oracle.xql: * packages/new-portal/tcl/portal-procs-postgresql.xql: * packages/new-portal/tcl/portal-procs.xql: Reduce divergency between oracle and postgres codebase * packages/acs-tcl/tcl/security-procs-postgresql.xql: Reintroduce :num_count variable in postgres query, as for oracle counterpart (for postgres, 15 was hardcoded) Notes: - :num_count comes from a parameter, defaulting to 100, instead of 15 - postgres 9.5 introduced table sampling, similar to what oracle does (but with different syntax) - this postgres query would be portable, except for random()... maybe the random value could come from tcl... * packages/search/tcl/search-procs.xql: Use portable sql idioms * packages/acs-tcl/tcl/apm-procs-oracle.xql: * packages/acs-tcl/tcl/apm-procs-postgresql.xql: * packages/acs-tcl/tcl/apm-procs.xql: * packages/acs-tcl/tcl/security-procs-oracle.xql: * packages/acs-tcl/tcl/security-procs-postgresql.xql: * packages/acs-tcl/tcl/security-procs.xql: Whitespace cleanup 2020-01-07 antoniop * packages/forums/tcl/messages-procs.tcl: Deprecate obsolete api * packages/forums/tcl/messages-procs.tcl: Implement operation in a way that oracle is supported * packages/forums/tcl/messages-procs.tcl: Indentation changes * packages/forums/tcl/messages-procs.tcl: No need to explicitly delete reading info, as both oracle and postgres define the reference constraint as on delete cascade * packages/acs-admin/www/users/member-state-change-oracle.xql: * packages/acs-admin/www/users/member-state-change-postgresql.xql: * packages/acs-admin/www/users/member-state-change.tcl: * packages/acs-subsite/www/admin/group-types/one-oracle.xql: * packages/acs-subsite/www/admin/group-types/one-postgresql.xql: * packages/acs-subsite/www/admin/group-types/one.tcl: * packages/forums/tcl/messages-procs-oracle.xql: * packages/forums/tcl/messages-procs-postgresql.xql: * packages/forums/tcl/messages-procs.tcl: Reduce divergency between oracle and postgres codebase * packages/forums/tcl/messages-procs.tcl: Use fully-qualified api names * packages/forums/tcl/messages-procs.tcl: Use fully-qualified api names, assume message is there (something went very wrong otherwise) * packages/acs-lang/tcl/localization-procs-oracle.xql: * packages/acs-lang/tcl/localization-procs-postgresql.xql: * packages/forums/tcl/messages-procs.tcl: Whitespace cleanup 2020-01-03 gustafn * packages/acs-tcl/tcl/defs-procs.tcl: fix for issue #3434 2020-01-03 antoniop * packages/acs-subsite/www/admin/rel-segments/one-oracle.xql: * packages/acs-subsite/www/admin/rel-segments/one-postgresql.xql: * packages/acs-subsite/www/admin/rel-segments/one.tcl: Reduce divergencies between oracle and postgres codebase * packages/acs-subsite/tcl/subsite-procs-oracle.xql: * packages/acs-subsite/tcl/subsite-procs-postgresql.xql: * packages/acs-subsite/tcl/subsite-procs.tcl: * packages/acs-subsite/www/admin/groups/rel-type-add-2-oracle.xql: * packages/acs-subsite/www/admin/groups/rel-type-add-2-postgresql.xql: * packages/acs-subsite/www/admin/groups/rel-type-add-2.tcl: * packages/acs-subsite/www/admin/rel-types/delete-2-oracle.xql: * packages/acs-subsite/www/admin/rel-types/delete-2-postgresql.xql: * packages/acs-subsite/www/admin/rel-types/delete-2.tcl: * packages/acs-subsite/www/admin/relations/add-oracle.xql: * packages/acs-subsite/www/admin/relations/add-postgresql.xql: * packages/acs-subsite/www/admin/relations/add.tcl: * packages/acs-tcl/tcl/site-node-object-map-procs-oracle.xql: * packages/acs-tcl/tcl/site-node-object-map-procs-postgresql.xql: * packages/acs-tcl/tcl/site-node-object-map-procs.tcl: Reduce divergency between oracle and postgres codebase * packages/acs-content-repository/tcl/revision-procs-oracle.xql: * packages/acs-content-repository/tcl/revision-procs-postgresql.xql: * packages/acs-content-repository/tcl/revision-procs.tcl: * packages/acs-content-repository/tcl/revision-procs.xql: Reduce divergency between oracle and postgres codebase, bring portable sql inline * packages/acs-subsite/www/admin/groups/elements-display.adp: * packages/acs-subsite/www/admin/groups/elements-display.tcl: Remove duplicated page properties, fix URL by using export_vars * packages/acs-subsite/www/admin/relations/add.tcl: Remove leftover test code * packages/acs-service-contract/tcl/acs-service-contract-init-oracle.xql: * packages/acs-service-contract/tcl/acs-service-contract-init-postgresql.xql: * packages/bulk-mail/tcl/bulk-mail-procs-oracle.xql: * packages/bulk-mail/tcl/bulk-mail-procs-postgresql.xql: Remove leftover xql files * packages/acs-content-repository/tcl/revision-procs-oracle.xql: * packages/acs-content-repository/tcl/revision-procs-postgresql.xql: * packages/acs-subsite/tcl/subsite-procs-oracle.xql: * packages/acs-subsite/tcl/subsite-procs-postgresql.xql: Whitespace cleanup 2020-01-02 antoniop * packages/acs-subsite/lib/services.tcl: Add ad_include_contract * packages/acs-subsite/lib/user-info.tcl: Fix remaining occurrence of "screen_name" variable used to actually tell HOW to display the screen_name * packages/acs-service-contract/tcl/acs-service-contract-procs-oracle.xql: * packages/acs-service-contract/tcl/acs-service-contract-procs-postgresql.xql: * packages/acs-service-contract/tcl/acs-service-contract-procs.tcl: * packages/acs-service-contract/www/binding-uninstall-oracle.xql: * packages/acs-service-contract/www/binding-uninstall-postgresql.xql: * packages/acs-service-contract/www/binding-uninstall.tcl: * packages/acs-service-contract/www/index-oracle.xql: * packages/acs-service-contract/www/index-postgresql.xql: * packages/acs-service-contract/www/index.tcl: * packages/acs-subsite/www/admin/group-types/index-oracle.xql: * packages/acs-subsite/www/admin/group-types/index-postgresql.xql: * packages/acs-subsite/www/admin/group-types/index.tcl: * packages/acs-subsite/www/admin/groups/constraints-create-oracle.xql: * packages/acs-subsite/www/admin/groups/constraints-create-postgresql.xql: * packages/acs-subsite/www/admin/groups/constraints-create.tcl: * packages/acs-subsite/www/admin/groups/elements-display-oracle.xql: * packages/acs-subsite/www/admin/groups/elements-display-postgresql.xql: * packages/acs-subsite/www/admin/groups/elements-display.tcl: * packages/acs-subsite/www/admin/rel-segments/constraints/index-oracle.xql: * packages/acs-subsite/www/admin/rel-segments/constraints/index-postgresql.xql: * packages/acs-subsite/www/admin/rel-segments/constraints/index.tcl: * packages/acs-subsite/www/admin/rel-segments/elements-oracle.xql: * packages/acs-subsite/www/admin/rel-segments/elements-postgresql.xql: * packages/acs-subsite/www/admin/rel-segments/elements.tcl: * packages/acs-subsite/www/admin/rel-segments/new-oracle.xql: * packages/acs-subsite/www/admin/rel-segments/new-postgresql.xql: * packages/acs-subsite/www/admin/rel-segments/new.tcl: * packages/acs-subsite/www/admin/relations/remove-oracle.xql: * packages/acs-subsite/www/admin/relations/remove-postgresql.xql: * packages/acs-subsite/www/admin/relations/remove.tcl: * packages/acs-subsite/www/admin/site-map/application-new-oracle.xql: * packages/acs-subsite/www/admin/site-map/application-new-postgresql.xql: * packages/acs-subsite/www/admin/site-map/application-new.tcl: * packages/news-portlet/www/news-portlet-oracle.xql: * packages/news-portlet/www/news-portlet-postgresql.xql: * packages/news-portlet/www/news-portlet.tcl: Reduce divergency between oracle and postgres codebase * packages/acs-service-contract/tcl/contract-procs-oracle.xql: * packages/acs-service-contract/tcl/contract-procs-postgresql.xql: * packages/acs-service-contract/tcl/contract-procs.tcl: Reduce divergency between oracle and postgres codebase, resolve ancient TODOs, reinstate lost query * packages/acs-subsite/tcl/package-procs.tcl: Replace deprecated idiom * packages/tsearch2-driver/tcl/tsearch2-driver-install-procs.tcl: * packages/tsearch2-driver/tsearch2-driver.info: Support uninstall/reinstall use case by implementing a uninstall callback getting rid of service contract implementations * packages/acs-subsite/lib/user-subsites.tcl: * packages/file-storage/lib/recent.tcl: * packages/openacs-default-theme/lib/tabbed-master.tcl: * packages/views/lib/record-view.tcl: * packages/views/lib/views-chunk.tcl: Use ad_include_contract * packages/openacs-default-theme/lib/plain-streaming-head.tcl: Use ad_include_contract, add some remarks * packages/acs-templating/www/admin/test/include.tcl: Use ad_page_contract, add some remarks * packages/acs-subsite/www/pvt/toggle-don't-spam-me-p.tcl: Use ad_page_contract, remove redundant sql 2019-12-30 antoniop * packages/search/www/index.tcl: Delete NOOP tcl file * packages/news/lib/news.tcl: Publish body is not optional and might contain HTML * packages/news/lib/news.tcl: * packages/xowiki/www/portlets/weblog-mini-calendar.tcl: Use ad_include_contract * packages/news/www/news.tcl: Use ad_include_contract * packages/xowiki/www/portlets/weblog-mini-calendar.adp: * packages/xowiki/www/portlets/weblog-mini-calendar.tcl: Whitespace cleanup 2019-12-27 antoniop * packages/chat/tcl/chat-procs.tcl: * packages/forums/tcl/forums-security-procs.tcl: Add @see for deprecated procs 2019-12-26 gustafn * packages/acs-tcl/tcl/request-processor-procs.tcl: improve handling of invalid characters * packages/acs-tcl/tcl/test/file-test-procs.tcl: * packages/acs-tcl/tcl/text-html-procs.tcl: * packages/acs-tcl/tcl/widgets-procs.tcl: improve spelling 2019-12-22 gustafn * packages/xowiki/tcl/form-field-procs.tcl: add scoring calculations * packages/xowiki/tcl/form-field-procs.tcl: improve comments 2019-12-20 gustafn * packages/acs-lang/www/admin/export-messages.tcl: * packages/acs-lang/www/admin/message-conflicts.tcl: improve page contracts * packages/acs-lang/www/admin/batch-editor.tcl: * packages/acs-lang/www/admin/edit-description.tcl: * packages/acs-lang/www/admin/edit-history.tcl: * packages/acs-lang/www/admin/edit-localized-message.tcl: * packages/acs-lang/www/admin/export-locale-to-files.tcl: * packages/acs-lang/www/admin/export-messages.tcl: * packages/acs-lang/www/admin/import-locale-from-files.tcl: * packages/acs-lang/www/admin/import-messages.tcl: * packages/acs-lang/www/admin/locale-delete.tcl: * packages/acs-lang/www/admin/locale-edit.tcl: * packages/acs-lang/www/admin/locale-make-default.tcl: * packages/acs-lang/www/admin/locale-set-enabled-p.tcl: * packages/acs-lang/www/admin/localized-message-new.tcl: * packages/acs-lang/www/admin/message-conflict-resolve.tcl: * packages/acs-lang/www/admin/message-conflict-revert.tcl: * packages/acs-lang/www/admin/message-delete.tcl: * packages/acs-lang/www/admin/message-list.tcl: * packages/acs-lang/www/admin/message-search.tcl: * packages/acs-lang/www/admin/message-undelete.tcl: * packages/acs-lang/www/admin/message-unregister.tcl: * packages/acs-lang/www/admin/package-list.tcl: improve page_contracts * packages/categories/www/cadmin/category-delete-2.tcl: * packages/categories/www/cadmin/category-delete.tcl: * packages/categories/www/cadmin/category-form.tcl: * packages/categories/www/cadmin/category-link-add-2.tcl: * packages/categories/www/cadmin/category-link-add-3.tcl: * packages/categories/www/cadmin/category-link-add-4.tcl: * packages/categories/www/cadmin/category-link-add.tcl: * packages/categories/www/cadmin/category-link-delete-2.tcl: * packages/categories/www/cadmin/category-link-delete.tcl: * packages/categories/www/cadmin/category-links-view.tcl: * packages/categories/www/cadmin/category-parent-change-2.tcl: * packages/categories/www/cadmin/category-parent-change.tcl: * packages/categories/www/cadmin/category-phase-in.tcl: * packages/categories/www/cadmin/category-phase-out.tcl: * packages/categories/www/cadmin/category-usage.tcl: * packages/categories/www/cadmin/index.tcl: * packages/categories/www/cadmin/master.tcl: * packages/categories/www/cadmin/object-map.tcl: * packages/categories/www/cadmin/one-object.tcl: * packages/categories/www/cadmin/permission-manage.tcl: * packages/categories/www/cadmin/site-wide-status-change.tcl: * packages/categories/www/cadmin/synonym-delete-2.tcl: * packages/categories/www/cadmin/synonym-delete.tcl: * packages/categories/www/cadmin/synonym-form.tcl: * packages/categories/www/cadmin/synonyms-view.tcl: * packages/categories/www/cadmin/tree-copy-2.tcl: * packages/categories/www/cadmin/tree-copy-view.tcl: * packages/categories/www/cadmin/tree-copy.tcl: * packages/categories/www/cadmin/tree-delete-2.tcl: * packages/categories/www/cadmin/tree-delete.tcl: * packages/categories/www/cadmin/tree-form.tcl: * packages/categories/www/cadmin/tree-map-2.tcl: * packages/categories/www/cadmin/tree-map.tcl: * packages/categories/www/cadmin/tree-order-update.tcl: * packages/categories/www/cadmin/tree-unmap-2.tcl: * packages/categories/www/cadmin/tree-unmap.tcl: * packages/categories/www/cadmin/tree-usage.tcl: * packages/categories/www/cadmin/tree-view.tcl: * packages/categories/www/cadmin/trees-code.tcl: tighten page contracts * packages/acs-tcl/tcl/server-cluster-procs.tcl: white space changes, improve line breaks 2019-12-20 antoniop * packages/search/lib/search.tcl: Add ad_include_contract * packages/acs-bootstrap-installer/installer/www/SYSTEM/csp-collector.tcl: Add ad_page_contract * packages/xowiki/www/portlet-ajax.tcl: * packages/xowiki/www/portlet.tcl: Add ad_page_contract, improve contract * packages/acs-tcl/tcl/test/file-test-procs.tcl: Extend automated test to include also '::xowiki::Package initialize -ad_doc' idiom as a possible way to define a page contract This has the limitation that the idiom is searched as-is... but works for upstream code * packages/calendar/www/view-list-display.tcl: Replace deprecated idiom * packages/xowiki/www/portlets/forums-portlet.tcl: Update api, prefer bind variables * packages/forums/lib/message/messages-list.tcl: * packages/forums/lib/search/search-form.tcl: * packages/xowiki/lib/view.tcl: * packages/xowiki/www/portlets/forums-portlet.tcl: Use ad_include_contract * packages/xowiki/www/admin/samples/ajax-chat.tcl: * packages/xowiki/www/admin/test.tcl: * packages/xowiki/www/portlet-ajax.tcl: * packages/xowiki/www/portlets/calendar-portlet.tcl: Use ad_page_contract * packages/forums/lib/message/messages-list.tcl: Use portable idioms * packages/forums/lib/message/messages-list.tcl: * packages/xowiki/www/admin/bulk-delete.tcl: Whitespace cleanup * packages/categories/www/cadmin/master.tcl: add ad_page_contract 2019-12-19 gustafn * packages/acs-templating/tcl/element-procs.tcl: * packages/acs-templating/tcl/widget-procs.tcl: Avoid sending potentially unquoted text via hidden form field * packages/acs-tcl/tcl/form-processing-procs.tcl: * packages/acs-templating/tcl/element-procs.tcl: * packages/acs-templating/tcl/widget-procs.tcl: address issue #3433: add option "noquote" for the "inform" widget type The flag is currently ignored for all other widget types * packages/acs-templating/www/doc/TclDocs/content.adp: * packages/acs-templating/www/doc/TclDocs/pagination.adp: capitalize SQL * packages/xowf/tcl/test-item-procs.tcl: switch back to previous version (change of Antonio was due to some local changes) * packages/acs-templating/tcl/deprecated-procs.tcl: * packages/acs-templating/tcl/head-procs.tcl: use same spelling for "i.e." as everywhere else 2019-12-19 antoniop * packages/rss-support/www/admin/subscrs.tcl: Add ad_page_contract * packages/acs-lang/www/admin/lookups-include.tcl: Add remark: this file seems to be a leftover from the old good days * packages/acs-api-browser/lib/search.tcl: * packages/acs-lang/lib/conflict-link.tcl: * packages/acs-lang/lib/messages-to-translate.tcl: * packages/acs-lang/www/admin/audit-include.tcl: * packages/acs-lang/www/admin/lookups-include.tcl: * packages/acs-lang/www/admin/message-usage-include.tcl: * packages/rss-support/www/subscrs-include.tcl: Use ad_include_contract * packages/acs-service-contract/www/index.tcl: * packages/rss-support/www/my-subscrs.tcl: Use ad_page_contract * packages/acs-api-browser/lib/search.adp: * packages/acs-api-browser/lib/search.tcl: * packages/acs-lang/www/admin/audit-include.tcl: * packages/acs-service-contract/www/index.tcl: * packages/rss-support/www/subscrs-include.tcl: Whitespace cleanup 2019-12-18 antoniop * packages/acs-authentication/tcl/authentication-procs.tcl: Replace deprecated idiom * packages/xowf/tcl/test-item-procs.tcl: Use www- prefix for web callable methods to avoid warnings 2019-12-17 gustafn * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: bump version number of ckeditor to 4.13.1 2019-12-17 antoniop * packages/acs-subsite/www/admin/site-map/instance-delete.tcl: * packages/acs-subsite/www/admin/site-map/instance-delete.xql: Bring sql inline, streamline sql idiom * packages/acs-core-docs/www/xml/kernel/ext-auth-design.xml: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/assessment/www/asm-admin/export/index.vuh: * packages/evaluation/www/admin/evaluations/download-archive/index.vuh: * packages/file-storage/www/download-archive/index.vuh: Deprecate with_finally and with_catch, superseded by e.g. try idioms in tcl 8.6 They would also not comply with OpenACS naming convention * packages/acs-templating/tcl/0-acs-templating-procs.tcl: Fix flag in proc definition * packages/acs-tcl/tcl/site-nodes-procs.tcl: Fix typo * packages/survey/tcl/survey-notification-procs.tcl: * packages/survey/tcl/survey-procs-oracle.xql: * packages/survey/tcl/survey-procs-postgresql.xql: * packages/survey/tcl/survey-procs.tcl: * packages/survey/tcl/survey-procs.xql: * packages/survey/www/admin/description-edit.tcl: * packages/survey/www/admin/modify-responses-2.tcl: * packages/survey/www/admin/modify-responses.tcl: * packages/survey/www/admin/name-edit.tcl: * packages/survey/www/admin/one-respondent.tcl: * packages/survey/www/admin/one.tcl: * packages/survey/www/admin/process-response.tcl: * packages/survey/www/admin/question-active-toggle.tcl: * packages/survey/www/admin/question-add-2.tcl: * packages/survey/www/admin/question-add-3.tcl: * packages/survey/www/admin/question-add.tcl: * packages/survey/www/admin/question-copy.tcl: * packages/survey/www/admin/question-delete.tcl: * packages/survey/www/admin/question-modify-text.tcl: * packages/survey/www/admin/question-modify.tcl: * packages/survey/www/admin/question-required-toggle.tcl: * packages/survey/www/admin/respond.tcl: * packages/survey/www/admin/respondents.tcl: * packages/survey/www/admin/response-drill-down.tcl: * packages/survey/www/admin/responses-export.tcl: * packages/survey/www/admin/responses.tcl: * packages/survey/www/admin/send-mail.tcl: * packages/survey/www/admin/survey-category-add.tcl: * packages/survey/www/admin/survey-copy.tcl: * packages/survey/www/admin/survey-copy.xql: * packages/survey/www/admin/survey-delete.tcl: * packages/survey/www/admin/survey-display-type-edit.tcl: * packages/survey/www/admin/survey-preview.tcl: * packages/survey/www/admin/view-text-responses.tcl: * packages/survey/www/one-respondent.tcl: * packages/survey/www/process-response.tcl: * packages/survey/www/respond.tcl: Rename get_survey_info, survey_answer_summary_display, survey_copy, survey_decode_boolean_answer, survey_display_types, survey_do_notifications, survey_get_score, survey_question_copy and survey_question_display to comply with OpenACS naming convention (all brought to the survey:: namespace), create deprecated wrappers, replace occurrences * packages/acs-subsite/tcl/subsite-callback-procs-oracle.xql: * packages/acs-subsite/tcl/subsite-callback-procs-postgresql.xql: * packages/acs-subsite/tcl/subsite-callback-procs.tcl: Rename subsite_callback to comply with OpenACS naming convention, reduce divergency between oracle and postgres codebase * packages/acs-templating/tcl/0-acs-templating-procs.tcl: * packages/acs-templating/tcl/list-procs.tcl: * packages/acs-templating/tcl/tab-procs.tcl: * packages/acs-templating/tcl/table-procs.tcl: * packages/acs-templating/tcl/tag-init.tcl: Rename template_tag proc to comply with OpenACS naming convention, create deprecated wrapper, massage variable juggling (use an absolutely namespaced variable instead of a namespace-sensitive one) * packages/acs-core-docs/www/xml/kernel/ext-auth-design.xml: * packages/acs-templating/tcl/0-acs-templating-procs.tcl: * packages/assessment/www/asm-admin/export/index.vuh: * packages/evaluation/www/admin/evaluations/download-archive/index.vuh: * packages/survey/tcl/survey-procs.tcl: * packages/survey/www/admin/survey-copy.tcl: Whitespace cleanup 2019-12-16 mischa * packages/acs-developer-support/tcl/acs-developer-support-procs.tcl: Make sure, variable you_are_really is initialized 2019-12-16 hectorr * packages/calendar/www/view-list-display.tcl: Adapt clock format for the now stricter 'lc_time_fmt' 2019-12-16 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: re-enable source_dependent operation (not clear, why this was commented out) 2019-12-16 antoniop * packages/acs-templating/tcl/util-procs.tcl: Bring stack_dump in the templating:: namespace to comply with OpenACS naming convention, create deprecated wrapper * packages/acs-lang/tcl/localization-procs.tcl: Doc formatting changes * packages/acs-lang/tcl/localization-procs.tcl: Fix typo * packages/acs-lang/tcl/localization-procs.tcl: * packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl: Keep supporting previously undocumented use cases for lc_time_fmt: - database timestamps e.g. "2019-12-16 12:58:10.370124+01" - short timestamps without seconds e.g. "2019-12-16 12:58" Improved documentation and extended test cases * packages/acs-content-repository/tcl/revision-procs.tcl: * packages/acs-core-docs/www/eng-standards-filenaming.adp: * packages/acs-core-docs/www/xml/engineering-standards/filenaming.xml: * packages/acs-subsite/www/shared/1pixel.tcl: * packages/acs-tcl/tcl/defs-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/dotlrn/www/admin/community-members-add-to-community.tcl: * packages/dotlrn/www/deregister.tcl: * packages/survey/www/admin/responses-export.tcl: * packages/survey/www/view-attachment.tcl: Rename ReturnHeaders proc to comply with OpenACS naming convention, create deprecated wrapper, replace occurrences * packages/acs-tcl/tcl/utilities-procs.tcl: Rename proc remove_nulls_from_ns_set to comply with OpenACS naming convention, create deprecated wrapper * packages/acs-admin/www/auth/authority.tcl: * packages/acs-admin/www/auth/batch-job.tcl: * packages/acs-lang/www/admin/message-conflicts.tcl: * packages/acs-tcl/tcl/test/html-conversion-procs.tcl: * packages/acs-tcl/tcl/text-html-procs.tcl: * packages/acs-templating/tcl/list-procs.tcl: * packages/news-portlet/www/summary.tcl: * packages/notifications/tcl/notification-procs.tcl: * packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl: * packages/xotcl-request-monitor/www/last-requests.tcl: * packages/xotcl-request-monitor/www/stat-details.tcl: Rename string_truncate and string_truncate_middle to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences As string_truncate_middle was defined in xotcl-request-monitor, bring it to acs-tcl instead * packages/acs-tcl/tcl/text-html-procs.tcl: Whitespace cleanup 2019-12-13 gustafn * packages/xowf/lib/online-exam-answer.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/test-item.css: add minutes string to exam protocol add support for multi-line entries in short_text answers minor refactoring to general handling of printing minutes per question * packages/xowiki/tcl/form-field-procs.tcl: allow empty "correct_when" field * packages/acs-authentication/tcl/authentication-procs.tcl: break overlong lines * packages/acs-subsite/lib/user-info.tcl: bug-fix: don't use variable "screen_name" for controlling display of ScreenName, since it used as value for the actual screen name as well. as a consequence, user got e.g. a value of "none" set as their actual screen name, which lead to a conflict with the unique screen name constraint of the data model * packages/xowiki/tcl/form-field-procs.tcl: support multiple lines in text_fields (as used by sort-text questions) 2019-12-13 antoniop * packages/acs-content-repository/tcl/search-procs.tcl: Add ad_library and a bit of doc * packages/acs-lang/tcl/localization-data-init.tcl: * packages/acs-lang/tcl/localization-procs.tcl: Address lc_time_fmt shortcomings: - use clock scan to enforce supported date formats, 'YYYY-MM-DD' (undocumented, but explicitly checked for in the code) and 'YYYY-MM-DD HH:MM:SS' - leverage clock scan capabilities to correctly handle 'impossible dates' such as 1999-02-29 - leverage clock format to obtain the correct week day - leverage clock api to correctly handle gregorian/julian dates - implement documented formats that had an empty entry in format array (%W, u, %U, %j) * packages/acs-datetime/tcl/acs-calendar-2-procs.tcl: Deprecate a bunch of date widget procs: they use hardcoded markup, lack localization, don't leverage existing tcl capabilities and most importantly are not in use anywhere in current codebase * packages/acs-content-repository/acs-content-repository.info: * packages/acs-content-repository/sql/postgresql/content-search.sql: * packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d7-5.10.0d8.sql: * packages/acs-content-repository/tcl/search-procs.tcl: Move CR search callbacks to new namespace in compliance with OpenACS naming convention, create deprecated wrappers, update service contract tables * packages/acs-subsite/tcl/rel-segments-procs-oracle.xql: * packages/acs-subsite/tcl/rel-segments-procs-postgresql.xql: * packages/acs-subsite/tcl/rel-segments-procs.tcl: * packages/acs-subsite/tcl/rel-segments-procs.xql: * packages/acs-subsite/tcl/subsite-procs.tcl: * packages/acs-subsite/tcl/test/acs-subsite-procs.tcl: * packages/acs-subsite/www/admin/groups/rel-type-remove-2.tcl: * packages/acs-subsite/www/admin/rel-segments/delete-2.tcl: * packages/acs-subsite/www/admin/rel-segments/new-3.tcl: * packages/acs-subsite/www/admin/rel-types/delete-2.tcl: * packages/dotlrn/tcl/community-procs.tcl: Move rel_segments_* procs in new rel_segment:: namespace to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences * packages/acs-content-repository/tcl/search-procs.tcl: Prefer bind variables, use portable idioms * packages/acs-content-repository/sql/postgresql/content-search.sql: * packages/acs-content-repository/tcl/search-procs.tcl: * packages/acs-subsite/tcl/rel-segments-procs-oracle.xql: * packages/acs-subsite/tcl/rel-segments-procs-postgresql.xql: Whitespace cleanup 2019-12-12 gustafn * packages/acs-subsite/tcl/email-image-procs.tcl: add missing SQL query * packages/acs-tcl/tcl/openacs-kernel-procs.tcl: * packages/acs-tcl/tcl/text-html-procs.tcl: avoid output of duplicate lines when an empty input line is encountered (many thanks to Franz Penz for the fix) * packages/acs-tcl/tcl/openacs-kernel-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: remove openacs-kernel-procs.tcl due to its misleading name and integrate its procs to the other utility procs * packages/acs-tcl/tcl/openacs-kernel-procs.tcl: whitespace cleanup 2019-12-11 antoniop * packages/acs-templating/tcl/form-procs.tcl: Deprecate "form" proc, as it doesn't comply with naming convention * packages/acs-templating/tcl/query-procs.tcl: Deprecate "multirow" proc as it does not comply with OpenACS naming convention * packages/acs-lang/www/change-locale-include.tcl: * packages/acs-subsite/www/shared/session-update.tcl: * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/acs-tcl/tcl/tcl-documentation-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/categories/lib/map.tcl: * packages/evaluation-portlet/www/evaluation-admin-portlet.tcl: * packages/faq/www/categories/remove.tcl: Deprecated get_referrer and NsSettoTclString, replace them with versions that respect OpenACS naming convention * packages/forums/tcl/forums-callback-procs-oracle.xql: * packages/forums/tcl/forums-callback-procs-postgresql.xql: * packages/forums/tcl/forums-callback-procs.tcl: Reduce divergency between oracle and postgres codebase * packages/acs-tcl/tcl/html-email-procs.tcl: * packages/notifications/tcl/notification-email-procs.tcl: Replace parse_incoming_email with ad_parse_incoming_email, replace occurrences * packages/acs-tcl/tcl/community-core-procs-oracle.xql: * packages/acs-tcl/tcl/community-core-procs-postgresql.xql: * packages/acs-tcl/tcl/object-type-procs-oracle.xql: * packages/acs-tcl/tcl/object-type-procs-postgresql.xql: Whitespace cleanup 2019-12-09 gustafn * packages/acs-lang/www/admin/edit-localized-message.tcl: Provide convenience link to default locale (resolves issue #3430) * packages/calendar/tcl/cal-item-procs.tcl: improve comments * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: improve spelling * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/utilities-procs.tcl: make passing name for temp tables optional 2019-12-09 antoniop * packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml: Update italian localization 2019-12-06 gustafn * packages/xotcl-core/tcl/cr-procs.tcl: Address suggestion from issue #3420 * packages/xowiki/tcl/form-field-procs.tcl: distinguish betweem Tcl command "file" and '::xowiki::formfield::file' 2019-12-05 gustafn * packages/xowiki/tcl/form-field-procs.tcl: - add stopword list for word cloud - use just lowercase words in word cloud * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/lib/online-exam.wf: improve internationalization * packages/xowf/lib/inclass-quiz-answer.wf: inclass-quizz: support as well participants, which are not logged-in 2019-12-04 gustafn * packages/acs-lang/www/admin/edit-localized-message.tcl: fix for issue # 3429 * packages/xowiki/tcl/form-field-procs.tcl: generalize "transimit_always" handling for select, radio and checkbox 2019-12-03 trenner * packages/xowiki/resources/templates/error-template.adp: * packages/xowiki/resources/templates/error-template.tcl: use ::template::head instead of broken variable substitution 2019-12-03 gustafn * packages/acs-admin/www/users/user-add-2.tcl: * packages/dotlrn/www/user-add-2.tcl: complete commit http://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agusta fn%3A20191128110631 * packages/xowiki/tcl/form-field-procs.tcl: fix a bug in multi-selects, when de-selecting the last element of an optional mulit-select (many thanks to Michael Aram) 2019-12-02 antoniop * packages/acs-tcl/tcl/widgets-procs.tcl: Reinstate a fixed, but deprecated version of us_state_widget 2019-11-29 gustafn * packages/xowiki/tcl/form-field-procs.tcl: handle more "correct_when" cases when providing a value via. "make_correct" * packages/xowf/lib/inclass-quiz-answer.wf: * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/www/resources/test-item.css: improve responsiveness * packages/xowf/tcl/test-item-procs.tcl: make sure to initialize variables (necessary for inclass-quiz) * packages/xowiki/tcl/form-field-procs.tcl: make the same (transitional) change for improved mobile behavior on radio checkmarks * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-quiz-answer.wf: * packages/xowf/lib/inclass-quiz.wf: more polishing of message keys and code * packages/xowiki/tcl/form-field-procs.tcl: use always check-box inline for formatting * packages/xowiki/tcl/form-field-procs.tcl: whitespace changes and fix logic for valid_subselection 2019-11-29 antoniop * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: Add more borderline cases for those tempted to reimplement these procs * packages/acs-tcl/tcl/widgets-procs.tcl: Delete this proc: does not comply with naming convention, uses the wrong table (even when the dependency package is installed), cannot be themed... you name it * packages/acs-tcl/tcl/widgets-procs.tcl: Deprecate a bunch of old and weird api used nowhere * packages/acs-tcl/tcl/utilities-procs.tcl: Deprecate merge_form_with_query proc * packages/acs-core-docs/www/tutorial-categories.adp: * packages/acs-core-docs/www/tutorial-categories.html: * packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/categories/tcl/category-form-procs.tcl: * packages/categories/www/cadmin/category-delete.tcl: * packages/categories/www/cadmin/category-form.tcl: * packages/categories/www/cadmin/category-link-add-2.tcl: * packages/categories/www/cadmin/category-link-add.tcl: * packages/categories/www/cadmin/category-link-delete.tcl: * packages/categories/www/cadmin/category-links-view.tcl: * packages/categories/www/cadmin/category-parent-change.tcl: * packages/categories/www/cadmin/category-usage.tcl: * packages/categories/www/cadmin/permission-manage.tcl: * packages/categories/www/cadmin/synonym-delete.tcl: * packages/categories/www/cadmin/synonym-form.tcl: * packages/categories/www/cadmin/synonyms-view.tcl: * packages/categories/www/cadmin/tree-copy-view.tcl: * packages/categories/www/cadmin/tree-copy.tcl: * packages/categories/www/cadmin/tree-delete.tcl: * packages/categories/www/cadmin/tree-usage.tcl: * packages/faq/www/admin/q-and-a-add-edit.tcl: Deprecate value_if_exists proc, replace occurrences with plain tcl idioms * packages/news/sql/postgresql/news-drop.sql: * packages/news/tcl/news-apm-callback-procs.tcl: Move installation callbacks in an own namespace to comply with naming convention, fix install/uninstall process found broken while testing * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Move min and max procs in the util:: namespace, improve documentation, improve tests, create deprecated wrappers * packages/acs-tcl/tcl/request-processor-procs.tcl: * packages/xotcl-core/tcl/06-package-procs.tcl: Move root_of_host to acs:: namespace, replace occurrences, create deprecated wrapper * packages/acs-lang/tcl/test/acs-lang-test-procs.tcl: * packages/acs-mail-lite/tcl/email-inbound-procs.tcl: * packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl: * packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl: * packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl: * packages/acs-tcl/tcl/utilities-init.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: Rename 'random', 'randomInit' and 'randomRange' procs to something compliant to OpenACS naming convention, replace occurrences, create deprecated wrapper * packages/assessment/tcl/as-item-form-procs.tcl: Replace deprecated idiom * packages/categories/tcl/category-form-procs.tcl: * packages/categories/www/cadmin/category-delete.tcl: * packages/categories/www/cadmin/category-form.tcl: * packages/categories/www/cadmin/category-link-add-2.tcl: * packages/categories/www/cadmin/category-link-add.tcl: * packages/categories/www/cadmin/category-link-delete.tcl: * packages/categories/www/cadmin/category-links-view.tcl: * packages/categories/www/cadmin/category-parent-change.tcl: * packages/categories/www/cadmin/category-usage.tcl: * packages/categories/www/cadmin/permission-manage.tcl: * packages/categories/www/cadmin/synonym-delete.tcl: * packages/categories/www/cadmin/synonym-form.tcl: * packages/categories/www/cadmin/synonyms-view.tcl: * packages/categories/www/cadmin/tree-copy-view.tcl: * packages/categories/www/cadmin/tree-copy.tcl: * packages/categories/www/cadmin/tree-delete.tcl: * packages/categories/www/cadmin/tree-usage.tcl: Replace deprecated idioms on oacs-5-10 * packages/categories/tcl/category-form-procs.tcl: * packages/categories/www/cadmin/category-parent-change.tcl: * packages/news/tcl/news-apm-callback-procs.tcl: Whitespace cleanup 2019-11-28 gustafn * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/lib/user-new.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/security-procs.tcl: * packages/dotlrn/dotlrn.info: * packages/dotlrn/www/user-add-2.tcl: don't pass sensitive information (e.g. password) as query variable, but use client properties instead. see also issue #3344 * packages/acs-templating/tcl/parse-procs.tcl: fix warning message (many thanks to Frank Bergmann for pointing this out) * packages/acs-subsite/lib/user-new.tcl: * packages/acs-tcl/tcl/security-procs.tcl: * packages/dotlrn/www/user-add-2.tcl: provde a global variable as transitional code for controlling passing of password as query variable * packages/acs-tcl/tcl/install-procs.tcl: * packages/acs-tcl/tcl/xml-1-dom-procs.tcl: unify spelling 2019-11-26 hectorr * packages/acs-templating/tcl/list-procs.tcl: Fix regression on template list 2019-11-26 gustafn * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/xowiki-www-procs.tcl: - Page.create_raw_form_field: + add flag to control nls_language (if not used, behave like before) - form-usages: + add "-date_format" flag to control formatting of dates + use nls_language of embedding page for form-fields in includelet - break overlong lines * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: add missing message key for German * packages/xowf/www/resources/test-item.css: add modal behavior for text_interaction * packages/xowf/www/resources/test-item.css: align CSS class names in CSS files with new names in code ("short_text" instead of "text_entry") * packages/xowiki/tcl/package-procs.tcl: avoiding picking up arbitrary content as site_wide xo* pages * packages/xowf/lib/inclass-quiz.wf: fix typo in comment * packages/boomerang/tcl/boomerang-procs.tcl: improve robustness when partial values are sent by boomerang * packages/xowiki/tcl/form-field-procs.tcl: include word statistics for text area * packages/xowf/lib/inclass-quiz-answer.wf: * packages/xowf/lib/online-exam-answer.wf: make URL hacking less enjoyable * packages/xowiki/tcl/package-procs.tcl: provide "-lang" to top-level "resolve_page" to reduce verbosity * packages/xowiki/tcl/form-field-procs.tcl: reduce verbosity * packages/xowf/lib/inclass-quiz.wf: remove dead code * packages/xowf/tcl/test-item-procs.tcl: use item_id in raw listing of submissions (since it is shorter) 2019-11-25 trenner * packages/acs-tcl/tcl/site-nodes-procs.tcl: * packages/xowf/lib/online-exam-answer.wf: fix typo 2019-11-25 gustafn * packages/xowf/tcl/xowf-procs.tcl: - make "title" configurable via Action.payload dict - whitespace changes * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/xowiki.info: form-fields: - new helper API call: "dict_to_fc" to convert from a dict to a form constraint spec. - extended formfield answer and word statistics - ckeditor4: add dimensions (width and height) when available to the configuration - prefer variables over method calls - added answer hints (one word, multiple words, ...) to text_fields widget - form_page: maintain list of references such that the referenced page knows if and from where it is referenced * packages/xowiki/tcl/xowiki-www-procs.tcl: make_link calls: remove parameter "-with_entitites 0" since it is default * packages/xowiki/www/resources/xowiki.css: not clear, why form-label with in "content-with-folders" have to be width limited * packages/xowiki/tcl/package-procs.tcl: prevent double encoding of utf8 chars in links still not sure, what the best way is, but for current situation, this fixs potentially broken links * packages/acs-tcl/tcl/exception-procs.tcl: reduce verbosity * packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml: * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/inclass-quiz-answer.wf: * packages/xowf/lib/inclass-quiz.wf: * packages/xowf/lib/online-exam-answer.wf: * packages/xowf/lib/online-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/form-generator.css: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: verworked test-item procs: - new teacher-paced inclass quiz - support for different shuffling options (never, always, per-user) - support for subsections (single and multiple choice, short text question) - support for answer hints for short text questions (single word, multiple words, ...) - new API for question and answers for student-paced and teacher-paced scenarios using on the following objects * renaming_form_loader - answer_attributes - answer_for_form - answers_for_form - form_name_based_attribute_stem - get_form_object - rename_attributes * question_manager - goto_page - more_ahead - current_question_form - current_question_obj - current_question_name - current_question_title - nth_question_obj - nth_question_form - combined_question_form - question_objs - question_names - question_property * answer_manager - create_workflow - delete_all_answer_data - get_answer_wf - get_wf_instances - get_answers - marked_results - answers_panel - special policies for workflows, defined as per-workflow policies. - improved i18n - improved styling 2019-11-25 antoniop * packages/acs-templating/tcl/element-procs.tcl: Deprecate 'element' proc, defined without a namespace * packages/assessment/lib/assessment.tcl: Fix typo * packages/categories/tcl/category-trees-procs-oracle.xql: * packages/categories/tcl/category-trees-procs-postgresql.xql: * packages/categories/tcl/category-trees-procs.tcl: Reduce divergency between oracle and postgres codebase * packages/acs-tcl/tcl/widgets-procs.tcl: Rename future_years_list as ad_future_years_list, create deprecated wrapper 2019-11-24 gustafn * packages/xowiki/tcl/includelet-procs.tcl: Improve comments * packages/attachments/www/doc/index.adp: * packages/attachments/www/doc/index.html: improve documentation * packages/dotlrn/tcl/class-procs.tcl: * packages/dotlrn/tcl/community-procs.tcl: * packages/dotlrn/www/members-chunk-table.tcl: * packages/dotlrn/www/members-chunk.tcl: * packages/evaluation/catalog/evaluation.de_DE.ISO-8859-1.xml: * packages/evaluation/catalog/evaluation.en_US.ISO-8859-1.xml: * packages/evaluation/catalog/evaluation.es_ES.ISO-8859-1.xml: * packages/evaluation/catalog/evaluation.es_GT.ISO-8859-1.xml: * packages/evaluation/catalog/evaluation.pt_BR.ISO-8859-1.xml: * packages/evaluation/evaluation.info: * packages/evaluation/tcl/evaluation-procs.tcl: * packages/evaluation/www/admin/evaluations/grades-sheet-explanation.adp: improve spelling * packages/acs-bootstrap-installer/db-init-checks-oracle.tcl: * packages/acs-bootstrap-installer/installer.tcl: * packages/acs-bootstrap-installer/installer/www/blank-master.tcl: * packages/acs-bootstrap-installer/tcl/20-db-bootstrap-procs.tcl: * packages/chat/www/doc/design.html: * packages/chat/www/doc/requirements.html: * packages/news/www/doc/design.adp: * packages/news/www/doc/design.html: * packages/news/www/doc/requirements.adp: * packages/news/www/doc/requirements.html: * packages/static-portlet/tcl/static-portal-content-procs.tcl: improve spelling: prefer comma after "therefore" and friends * packages/tsearch2-driver/tcl/tsearch2-driver-install-procs.tcl: prefer spelling "SQL" over "sql" in sentences * packages/xowiki/tcl/template-procs.tcl: remove file for running current xowiki under OpenACS 5.1 (an attempt, which would fail for other reasons) * packages/xowiki/tcl/xowiki-procs.tcl: remove unneeded statement 2019-11-23 gustafn * packages/boomerang/tcl/boomerang-procs.tcl: add one more heuristic to deal with partial information returned from boomerang * packages/xowiki/tcl/xowiki-procs.tcl: improve comments 2019-11-22 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: be more liberal for accepted network driver names * packages/acs-subsite/acs-subsite.info: * packages/acs-subsite/www/admin/site-map/instance-delete.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/site-nodes-procs.tcl: bugfix: unmounting a package could lead to a deletion of services used in other packages A new API call "site_node::unmount_services" can be used to unmount all services in a first step. unmount services before calling "site_node::delete -node_id $node_id -delete_subnodes -delete_package" prevents collateral damage. * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: exptend message catalog * packages/acs-templating/tcl/richtext-procs.tcl: improve spelling * packages/acs-api-browser/www/package-view.tcl: improving comments * packages/acs-admin/www/apm/version-i18n.tcl: * packages/acs-core-docs/www/xml/developers-guide/parties.xml: * packages/acs-core-docs/www/xml/developers-guide/permissions.xml: * packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml: * packages/acs-core-docs/www/xml/developers-guide/tutorial-db.xml: * packages/acs-core-docs/www/xml/engineering-standards/style-guide.xml: * packages/acs-core-docs/www/xml/for-everyone/release-notes.xml: * packages/acs-subsite/tcl/attribute-procs.tcl: * packages/acs-subsite/www/shared/community-member.tcl: * packages/acs-tcl/tcl/01-database-procs.tcl: * packages/acs-tcl/tcl/acs-kernel-procs.tcl: * packages/acs-tcl/tcl/install-procs.tcl: * packages/acs-tcl/tcl/sql-statement-procs.tcl: * packages/acs-tcl/tcl/widgets-procs.tcl: * packages/xotcl-core/tcl/05-db-procs.tcl: * packages/xotcl-core/tcl/cr-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: prefer all caps spelling for SQL * packages/acs-subsite/www/admin/site-map/instance-delete.tcl: * packages/acs-tcl/tcl/site-nodes-procs.tcl: provide a better name (site_node::delete_service_nodes) amd delete nodes of services packages as well * packages/xotcl-core/tcl/context-procs.tcl: provide interface for setting query parameter * packages/richtext-ckeditor4/richtext-ckeditor4.info: * packages/richtext-ckeditor4/tcl/richtext-procs.tcl: * packages/richtext-ckeditor4/www/sitewide-admin/index.adp: * packages/richtext-ckeditor4/www/sitewide-admin/index.tcl: update version number of CKeditor * packages/acs-core-docs/tcl/acs-core-docs-procs.tcl: whitespace change * packages/new-portal/tcl/portal-procs.tcl: * packages/news-portlet/news-portlet.info: whitespace changes 2019-11-22 antoniop * packages/acs-tcl/tcl/widgets-procs.tcl: Deprecate country_widget proc 2019-11-21 hectorr * packages/xowiki/catalog/xowiki.es_ES.ISO-8859-1.xml: Update es_ES localization 2019-11-21 gustafn * packages/xowiki/resources/templates/oacs-view.adp: * packages/xowiki/resources/templates/oacs-view2.adp: * packages/xowiki/resources/templates/oacs-view3-bootstrap3.adp: * packages/xowiki/resources/templates/oacs-view3.adp: * packages/xowiki/resources/templates/view-book-no-ajax.adp: * packages/xowiki/resources/templates/view-book.adp: * packages/xowiki/resources/templates/view-default.adp: * packages/xowiki/resources/templates/view-links.adp: * packages/xowiki/resources/templates/view-plain-master.adp: * packages/xowiki/resources/templates/view-plain.adp: * packages/xowiki/tcl/adp-generator-procs.tcl: add a plain template using the master * packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml: add message keys for "answers" and "words" * packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml: fix plural form of Schlogwort * packages/rss-support/www/doc/bboard.html: improve spelling * packages/xowiki/tcl/includelet-procs.tcl: prevent double encoding * packages/xotcl-core/tcl/03-doc-procs.tcl: remove one dependency on jquery reuse the hardcoded bootstrap version (maybe add later fallback, when openacs-bootstrap3 is not defined) 2019-11-21 antoniop * packages/acs-mail-lite/www/doc/incoming-email-legacy-notes.adp: * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/acs-templating/tcl/list-procs.tcl: * packages/acs-templating/www/resources/xinha-nightly/plugins/OacsFs/popups/insert-ilink.xql: Deprecate exists_and_not_null proc as it does not comply with openacs naming convention and can be replaced with plain tcl idioms * packages/assessment/assessment.info: * packages/assessment/lib/assessment.tcl: * packages/assessment/sql/oracle/assessment-actions-package-create.sql: * packages/assessment/sql/oracle/upgrade/upgrade-2.10.0d4-2.10.0d5.sql: * packages/assessment/sql/postgresql/assessment-actions-create.sql: * packages/assessment/sql/postgresql/upgrade/upgrade-2.10.0d4-2.10.0d5.sql: * packages/assessment/www/asm-admin/results-export.tcl: Replace occurrences of exists_and_not_null with plain tcl idioms, as the goal is to deprecate this proc shortly This required an upgrade script as some code is actually stored in the database * packages/xowiki/catalog/xowiki.it_IT.ISO-8859-1.xml: Update italian localization 2019-11-20 hectorr * packages/acs-tcl/tcl/test/doc-check-procs.tcl: Check the namespace as well in the 'naming__proc_naming' testcase 2019-11-20 gustafn * packages/openacs-bootstrap3-theme/tcl/resource-init.tcl: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.4.1.js: * packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.4.1.min.js: add jquery as it is referenced by resource-init.tcl * packages/acs-templating/tcl/parse-procs.tcl: generalize alnum handling * packages/xowiki/tcl/resource-init.tcl: load highcharts from CDN (and don't refer to non-existing resource file) * packages/boomerang/tcl/boomerang-procs.tcl: try to figure out, how to improve robustness further * packages/xowiki/tcl/resource-init.tcl: * packages/xowiki/www/resources/jquery/jquery-3.4.1.js: * packages/xowiki/www/resources/jquery/jquery-3.4.1.min.js: upgrade to latests jquery (3.4.1) 2019-11-20 antoniop * packages/acs-tcl/tcl/utilities-procs.tcl: * packages/acs-templating/tcl/list-procs.tcl: Deprecate exists_and_equals and replace its occurrences * packages/file-storage/tcl/file-storage-procs-oracle.xql: * packages/file-storage/tcl/file-storage-procs-postgresql.xql: * packages/file-storage/tcl/file-storage-procs.tcl: Fix missing query due to naming convention reform by rewriting the entire proc based on a single portable recursive query * packages/acs-core-docs/www/tutorial-html-email.adp: * packages/acs-core-docs/www/tutorial-html-email.html: * packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml: * packages/acs-mail-lite/tcl/email-inbound-procs.tcl: * packages/acs-tcl/tcl/html-email-procs.tcl: * packages/acs-tcl/tcl/test/html-email-procs.tcl: Rename build_mime_message to ad_build_mime_message to comply with naming convention, replace occurrences, create deprecated wrapper * packages/acs-admin/www/auth/login-attempts.tcl: * packages/acs-lang/tcl/localization-procs.tcl: * packages/categories/lib/contributions.tcl: * packages/xotcl-request-monitor/www/whos-online-today.tcl: * packages/xowiki/tcl/includelet-procs.tcl: * packages/xowiki/tcl/weblog-procs.tcl: Rename clock_to_ansi to lc_clock_to_ansi to comply with naming convention, replace occurrences, create deprecated wrapper * packages/acs-core-docs/tcl/acs-core-docs-procs.tcl: Rename core_docs_uninstalled_packages to ad_core_docs_uninstalled_packages to comply with naming convention * packages/acs-datetime/tcl/acs-datetime-procs.tcl: Replace deprecated occurrences 2019-11-19 gustafn * packages/openacs-bootstrap3-theme/resources/forms/form-horizontal.adp: * packages/openacs-bootstrap3-theme/resources/forms/standard.adp: Use glyphicon instead of gif image in for info texts * packages/xowiki/tcl/includelet-procs.tcl: add duplicate button support to form-usages * packages/xowiki/tcl/xowiki-procs.tcl: add option to control path encoding to the method Page.pretty_link for symmetry (was already allowed on the package level "pretty_link" method * packages/xowiki/tcl/xowiki-www-procs.tcl: generalize alnum handling * packages/xowiki/tcl/form-field-procs.tcl: * packages/xowiki/www/resources/xowiki-bootstrap3-specific.css: * packages/xowiki/www/resources/xowiki-yui-specific.css: use glyph icon in bootstrap mode instead of gif image in form info messages 2019-11-18 hectorr * packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl: Fix test description * packages/acs-automated-testing/tcl/aa-test-procs.tcl: Normalize proc naming during testcase population of the 'api_proc_doc' nsv 2019-11-16 gustafn * packages/acs-templating/tcl/util-procs.tcl: Move helper function to namespace and make it private * packages/acs-tcl/tcl/test/doc-check-procs.tcl: added test to check, if names of Tcl procsfollow the naming guidelines of OpenACS * packages/acs-tcl/tcl/test/ad-proc-test-procs.tcl: don't clobber top-level namespace * packages/acs-templating/tcl/doc-tcl-procs.tcl: ease syntax highlighting * packages/file-storage/tcl/file-storage-procs.tcl: * packages/file-storage/www/folder-delete.tcl: move private function children_have_permission_p to fs_* naming convention * packages/acs-templating/tcl/query-procs.tcl: move private function to own namespace * packages/acs-tcl/tcl/request-processor-procs.tcl: move rp filter consistently under the rp_* prefix * packages/acs-templating/tcl/tag-init.tcl: * packages/acs-templating/tcl/tag-procs.tcl: move template_tag_* commands to proper namespace * packages/acs-bootstrap-installer/acs-bootstrap-installer.info: * packages/acs-bootstrap-installer/installer/install.tcl: * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/security-init.tcl: * packages/acs-tcl/tcl/security-procs-oracle.xql: * packages/acs-tcl/tcl/security-procs-postgresql.xql: * packages/acs-tcl/tcl/security-procs.tcl: moved "populate_secrect" to "sec_*" prefix to reduce clobbering of global namespace * packages/acs-mail-lite/tcl/email-inbound-procs.tcl: * packages/acs-mail-lite/tcl/imap-inbound-procs.tcl: * packages/acs-mail-lite/tcl/maildir-inbound-procs.tcl: * packages/acs-outdated/tcl/acs-tcl-procs.tcl: * packages/acs-tcl/tcl/utilities-procs.tcl: moved "safe_eval" under the "ad_" prefix and marked the original function as deprecated * packages/acs-templating/tcl/filter-procs.tcl: * packages/acs-templating/tcl/template-init.tcl: moved filters into namespace and made these consistently private * packages/acs-core-docs/tcl/acs-core-docs-procs.tcl: moved private function to the accepted nameprefix * packages/acs-templating/tcl/doc-tcl-procs.tcl: no need to allow funny characters in proc names * packages/acs-tcl/tcl/request-processor-procs.tcl: reduced clobbing of global namespace * packages/acs-templating/tcl/debug-procs.tcl: remove file that depends on files (in a folder ats/) that seem to have been deleted ages ago * packages/general-comments/tcl/general-comments-procs-oracle.xql: * packages/general-comments/tcl/general-comments-procs-postgresql.xql: * packages/general-comments/tcl/general-comments-procs.tcl: * packages/general-comments/tcl/general-comments-procs.xql: * packages/general-comments/www/comment-add-3.tcl: use consistently the same prefix "general_comments" (and not singular version) * packages/acs-core-docs/tcl/acs-core-docs-init.tcl: * packages/acs-core-docs/tcl/acs-core-docs-procs.tcl: use internally used redirector under the ad_* prefix 2019-11-15 hectorr * packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl: Include '-' as a valid character in a proc name in acs-api-browser's 'length_proc'. Fixes the 'acs_api_browser_apidoc_tclcode_to_html' test case. 2019-11-15 gustafn * packages/categories/tcl/category-xml-procs.tcl: Use current namespace ::tdom instead of legacy ::tDOM essentially the same change as in http://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Amischa%3A2 0191114130401 * packages/assessment/tcl/as-qti-procs.tcl: apply patch from mischa to current development pranch 2019-11-15 antoniop * packages/acs-kernel/acs-kernel.info: * packages/acs-kernel/sql/postgresql/acs-objects-create.sql: * packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d23-5.10.0d24.sql: Index acs_object's creation and modification date 2019-11-14 mischa * packages/assessment/tcl/as-qti-procs.tcl: Use current namespace ::tdom instead of legacy ::tDOM 2019-11-14 gustafn * packages/boomerang/tcl/boomerang-procs.tcl: improve robustness when just partial results are returned by the library * packages/acs-tcl/tcl/utilities-procs.tcl: point out pre UNICODE character handling that should be fixed * packages/xotcl-core/tcl/context-procs.tcl: provide API to unset query and connection parameters 2019-11-13 gustafn * packages/acs-tcl/tcl/security-procs.tcl: addres kernel_id always via variable rathen than via method * packages/acs-tcl/tcl/navigation-procs.tcl: fix wrong argument (many thank to Franz Penz for reporting the bug) 2019-11-12 gustafn * packages/xowiki/tcl/form-field-procs.tcl: extended form-fields autocorrection handling - added functionality of per-form-field statistics - added support for "radio"/single choice test items - added support for richtext handling in "radio" - added a (limited) method to set a form-field to a correct value, based on "correct_when". So far, just a minimal set of predicated is handled - improved "unknown" handling, when the code does not know, whether item is correct or not - refactored some code - improved source code documentation 2019-11-11 gustafn * packages/xowiki/tcl/xowiki-www-procs.tcl: - use is_disabled on more places instead of just checking for the instance variable * packages/xowiki/tcl/xowiki-www-procs.tcl: reduce verbosity 2019-11-11 antoniop * packages/xowiki/tcl/form-field-procs.tcl: Check for answer being not-empty instead of being true 2019-11-09 gustafn * packages/xowiki/tcl/xowiki-procs.tcl: added flag "-lookup" to Page.create_form_fields_from_form_constraints to avoid optioanlly recreation of form-fields 2019-11-07 gustafn * packages/acs-tcl/tcl/utilities-procs.tcl: Provide a more straightforward approach of gzipping 2019-11-07 antoniop * packages/acs-tcl/tcl/utilities-procs.tcl: Support gzip versions < 1.6 2019-11-06 gustafn * packages/xowf/lib/online-exam-answer.wf: * packages/xowf/lib/online-exam.wf: add fingerprinting to results * packages/xowf/tcl/test-item-procs.tcl: add method to select answer attributes in a predictable order * packages/xowf/www/resources/test-item.css: fine-tune styling of test items 2019-11-05 gustafn * packages/acs-tcl/acs-tcl.info: * packages/acs-tcl/tcl/security-procs.tcl: backport security patch from oacs-5-10 * packages/xowiki/tcl/import-procs.tcl: improve logging message to ease debugging in case of errors * packages/xowf/tcl/xowf-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: move also hstore examples to xowiki * packages/xowf/tcl/xowf-procs.tcl: * packages/xowiki/tcl/xowiki-procs.tcl: * packages/xowiki/tcl/xowiki-utility-procs.tcl: relocate update_hstore from xowf to xowiki::hstore, where the other hstore helpers exist 2019-11-04 gustafn * packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml: * packages/xowf/lib/online-exam-answer.wf: * packages/xowf/lib/online-exam.wf: * packages/xowf/tcl/test-item-procs.tcl: * packages/xowf/www/resources/myform.css: * packages/xowf/www/resources/test-item.css: * packages/xowf/xowf.info: - form-generator.css: based on former myform.css, substantially revamped (to be used together with form field classes in test-item-procs) - test-item classes: * feedback_level extended to "full", "single", or "none" middle is new for a single feedback per item * shuffling support with 3 modes ("none", "peruser", "always"). can be used for shuffling MC questions and text_entry questions (short-text), and in future for all "enumeration" based question types. * new question type "mc2", shuffling multiple choice question, fully stylable via CSS (old question type "mc" can still be used for the time being) * ease styling for all test-item types by added explicit wrappers * factor out "renaming_form_loader" from online-exam*.wf (including support methods) - online-exam*.wf: * fix broken behavior with shared workflow definitions when closing/opening exams and student tried interactions. Previous code did dynamic changes in the shared definition (probably more to come). * used factored out renaming_form_loader * cleanup of old code - removed low-level rewriting of