Index: openacs-4/packages/xotcl-core/xotcl-core.info
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/xotcl-core.info,v
diff -u -r1.22.2.2 -r1.22.2.3
--- openacs-4/packages/xotcl-core/xotcl-core.info	13 Sep 2007 12:39:37 -0000	1.22.2.2
+++ openacs-4/packages/xotcl-core/xotcl-core.info	19 Sep 2007 11:27:29 -0000	1.22.2.3
@@ -8,7 +8,7 @@
     <singleton-p>t</singleton-p>
     <auto-mount>xotcl</auto-mount>
 
-    <version name="0.56.1" url="http://media.wu-wien.ac.at/download/xotcl-core-0.56.1.apm">
+    <version name="0.56.2" url="http://media.wu-wien.ac.at/download/xotcl-core-0.56.2.apm">
         <owner url="mailto:neumann@wu-wien.ac.at">Gustaf Neumann</owner>
         <summary>XOTcl library functionality (e.g. thread handling, online documentation, Generic Form and List Classes)</summary>
         <release-date>2007-09-13</release-date>
@@ -39,7 +39,7 @@
         <license>BSD-Style</license>
         <maturity>0</maturity>
 
-        <provides url="xotcl-core" version="0.56.1"/>
+        <provides url="xotcl-core" version="0.56.2"/>
 
         <callbacks>
             <callback type="before-install"  proc="::xotcl::before_install_callback"/>
Index: openacs-4/packages/xotcl-core/tcl/generic-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/generic-procs.tcl,v
diff -u -r1.40.2.4 -r1.40.2.5
--- openacs-4/packages/xotcl-core/tcl/generic-procs.tcl	19 Sep 2007 10:18:13 -0000	1.40.2.4
+++ openacs-4/packages/xotcl-core/tcl/generic-procs.tcl	19 Sep 2007 11:27:29 -0000	1.40.2.5
@@ -140,17 +140,10 @@
   # TODO: make it more general, based on slots
   #
   CrClass instproc insert_statement {atts postponed_vars} {
-    my log "-- insert_statement: sql_long_text_attributes [my set sql_long_text_attributes]"
-    ### todo: do be removed
-    my upvar $postponed_vars still_to_do
-    array set clob_vars [my set sql_long_text_attributes]
-    foreach a $atts {
-      set key clob_vars($a)
-      if {[info exists $key]} {
-        lappend still_to_do $a [set $key] [my uplevel "set $a"]
-      }
-    }
-    ####
+    # 
+    # postponed vars are only used in Oracle
+    #
+    # my log "-- insert_statement: sql_long_text_attributes [my set sql_long_text_attributes]"
     return "insert into [my set table_name]i ([join $atts ,]) \
                 values (:[join $atts ,:])"
   }
@@ -162,16 +155,27 @@
 
     # redefine for the time being the insert statement
     CrClass instproc insert_statement {atts postponed_vars} {
+      #
+      # The Oracle implementation of OpenACS cannot update
+      # here *LOBs safely updarted through the automatic generated
+      # view. So we postpone these updates and perform these
+      # as separate statements.
+      #
       my upvar $postponed_vars still_to_do
       set values [list]
       set attributes [list]
       array set clob_vars [my set sql_long_text_attributes]
       foreach a $atts {
-        # Don't insert the attribute text, which is added in Oracle
-        # via a separate statement.
+        #
+        # "text" is always handled in Oracle via separate statement
+        #
         if {$a eq "text"} continue
         set key clob_vars($a)
         if {[info exists $key]} {
+          #
+          # Pass back the attribute_name, the context (class) and 
+          # the value for the postponed updates
+          #
           lappend still_to_do $a [set $key] [my uplevel "set $a"]
         } else {
           lappend attributes $a
@@ -462,6 +466,15 @@
     $o destroy_on_cleanup
     foreach att [$o children] { 
       lappend sql_attribute_names [$att attribute_name]
+      #
+      # The virtual sqltype "long_text" indicates text variales
+      # with long content. In postgres, this is realized via
+      # the datatype text. Due to various limitations in Oracle,
+      # we use there CLOBS, which need in some context special 
+      # treatments (e.g. on updates). Thefore, we keep book about these
+      # in the class variable "sql_long_text_attributes", together 
+      # with [self] (the class, to which this variable belongs) as context.
+      #
       if {[$att sqltype] eq "long_text"} {
         lappend sql_long_text_attributes [$att attribute_name] [self]
       }
@@ -473,7 +486,7 @@
       foreach n [$sc set sql_long_text_attributes] {lappend sql_long_text_attributes $n}
     }
     #my log "-- attribute_names <$sql_attribute_names> [$o info children]"
-    my log "-- sql_long_text_attributes <$sql_long_text_attributes>"
+    #my log "-- sql_long_text_attributes <$sql_long_text_attributes>"
 
     if {![my object_type_exists]} {
       my create_object_type
@@ -877,13 +890,13 @@
                where  revision_id = $revision_id \
                returning content into :1" -blobs [list $content]
       }
-      my msg "--fix postponed_vars nr: [llength $postponed_vars]"
+      #my msg "--fix postponed_vars nr: [expr {[llength $postponed_vars]/3}]"
       foreach {att cls content} $postponed_vars {
-        my msg "$att [$cls table_name] [$cls id_column] length=[string length $content]"
+        #my msg "$att [$cls table_name] [$cls id_column] length=[string length $content]"
         db_dml [my qn att-$att] "update [$cls table_name] \
-               set    $att = empty_blob() \
+               set    $att = empty_clob() \
                where  [$cls id_column] = $revision_id \
-               returning $att into :1" -blobs [list $content]
+               returning $att into :1" -clobs [list $content]
       }
     }