Index: openacs-4/packages/acs-tcl/tcl/test/proxy-test-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/test/proxy-test-procs.tcl,v
diff -u -r1.1.2.3 -r1.1.2.4
--- openacs-4/packages/acs-tcl/tcl/test/proxy-test-procs.tcl	13 Apr 2021 09:02:24 -0000	1.1.2.3
+++ openacs-4/packages/acs-tcl/tcl/test/proxy-test-procs.tcl	13 Apr 2021 12:42:31 -0000	1.1.2.4
@@ -6,52 +6,73 @@
     @creation-date 2021-03-18
 }
 
-aa_register_case \
-    -error_level warning \
-    -cats {api smoke} -procs {
-    proxy::exec
-} exec_binary_input {
-    When the encoding is iso8859-1, Tcl's exec does not do line
-    translation.  the exec wrapper should be sensitive to this.  Use a
-    temporary file to work around the fact that there is no way to
-    disable line translation on the result of [exec].
-} {
-    set tclsh ${::env(HOME)}/bin/tclsh
-    set data0 [encoding convertto utf-8 зайчик]
+#
+# The following test was deactivated by Gustaf Neumann, since it makes
+# little sense and does more harm than good.
+#
+# Rationale:
+#
+#  a) never change the system encoding in a multi threaded Tcl code,
+#     unless you are aware of all the consequences. So far, the system
+#     encoding is a global variable in C. If this is changed from
+#     e.g. one thread, it is changed at the same time for all threads
+#     (maybe in the middle of of a Tcl command). It also will effect
+#     to communication with databases.
+#
+#  b) Since the nsproxy code is running as a different process, the
+#     intention is not clear to me. If there is the goal to change the
+#     encoding for a single file, why not change it for this file?
+#
+#  c) The use case for the test is unclear. if a program requries in a
+#     single run different system encodings, it does something
+#     probably wrong.
+#
+#
+# aa_register_case \
+#     -cats {api smoke} -procs {
+#     proxy::exec
+# } exec_binary_input {
+#     When the encoding is iso8859-1, Tcl's exec does not do line
+#     translation.  the exec wrapper should be sensitive to this.  Use a
+#     temporary file to work around the fact that there is no way to
+#     disable line translation on the result of [exec].
+# } {
+#     set tclsh ${::env(HOME)}/bin/tclsh
+#     set data0 [encoding convertto utf-8 зайчик]
+#
+#     set chan [file tempfile filename]
+#     chan configure $chan -translation binary
+#     try {
+#         if {[catch {
+#             set encoding [encoding system]
+#             try {
+#                 encoding system iso8859-1
+#                 ::proxy::exec -call [list $tclsh - << "
+# 						chan configure stdin -translation binary
+# 						# assume tclsh now reads the rest of this script in binary mode
+# 						chan configure stdout -translation binary
+# 						puts -nonewline stdout [list $data0]
+# 					" >> [list $filename]]
+#             } finally {
+#                 encoding system $encoding
+#             }
+#         } cres copts]} {
+#             regsub -all {[^[:print:]]} $cres ? cres
+#             regsub -all {[^[:print:]]} $copts ? copts
+#             return -options $copts $cres
+#         }
+#         set data1 [read $chan]
+#     } finally {
+#         close $chan
+#         file delete $filename
+#     }
+#
+#     binary scan $data0 H* data0hex
+#     binary scan $data1 H* data1hex
+#
+#     aa_equals data $data1hex $data0hex
+# }
 
-    set chan [file tempfile filename]
-    chan configure $chan -translation binary
-    try {
-        if {[catch {
-            set encoding [encoding system]
-            try {
-                encoding system iso8859-1
-                ::proxy::exec -call [list $tclsh - << "
-                    chan configure stdin -translation binary
-                    # assume tclsh now reads the rest of this script in binary mode
-                    chan configure stdout -translation binary
-                    puts -nonewline stdout [list $data0]
-                " >> [list $filename]]
-            } finally {
-                encoding system $encoding
-            }
-        } cres copts]} {
-            regsub -all {[^[:print:]]} $cres ? cres
-            regsub -all {[^[:print:]]} $copts ? copts
-            return -options $copts $cres
-        }
-        set data1 [read $chan]
-    } finally {
-        close $chan
-        file delete $filename
-    }
-
-    binary scan $data0 H* data0hex
-    binary scan $data1 H* data1hex
-
-    aa_equals data $data1hex $data0hex
-}
-
 # Local variables:
 #    mode: tcl
 #    tcl-indent-level: 4