Index: openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl,v diff -u -r1.1.2.5 -r1.1.2.6 --- openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl 1 Nov 2019 13:16:18 -0000 1.1.2.5 +++ openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl 22 Nov 2019 16:21:43 -0000 1.1.2.6 @@ -933,7 +933,7 @@
- You can call several pl/sql statements at once, like this: + You can call several pl/SQL statements at once, like this:
@@ -1542,7 +1542,7 @@ Usage: db_list_of_ns_sets statement-name sql [ -bind bind_set_id | -bind bind_value_list ] @return a list of ns_sets with the values of each column of each row - returned by the sql query specified. + returned by the SQL query specified. @param statement_name The name of the query. @param sql The SQL to be executed. Index: openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.tcl,v diff -u -r1.13 -r1.13.2.1 --- openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.tcl 4 Dec 2018 22:12:06 -0000 1.13 +++ openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.tcl 22 Nov 2019 16:21:43 -0000 1.13.2.1 @@ -44,7 +44,7 @@ foreach file $files { set fn $kernelSqlDir/$file if {[file readable $fn]} { - ns_log notice "bootstrap: upgrading sql file $fn" + ns_log notice "bootstrap: upgrading SQL file $fn" db_source_sql_file -callback apm_dummy_callback $fn } } Index: openacs-4/packages/acs-tcl/tcl/install-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/install-procs.tcl,v diff -u -r1.35.2.1 -r1.35.2.2 --- openacs-4/packages/acs-tcl/tcl/install-procs.tcl 14 Feb 2019 16:15:00 -0000 1.35.2.1 +++ openacs-4/packages/acs-tcl/tcl/install-procs.tcl 22 Nov 2019 16:21:43 -0000 1.35.2.2 @@ -21,7 +21,7 @@ } ad_proc -private ::install::xml::action::source { node } { - Source an install.xml file, sql file or Tcl script during execution of + Source an install.xml file, SQL file or Tcl script during execution of the current install.xml. If no type attribute is specified then this tag will attempt to guess Index: openacs-4/packages/acs-tcl/tcl/sql-statement-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/Attic/sql-statement-procs.tcl,v diff -u -r1.5 -r1.5.2.1 --- openacs-4/packages/acs-tcl/tcl/sql-statement-procs.tcl 7 Aug 2017 23:48:00 -0000 1.5 +++ openacs-4/packages/acs-tcl/tcl/sql-statement-procs.tcl 22 Nov 2019 16:21:43 -0000 1.5.2.1 @@ -7,7 +7,7 @@ How to use this: You simply call ad_sql_append any number of times, then ad_sql_get to feed to the database. - What you gain from using these two procs is that the parts of the sql statement will + What you gain from using these two procs is that the parts of the SQL statement will always be output in the right sequence. @@ -27,7 +27,7 @@ } { @param sqlarrayname array reference - @return a sql statement constructed from the pieces provided via ad_sql_append + @return a SQL statement constructed from the pieces provided via ad_sql_append @see ad_sql_append } { Index: openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl,v diff -u -r1.23.2.1 -r1.23.2.2 --- openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl 22 Nov 2019 10:51:10 -0000 1.23.2.1 +++ openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl 22 Nov 2019 16:21:43 -0000 1.23.2.2 @@ -227,7 +227,7 @@ sql_qry name } { - given a sql query this generates a select group. If there is only + given a SQL query this generates a select group. If there is only one value it returns the text and a hidden variable setting that value. The first selected column should contain the optionlist items. The second selected column should contain the optionlist values. Index: openacs-4/packages/acs-core-docs/www/xml/developers-guide/parties.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/developers-guide/parties.xml,v diff -u -r1.10 -r1.10.2.1 --- openacs-4/packages/acs-core-docs/www/xml/developers-guide/parties.xml 30 Sep 2018 15:53:28 -0000 1.10 +++ openacs-4/packages/acs-core-docs/www/xml/developers-guide/parties.xml 22 Nov 2019 16:30:46 -0000 1.10.2.1 @@ -244,7 +244,7 @@-# sql code +# SQL code create or replace package membership_rel as @@ -303,7 +303,7 @@ -# sql code +# SQL code create or replace package composition_rel as Index: openacs-4/packages/acs-core-docs/www/xml/developers-guide/permissions.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/developers-guide/permissions.xml,v diff -u -r1.18 -r1.18.2.1 --- openacs-4/packages/acs-core-docs/www/xml/developers-guide/permissions.xml 7 Aug 2017 23:47:54 -0000 1.18 +++ openacs-4/packages/acs-core-docs/www/xml/developers-guide/permissions.xml 22 Nov 2019 16:30:46 -0000 1.18.2.1 @@ -196,7 +196,7 @@ -# sql code +# SQL code acs_permission.grant_permission ( object_id => some_object_id, grantee_id => some_party_id, Index: openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml,v diff -u -r1.60.2.4 -r1.60.2.5 --- openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml 20 Nov 2019 11:27:31 -0000 1.60.2.4 +++ openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml 22 Nov 2019 16:30:46 -0000 1.60.2.5 @@ -878,7 +878,7 @@ First step is to create the notification types. To do this a script similar to the one below needs to be loaded into Postgresql. I create this script in a package-name/sql/postgresql/package-name-notifications-init.sql file. I then load - this file from my create sql file. The following code snippet is taken from + this file from my create SQL file. The following code snippet is taken from Weblogger. It creates a lars_blogger_notif notification type (which was created above). @@ -1569,8 +1569,7 @@If your package changes its data model, you have to write an upgrade script. This is very easy in OpenACS. -First, you want to make sure you change the original .sql - file so that new installation will have the new data model. +First, you want to make sure you change the original .sql file so that new installation will have the new data model. Next, check what version your package is currently at. For example, it may be at version 1.0b1. Create a file in Index: openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-db.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-db.xml,v diff -u -r1.19 -r1.19.2.1 --- openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-db.xml 7 Aug 2017 23:47:54 -0000 1.19 +++ openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-db.xml 22 Nov 2019 16:30:46 -0000 1.19.2.1 @@ -52,7 +52,7 @@ - The top of each sql file has some + The top of each SQL file has some standard comments, including doc tags such as @author which will be picked up by the API browser. The string @@ -89,7 +89,7 @@ (1 row) [$OPENACS_SERVICE_NAME postgresql]$ -If there are errors, use them to debug the sql file and try again. If there are errors in the database table creation, you may need to run the drop script to drop the table so that you can recreate it. The drop script will probably have errors since some of the things it's trying to drop may be missing. They can be ignored. +If there are errors, use them to debug the SQL file and try again. If there are errors in the database table creation, you may need to run the drop script to drop the table so that you can recreate it. The drop script will probably have errors since some of the things it's trying to drop may be missing. They can be ignored. Once you get the same output as shown above, test the drop script: [$OPENACS_SERVICE_NAME postgresql]$ psql service0 -f myfirstpackage-drop.sql Index: openacs-4/packages/acs-core-docs/www/xml/engineering-standards/style-guide.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/engineering-standards/style-guide.xml,v diff -u -r1.4 -r1.4.2.1 --- openacs-4/packages/acs-core-docs/www/xml/engineering-standards/style-guide.xml 7 Aug 2017 23:47:54 -0000 1.4 +++ openacs-4/packages/acs-core-docs/www/xml/engineering-standards/style-guide.xml 22 Nov 2019 16:30:46 -0000 1.4.2.1 @@ -20,7 +20,7 @@Well, first lets consider the OpenACS code base (all this as of December 2003 and including dotLRN). There are about 390,000 - lines of Tcl code, about 460,000 lines of sql (in datamodel + lines of Tcl code, about 460,000 lines of SQL (in datamodel scripts and .xql files), about 80,000 lines of markup in .adp files, and about 100,000 lines of documentation. All told, just about a million lines of "stuff". In terms of logical units Index: openacs-4/packages/acs-core-docs/www/xml/for-everyone/release-notes.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/for-everyone/release-notes.xml,v diff -u -r1.39.2.1 -r1.39.2.2 --- openacs-4/packages/acs-core-docs/www/xml/for-everyone/release-notes.xml 10 Mar 2019 21:36:25 -0000 1.39.2.1 +++ openacs-4/packages/acs-core-docs/www/xml/for-everyone/release-notes.xml 22 Nov 2019 16:30:46 -0000 1.39.2.2 @@ -182,7 +182,7 @@ - Marked redundant / uncalled sql functions as deprecated + Marked redundant / uncalled SQL functions as deprecated Replaced usages of obsolete view @@ -206,7 +206,7 @@ - Simplified core sql functions by using defaults: + Simplified core SQL functions by using defaults: Number of functions reduced by a factor of 2 compared to OpenACS @@ -1158,7 +1158,7 @@ @@ -1242,8 +1242,7 @@ Removed bug where same query-name was used in different branches of an if-statement for - different sql statements, but the query-name lead to the + different SQL statements, but the query-name lead to the wrong result. @@ -1563,7 +1562,7 @@ Improved them-ability for display_templates. One can now - provide a display_template_name (similar to the sql - statement name) to refer to display templates. This + provide a display_template_name (similar to the SQL statement name) to refer to display templates. This enables reusability and is theme-able. Made changes that extend acs-kernel's create_type and create_attribute procs, - so they're optionally able to create sql tables and columns. Optional metadata + so they're optionally able to create SQL tables and columns. Optional metadata params allow for the automatic generation of foreign key references, check exprs, etc.