Index: openacs-4/packages/acs-tcl/lib/actions.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/lib/actions.tcl,v diff -u -r1.5 -r1.5.2.1 --- openacs-4/packages/acs-tcl/lib/actions.tcl 3 Dec 2018 17:31:58 -0000 1.5 +++ openacs-4/packages/acs-tcl/lib/actions.tcl 10 Mar 2019 21:34:33 -0000 1.5.2.1 @@ -1,5 +1,5 @@ ad_include_contract { - Generate an html version of the given package_id's admin actions. + Generate an HTML version of the given package_id's admin actions. expects to be in a conn. } { package_id:integer Index: openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/Attic/00-database-procs.tcl,v diff -u -r1.126.2.2 -r1.126.2.3 --- openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl 18 Feb 2019 12:40:09 -0000 1.126.2.2 +++ openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl 10 Mar 2019 21:34:33 -0000 1.126.2.3 @@ -342,7 +342,7 @@ Deprecated: This routine was invented to provide an RDBMS-specific null value but doesn't actually work. I (DRB) left it in to speed porting - we - should really clean up the code an pull out the calls instead, though. + should really clean up the code and pull out the calls instead, though. @see "" } { @@ -391,7 +391,7 @@ @return the next value for a sequence. This can utilize a pool of sequence values. - @param sequence the name of an sql sequence + @param sequence the name of an SQL sequence @param dbn The database name to use. If empty_string, uses the default database. @@ -597,7 +597,7 @@ if {[dict exists $currentHandles $pool]} { # # Are there handles, which are not active (i.e. not in - # an currently open "ns_db select" and "ns_db getrow" + # a currently open "ns_db select" and "ns_db getrow" # context. # foreach {handle active} [dict get $currentHandles $pool] { Index: openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl,v diff -u -r1.126.2.2 -r1.126.2.3 --- openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl 1 Mar 2019 12:12:37 -0000 1.126.2.2 +++ openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl 10 Mar 2019 21:34:33 -0000 1.126.2.3 @@ -691,7 +691,7 @@ package_key } { Simple basic package install function. Wraps up - basically what the old install xml action did. + basically what the old install XML action did. } { set install_spec_file [apm_package_info_file_path $package_key] @@ -2178,7 +2178,7 @@ @param filename relative to serverroot, leading slash needed. @param binds list of {variable value variable value ...} - @return root_node of the parsed xml file. + @return root_node of the parsed XML file. @author Jeff Davis davis@xarg.net @creation-date 2003-10-30 @@ -2216,10 +2216,10 @@ -install_from_repository:boolean filename binds } { - process an xml install definition file which is expected to contain + process an XML install definition file which is expected to contain directives to install, mount and configure a series of packages. - @param filename path to the xml file relative to serverroot. + @param filename path to the XML file relative to serverroot. @param binds list of {variable value variable value ...} @return list of messages @@ -2276,11 +2276,11 @@ {-type "action"} {-node:required} } { - read an xml install element and invoke the appropriate processing + read an XML install element and invoke the appropriate processing procedure. @param type the type of element to search for - @param node the xml node to process + @param node the XML node to process @return the result of the invoked proc @@ -2590,9 +2590,9 @@ -value:required } { Format an XML element wit a value depending on the specified arguments - @param attribute_name code the value as xml attribute - @param multiple treat the value as a list and produce multiple xml elements - @return the xml-formatted string + @param attribute_name code the value as XML attribute + @param multiple treat the value as a list and produce multiple XML elements + @return the XML-formatted string @author Gustaf Neumann } { @@ -2635,9 +2635,10 @@ -version_id $version_id \ -array attributes] set attribute_defs [apm::package_version::attributes::get_spec] - - # sort the array so that the xml is always in the same order so + # + # Sort the array so that the XML is always in the same order so # its stable for CVS. + # foreach attribute_name [lsort [array names attributes]] { # # Only output tag if its value is non-empty Index: openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl,v diff -u -r1.98 -r1.98.2.1 --- openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl 20 Jul 2018 12:57:17 -0000 1.98 +++ openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl 10 Mar 2019 21:34:33 -0000 1.98.2.1 @@ -883,7 +883,7 @@
- build and return an html fragment given an active query and a data definition. + build and return an HTML fragment given an active query and a data definition.
[list [list url1 text1] [list url2 text2] ... "terminal text"] @@ -102,7 +102,7 @@ @param node_id If provided work up from this node, otherwise the current node @param from_node If provided do not generate links to the given node and above. - @return an html fragment generated by ad_context_bar_html + @return an HTML fragment generated by ad_context_bar_html @see ad_context_bar_html } { @@ -163,7 +163,7 @@ @param node_id If provided work up from this node, otherwise the current node @param from_node If provided do not generate links to the given node and above. @param separator The text placed between each link (passed to ad_context_bar_html if provided) - @return an html fragment generated by ad_context_bar_html + @return an HTML fragment generated by ad_context_bar_html @see ad_context_bar_html } { Index: openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl,v diff -u -r1.153 -r1.153.2.1 --- openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 11 Feb 2019 11:51:43 -0000 1.153 +++ openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 10 Mar 2019 21:34:33 -0000 1.153.2.1 @@ -1073,7 +1073,7 @@ # # On internal redirects, the current ::ad_conn(extra_url) might be # from a previous request, which might have lead to a not-found - # error pointing to a new url. This can lead to an hard-to find + # error pointing to a new URL. This can lead to a hard-to find # loop which ends with a "recursion depth exceeded". There is a # similar problem with ::ad_conn(package_key) and # ::ad_conn(package_url) Therefore, we refetch the url info in case, Index: openacs-4/packages/acs-tcl/tcl/security-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/security-procs.tcl,v diff -u -r1.126.2.7 -r1.126.2.8 --- openacs-4/packages/acs-tcl/tcl/security-procs.tcl 10 Mar 2019 21:19:39 -0000 1.126.2.7 +++ openacs-4/packages/acs-tcl/tcl/security-procs.tcl 10 Mar 2019 21:34:33 -0000 1.126.2.8 @@ -654,7 +654,7 @@ ns_log debug "OACS= empty session_id" set session_id [sec_allocate_session] - # if we have a user on an newly allocated session, update + # if we have a user on a newly allocated session, update # users table ns_log debug "OACS= newly allocated session $session_id" @@ -2723,7 +2723,7 @@ Create a security token to protect against CSRF (Cross-Site Request Forgery). The token is set (and cached) in a global - per-thread variable an can be included in forms e.g. via the + per-thread variable and can be included in forms e.g. via the following command.Index: openacs-4/packages/acs-tcl/tcl/utilities-procs-aolserver.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/utilities-procs-aolserver.tcl,v diff -u -r1.6.2.1 -r1.6.2.2 --- openacs-4/packages/acs-tcl/tcl/utilities-procs-aolserver.tcl 17 Feb 2019 12:19:29 -0000 1.6.2.1 +++ openacs-4/packages/acs-tcl/tcl/utilities-procs-aolserver.tcl 10 Mar 2019 21:34:33 -0000 1.6.2.2 @@ -250,7 +250,7 @@ #------------------------------------------------------------------------- # Provide a clean way of handling exceptions in mutexed regions -# (between locking and unlocking of an mutex). Should be used probably +# (between locking and unlocking of a mutex). Should be used probably # on more places in OpenACS. #------------------------------------------------------------------------- Index: openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl,v diff -u -r1.4.2.1 -r1.4.2.2 --- openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl 17 Feb 2019 12:19:29 -0000 1.4.2.1 +++ openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl 10 Mar 2019 21:34:33 -0000 1.4.2.2 @@ -183,7 +183,7 @@ #------------------------------------------------------------------------- # Provide a clean way of handling exceptions in mutexed regions -# (between locking and unlocking of an mutex). Should be used probably +# (between locking and unlocking of a mutex). Should be used probably # on more places in OpenACS. #------------------------------------------------------------------------- Index: openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl,v diff -u -r1.189.2.4 -r1.189.2.5 --- openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 19 Feb 2019 09:45:51 -0000 1.189.2.4 +++ openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 10 Mar 2019 21:34:33 -0000 1.189.2.5 @@ -478,7 +478,7 @@ sql } { - Generate html option tags for an html selection widget. If select_option + Generate html option tags for an HTML selection widget. If select_option is passed, this option will be marked as selected. @author yon [yon@arsdigita.com] @@ -513,7 +513,7 @@ sql } { - Generate html option tags with values for an html selection widget. If + Generate html option tags with values for an HTML selection widget. If select_option is passed and there exists a value for it in the values list, this option will be marked as selected. The "select_option" can be a list, in which case all options matching a value in the list will be @@ -1950,7 +1950,7 @@ # if {[ad_conn behind_secure_proxy_p]} { # - # We know, the request was an https request + # We know, the request was an HTTPS request # set proto https } @@ -4077,7 +4077,7 @@ # # Management of resource files, to be used in sitewide-admin procs to -# decide between CDN installations an local installations. +# decide between CDN installations and local installations. # # The configuration information is provided via dict named resource_info, # containing typically the following fields (all in Camel case style): @@ -4089,7 +4089,7 @@ # - cdn: the CDN URL prefix for obtaining the content (e.g. //maxcdn.bootstrapcdn.com/bootstrap) # - cdnHost: CDN host, sometimes needed for content security policies # - cssFiles: list of CSS files for that package (can be provided via URN) -# - jsFiles: list oj JavaScript files for that package (can be provided via URN) +# - jsFiles: list of JavaScript files for that package (can be provided via URN) # - extraFiles: list of more files, probably included by cssFiles (e.g. fonts) # - prefix: used for resolving the files on the server; might either point # to the CDN or to locally installed files (typically /resources/...) Index: openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl,v diff -u -r1.5 -r1.5.2.1 --- openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl 25 Jul 2018 13:42:48 -0000 1.5 +++ openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl 10 Mar 2019 21:34:33 -0000 1.5.2.1 @@ -35,7 +35,7 @@ aa_log "Registering a global parameter" apm_parameter_register -parameter_id $parameter_id -scope $scope $parameter_name $description $package_key $default_value $datatype aa_true "check apm_parameter_register global parameter" [string equal [parameter::get_global_value -package_key $package_key -parameter $parameter_name] $default_value] - aa_log "Unregistering an global parameter" + aa_log "Unregistering a global parameter" apm_parameter_unregister $parameter_id } Index: openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl,v diff -u -r1.20 -r1.20.2.1 --- openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl 3 Nov 2018 11:15:16 -0000 1.20 +++ openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl 10 Mar 2019 21:34:33 -0000 1.20.2.1 @@ -49,7 +49,7 @@ } { set html { - This is a text with an regular image , + This is a text with a regular image , image with alt text , and an embedded image . Index: openacs-4/packages/acs-core-docs/www/xml/for-everyone/release-notes.xml =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/for-everyone/release-notes.xml,v diff -u -r1.39 -r1.39.2.1 --- openacs-4/packages/acs-core-docs/www/xml/for-everyone/release-notes.xml 5 Aug 2018 21:26:03 -0000 1.39 +++ openacs-4/packages/acs-core-docs/www/xml/for-everyone/release-notes.xml 10 Mar 2019 21:36:25 -0000 1.39.2.1 @@ -1304,7 +1304,7 @@ + (e.g. ds_properties) Use per-thread caching to reduce number of mutex lock operations and lock contention on various caches (util-memoize, xo_site_nodes, xotcl_object_types) and nsvs - (e.g ds_properties) Improved templating of OpenACS core documentation