Index: openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl,v
diff -u -r1.4.2.25 -r1.4.2.26
--- openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl	19 Feb 2021 15:12:56 -0000	1.4.2.25
+++ openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl	22 Feb 2021 19:00:04 -0000	1.4.2.26
@@ -423,6 +423,15 @@
         @creation-date 2020-02-18
     } {
 
+        # Fetch service-contract procs to exclude them from the check
+        # when they are called from within the acs-service-contract
+        # package.
+        foreach alias [db_list get_sc_aliases {
+            select distinct impl_alias from acs_sc_impl_aliases
+        }] {
+            set sc_aliases($alias) 1
+        }
+
         foreach caller [lsort -dictionary [nsv_array names api_proc_doc]] {
             #set caller db_transaction
             set called_procs [api_called_proc_names -proc_name $caller]
@@ -445,6 +454,12 @@
                     && $package_key ne ""
                     && $caller_package_key ne $package_key
                 } {
+                    # It is fine for acs-service-contract to invoke
+                    # contract implementations.
+                    if {$caller_package_key eq "acs-service-contract" &&
+                        [info exists sc_aliases($called)]} {
+                        continue
+                    }
                     if {[apidoc::get_doc_property $called protection public] eq "private"
                         && ![string match AcsSc.* $caller]
                     } {
Index: openacs-4/packages/acs-authentication/tcl/local-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-authentication/tcl/local-procs.tcl,v
diff -u -r1.47.2.2 -r1.47.2.3
--- openacs-4/packages/acs-authentication/tcl/local-procs.tcl	22 Feb 2021 14:35:59 -0000	1.47.2.2
+++ openacs-4/packages/acs-authentication/tcl/local-procs.tcl	22 Feb 2021 19:00:04 -0000	1.47.2.3
@@ -134,7 +134,7 @@
 }
 
 
-ad_proc -public auth::local::authentication::Authenticate {
+ad_proc -private auth::local::authentication::Authenticate {
     username
     password
     {parameters {}}
@@ -170,7 +170,7 @@
     return [array get auth_info]
 }
 
-ad_proc -public auth::local::authentication::GetParameters {} {
+ad_proc -private auth::local::authentication::GetParameters {} {
     Implements the GetParameters operation of the auth_authentication
     service contract for the local account implementation.
 } {
@@ -431,7 +431,7 @@
     acs_sc::impl::delete -contract_name "auth_registration" -impl_name "local"
 }
 
-ad_proc -public auth::local::registration::GetElements {
+ad_proc -private auth::local::registration::GetElements {
     {parameters ""}
 } {
     Implements the GetElements operation of the auth_registration
@@ -457,7 +457,7 @@
     return [array get result]
 }
 
-ad_proc -public auth::local::registration::Register {
+ad_proc -private auth::local::registration::Register {
     parameters
     username
     authority_id
@@ -571,7 +571,7 @@
     return [array get result]
 }
 
-ad_proc -public auth::local::registration::GetParameters {} {
+ad_proc -private auth::local::registration::GetParameters {} {
     Implements the GetParameters operation of the auth_registration
     service contract for the local account implementation.
 } {
Fisheye: Tag 1.1 refers to a dead (removed) revision in file `openacs-4/packages/acs-authentication/tcl/test-authority-procs.tcl'.
Fisheye: No comparison available.  Pass `N' to diff?
Fisheye: Tag 1.1.2.1 refers to a dead (removed) revision in file `openacs-4/packages/acs-automated-testing/tcl/authority-procs.tcl'.
Fisheye: No comparison available.  Pass `N' to diff?