Index: openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl,v diff -u -r1.11 -r1.11.2.1 --- openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl 9 May 2018 15:33:28 -0000 1.11 +++ openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl 13 Mar 2019 09:04:09 -0000 1.11.2.1 @@ -50,7 +50,7 @@ invoke { label "\#acs-admin.Invoke\#" display_template {\#acs-admin.Invoke\#N/A} - link_url_eval {[ad_decode [lsearch { before-install after-install before-uninstall after-uninstall } $type] -1 {} [export_vars -base "version-callback-invoke" { version_id type }]]} + link_url_eval {[expr {$type in { before-install after-install before-uninstall after-uninstall } ? [export_vars -base "version-callback-invoke" { version_id type }] : ""}]} link_html { title "\#acs-admin.Invoke_this_callback_proc_now_Be_careful\#" } html { align center } } Index: openacs-4/packages/acs-admin/www/apm/version-view.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-view.tcl,v diff -u -r1.30 -r1.30.2.1 --- openacs-4/packages/acs-admin/www/apm/version-view.tcl 25 Nov 2018 02:40:16 -0000 1.30 +++ openacs-4/packages/acs-admin/www/apm/version-view.tcl 13 Mar 2019 09:07:19 -0000 1.30.2.1 @@ -23,7 +23,7 @@ db_1row apm_all_version_info {} -set downloaded_p [ad_decode $version_uri "" 0 1] +set downloaded_p [expr {$version_uri ne ""}] # Obtain information about the enabled version of the package (if there is one). # We use rownum = 1 in case someone mucks up the database and leaves two package versions