Index: openacs-4/packages/dotlrn/tcl/dotlrn-user-extension-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/dotlrn-user-extension-procs.tcl,v diff -u -r1.10 -r1.10.2.1 --- openacs-4/packages/dotlrn/tcl/dotlrn-user-extension-procs.tcl 7 Aug 2017 23:48:09 -0000 1.10 +++ openacs-4/packages/dotlrn/tcl/dotlrn-user-extension-procs.tcl 1 Mar 2019 11:38:00 -0000 1.10.2.1 @@ -60,7 +60,14 @@ -package_id [dotlrn::get_package_id] \ -default 1] - set guest_p [ad_decode $read_private_data_p 1 0 0 1 $read_private_data_p] + # apisano: this was previous version of this + # line. Basically, if one would supply e.g. '57' as a + # value in the parameter, this would have taken over + # the guest_p value as well. I decided to normalize + # the boolean and the turn it, as seems a saner + # behavior. + # set guest_p [ad_decode $read_private_data_p 1 0 0 1 $read_private_data_p] + set guest_p [expr {![string is true -strict $read_private_data_p]}] # create the dotLRN user now db_transaction { Index: openacs-4/packages/bulk-mail/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bulk-mail/www/index.tcl,v diff -u -r1.16 -r1.16.2.1 --- openacs-4/packages/bulk-mail/www/index.tcl 7 Aug 2017 23:48:04 -0000 1.16 +++ openacs-4/packages/bulk-mail/www/index.tcl 1 Mar 2019 11:41:40 -0000 1.16.2.1 @@ -49,7 +49,7 @@ db_multirow -extend {send_date_pretty message_url status_pretty} message_list get_mail_messages {} { set send_date_pretty [lc_time_fmt $send_date %q] set message_url "[lindex [site_node::get_url_from_object_id -object_id $package_id] 0]one?bulk_mail_id=$bulk_mail_id" - set status_pretty [ad_decode $status sent [_ bulk-mail.Sent] pending [_ bulk-mail.Pending] [_ bulk-mail.Cancelled]] + set status_pretty [switch $status { "sent" {_ bulk-mail.Sent} "pending" {_ bulk-mail.Pending} default {_ bulk-mail.Cancelled} }] } ad_return_template