Index: openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs-postgresql.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs-postgresql.xql,v
diff -u -r1.1.2.1 -r1.1.2.2
--- openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs-postgresql.xql	9 Dec 2002 14:10:46 -0000	1.1.2.1
+++ openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs-postgresql.xql	17 Dec 2002 13:12:45 -0000	1.1.2.2
@@ -3,7 +3,7 @@
 <queryset>
   <rdbms><type>postgresql</type><version>7.1</version></rdbms>
 
-  <fullquery name="plpgsql_utility::generate_attribute_parameter_call.get_function_args">      
+  <fullquery name="plpgsql_utility::get_function_args.get_function_args">      
     <querytext>
       select arg_name, arg_default
       from acs_function_args
Index: openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl,v
diff -u -r1.2 -r1.2.4.1
--- openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl	3 Aug 2001 21:09:20 -0000	1.2
+++ openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl	17 Dec 2002 13:12:45 -0000	1.2.4.1
@@ -29,6 +29,12 @@
 	return [generate_attribute_parameter_call -prepend $prepend $function_name $the_list]
     }
 
+    ad_proc -private get_function_args {function_name} {
+        uncached version returns list of lists args
+        called from generate_attribute_parameter_call
+    } { 
+        return [db_list_of_lists get_function_args {}]
+    }
 
     ad_proc -public generate_attribute_parameter_call {
 	{ -prepend "" }
@@ -41,14 +47,8 @@
 	@creation-date 07/2001
 
     } {
-	ns_log Notice "*** $function_name [join $pairs "\n"]"
 	# Get the list of real args to the function
-	set real_args [db_list_of_lists get_function_args "
-	    select arg_name, arg_default
-	      from acs_function_args
-	     where function = upper(:function_name)
-	     order by arg_seq
-	"]
+	set real_args [util_memoize [list plpgsql_utility::get_function_args $function_name]]
 
 	foreach row $pairs {
 	    set attr [string trim [lindex $row 0]]
@@ -84,12 +84,7 @@
 	@creation-date 07/2001
 
     } {
-	return [db_string fetch_type "
-	       select data_type
-	         from user_tab_columns
-		where table_name = upper(:table)
-		  and column_name = upper(:column)
-	"]
+	return [db_string fetch_type {}]
     }
 
     ad_proc -public generate_attribute_parameters {