Index: openacs-4/packages/acs-core-docs/www/xml/developers-guide/i18n.xml
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-core-docs/www/xml/developers-guide/i18n.xml,v
diff -u -r1.18 -r1.19
--- openacs-4/packages/acs-core-docs/www/xml/developers-guide/i18n.xml 21 Apr 2004 13:18:35 -0000 1.18
+++ openacs-4/packages/acs-core-docs/www/xml/developers-guide/i18n.xml 21 Apr 2004 13:30:34 -0000 1.19
@@ -761,8 +761,9 @@
... and include the variable in the key: "New %bug_label%". This gives translators more control over the phrase.
- In this bad example, full name is created by concatenating first and last name (admittedly this is pervasive in the toolkit):
- <a href="@past_version.maintainer_url@" title="#bug-tracker.Email# @past_version.maintainer_email@">@past_version.maintainer_first_names@ @past_version.maintainer_last_name@</a>
+ In this example of bad i18n, full name is created by concatenating first and last name (admittedly this is pervasive in the toolkit):
+ <a href="@past_version.maintainer_url@" title="#bug-tracker.Email# @past_version.maintainer_email@">
+@past_version.maintainer_first_names@ @past_version.maintainer_last_name@</a>
@@ -802,14 +803,14 @@
-entry_id $entry_id \
-key "resolution" \
-value [db_string select_resolution_code {}]
- This is internationalized to
+ This is incorrectly internationalized to
workflow::case::add_log_data \
-entry_id $entry_id \
-key "[_ bug-tracker.resolution]" \
-value [db_string select_resolution_code {}]
But resolution is a keyword in a table and in the code, so this breaks the code. It should not have been internationalized at all. Here's another example of text that should not have been internationalized:
{show_patch_status "open"}
- was changed to
+ It is broken if changed to
{show_patch_status "[_ bug-tracker.open]"}
@@ -826,8 +827,8 @@
Sometimes the automatic converter creates keys that don't semantically match their text. Fix these:
<msg key="Fix">for version</msg>
- <msg key="Fix_1">for</msg>
- <msg key="Fix_2">for Bugs</msg>
+<msg key="Fix_1">for</msg>
+<msg key="Fix_2">for Bugs</msg>
Another example: Bug-tracker component maintainer" was converted to "[_ bug-tracker.Bug-tracker]". Instead, it should be bug_tracker_component_maintainer.
@@ -848,9 +849,9 @@
Watch out for quoting and escaping when editing text that is also code. For example, the original string
set title "Patch \"$patch_summary\" is nice."
- is broken if converted to
+ breaks if the message text retains all of the escaping that was in the tcl command:
<msg>Patch \"$patch_summary\" is nice.</msg>
- instead it should be
+ When it becomes a key, it should be:
<msg>Patch "$patch_summary" is nice.</msg>
Also, some keys had %var;noquote%, which is not needed since those
variables are not quoted (and in fact the variable won't even be