Index: openacs-4/packages/acs-admin/lib/password-update.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/lib/password-update.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/acs-admin/lib/password-update.tcl 21 Jan 2018 00:38:37 -0000 1.8 +++ openacs-4/packages/acs-admin/lib/password-update.tcl 17 Jul 2018 11:42:26 -0000 1.9 @@ -64,7 +64,7 @@ # Continue } old_password_bad { - if { (![info exists old_password] || $old_password eq "") } { + if { ![info exists old_password] || $old_password eq "" } { form set_error update password_old $result(password_message) } else { # This hack causes the form to reload as if submitted, but with the old password showing Index: openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl,v diff -u -N -r1.22 -r1.23 --- openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl 30 Apr 2018 12:45:00 -0000 1.22 +++ openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl 17 Jul 2018 11:42:26 -0000 1.23 @@ -54,7 +54,7 @@ set replace_tags_p [ad_decode [lsearch -exact $file_action replace_tags] "-1" "0" "1"] # We need either or both of the actions to be selected -if { (! $replace_text_p) && (! $replace_tags_p) } { +if { ! $replace_text_p && ! $replace_tags_p } { ad_return_complaint 1 "Invalid HTML Parameters: you must choose an action to take on selected adp files, either replace_text or replace_tags or both." ad_script_abort } Index: openacs-4/packages/acs-api-browser/www/proc-search.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/proc-search.tcl,v diff -u -N -r1.21 -r1.22 --- openacs-4/packages/acs-api-browser/www/proc-search.tcl 23 May 2018 06:57:54 -0000 1.21 +++ openacs-4/packages/acs-api-browser/www/proc-search.tcl 17 Jul 2018 11:42:26 -0000 1.22 @@ -48,7 +48,10 @@ ########################### # No weighting use default: -if { ($name_weight == 0) && ($doc_weight == 0) && ($param_weight == 0) && ($source_weight == 0) } { +if { $name_weight == 0 + && $doc_weight == 0 + && $param_weight == 0 + && $source_weight == 0 } { set name_weight 1 } Index: openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl,v diff -u -N -r1.29 -r1.30 --- openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl 28 Jun 2018 16:14:53 -0000 1.29 +++ openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl 17 Jul 2018 11:42:26 -0000 1.30 @@ -167,7 +167,7 @@ append output [subst {$day_number_template}] " " } - if { (!$skip_day) && $large_calendar_p == 1 } { + if { !$skip_day && $large_calendar_p == 1 } { append output "
" set calendar_day_index [ns_set find $calendar_details $julian_date] Index: openacs-4/packages/acs-lang/lib/change-locale-bar.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/lib/change-locale-bar.tcl,v diff -u -N -r1.6 -r1.7 --- openacs-4/packages/acs-lang/lib/change-locale-bar.tcl 7 Aug 2017 23:47:56 -0000 1.6 +++ openacs-4/packages/acs-lang/lib/change-locale-bar.tcl 17 Jul 2018 11:42:26 -0000 1.7 @@ -6,16 +6,16 @@ set current_locale [lang::conn::locale] set base_lang_url [site_node::get_package_url -package_key acs-lang] -if { (![info exists return_url] || $return_url eq "")} { +if { ![info exists return_url] || $return_url eq "" } { # Use referer header set return_url [ad_return_url] } -if { (![info exists max_locales] || $max_locales eq "")} { +if { ![info exists max_locales] || $max_locales eq "" } { set max_locales 8 } -if { (![info exists avail_key] || $avail_key eq "") } { +if { ![info exists avail_key] || $avail_key eq "" } { set avail_key "this-language" } Index: openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl,v diff -u -N -r1.61 -r1.62 --- openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl 12 Jul 2018 09:02:29 -0000 1.61 +++ openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl 17 Jul 2018 11:42:26 -0000 1.62 @@ -668,7 +668,7 @@ upvar $upvar_level $variable_name local_variable if { [info exists local_variable] } { - if { (![info exists array_key] || $array_key eq "") } { + if { ![info exists array_key] || $array_key eq "" } { # Normal Tcl variable append formatted_message $local_variable } else { Index: openacs-4/packages/acs-tcl/lib/static-progress-bar.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/lib/static-progress-bar.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/acs-tcl/lib/static-progress-bar.tcl 7 Aug 2017 23:47:59 -0000 1.3 +++ openacs-4/packages/acs-tcl/lib/static-progress-bar.tcl 17 Jul 2018 11:42:26 -0000 1.4 @@ -43,7 +43,7 @@ set header_color "black" } -if { ($total == 0) || [string is true $finish] } { +if { $total == 0 || [string is true $finish] } { set percentage_done 100 } elseif {[info exists finished_page] && $finished_page == $current} { # subtract 1 from current, since we haven't completed this page yet Index: openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl,v diff -u -N -r1.43 -r1.44 --- openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl 15 Jun 2018 22:12:48 -0000 1.43 +++ openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl 17 Jul 2018 11:42:26 -0000 1.44 @@ -333,7 +333,7 @@ set netscape3_p 0 - if { ($netscape_p && ($version == 3))} { + if { $netscape_p && $version == 3 } { set netscape3_p 1 } Index: openacs-4/packages/acs-templating/tcl/list-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/list-procs.tcl,v diff -u -N -r1.87 -r1.88 --- openacs-4/packages/acs-templating/tcl/list-procs.tcl 15 Jun 2018 22:10:30 -0000 1.87 +++ openacs-4/packages/acs-templating/tcl/list-procs.tcl 17 Jul 2018 11:42:26 -0000 1.88 @@ -1693,7 +1693,7 @@ set selected_p [exists_and_equal current_filter_value $value] } multival { - if { (![info exists current_filter_value] || $current_filter_value eq "") } { + if { ![info exists current_filter_value] || $current_filter_value eq "" } { set selected_p 0 } else { # Since here we have multiple values Index: openacs-4/packages/acs-templating/tcl/wizard-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/wizard-procs.tcl,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/acs-templating/tcl/wizard-procs.tcl 9 May 2018 15:33:29 -0000 1.17 +++ openacs-4/packages/acs-templating/tcl/wizard-procs.tcl 17 Jul 2018 11:42:26 -0000 1.18 @@ -319,7 +319,7 @@ # otherwise we keep the current value set last_visitedstep [get_param wizard_visitedstep${wizard_name}] set current_step [current_step] - if { ($last_visitedstep < $current_step) || $last_visitedstep eq "" } { + if { $last_visitedstep < $current_step || $last_visitedstep eq "" } { return $current_step } else { return $last_visitedstep Index: openacs-4/packages/assessment/lib/assessment.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/lib/assessment.tcl,v diff -u -N -r1.31 -r1.32 --- openacs-4/packages/assessment/lib/assessment.tcl 28 May 2018 13:46:43 -0000 1.31 +++ openacs-4/packages/assessment/lib/assessment.tcl 17 Jul 2018 11:42:26 -0000 1.32 @@ -191,7 +191,7 @@ } # determine on which page we are right now based on item_order - if { (![info exists item_order] || $item_order eq "") } { set item_order 0 } + if { ![info exists item_order] || $item_order eq "" } { set item_order 0 } # add 1 because we want to compare the 1 indexed display number # to the current page set current_page [expr {$item_order == 0 ? 0 : $item_order / $page_display_per_page + 1}] Index: openacs-4/packages/assessment/lib/progress-bar.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/lib/Attic/progress-bar.tcl,v diff -u -N -r1.3 -r1.4 --- openacs-4/packages/assessment/lib/progress-bar.tcl 7 Aug 2017 23:48:03 -0000 1.3 +++ openacs-4/packages/assessment/lib/progress-bar.tcl 17 Jul 2018 11:42:26 -0000 1.4 @@ -38,7 +38,7 @@ set header_color "black" } -if { ($total == 0) || [string is true $finish] } { +if { $total == 0 || [string is true $finish] } { set percentage_done 100 } elseif {[info exists finished_page] && $finished_page == $current} { # subtract 1 from current, since we haven't completed this page yet Index: openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl,v diff -u -N -r1.12 -r1.13 --- openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl 29 Jun 2018 17:27:18 -0000 1.12 +++ openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl 17 Jul 2018 11:42:26 -0000 1.13 @@ -59,7 +59,7 @@ set question_text [db_string get_question {}] if {[info exists edit_check] && $edit_check ne ""} { - if { (![info exists type] || $type eq "")} { + if { ![info exists type] || $type eq "" } { set return_url "&check_id=$inter_item_check_id&edit_check=t" } Index: openacs-4/packages/assessment/www/asm-admin/item-stats.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/item-stats.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/assessment/www/asm-admin/item-stats.tcl 9 May 2018 15:33:29 -0000 1.10 +++ openacs-4/packages/assessment/www/asm-admin/item-stats.tcl 17 Jul 2018 11:42:26 -0000 1.11 @@ -27,7 +27,7 @@ # if we get a dotlrn_ecommerce_section_id (catalog_section_id), # let's create a clause to query all the rel_ids with type membership_rels set limit_to_section_clause "" -if { ([info exists catalog_section_id] && $catalog_section_id ne "") } { +if { [info exists catalog_section_id] && $catalog_section_id ne "" } { set limit_to_section_clause "(select session_id from dotlrn_ecommerce_application_assessment_map where rel_id in (select rel_id from acs_rels where rel_type='dotlrn_member_rel' and object_id_one = (select community_id from dotlrn_ecommerce_section where section_id=:catalog_section_id)))" } @@ -99,7 +99,7 @@ set visited_session_ids [list] set item_choices_limit_session "" - if { ([info exists limit_to_section_clause] && $limit_to_section_clause ne "") } { set item_choices_limit_session "and d.session_id in $limit_to_section_clause" } + if { [info exists limit_to_section_clause] && $limit_to_section_clause ne "" } { set item_choices_limit_session "and d.session_id in $limit_to_section_clause" } if {([info exists session_id_list] && $session_id_list ne "")} {set item_choices_limit_session " and d.session_id in ([template::util::tcl_to_sql_list $session_id_list]) " } set item_choices_query "select r.title as choice_title, c.choice_id, c.correct_answer_p, (select count(*) @@ -139,7 +139,7 @@ } set total_responses_limit_session "" - if { ([info exists limit_to_section_clause] && $limit_to_section_clause ne "") } { set total_responses_limit_session "and s.session_id in $limit_to_section_clause" } + if { [info exists limit_to_section_clause] && $limit_to_section_clause ne "" } { set total_responses_limit_session "and s.session_id in $limit_to_section_clause" } if {([info exists session_id_list] && $session_id_list ne "")} { set total_responses_limit_session " and s.session_id in ([template::util::tcl_to_sql_list $session_id_list]) " Index: openacs-4/packages/assessment/www/asm-admin/one-a.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/one-a.tcl,v diff -u -N -r1.17 -r1.18 --- openacs-4/packages/assessment/www/asm-admin/one-a.tcl 29 Jun 2018 17:27:18 -0000 1.17 +++ openacs-4/packages/assessment/www/asm-admin/one-a.tcl 17 Jul 2018 11:42:26 -0000 1.18 @@ -49,7 +49,7 @@ set results_url [export_vars -base results-users {assessment_id}] set export_url [export_vars -base results-export {assessment_id}] -if { ([info exists asm_instance] && $asm_instance ne "")} { +if { [info exists asm_instance] && $asm_instance ne "" } { set reg_url "[apm_package_url_from_id $asm_instance]admin" } else { set reg_url "../admin" Index: openacs-4/packages/assessment/www/asm-admin/section-select.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/section-select.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/assessment/www/asm-admin/section-select.tcl 29 Jun 2018 17:27:18 -0000 1.9 +++ openacs-4/packages/assessment/www/asm-admin/section-select.tcl 17 Jul 2018 11:42:26 -0000 1.10 @@ -27,7 +27,7 @@ set return_url "one-a?assessment_id=$assessment_id" -if { ([info exists by_item_p] && $by_item_p ne "") } { +if { [info exists by_item_p] && $by_item_p ne "" } { if { $by_item_p == 1} { set return_url "checks-admin?assessment_id=$assessment_id§ion_id=$section_id&item_id=$item_id" } else { Index: openacs-4/packages/assessment/www/asm-admin/sessions.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/sessions.tcl,v diff -u -N -r1.10 -r1.11 --- openacs-4/packages/assessment/www/asm-admin/sessions.tcl 9 May 2018 15:33:29 -0000 1.10 +++ openacs-4/packages/assessment/www/asm-admin/sessions.tcl 17 Jul 2018 11:42:26 -0000 1.11 @@ -54,7 +54,7 @@ lappend actions "[_ assessment.Summary]" [export_vars -base item-stats { assessment_id {return_url [ad_return_url]} }] "[_ assessment.Summary]" } -if { ([info exists status] && $status ne "") } { +if { [info exists status] && $status ne "" } { if { $status eq "complete" } { set whereclause "cs.completed_datetime is not null" } elseif { $status eq "incomplete" } { Index: openacs-4/packages/bug-tracker/tcl/bug-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-procs.tcl,v diff -u -N -r1.45 -r1.46 --- openacs-4/packages/bug-tracker/tcl/bug-procs.tcl 26 Jun 2018 19:31:20 -0000 1.45 +++ openacs-4/packages/bug-tracker/tcl/bug-procs.tcl 17 Jul 2018 11:42:26 -0000 1.46 @@ -107,7 +107,7 @@ set comment_content $description set comment_format $desc_format - if { (![info exists creation_date] || $creation_date eq "") } { + if { ![info exists creation_date] || $creation_date eq "" } { set creation_date [db_string select_sysdate {}] } @@ -280,7 +280,7 @@ # Update the keywords foreach {category_id category_name} [bug_tracker::category_types] { - if { ([info exists row($category_id)] && $row($category_id) ne "") } { + if { [info exists row($category_id)] && $row($category_id) ne "" } { content::keyword::item_assign -item_id $bug_id -keyword_id $row($category_id) } # LARS: Index: openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl,v diff -u -N -r1.61 -r1.62 --- openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl 27 Jun 2018 09:46:41 -0000 1.61 +++ openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl 17 Jul 2018 11:42:26 -0000 1.62 @@ -1471,7 +1471,7 @@ set properties_url [export_vars -base "related-file-properties" {bug_id related_object_id}] set delete_url [export_vars -base "related-file-delete" {bug_id related_object_id return_url}] set new_version_url [export_vars -base "related-file-update" {bug_id related_object_id return_url}] - if { ( $related_creation_user == $user_id ) || $admin_p } { + if { $related_creation_user == $user_id || $admin_p } { set extra_actions [subst { | [_ bug-tracker.upload_new_version] | [_ bug-tracker.delete] @@ -1522,7 +1522,7 @@ set properties_url [export_vars -base "related-file-properties" {bug_id related_object_id}] set delete_url [export_vars -base "related-file-delete" {bug_id related_object_id return_url}] set new_version_url [export_vars -base "related-file-update" {bug_id related_object_id return_url}] - if { ( $related_creation_user == $user_id ) || $admin_p } { + if { $related_creation_user == $user_id || $admin_p } { set extra_actions [subst { | upload new version | delete Index: openacs-4/packages/bug-tracker/www/map-patch-to-bugs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/map-patch-to-bugs.tcl,v diff -u -N -r1.15 -r1.16 --- openacs-4/packages/bug-tracker/www/map-patch-to-bugs.tcl 29 Jun 2018 17:27:18 -0000 1.15 +++ openacs-4/packages/bug-tracker/www/map-patch-to-bugs.tcl 17 Jul 2018 11:42:26 -0000 1.16 @@ -30,7 +30,7 @@ bug_tracker::get_pretty_names -array pretty_names -if { ([info exists cancel] && $cancel ne "") } { +if { [info exists cancel] && $cancel ne "" } { # The user chose to abort the mapping so redirect without further processing ad_returnredirect $redirect_url ad_script_abort @@ -45,7 +45,7 @@ } -if { ([info exists bug_number] && $bug_number ne "") } { +if { [info exists bug_number] && $bug_number ne "" } { # Do the mapping foreach one_bug_number $bug_number { set bug_id [db_string get_bug_id_for_number {}] @@ -63,7 +63,7 @@ set context [list "$page_title"] # Build the component filter -if { (![info exists component_id] || $component_id eq "") } { +if { ![info exists component_id] || $component_id eq "" } { set component_id [db_string component_id_for_patch {}] } set component_where_clause "" Index: openacs-4/packages/bug-tracker/www/notifications.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/notifications.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/bug-tracker/www/notifications.tcl 14 Oct 2013 18:14:22 -0000 1.5 +++ openacs-4/packages/bug-tracker/www/notifications.tcl 17 Jul 2018 11:42:26 -0000 1.6 @@ -9,7 +9,7 @@ set package_id [ad_conn package_id] set workflow_id [bug_tracker::bug::get_instance_workflow_id] -if { ([info exists bug_number] && $bug_number ne "") } { +if { [info exists bug_number] && $bug_number ne "" } { set bug_id [bug_tracker::get_bug_id \ -bug_number $bug_number \ -project_id [ad_conn package_id]] Index: openacs-4/packages/bug-tracker/www/patch-add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/patch-add.tcl,v diff -u -N -r1.20 -r1.21 --- openacs-4/packages/bug-tracker/www/patch-add.tcl 29 Jun 2018 17:27:18 -0000 1.20 +++ openacs-4/packages/bug-tracker/www/patch-add.tcl 17 Jul 2018 11:42:26 -0000 1.21 @@ -23,7 +23,7 @@ permission::require_permission -object_id [ad_conn package_id] -privilege create if { $return_url eq "" } { - if { ([info exists bug_number] && $bug_number ne "") } { + if { [info exists bug_number] && $bug_number ne "" } { set return_url [export_vars -base bug { bug_number }] } else { set return_url "patch-list" @@ -87,7 +87,7 @@ -widget file \ -label "[_ bug-tracker.Patch]" \ -if { ([info exists bug_number] && $bug_number ne "") } { +if { [info exists bug_number] && $bug_number ne "" } { # Export the bug number element create patch bug_number \ -datatype integer \ @@ -109,7 +109,7 @@ if { [form is_request patch] } { # Form requested - if { ([info exists bug_number] && $bug_number ne "") } { + if { [info exists bug_number] && $bug_number ne "" } { element set_properties patch bug_number -value $bug_number } Index: openacs-4/packages/bug-tracker/www/admin/category-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/admin/category-edit.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/bug-tracker/www/admin/category-edit.tcl 26 Jun 2015 14:47:08 -0000 1.8 +++ openacs-4/packages/bug-tracker/www/admin/category-edit.tcl 17 Jul 2018 11:42:26 -0000 1.9 @@ -29,7 +29,7 @@ {parent_id:integer(hidden)} {heading:text {label $object_type_name}} } -new_request { - if { (![info exists parent_id] || $parent_id eq "") } { + if { ![info exists parent_id] || $parent_id eq "" } { set parent_id [bug_tracker::conn project_root_keyword_id] } } -select_query { Index: openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl,v diff -u -N -r1.44 -r1.45 --- openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl 29 Jun 2018 17:27:18 -0000 1.44 +++ openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl 17 Jul 2018 11:42:26 -0000 1.45 @@ -72,7 +72,7 @@ set calendar_id [lindex $list_of_calendar_ids 0] db_0or1row select_calendar_package_id {select package_id from calendars where calendar_id=:calendar_id} if { ![info exists period_days] } { - if { ([info exists community_id] && $community_id ne "") } { + if { [info exists community_id] && $community_id ne "" } { set period_days [parameter::get -package_id $package_id -parameter ListView_DefaultPeriodDays -default 31] } else { foreach calendar $list_of_calendar_ids { Index: openacs-4/packages/chat/www/search-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/chat/www/search-2.tcl,v diff -u -N -r1.9 -r1.10 --- openacs-4/packages/chat/www/search-2.tcl 15 Jun 2018 23:11:09 -0000 1.9 +++ openacs-4/packages/chat/www/search-2.tcl 17 Jul 2018 11:42:26 -0000 1.10 @@ -84,7 +84,7 @@ set passthrough_parameters "[export_entire_form_as_url_vars $passthrough]" } -if { ([info exists limit_to_users_in_group_id] && $limit_to_users_in_group_id ne "") } { +if { [info exists limit_to_users_in_group_id] && $limit_to_users_in_group_id ne "" } { set query "select distinct first_names, last_name, email, member_state, email_verified_p, cu.user_id from cc_users cu, group_member_map gm, membership_rels mr where cu.user_id = gm.member_id @@ -133,7 +133,7 @@ set user_search:rowcount $rowcount # We are limiting the search to one group - display that group's name -if { ([info exists limit_to_users_in_group_id] && $limit_to_users_in_group_id ne "") && ![regexp {[^0-9]} $limit_to_users_in_group_id] } { +if { [info exists limit_to_users_in_group_id] && $limit_to_users_in_group_id ne "" && ![regexp {[^0-9]} $limit_to_users_in_group_id] } { set group_name [db_string user_group_name_from_id "select group_name from user_groups where group_id = :limit_to_users_in_group_id"] set title "User search in $group_name" } else { Index: openacs-4/packages/dotlrn/tcl/community-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/community-procs.tcl,v diff -u -N -r1.230 -r1.231 --- openacs-4/packages/dotlrn/tcl/community-procs.tcl 12 Jul 2018 13:44:08 -0000 1.230 +++ openacs-4/packages/dotlrn/tcl/community-procs.tcl 17 Jul 2018 11:42:26 -0000 1.231 @@ -2392,7 +2392,7 @@ return [list $subject $email] } # Shamelessly cut & pasted from bulk mail - if { (![info exists from_addr] || $from_addr eq "") } { + if { ![info exists from_addr] || $from_addr eq "" } { set from_addr [ad_system_owner] } Index: openacs-4/packages/dotlrn/www/spam-recipients.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/spam-recipients.tcl,v diff -u -N -r1.8 -r1.9 --- openacs-4/packages/dotlrn/www/spam-recipients.tcl 7 Aug 2017 23:48:09 -0000 1.8 +++ openacs-4/packages/dotlrn/www/spam-recipients.tcl 17 Jul 2018 11:42:26 -0000 1.9 @@ -7,7 +7,7 @@ set spam_name [bulk_mail::parameter -parameter PrettyName -default [_ dotlrn.Spam]] set context_bar [list [list $referer [_ dotlrn.Admin]] "$spam_name [_ dotlrn.Community]"] -if { (![info exists community_id] || $community_id eq "") } { +if { ![info exists community_id] || $community_id eq "" } { set community_id [dotlrn_community::get_community_id] } set community_name [dotlrn_community::get_community_name $community_id] Index: openacs-4/packages/faq/lib/faq-add-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/faq/lib/faq-add-edit.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/faq/lib/faq-add-edit.tcl 7 Aug 2017 23:48:10 -0000 1.5 +++ openacs-4/packages/faq/lib/faq-add-edit.tcl 17 Jul 2018 11:42:26 -0000 1.6 @@ -1,5 +1,5 @@ -if { (![info exists mode] || $mode eq "") } { +if { ![info exists mode] || $mode eq "" } { set mode "edit" } @@ -15,7 +15,7 @@ } -edit_data { db_dml edit_faq {} } -after_submit { - if { (![info exists return_url] || $return_url eq "") } { + if { ![info exists return_url] || $return_url eq "" } { set return_url [export_vars -base one-faq { faq_id }] } ad_returnredirect $return_url Index: openacs-4/packages/static-portlet/www/element.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/static-portlet/www/element.tcl,v diff -u -N -r1.24 -r1.25 --- openacs-4/packages/static-portlet/www/element.tcl 29 Jun 2018 17:27:19 -0000 1.24 +++ openacs-4/packages/static-portlet/www/element.tcl 17 Jul 2018 11:42:27 -0000 1.25 @@ -167,7 +167,7 @@ db_foreach dotlrn_type_portals "$query" { - if { ($type ne "user") } { + if { $type ne "user" } { catch { set element_content_id [db_string get_content_id { select content_id Index: openacs-4/packages/theme-selva/tcl/selva-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/theme-selva/tcl/selva-procs.tcl,v diff -u -N -r1.19 -r1.20 --- openacs-4/packages/theme-selva/tcl/selva-procs.tcl 29 Jun 2018 17:27:19 -0000 1.19 +++ openacs-4/packages/theme-selva/tcl/selva-procs.tcl 17 Jul 2018 11:42:27 -0000 1.20 @@ -101,7 +101,7 @@ incr which_tab } - if { ([info exists community_id] && $community_id ne "") } { + if { [info exists community_id] && $community_id ne "" } { set type [dotlrn_community::get_community_type_from_community_id $community_id] if { $type eq "dotlrn_community" || $type eq "dotlrn_pers_community" } { set community_message_key "#dotlrn.subcommunities_pretty_name#"