Index: openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl,v
diff -u -r1.46 -r1.47
--- openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl 25 Jul 2018 21:57:06 -0000 1.46
+++ openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl 19 Sep 2018 00:55:36 -0000 1.47
@@ -204,7 +204,7 @@
ad_proc -public ad_navbar args {
- produces navigation bar. notice that navigation bar is different
+ Produces a navigation bar. Notice that navigation bar is different
than context bar, which displays packages in the site map. Navbar will
only generate HTML for those links passed to it.
@@ -344,7 +344,7 @@
# creates the generic javascript/nonjavascript
# select box for the submenu
-proc menu_submenu_select_list {items urls {highlight_url "" }} {
+proc menu_submenu_select_list {items URLs {highlight_url "" }} {
set return_string ""
set counter 0
@@ -362,12 +362,12 @@
# if the url matches the url you would redirect to, as determined
# either by highlight_url, or if highlight_url is not set,
# the current url then select it
- if {$highlight_url ne "" && $highlight_url == [lindex $urls $counter]} {
- append return_string [subst {<option value="[lindex $urls $counter]" selected>$item}]
- } elseif {$highlight_url eq "" && [string match "*$url_stub*" [lindex $urls $counter]]} {
- append return_string [subst {<option value="[lindex $urls $counter]" selected>$item}]
+ if {$highlight_url ne "" && $highlight_url == [lindex $URLs $counter]} {
+ append return_string [subst {<option value="[lindex $URLs $counter]" selected>$item}]
+ } elseif {$highlight_url eq "" && [string match "*$url_stub*" [lindex $URLs $counter]]} {
+ append return_string [subst {<option value="[lindex $URLs $counter]" selected>$item}]
} else {
- append return_string [subst {<option value="[lindex $urls $counter]">$item}]
+ append return_string [subst {<option value="[lindex $URLs $counter]">$item}]
}
incr counter
}
Index: openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl,v
diff -u -r1.24 -r1.25
--- openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl 20 Jun 2018 13:06:26 -0000 1.24
+++ openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl 19 Sep 2018 00:55:36 -0000 1.25
@@ -105,7 +105,7 @@
} {
Set the value of a package instance parameter
- @param package_id what package to set the parameter in. defaults to
+ @param package_id what package to set the parameter in. Defaults to
[ad_conn package_id]
@param parameter which parameter's value to set
@param value what value to set said parameter to
@@ -130,7 +130,7 @@
@param localize should we attempt to localize the parameter
@param boolean insure boolean parameters are normalized to 0 or 1
- @param package_id what package to get the parameter from. defaults to
+ @param package_id what package to get the parameter from. Defaults to
[ad_conn package_id]
@param parameter which parameter's value to get
@param default what to return if we don't find a value. Defaults to returning the empty string.
@@ -219,10 +219,10 @@
New packages should use global parameters instead.
- @param package_key what package to get the parameter from. we will try
- to get the package_id from the package_key. this
- may cause an error if there are more than one
- instance of this package
+ @param package_key what package to get the parameter from. We will try
+ to get the package_id from the package_key. This
+ may cause an error if there are more than one
+ instance of this package
@param parameter which parameter's value to get
@param default what to return if we don't find a value
} {
Index: openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl,v
diff -u -r1.144 -r1.145
--- openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 9 Sep 2018 13:24:10 -0000 1.144
+++ openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 19 Sep 2018 00:55:36 -0000 1.145
@@ -62,12 +62,12 @@
}
}
- # save the current file setting
+ # Save the current file setting.
set saved_file [ad_conn file]
rp_serve_abstract_file $path
- # restore the file setting. we need to do this because
+ # Restore the file setting. We need to do this because
# rp_serve_abstract_file sets it to the path we internally
# redirected to, and rp_handler will cache the file setting
# internally in the ::tcl_url2file variable when PerformanceModeP is
Index: openacs-4/packages/acs-tcl/tcl/security-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/security-procs.tcl,v
diff -u -r1.106 -r1.107
--- openacs-4/packages/acs-tcl/tcl/security-procs.tcl 13 Sep 2018 06:20:36 -0000 1.106
+++ openacs-4/packages/acs-tcl/tcl/security-procs.tcl 19 Sep 2018 00:55:36 -0000 1.107
@@ -38,7 +38,7 @@
} {
# ::tcl_sec_seed is used to maintain a small subset of the previously
# generated random token to use as the seed for the next
- # token. this makes finding a pattern in sec_random_token harder
+ # token. This makes finding a pattern in sec_random_token harder
# to guess when it is called multiple times in the same thread.
if { [ad_conn -connected_p] } {
@@ -210,8 +210,8 @@
ad_conn -set auth_level $auth_level
ad_conn -set account_status $account_status
- # reissue session cookie so session doesn't expire if the
- # renewal period has passed. this is a little tricky because
+ # Reissue session cookie so session doesn't expire if the
+ # renewal period has passed. This is a little tricky because
# the cookie doesn't know about sec_session_renew; it only
# knows about sec_session_timeout.
# [sec_session_renew] = SessionTimeout - SessionRenew (see security-init.tcl)
@@ -388,7 +388,7 @@
ad_proc -public sec_change_user_auth_token {
user_id
} {
- Change the user's auth_token, which invalidates all existing login cookies, ie. forces user logout at the server.
+ Change the user's auth_token, which invalidates all existing login cookies, i.e. forces user logout at the server.
} {
set auth_token [ad_generate_random_string]
@@ -2200,7 +2200,7 @@
}
#
- # Check against the virtual server configuration of NaviServer. xxxx
+ # Check against the virtual server configuration of NaviServer.
#
if {[ns_info name] eq "NaviServer"} {
set s [ns_info server]
Index: openacs-4/packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl,v
diff -u -r1.13 -r1.14
--- openacs-4/packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl 7 Aug 2017 23:48:00 -0000 1.13
+++ openacs-4/packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl 19 Sep 2018 00:55:36 -0000 1.14
@@ -38,8 +38,9 @@
{-package_id ""}
{-package_key:required}
} {
- get the package_id of package_key that is mounted directly under
- package_id. returns empty string if not found.
+ Get the package_id of package_key that is mounted directly under
+ package_id.
+ @return empty string if not found.
} {
if {$package_id eq ""} {
if {[ad_conn isconnected]} {
Index: openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl,v
diff -u -r1.129 -r1.130
--- openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl 18 Sep 2018 18:28:55 -0000 1.129
+++ openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl 19 Sep 2018 00:55:36 -0000 1.130
@@ -1331,7 +1331,7 @@
# results, we cache for every parameter combination.
#
# Since this cache contains subtrees, we have to flush
- # trees, which is implemented via pattern flushes. so
+ # trees, which is implemented via pattern flushes. So
# we use a separate cache to avoid long locks on
# site-nodes in general.
#
Index: openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl,v
diff -u -r1.179 -r1.180
--- openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 17 Sep 2018 18:17:42 -0000 1.179
+++ openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 19 Sep 2018 00:55:36 -0000 1.180
@@ -13,9 +13,9 @@
ad_proc util::pdfinfo {
file
} {
- Calls the pdfinfo command line utility on a given pdf
- file. pdfinfo must be installed on the server for this to work. On
- linux this is usually part of the poppler-utils
+ Calls the pdfinfo command line utility on a given pdf file. The
+ command pdfinfo must be installed on the server for this to
+ work. On linux this is usually part of the poppler-utils
(https://poppler.freedesktop.org/).
@param file absolute path to the pdf file
@@ -460,9 +460,9 @@
sql
} {
- Generate html option tags with values for an html selection widget. if
+ Generate html option tags with values for an html selection widget. If
select_option is passed and there exists a value for it in the values
- list, this option will be marked as selected. select_option can be passed
+ list, this option will be marked as selected. The "select_option" can be
a list, in which case all options matching a value in the list will be
marked as selected.
@@ -647,7 +647,7 @@
This avoids cluttering up the URLs with lots of unnecessary variables.
@option base The base URL to make a link to. This will be prepended to the query string
- along with a question mark (?), if the query is non-empty. so the returned
+ along with a question mark (?), if the query is non-empty. So the returned
string can be used directly in a link. This is only relevant to URL export.
@option no_base_encode Decides whether argument passed as <code>base</code> option will be
@@ -1237,12 +1237,12 @@
}
ad_proc -public ad_decode { args } {
- this procedure is analogus to sql decode procedure. first parameter is
- the value we want to decode. this parameter is followed by a list of
+ This procedure is analogus to sql decode procedure. The first parameter is
+ the value we want to decode. This parameter is followed by a list of
pairs where first element in the pair is convert from value and second
- element is convert to value. last value is default value, which will
+ element is convert to value. The last value is default value, which will
be returned in the case convert from values matches the given value to
- be decoded
+ be decoded.
} {
set num_args [llength $args]
set input_value [lindex $args 0]
Index: openacs-4/packages/acs-tcl/tcl/xml-0-sgml-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/xml-0-sgml-procs.tcl,v
diff -u -r1.8 -r1.9
--- openacs-4/packages/acs-tcl/tcl/xml-0-sgml-procs.tcl 11 Jul 2018 10:37:41 -0000 1.8
+++ openacs-4/packages/acs-tcl/tcl/xml-0-sgml-procs.tcl 19 Sep 2018 00:55:36 -0000 1.9
@@ -885,7 +885,7 @@
# Content model is mixed (PCDATA and elements).
# The second element of the list contains the
# elements that may occur. #PCDATA is assumed
-# (ie. the list is normalized).
+# (i.e. the list is normalized).
#
# Arguments:
# id identifier for the element.
@@ -1434,7 +1434,7 @@
# sgml::makeSet --
#
-# Turn a list into a set, ie. remove duplicates.
+# Turn a list into a set, i.e. remove duplicates.
#
# Arguments:
# s a list
Index: openacs-4/packages/acs-admin/www/test/signed-cookies-test.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/test/Attic/signed-cookies-test.tcl,v
diff -u -r1.3 -r1.4
--- openacs-4/packages/acs-admin/www/test/signed-cookies-test.tcl 7 Aug 2017 23:47:45 -0000 1.3
+++ openacs-4/packages/acs-admin/www/test/signed-cookies-test.tcl 19 Sep 2018 00:59:56 -0000 1.4
@@ -1,6 +1,6 @@
ad_page_contract {
- A quick and dirty test page for signed cookies. sets a signed cookie
+ A quick and dirty test page for signed cookies. Sets a signed cookie
with a known secret as well as one with an unknown secret.
@author Richard Li (richardl@arsdigita.com)
@@ -14,13 +14,13 @@
# random secret
ad_set_signed_cookie -max_age 1 testcookie2 "lots,of,,commas"
-ns_return 200 text/html "
+ns_return 200 text/html [subst {
[ad_header "Signed Cookies Test Page"]
-
cookies set. <a href=\"signed-cookies-test-2\">test it out</a>.
-[ad_footer]"
+[ad_footer]
+}]
# Local variables:
# mode: tcl
# tcl-indent-level: 4
Index: openacs-4/packages/acs-api-browser/www/package-view.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-api-browser/www/package-view.tcl,v
diff -u -r1.17 -r1.18
--- openacs-4/packages/acs-api-browser/www/package-view.tcl 26 Jun 2018 19:39:05 -0000 1.17
+++ openacs-4/packages/acs-api-browser/www/package-view.tcl 19 Sep 2018 00:59:56 -0000 1.18
@@ -172,7 +172,7 @@
set last_components $components
} on error {errorMsg} {
#
- # Couldn't read info from the file. it probably doesn't exist.
+ # Couldn't read info from the file. It probably doesn't exist.
#
ad_log Error "API Browser: Package View: $errorMsg\n$::errorInfo"
Index: openacs-4/packages/xowiki/tcl/form-field-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/form-field-procs.tcl,v
diff -u -r1.277 -r1.278
--- openacs-4/packages/xowiki/tcl/form-field-procs.tcl 21 Jul 2018 11:56:37 -0000 1.277
+++ openacs-4/packages/xowiki/tcl/form-field-procs.tcl 19 Sep 2018 01:03:00 -0000 1.278
@@ -2103,8 +2103,8 @@
# Try to use the ckeditor from the richtext-ckeditor4
# installation.
#
- # There seems to be something broken on 4.9.2 version on
- # cdn. if we do not use standard-all, then we see an error
+ # There seems to be something broken on 4.9.2 version on the
+ # CDN. If we do not use standard-all, then we see an error
# about a missing
# ".../4.9.2/full/plugins/iframedialog/plugin.js". There
# exists a "iframe" and a "iframedialog" plugin for ckeditor4,