Index: openacs-4/packages/bug-tracker/www/bug.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/bug.tcl,v diff -u -N -r1.53 -r1.54 --- openacs-4/packages/bug-tracker/www/bug.tcl 25 May 2016 07:38:02 -0000 1.53 +++ openacs-4/packages/bug-tracker/www/bug.tcl 7 Apr 2018 11:27:06 -0000 1.54 @@ -466,7 +466,7 @@ set prev_bug_number [lindex $filter_bug_numbers $filter_bug_index-1] set prev_url [export_vars -base bug -entire_form -override { { bug_number $prev_bug_number } }] } - if { $filter_bug_index < [expr {[llength $filter_bug_numbers]-1}] } { + if { $filter_bug_index < [llength $filter_bug_numbers]-1 } { set next_bug_number [lindex $filter_bug_numbers $filter_bug_index+1] set next_url [export_vars -base bug -entire_form -override { { bug_number $next_bug_number } }] set last_bug_number [lindex $filter_bug_numbers end] Index: openacs-4/packages/bug-tracker/www/map-patch-to-bugs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/map-patch-to-bugs.tcl,v diff -u -N -r1.13 -r1.14 --- openacs-4/packages/bug-tracker/www/map-patch-to-bugs.tcl 29 May 2016 10:50:02 -0000 1.13 +++ openacs-4/packages/bug-tracker/www/map-patch-to-bugs.tcl 7 Apr 2018 11:27:06 -0000 1.14 @@ -39,7 +39,7 @@ set write_p [permission::permission_p -object_id $package_id -privilege write] set user_is_submitter_p [expr {$user_id == [bug_tracker::get_patch_submitter -patch_number $patch_number]}] -if { ![expr {$user_is_submitter_p || $write_p}] } { +if { !($user_is_submitter_p || $write_p) } { ad_return_forbidden "[_ bug-tracker.Permission]" "[_ bug-tracker.You_1]" ad_script_abort } Index: openacs-4/packages/bug-tracker/www/patch.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/patch.tcl,v diff -u -N -r1.31 -r1.32 --- openacs-4/packages/bug-tracker/www/patch.tcl 4 Jun 2016 17:10:46 -0000 1.31 +++ openacs-4/packages/bug-tracker/www/patch.tcl 7 Apr 2018 11:27:06 -0000 1.32 @@ -98,7 +98,7 @@ # And check that the user is permitted to take the chosen action switch -- $mode { edit { - if { ![expr {$write_p || $user_is_submitter_p}] } { + if { !($write_p || $user_is_submitter_p) } { ad_return_forbidden "[_ bug-tracker.Permission]" "[_ bug-tracker.You_2]" ad_script_abort } Index: openacs-4/packages/bug-tracker/www/unmap-patch-from-bug.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bug-tracker/www/unmap-patch-from-bug.tcl,v diff -u -N -r1.5 -r1.6 --- openacs-4/packages/bug-tracker/www/unmap-patch-from-bug.tcl 14 Oct 2013 18:14:22 -0000 1.5 +++ openacs-4/packages/bug-tracker/www/unmap-patch-from-bug.tcl 7 Apr 2018 11:27:06 -0000 1.6 @@ -15,7 +15,7 @@ set write_p [permission::permission_p -object_id $package_id -privilege write] set user_is_submitter_p [expr {$user_id == [bug_tracker::get_patch_submitter -patch_number $patch_number]}] -if { ![expr {$user_is_submitter_p || $write_p}] } { +if { !($user_is_submitter_p || $write_p) } { ad_return_forbidden "[_ bug-tracker.Permission]" "[_ bug-tracker.You_7]" ad_script_abort }