Index: openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl,v
diff -u -r1.89 -r1.90
--- openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl 10 Nov 2007 19:56:56 -0000 1.89
+++ openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl 22 Mar 2008 18:31:32 -0000 1.90
@@ -2189,7 +2189,7 @@
set parameter "package_instance_name"
set version_id [apm_version_id_from_package_key $package_key]
- if {![empty_string_p $version_id]} {
+ if {$version_id ne ""} {
apm::package_version::attributes::get -version_id $version_id -array packages_names
# it was added this catch for those packages that does not
# have the attribute package instance name, in this case
Index: openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl,v
diff -u -r1.55 -r1.56
--- openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl 20 Jan 2008 11:30:41 -0000 1.55
+++ openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl 22 Mar 2008 18:31:32 -0000 1.56
@@ -654,7 +654,7 @@
@author Malte Sussdorff (malte.sussdorff@cognovis.de)
} {
- if { [empty_string_p $user_id]} {
+ if { $user_id eq ""} {
set user_id [ad_conn user_id]
}
Index: openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl,v
diff -u -r1.91 -r1.92
--- openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 12 Oct 2007 07:33:45 -0000 1.91
+++ openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl 22 Mar 2008 18:31:32 -0000 1.92
@@ -1479,7 +1479,7 @@
# Other hostnames map to subsites.
set node_id [util_memoize [list rp_lookup_node_from_host $host]]
- if {[empty_string_p $node_id]} {
+ if {$node_id eq ""} {
set host [regsub "www\." $host ""]
set node_id [rp_lookup_node_from_host $host]
}
Index: openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl,v
diff -u -r1.23 -r1.24
--- openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl 29 Aug 2007 13:53:40 -0000 1.23
+++ openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl 22 Mar 2008 18:31:32 -0000 1.24
@@ -1872,7 +1872,7 @@
}
# trim leading zeros, so as not to confuse Tcl
set value [string trimleft $value "0"]
- if { [empty_string_p $value] } {
+ if { $value eq "" } {
# but not all of the zeros
set value "0"
}
Index: openacs-4/packages/acs-tcl/tcl/tdom-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/tdom-procs.tcl,v
diff -u -r1.2 -r1.3
--- openacs-4/packages/acs-tcl/tcl/tdom-procs.tcl 1 Aug 2007 08:30:53 -0000 1.2
+++ openacs-4/packages/acs-tcl/tcl/tdom-procs.tcl 22 Mar 2008 18:31:32 -0000 1.3
@@ -45,7 +45,7 @@
set node_object ""
foreach node_name $args {
catch {set node_object [$parent_node_object getElementsByTagName "$node_name"]}
- if {![string equal $node_object ""]} {
+ if {$node_object ne "" } {
return $node_object
}
}
@@ -85,7 +85,7 @@
foreach tag_name $args {
catch {set tag_value [[$node_object getElementsByTagName "$tag_name"] text]} errormsg
- if {![string equal [string trim $tag_value] ""]} {
+ if {[string trim $tag_value] ne "" } {
return $tag_value
}
}
Index: openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl,v
diff -u -r1.1 -r1.2
--- openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl 15 Feb 2008 18:05:00 -0000 1.1
+++ openacs-4/packages/acs-tcl/tcl/util-diff-procs.tcl 22 Mar 2008 18:31:32 -0000 1.2
@@ -60,14 +60,14 @@
lappend output [string trim $item]
}
lappend output </a>
- incr i [expr $old_index2 - $old_index1 + 1]
+ incr i [expr {$old_index2 - $old_index1 + 1}]
} elseif { $action eq "deleted" } {
lappend output <d>
foreach item [lrange $old $old_index1 $old_index2] {
lappend output [string trim $item]
}
lappend output </d>
- incr i [expr $old_index2 - $old_index1 + 1]
+ incr i [expr {$old_index2 - $old_index1 + 1}]
} elseif { $action eq "added" } {
while {$i < $old_index2} {
lappend output [lindex $old $i]
@@ -218,14 +218,14 @@
}
ns_log notice "adding </a>"
lappend output </a>
- incr i [expr $old_index2 - $old_index1 + 1]
+ incr i [expr {$old_index2 - $old_index1 + 1}]
} elseif { $action eq "deleted" } {
lappend output <d>
foreach item [lrange $old_list $old_index1 $old_index2] {
lappend output [string trim $item]
}
lappend output </d>
- incr i [expr $old_index2 - $old_index1 + 1]
+ incr i [expr {$old_index2 - $old_index1 + 1}]
} elseif { $action eq "added" } {
while {$i < $old_index2} {
ns_log notice "unchanged $item"
Index: openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl,v
diff -u -r1.105 -r1.106
--- openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 28 Jan 2008 20:16:53 -0000 1.105
+++ openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 22 Mar 2008 18:31:32 -0000 1.106
@@ -4484,7 +4484,7 @@
# redirected it
ns_log notice "Status == 0 $result"
- } elseif { [string equal $::errorCode NONE] } {
+ } elseif {$::errorCode eq "NONE"} {
# The command exited with a normal status, but wrote something
# to stderr, which is included in $result.