Index: openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs-oracle.xql =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-service-contract/tcl/Attic/acs-service-contract-procs-oracle.xql,v diff -u -r1.4 -r1.5 --- openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs-oracle.xql 5 Mar 2004 16:30:45 -0000 1.4 +++ openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs-oracle.xql 9 May 2018 10:11:45 -0000 1.5 @@ -36,31 +36,18 @@ - + select element_name, acs_sc_msg_type.get_name(element_msg_type_id) as element_msg_type_name, element_msg_type_isset_p, element_pos from acs_sc_msg_type_elements - where msg_type_id = :operation_inputtype_id + where msg_type_id = :msg_type_id order by element_pos asc - - - select - element_name, - acs_sc_msg_type.get_name(element_msg_type_id) as element_msg_type_name, - element_msg_type_isset_p, - element_pos - from acs_sc_msg_type_elements - where msg_type_id = :operation_outputtype_id - order by element_pos asc - - - Index: openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs-postgresql.xql =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-service-contract/tcl/Attic/acs-service-contract-procs-postgresql.xql,v diff -u -r1.3 -r1.4 --- openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs-postgresql.xql 24 Feb 2004 12:10:34 -0000 1.3 +++ openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs-postgresql.xql 9 May 2018 10:11:45 -0000 1.4 @@ -34,32 +34,18 @@ - - + select element_name, acs_sc_msg_type__get_name(element_msg_type_id) as element_msg_type_name, element_msg_type_isset_p, element_pos from acs_sc_msg_type_elements - where msg_type_id = :operation_inputtype_id + where msg_type_id = :msg_type_id order by element_pos asc - - - select - element_name, - acs_sc_msg_type__get_name(element_msg_type_id) as element_msg_type_name, - element_msg_type_isset_p, - element_pos - from acs_sc_msg_type_elements - where msg_type_id = :operation_outputtype_id - order by element_pos asc - - - Index: openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl,v diff -u -r1.28 -r1.29 --- openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl 25 Apr 2018 19:23:26 -0000 1.28 +++ openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl 9 May 2018 10:11:45 -0000 1.29 @@ -167,15 +167,17 @@ append docblock "\nacs-service-contract operation. Call via acs_sc::invoke.\n\n$operation_desc\n\n" - db_foreach operation_inputtype_element {} { + set msg_type_id $operation_inputtype_id + db_foreach operation_msgtype_element {} { lappend arguments "$element_name" append docblock "\n@param $element_name $element_msg_type_name" if { $element_msg_type_isset_p } { append docblock " \[\]" } } - db_foreach operation_outputtype_element {} { + set msg_type_id $operation_outputtype_id + db_foreach operation_msgtype_element {} { append docblock "\n@return $element_name - $element_msg_type_name" if { $element_msg_type_isset_p } { append docblock " \[\]"