Index: openacs-4/packages/faq/sql/postgresql/faq-package-create.sql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/faq/sql/postgresql/faq-package-create.sql,v
diff -u -r1.3 -r1.4
--- openacs-4/packages/faq/sql/postgresql/faq-package-create.sql	27 Oct 2014 16:41:29 -0000	1.3
+++ openacs-4/packages/faq/sql/postgresql/faq-package-create.sql	3 Sep 2024 15:37:38 -0000	1.4
@@ -5,20 +5,20 @@
 -- @cvs-id $Id$
 --
 
-select define_function_args('faq__new_q_and_a','entry_id;null,faq_id,question,answer,sort_key,object_type,creation_date;sysdate,creation_user;null,creation_ip;null,context_id;null');
+select define_function_args('faq__new_q_and_a','entry_id;null,faq_id,question,answer,sort_key,object_type,creation_date;current_timestamp,creation_user;null,creation_ip;null,context_id;null');
 
 CREATE OR REPLACE FUNCTION faq__new_q_and_a (
-       p_entry_id integer, 		-- default null,
-       p_faq_id integer,
-       p_question varchar,
-       p_answer varchar,
-       p_sort_key integer,
-       p_object_type varchar,		-- default faq_q_and_a
-       p_creation_date timestamptz,	-- in acs_objects.creation_date%TYPE	default sysdate,
-       p_creation_user integer,		-- in acs_objects.creation_user%TYPE   default null,
-       p_creation_ip varchar, 		-- in acs_objects.creation_ip%TYPE     default null,
-       p_context_id integer		-- in acs_objects.context_id%TYPE      default null
-) RETURNS integer AS $$
+       p_entry_id      faq_q_and_as.entry_id%TYPE,
+       p_faq_id        faq_q_and_as.faq_id%TYPE,
+       p_question      faq_q_and_as.question%TYPE,
+       p_answer        faq_q_and_as.answer%TYPE,
+       p_sort_key      faq_q_and_as.sort_key%TYPE,
+       p_object_type   acs_objects.object_type%TYPE,   -- default faq_q_and_a
+       p_creation_date acs_objects.creation_date%TYPE, -- default current_timestamp,
+       p_creation_user acs_objects.creation_user%TYPE, -- default null,
+       p_creation_ip   acs_objects.creation_ip%TYPE,   -- default null,
+       p_context_id    acs_objects.context_id%TYPE    -- default null
+) RETURNS faq_q_and_as.entry_id%TYPE AS $$
 DECLARE
 	v_entry_id 			faq_q_and_as.entry_id%TYPE;
 	v_package_id 			acs_objects.package_id%TYPE;
@@ -54,7 +54,7 @@
 -- procedure faq__delete_q_and_a/1
 --
 CREATE OR REPLACE FUNCTION faq__delete_q_and_a(
-   p_entry_id integer
+   p_entry_id faq_q_and_as.entry_id%TYPE
 ) RETURNS integer AS $$
 DECLARE
 BEGIN
@@ -76,15 +76,15 @@
 -- procedure faq__new_faq/8
 --
 CREATE OR REPLACE FUNCTION faq__new_faq(
-   p_faq_id integer,
-   p_faq_name varchar,
-   p_separate_p boolean,
-   p_object_type varchar,
-   p_creation_date timestamptz,
-   p_creation_user integer,
-   p_creation_ip varchar,
-   p_context_id integer
-) RETURNS integer AS $$
+   p_faq_id        faqs.faq_id%TYPE,
+   p_faq_name      faqs.faq_name%TYPE,
+   p_separate_p    faqs.separate_p%TYPE,
+   p_object_type   acs_objects.object_type%TYPE,
+   p_creation_date acs_objects.creation_date%TYPE,
+   p_creation_user acs_objects.creation_user%TYPE,
+   p_creation_ip   acs_objects.creation_ip%TYPE,
+   p_context_id    acs_objects.context_id%TYPE
+) RETURNS faqs.faq_id%TYPE AS $$
 DECLARE
 	v_faq_id 				faqs.faq_id%TYPE;
 BEGIN
@@ -120,7 +120,7 @@
 -- procedure faq__delete_faq/1
 --
 CREATE OR REPLACE FUNCTION faq__delete_faq(
-   p_faq_id integer
+   p_faq_id faqs.faq_id%TYPE
 ) RETURNS integer AS $$
 DECLARE
 	del_rec record;
@@ -153,8 +153,8 @@
 -- procedure faq__name/1
 --
 CREATE OR REPLACE FUNCTION faq__name(
-   p_faq_id integer
-) RETURNS varchar AS $$
+   p_faq_id faqs.faq_id%TYPE
+) RETURNS faqs.faq_name%TYPE AS $$
 DECLARE 
     v_faq_name    faqs.faq_name%TYPE;
 BEGIN
@@ -168,7 +168,9 @@
 $$ LANGUAGE plpgsql;
 
 
-
+-- apisano 2020-03-20: not sure what is going on with this function,
+-- as it calls for faq__new_faq with 3 arguments signature... in
+-- current codebase we do not define such function...
 -- added
 select define_function_args('faq__clone','new_package_id,old_package_id');