Index: openacs-4/packages/evaluation/www/admin/grades/distribution-edit-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/evaluation/www/admin/grades/distribution-edit-2.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/evaluation/www/admin/grades/distribution-edit-2.tcl 8 Aug 2006 21:26:42 -0000 1.2 +++ openacs-4/packages/evaluation/www/admin/grades/distribution-edit-2.tcl 27 Oct 2014 16:41:26 -0000 1.3 @@ -3,7 +3,7 @@ ad_page_contract { Bulk edit a set tasks } { - grade_id:integer,notnull + grade_id:naturalnum,notnull no_grade:array weights:array {weight_sum "0"} @@ -29,19 +29,19 @@ weights_sum { set count 0 foreach id [array names weights] { - set count [expr $count+$weights($id)] + set count [expr {$count+$weights($id)}] } if { $count > 100} { ad_complain "[_ evaluation.not_equal_100]" } } } -if {[string equal $info "[_ evaluation.Over_total_grade]"]} { +if {$info eq "[_ evaluation.Over_total_grade]"} { set points_p 1 } -if {[string equal $info "[_ evaluation.rel_weight]"]} { +if {$info eq "[_ evaluation.rel_weight]"} { set relative_p 1 } @@ -54,7 +54,7 @@ } foreach id [array names weights] { # create a list of tasks that requieres/not requires grade - if { [string eq $no_grade($id) "t"] } { + if {$no_grade($id) == "t"} { lappend with_grade $id } else { lappend without_grade $id