Index: openacs-4/packages/bookmarks/www/bookmark-edit-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bookmarks/www/bookmark-edit-2.tcl,v diff -u -N -r1.4 -r1.5 --- openacs-4/packages/bookmarks/www/bookmark-edit-2.tcl 9 Sep 2013 12:19:56 -0000 1.4 +++ openacs-4/packages/bookmarks/www/bookmark-edit-2.tcl 18 Apr 2014 06:38:29 -0000 1.5 @@ -25,7 +25,7 @@ old_private_p } -validate { valid_url { - if { [string equal $folder_p "f"] && [empty_string_p [string trim $complete_url]] } { + if { $folder_p == "f" && [empty_string_p [string trim $complete_url]] } { ad_complain "You must provide a non empty url" } } @@ -42,7 +42,7 @@ permission::require_permission -object_id $bookmark_id -privilege admin # We update or insert the url -if { [string equal $folder_p "f"] } { +if {$folder_p == "f"} { set host_url [bm_host_url $complete_url] set creation_ip [ad_conn peeraddr] @@ -83,7 +83,7 @@ end;" # Update the private_p status of the bookmark -if { ![string equal $old_private_p $private_p] } { +if { $old_private_p ne $private_p } { bm_update_bookmark_private_p $bookmark_id $private_p }