Index: openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl,v
diff -u -r1.10 -r1.11
--- openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl	7 Aug 2017 23:48:04 -0000	1.10
+++ openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl	20 Jan 2018 22:38:28 -0000	1.11
@@ -35,7 +35,7 @@
 set title $assessment_data(title)
 set context [list [list index [_ assessment.admin]] [list "one-a?assessment_id=$assessment_id" $title] "$title Triggers"]
 
-if {(![info exists as_item_id] || $as_item_id eq "") } {
+if {![info exists as_item_id] || $as_item_id eq ""} {
     set condition_sql [db_string get_item_id {}] 
     #parse condition_sql to get item_id
     set cond_list  [split $condition_sql "="]
@@ -47,7 +47,7 @@
     set item_id $as_item_id
 }
 
-if {([info exists section_id] && $section_id ne "")} {
+if {[info exists section_id] && $section_id ne ""} {
     set section_id_from $section_id
 }
 
@@ -58,13 +58,13 @@
 set choices [db_list_of_lists get_choices {} ] 
 set question_text [db_string get_question {}]
 
-if {([info exists edit_check] && $edit_check ne "")} {
+if {[info exists edit_check] && $edit_check ne ""} {
     if { (![info exists type] || $type eq "")} {
-    set return_url "&check_id=$inter_item_check_id&edit_check=t"
-    } 
+        set return_url "&check_id=$inter_item_check_id&edit_check=t"
+    }
     
 }
-if {([info exists by_item_p] && $by_item_p ne "")} {
+if {[info exists by_item_p] && $by_item_p ne ""} {
     if {$by_item_p==1} {
 	    append return_url "&item_id=$item_id&by_item_p=$by_item_p"
 	} else  {
@@ -105,7 +105,7 @@
 
 }
 
-if {(![info exists inter_item_check_id] || $inter_item_check_id eq "")} {
+if {![info exists inter_item_check_id] || $inter_item_check_id eq ""} {
     ad_form -extend -name new_check -form {
 	{action_p:boolean(radio)
 	    {label "[_ assessment.parameter_type]"}
@@ -144,6 +144,7 @@
     
     set url [as::assessment::check::add_check_return_url $action_p]
     ad_returnredirect "${url}?assessment_id=$assessment_id&inter_item_check_id=$inter_item_check_id&section_id=$section_id_from$return_url"
+    ad_script_abort
 
 }
 # Local variables: