Index: openacs-4/packages/assessment/tcl/as-action-proc.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-action-proc.tcl,v
diff -u -N -r1.4 -r1.5
--- openacs-4/packages/assessment/tcl/as-action-proc.tcl	3 May 2018 20:27:42 -0000	1.4
+++ openacs-4/packages/assessment/tcl/as-action-proc.tcl	18 Sep 2018 23:38:34 -0000	1.5
@@ -2,33 +2,29 @@
     Assessment action procs
     @author vivian@viaro.net Viaro Networks (www.viaro.net)
     @creation-date 2005-01-13
-
 }
 
 namespace eval as::action_p {}
 
 ad_proc -public as::action_p::action_exec {
     {-inter_item_check_id}
     {-session_id}
-
-
 } {
     Execute the action created on the tcl_code
 } {
     db_foreach get_check_params { select * from as_param_map where inter_item_check_id = :inter_item_check_id } {
-    set parameter_name [db_1row select_name "select varname from as_action_params where parameter_id = :parameter_id"]
-    if {![info exists value] || $value eq ""} {
-        set $varname [db_string get_item_choice {select idc.choice_id from as_item_data_choices idc,as_item_data id where id.as_item_id=$item_id and id.item_data_id=idc.item_data_id and id.session_id=:session_id}]
+        set parameter_name [db_1row select_name "select varname from as_action_params where parameter_id = :parameter_id"]
+        if {![info exists value] || $value eq ""} {
+            set $varname [db_string get_item_choice {select idc.choice_id from as_item_data_choices idc,as_item_data id where id.as_item_id=$item_id and id.item_data_id=idc.item_data_id and id.session_id=:session_id}]
 
-    }else {
+        } else {
 
-        set $varname $value
+            set $varname $value
+        }
     }
-    }
     set tcl_code [db_1row select_tcl "select a.tcl_code from as_actions a,as_actions_map am where am.action_id = a.action_id and inter_item_check_id = :inter_item_check_id"]
     eval $tcl_code
     return
-
 }
 
 # Local variables: