Index: openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl,v
diff -u -r1.10 -r1.11
--- openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl	10 Jan 2007 21:22:12 -0000	1.10
+++ openacs-4/packages/acs-templating/tcl/doc-tcl-procs.tcl	27 Oct 2014 16:40:11 -0000	1.11
@@ -42,10 +42,9 @@
     procedure to deal with @see comments
 } {
   upvar $list_ref see_list
-  set type [lindex $directive_comments 0]
-  set see_name [lindex $directive_comments 1]
-  set url [lindex $directive_comments 2]
 
+  lassign $directive_comments type see_name url
+
   if {$url eq "" } {
     switch -exact $type {
 
@@ -57,7 +56,7 @@
 	  set split_name $see_name
 	  doc::util::text_divider split_name ::
 	  set name_length [llength $split_name]
-	  set see_namespace [join [lrange $split_name 0 [expr {$name_length - 2}]] ""]
+	  set see_namespace [join [lrange $split_name 0 $name_length-2] ""]
 	  set url "[doc::util::dbl_colon_fix $see_namespace].html#[set see_name]"
 	}
     }
@@ -92,7 +91,7 @@
    
   while { [regexp -indices $marker $text marker_idx] } {
     lappend indices_list [expr {[lindex $marker_idx 0] + $last_index}]
-    set text [string range $text [expr {[lindex $marker_idx 1] + 1}]  end]
+    set text [string range $text [lindex $marker_idx 1]+1 end]
     set last_index [expr {[lindex $marker_idx 1] + $last_index + 1}]
   }
 
@@ -137,10 +136,12 @@
     return 1
 }
 
-ad_proc -private template::util::server_root {} {
+ad_proc -private -deprecated template::util::server_root {} {
     uses ns_library to find the server root, may not always be accurate
     because it essentially asks for the tcl library path and
-    strips off the last /tcl directory
+    strips off the last /tcl directory.
+
+    @see use $::acs::rootdir instead
 } {
 
   set path_length [expr [llength [file split [ns_library private]]] - 1]
@@ -168,24 +169,29 @@
 
 }
 
-ad_proc -private template::util::display_value { ref } {
+ad_proc -private -deprecated template::util::display_value { ref } {
     a proc used for debugging, just prints out a value to the error log
+
+    @see use simple "ns_log ...." instead
 } {
     upvar $ref value
     ns_log notice "$ref: $value
 "
 }
 
 
-ad_proc -private template::util::proper_noun { string_ref } {
+ad_proc -private -deprecated template::util::proper_noun { string_ref } {
     capitalizes the first letter of a string
     @return returns formatted string (UNFINISHED. FIXME.)
+    @see use "string totitle ..."
 } {
 
 }
 
 
-ad_proc -private template::util::string_range { string indices } {
+ad_proc -private -deprecated template::util::string_range { string indices } {
+    @see use "string range instead"
+} {
     return [string range $string [lindex $indices 0] [lindex $indices 1]]
 }
 
@@ -273,9 +279,7 @@
 ad_proc -private template::util::proc_element_compare { element1 element2 } {
     used to compare two different elements in a list of parsed data for public or private procs
 } {
-
-    return [string compare -nocase [lindex [lindex [lindex $element2 1] 0] 1] [lindex [lindex [lindex $element1 1] 0] 1]]
-
+    return [string compare -nocase [lindex $element2 1 0 1] [lindex $element1 1 0 1]]
 }
 
 ad_proc -private doc::set_proc_name_source_text_comment_text { proc_block } {
@@ -468,9 +472,9 @@
 
         set namespace_entry [lindex $total_result_listing [lsearch -exact $namespace_list $namespace_name]]
 
-	set namespace_info [lindex [lindex $namespace_entry 0] 1]
-	set namespace_public [lindex [lindex $namespace_entry 1] 1]
-	set namespace_private [lindex [lindex $namespace_entry 2] 1]
+	set namespace_info [lindex $namespace_entry 0 1]
+	set namespace_public [lindex $namespace_entry 1 1]
+	set namespace_private [lindex $namespace_entry 2 1]
 		
     } else {
         set namespace_info [list name "$namespace_name" overview "$namespace_description" author "$namespace_author" see "$namespace_see"]
@@ -603,7 +607,7 @@
   foreach dir $dir_list {
 
   #debug
-  template::util::display_value dir
+  #template::util::display_value dir
 
   # using this lame hack since most aD servers are running an earlier version of Tcl than 8.3,
   # which supports the -directory switch that this hack emulates
@@ -612,7 +616,7 @@
   }
 
   #debugging
-  template::util::display_value file_list
+  #template::util::display_value file_list
 
   foreach tcl_file $file_list {
       ns_log notice "doc::parse_tcl_library: parsing through $tcl_file for documentation"