Index: openacs-4/packages/acs-admin/www/apm/packages-install.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-admin/www/apm/packages-install.tcl,v
diff -u -N -r1.28.2.4 -r1.28.2.5
--- openacs-4/packages/acs-admin/www/apm/packages-install.tcl	16 Apr 2019 07:00:36 -0000	1.28.2.4
+++ openacs-4/packages/acs-admin/www/apm/packages-install.tcl	13 May 2020 19:29:28 -0000	1.28.2.5
@@ -93,6 +93,8 @@
     }]
 } else {
 
+    ns_log notice "spec_files <$spec_files>"
+
     append body [subst {
         <h2>Select Packages to $operation</h2><p>
         <p>Please select the set of packages you'd like to [string tolower $operation].</p>
@@ -102,29 +104,6 @@
     }]
 
     set formName "pkgsForm"
-    template::add_event_listener \
-        -id check_all \
-        -script [subst {
-            var install_form = document.getElementsByName('$formName')\[0\];
-            for (var i = 0; i < install_form.length; ++i) {
-                install_form.elements\[i\].checked = true;
-                //install_form.elements\[i\].href = '';
-            }
-        }]
-
-    template::add_event_listener \
-        -id uncheck_all \
-        -script [subst {
-            var install_form = document.getElementsByName('$formName')\[0\];
-            for (var i = 0; i < install_form.length; ++i) {
-                install_form.elements\[i\].checked = false;
-            }
-        }]
-
-    append body {
-        <a href="#" id="uncheck_all"><b>uncheck all boxes</b></a> |
-        <a href="#" id="check_all"><b>check all boxes</b></a>
-    }
     #packages-install?checked_by_default_p=1
 
     append body "<form name='$formName' action='packages-install-2' method='post'>\n"
@@ -138,6 +117,7 @@
     set pkg_info_list [list]
     set pkg_key_list [list]
     apm_log APMDebug "APM: Specification files available: $spec_files"
+
     foreach spec_file $spec_files {
         ### Parse the package.
         if { [catch {
@@ -154,28 +134,28 @@
     }
 
     if { $checked_by_default_p } {
-        set widget [apm_package_selection_widget $pkg_info_list $pkg_key_list $operation]
+        set widget [apm_package_selection_widget $pkg_info_list $pkg_key_list $operation $formName]
     } else {
-        set widget [apm_package_selection_widget $pkg_info_list "" $operation]
+        set widget [apm_package_selection_widget $pkg_info_list "" $operation $formName]
     }
 
     if {$widget eq ""} {
-        append body "There are no new packages available."
-        ad_script_abort
-    }
+        append body \
+            "There are no packages to [string tolower $operation]."
+    } else {
 
-    append body $widget
-    append body [subst {
-        <div><input type="submit" value="Next -->"></div>
-        </form>
-    }]
-
+        append body \
+            $widget \
+            [subst {
+                <div><input type="submit" value="Next -->"></div>
+                </form>
+            }]
+    }
     if {$errors ne ""} {
-        append body "The following errors were generated
-    <ul>
-        $errors
-    </ul>
-    "
+        append body [subst {The following errors were generated:
+            <ul>
+            $errors
+            </ul>}]
     }
 }