Index: openacs-4/contrib/packages/simulation/www/simbuild/role-edit.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/www/simbuild/Attic/role-edit.tcl,v
diff -u -r1.4 -r1.5
--- openacs-4/contrib/packages/simulation/www/simbuild/role-edit.tcl	2 Dec 2003 17:24:32 -0000	1.4
+++ openacs-4/contrib/packages/simulation/www/simbuild/role-edit.tcl	9 Dec 2003 09:52:44 -0000	1.5
@@ -46,9 +46,9 @@
         {html {size 20}}
     }
 } -edit_request {
-    permission::require_write_permission -object_id $role_id    
     workflow::role::get -role_id $role_id -array role_array
     set workflow_id $role_array(workflow_id)
+    permission::require_write_permission -object_id $workflow_id
     set name $role_array(pretty_name)
     workflow::get -workflow_id $workflow_id -array sim_template_array
     set page_title "Edit Role template $name"
@@ -68,7 +68,12 @@
         -role_pretty_name $name
 
 } -edit_data {
-    permission::require_write_permission -object_id $role_id        
+    workflow::role::get -role_id $role_id -array role_array
+    # We use role_array(workflow_id) here, which is gotten from the DB, and not
+    # workflow_id, which is gotten from the form, because the workflow_id from the form 
+    # could be spoofed
+    permission::require_write_permission -object_id $role_array(workflow_id)
+
     set role_array(pretty_name) $name
 
     workflow::role::edit \