generic

Clone Tools
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve code safety and remove dead statement

get rid of warning of static checker, reduce number of returns before end of function

minor code cleanup

add asserts

fix memory leak on "hyper-volatile" objects. it seems, we have to set the _is_autonamed flag in advance of obj initialization

addressing coverty defect 337829 (dereference before null check)

make spelling more consitent

Provide a more conservative change for setting autonamed flag

Improve consistency of naming nsf objects

* nsf.c (NsfCCreateMethod): Fix access of potentially freed object to set the autonamed property (indicated by valdgrind). When destroyed and cleaned during DoObjInitialization, "newObject" will remain as a dangling pointer. Besides, setting the property before DoObjInitialization will make the object property available from within the initcmd or init method.

* nsf.c (NsfProcStubDeleteProc): Plug leakage of command structure (found by valgrind)

muniro formatting changes

* nsf.c (NsfDebugShowObj): For consistency, stick with %x using PRIxPTR

*nsf.c (NsfDebugShowObj): Simplify from using %x to %p, to avoid PTR2UINT (which, starting with 8.7, will return u long, not u int)

Change http:// occurrences to https://, if applicable (URLs tested)

  1. … 43 more files in changeset.
Rewrite URLs containing tcl.tk as authority to tcl-lang.org

  1. … 11 more files in changeset.
improve spelling

  1. … 3 more files in changeset.
move new assertion to the right place

ease human tracing of uninitialized/NULL values

* nsf.c (NsfOUplevelMethod, NsfOUpvarMethod): Silence compiler warnings on nonnull/NULL compares.

* nsf.c (NsfOUplevelMethod, NsfOUpvarMethod, NsfCallstackFindCallingContext): Reform of uplevel and upvar methods, based on the recent feedback by Zoran. First, uplevel and upvar methods, as well as [current callinglevel] now behave consistently (re frame skipping for mixin and filter transparency). If there is no innermost enclosing proc frame, the innermost non-proc (e.g., namespace) frame is selected (rather than a "#0" as default). Second, argument handling for both uplevel (i.e., level sniffing in multi-arg case) and upvar (e.g., made silent TCL_ERROR for invalid argument arities explicit) have been fixed. * Object.man, methods.test: Added documentation for both methods (Object.man) and tests.

  1. … 5 more files in changeset.
Fix merge glitch

Leave a to-do

* nsf.c (NsfOUpvarMethod): Fix argument parsing, to reflect Tcl's upvar behaviour for different (invalid) argument arities. Added tests.

  1. … 1 more file in changeset.
cleaning up

reduce dead assignments improve indentation of variables

avoid variable name "index" in generated code since "index" shadows an outer function

  1. … 1 more file in changeset.
Fix indentation

* nsf.c, methods.test (NsfOUplevelMethod): Fix argument handling (level sniffing in the multi-arg case etc.), to match 1:1 the handling of Tcl's uplevel. Added tests.

  1. … 1 more file in changeset.
WIP; rewrite NsfCallStackFindCallingContext

  1. … 1 more file in changeset.