nsf

Clone Tools
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- address covertiy CID 88773

- move assignmetns after assertions in generated code

- revert overeager part of the change

- remove logically dead code as flagged by coverity

Adding details how to upload Coverity builds

- remove expression which were always true

- turn for() loop into a repeat-until loop, since in first iteration, the loop controlling expression was always true

- address coverty CID 88774

- address coverty issue 88776

Merging README.release

Adding Coverity instructions

- move assertion after assingment

- move dereferencing of members after assertions

- fix potential bug on tcl-triggered cmd-delete operations, where destroy returns non-TCL_OK and name of the object could not be retrieved anymore in error message.

- attempt to make Coverty happy (CID 88769)

- removed NsfParamDefs.slotObj (and single occurance for memory-management) since it is not used for the time being

- remove test, since it is covered already by assertions

- write body-blocks of if on separate lines - change variable name "validCscPtr" to "isValidCsc", since it is a boolean and not a ptr (tcl coding guidelines) - prefer explicit comparisons

MethodDispatch(): Fix compiler warning on typecast mismatch

MixinregSetFromAny(): Re-arrange control flow as to match other uses in the code base (CID 88777)

ResolveMethodName(): Guard against potential null pointer dereference (CID 88771).

FreeAllNsfObjectsAndClasses(): Remove unneeded NULL check as dereferencing already occurred before; check for NULL earlier (CID 88780)

MixinregSetFromAny(): Fix crash through explicit null dereferencing when an invalid list string-rep is provided as mixinreg (CID 88777); added tests

MakeProc(): Silence false-positive warning, due to missing returns_nonnull annotation (CID 88770).

nsf.c: Check return values of GetObjectFromObj explicitly (CID 88763, 88764, 88765).

ObjectSystemsCheckSystemMethod(): Mark TCL_ERROR path as unlikely

ObjectSystemsCheckSystemMethod(): Re-order control flow to remove otherwise dead IF-branch (CID 88768)

NsfMethodPropertyCmd(): Dropped option 'slotobj' as it is obsolete. Also fixes CID 88767. See TODO for further cleanup steps.

info.man.inc: Make empty-string ambiguity explicit for 'info method *'

ListMethod(): Make sure that 'info method exists' returns 0 for (plain) NX objects; added some tests