• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
moved helper proc "portlet_exists_p" from test cases to library

include package key in proc info

replace call to deprecated function

remove protection "private", since function has to be called from other packages

- fixed mis-classification of "max", "min" and "random" in "tclcode_to_html"

- added new test case "callgraph__bad_calls" to check for

a) calls to deprecated procs

b) direct calls to private procs from other packages ("private" means "packakge private"

reduce verbosity, add covered calls in test cases

Fix extra braces

Add 'calendar_basic_api' test case, covering 'calendar::new', 'calendar::delete', 'calendar::rename' and 'calendar::name'

Extend 'create_portal_from_template' test case to cover 'portal::delete', 'portal::page_delete', 'portal::page_count', 'portal::get_page_id', 'portal::get_page_pretty_name', 'portal::set_page_pretty_name' and 'portal::first_page_p'

Whitespace changes

Add covered procs to test case

Add trivial test for 'bulk_mail::package_key'

remove dependency on ad_ns_set_keys

improve listing of test coverage

mark functions called only internally as private

bring test coverage to >50% by adding test cases and marking only locally called functions as private

Add editor hints + whitespace changes

Remove leftover comment

Add 'attachments_basic_api' test case. Covers basic api of the attachments package: 'attachments::attach', 'attachments::unattach', 'attachments::get_all_attachments', 'attachments::get_attachments' and 'attachments::toggle_approved'

file attachments-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/attachments/tcl/test/attachments-procs.tcl
mark unused function "_mr" as deprecated

mark unused functions as deprecated

improve comment

make use of built-in reverse proxy mode of newer versions of NaviServer

overwork get_community_id once more. provide a shortcut is hopless situations, reduce potential warnings and improve comments

make clear that get_community_id_from_url needs connection in case no URL is provided; provide shortcut, when determined package_id is empty

    • -1
    • +1
    /openacs-4/packages/survey/tcl/survey-procs.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/admin/one.tcl
don't load deprecated code unless explicitly required

deprecate unused and untested code

fix deprecated function

remove call to deprecated proc