OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 145
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 08 Feb 2019
6:11 pm

antoniop

Reinstate reworked versions of some oracle database utilities left behind during solution of bug #3302

Rework is based on coding style observed in code provided by Brian Fenton, but could still not be tested. See https://openacs.org/bugtracker/openacs/bug?bug_number=3302

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -1
    • +187
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
    • -0
    • +353
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
4:04 pm

antoniop

Fix typo (thanks to Thomas Renner)

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
2:00 pm

gustafn

reduce redirects

Options
    • -1
    • +1
    /openacs-4/packages/acs-authentication/www/doc/configure-batch-sync.adp
    • -1
    • +1
    /openacs-4/packages/acs-authentication/www/doc/ext-auth-design.adp
    • -1
    • +1
    /openacs-4/packages/acs-authentication/www/doc/ext-auth-install.adp
    • -2
    • +2
    /openacs-4/packages/acs-authentication/www/doc/ext-auth-ldap-install.adp
    • -1
    • +1
    /openacs-4/packages/acs-authentication/www/doc/ext-auth-pam-install.adp
    • -1
    • +1
    /openacs-4/packages/acs-authentication/www/doc/ims-sync-driver-design.adp
    • -1
    • +1
    /openacs-4/packages/acs-authentication/www/doc/index.adp
    • -3
    • +3
    /openacs-4/packages/news/www/doc/design.adp
    • -1
    • +1
    /openacs-4/packages/news/www/doc/index.adp
    • -1
    • +1
    /openacs-4/packages/news/www/doc/requirements.adp
1:40 pm

antoniop

Fix comment

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/group-procs.tcl
1:37 pm

antoniop

Add flushing of user permissions as well when adding to a new group, extend comments

Options
    • -1
    • +9
    /openacs-4/packages/acs-subsite/tcl/group-procs.tcl
3:46 am

gustafn

whitespace and comment changes

Options
    • -6
    • +11
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
3:15 am

gustafn

- make sure to get rid over overdue elements from statistics

- improve comments

Options
    • -28
    • +37
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
2:19 am

gustafn

reflow overlong lines in comments

Options
    • -52
    • +75
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
2:07 am

gustafn

ad_form: Add optional parameter -csrf_protection_p (defaults to false)

Options
    • -5
    • +35
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
1:43 am

gustafn

white space changes

Options
    • -12
    • +19
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
1:41 am

gustafn

simplify code

Options
    • -13
    • +3
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
Thursday 07 Feb 2019
11:31 pm

antoniop

Cleanup not more relevant comments, remove idiom meant to work in the context of a db_with_handle we are not using anymore

Options
    • -5
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
7:24 pm

antoniop

Reuse already existing db_list_of_ns_sets inside db_foreach and db_list_of_lists, as it uses the most native return type: the ns_set

Options
    • -41
    • +20
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
7:03 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
5:03 pm

antoniop

Operate on the original list to not incur in possible memory foortprint inflation via lrange

Options
    • -7
    • +10
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
3:08 pm

antoniop

Exploit new -with_headers flag in db_list_of_lists to reimplement db_foreach in a way that only one db handle is used

Advantages:

- api is now transaction safe (with respect to database operations executed in the code block)

- nested db_foreach statements won't risk to occupy all available handles anymore

Possible drawbacks:

- query result needs to be completely stored inside a list before looping

- calling stack is now one level deeper...

This passes automated tests

Options
    • -52
    • +53
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
2:07 pm

antoniop

Reduce code duplication

Options
    • -20
    • +13
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
1:45 pm

antoniop

Introduce -with_headers flag in db_list_of_lists so names of returned column values can be returned as well as the first list in the result

Options
    • -4
    • +20
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
12:18 pm

antoniop

Reduce code duplication (passes automated tests)

Options
    • -27
    • +16
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
Wednesday 06 Feb 2019
8:36 pm

hectorr

Refactoring of 'folder-zip-add'

Options
    • -66
    • +113
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
Tuesday 05 Feb 2019
7:16 pm

gustafn

return empty body in 304 replies

Options
    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
5:55 pm

hectorr

Fix folder creation in 'folder-zip-add'

Options
    • -3
    • +4
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
5:27 pm

gustafn

add missing script abort

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
5:21 pm

gustafn

new parameter: use_fallback_page_in_system_locale

When this parameter is set, use the page in the system locale as fallback rather than offering a link for creation of a page in that locale, when the page in the requested locale does not exist.

Bump version to 5.10.0d21

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -3
    • +16
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
4:19 pm

gustafn

improve security of ad_forms by binding request to a user

Options
    • -4
    • +16
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
4:18 pm

gustafn

fix bracket in last commit

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
4:09 pm

gustafn

use usual idioms, white space changes

Options
    • -78
    • +77
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
Monday 04 Feb 2019
3:30 pm

hectorr

Whitespace changes

Options
    • -106
    • +106
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
Thursday 31 Jan 2019
6:07 pm

hectorr

Remove backtick from the list of characters to be replaced by 'ad_sanitize_filename', as 'util::zip' deals with them properly now

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:02 pm

hectorr

util::zip reform.

+ Use '::zipfile::mkzip', introduced in tcllib 1.18, if available.

+ For unix-like systems, with older tcllib versions, bash was used for changing directories. This method was problematic when using certain characters for the filenames, such as backticks, for example. In order to avoid this and properly quote everything, we use tclsh instead, in a convoluted and funny way (thanks to Nathan Coulter for the hack).

+ TODO: test this method also on windows, and unify the legacy implementations if it works.

Options
    • -20
    • +73
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl